detached 6dfb1bb

internal/strings: explicitly copy C string into Go memory in GoString (#63)

commit
6dfb1bbf605466de9d3c3bf031a149a17313e096
author
TotallyGamerJet · · 2022-11-08 03:43 UTC
committer
GitHub · · 2022-11-08 03:43 UTC
parent
382f4c6
signature
GPG Unverified4AEE18F83AFDEB23 The key is unknown
1 file · +3 -1
M internal/strings/strings.go +3 -1
@@ -36,5 +36,7 @@ func GoString(c uintptr) string {
3636 }
3737 length++
3838 }
39- return string(unsafe.Slice((*byte)(ptr), length))
39+ dst := make([]byte, length)
40+ copy(dst, unsafe.Slice((*byte)(ptr), length))
41+ return string(dst)
4042 }
@@ -36,5 +36,7 @@ func GoString(c uintptr) string {
36 }36 }
37 length++37 length++
38 }38 }
39- return string(unsafe.Slice((*byte)(ptr), length))39+ dst := make([]byte, length)
40+ copy(dst, unsafe.Slice((*byte)(ptr), length))
41+ return string(dst)
40 }42 }

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 1

Tags 102

↑↓ moveenter openesc close