detached 7850e38

fix: avoid uintptr arithmetic when reading []string results

commit
7850e384cde9eaab6c5ce5f1588a13798f2b5cec
author
brice · · 2026-04-13 04:37 UTC
parent
91aa177
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
1 file · +3 -3
M func.go +3 -3
@@ -448,14 +448,14 @@ func callAndReturn(ty reflect.Type, is32bit bool, cfn uintptr, sysargs *[maxArgs
448448 v = reflect.Zero(outType)
449449 } else {
450450 var result []string
451- ptr := syscall.a1
451+ p := *(*unsafe.Pointer)(unsafe.Pointer(&syscall.a1))
452452 for {
453- strPtr := *(*uintptr)(unsafe.Pointer(ptr))
453+ strPtr := *(*uintptr)(p)
454454 if strPtr == 0 {
455455 break
456456 }
457457 result = append(result, strings.GoString(strPtr))
458- ptr += unsafe.Sizeof(uintptr(0))
458+ p = unsafe.Add(p, unsafe.Sizeof(uintptr(0)))
459459 }
460460 v = reflect.ValueOf(result)
461461 }
@@ -448,14 +448,14 @@ func callAndReturn(ty reflect.Type, is32bit bool, cfn uintptr, sysargs *[maxArgs
448 v = reflect.Zero(outType)448 v = reflect.Zero(outType)
449 } else {449 } else {
450 var result []string450 var result []string
451- ptr := syscall.a1451+ p := *(*unsafe.Pointer)(unsafe.Pointer(&syscall.a1))
452 for {452 for {
453- strPtr := *(*uintptr)(unsafe.Pointer(ptr))453+ strPtr := *(*uintptr)(p)
454 if strPtr == 0 {454 if strPtr == 0 {
455 break455 break
456 }456 }
457 result = append(result, strings.GoString(strPtr))457 result = append(result, strings.GoString(strPtr))
458- ptr += unsafe.Sizeof(uintptr(0))458+ p = unsafe.Add(p, unsafe.Sizeof(uintptr(0)))
459 }459 }
460 v = reflect.ValueOf(result)460 v = reflect.ValueOf(result)
461 }461 }

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 1

Tags 102

↑↓ moveenter openesc close