detached 7e3b362

objc: anchor ivarRegex so malformed names are rejected (#513)

MatchString does substring matching, so the unanchored pattern let
names like Bar or 'foo bar' through RegisterClass validation. Anchor
it for a full-string match.

Closes #508
commit
7e3b3624cbe3f375762e621900c61f58d19f8c41
author
Hiroki KUMAZAKI · · 2026-09-05 12:37 UTC
committer
GitHub · · 2026-09-05 12:37 UTC
parent
63002e0
signature
GPG UnverifiedB5690EEEBB952194 The key is unknown
refs
tag: v0.12.0-alpha
1 file · +1 -1
M objc/objc_runtime_darwin.go +1 -1
@@ -269,7 +269,7 @@ type FieldDef struct {
269269 }
270270
271271 // ivarRegex checks to make sure the Ivar is correctly formatted
272-var ivarRegex = regexp.MustCompile("[a-z_][a-zA-Z0-9_]*")
272+var ivarRegex = regexp.MustCompile(`^[a-z_][a-zA-Z0-9_]*$`)
273273
274274 // RegisterClass takes the name of the class to create, the superclass, a list of protocols this class
275275 // implements, a list of fields this class has and a list of methods. It returns the created class or an error
@@ -269,7 +269,7 @@ type FieldDef struct {
269 }269 }
270 270
271 // ivarRegex checks to make sure the Ivar is correctly formatted271 // ivarRegex checks to make sure the Ivar is correctly formatted
272-var ivarRegex = regexp.MustCompile("[a-z_][a-zA-Z0-9_]*")272+var ivarRegex = regexp.MustCompile(`^[a-z_][a-zA-Z0-9_]*$`)
273 273
274 // RegisterClass takes the name of the class to create, the superclass, a list of protocols this class274 // RegisterClass takes the name of the class to create, the superclass, a list of protocols this class
275 // implements, a list of fields this class has and a list of methods. It returns the created class or an error275 // implements, a list of fields this class has and a list of methods. It returns the created class or an error

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 1

Tags 102

↑↓ moveenter openesc close