test(daemon): release locks before assertions

commit: 7538f61b225dc0eb8f98c7e0c621d1619df8d43c
author: brice · 3mo ago · 2026-07-24 04:32 UTC
parent: 71b3504
signature: GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email

1 file · +7 -2

M internal/usecase/daemon/performance_benchmark_test.go +7 -2


@@ -170,11 +170,16 @@ func TestPerformanceFixtureExplicitCloseReleasesIterationState(t *testing.T) {
170	170		require.Error(t, serveCtx.Err())
171	171		require.Error(t, hardCtx.Err())
172	172		d.mu.Lock()
173		-	require.NotContains(t, d.sessions, sess.id)
	173	+	sessionIDs := make([]domain.SessionID, 0, len(d.sessions))
	174	+	for id := range d.sessions {
	175	+	sessionIDs = append(sessionIDs, id)
	176	+	}
174	177		d.mu.Unlock()
	178	+	require.NotContains(t, sessionIDs, sess.id)
175	179		d.snapshotWorkerMu.Lock()
176		-	require.Nil(t, d.snapshotWorkerCancel)
	180	+	workerCancel := d.snapshotWorkerCancel
177	181		d.snapshotWorkerMu.Unlock()
	182	+	require.Nil(t, workerCancel)
178	183		}
179	184
180	185		func TestCountingOutputTransportCountsOpaquePayloadAndRejectsShortPayload(t *testing.T) {

 	require.Error(t, serveCtx.Err())
 	require.Error(t, hardCtx.Err())
 	d.mu.Lock()
-	require.NotContains(t, d.sessions, sess.id)
+	sessionIDs := make([]domain.SessionID, 0, len(d.sessions))
+	for id := range d.sessions {
+		sessionIDs = append(sessionIDs, id)
+	}
 	d.mu.Unlock()
+	require.NotContains(t, sessionIDs, sess.id)
 	d.snapshotWorkerMu.Lock()
-	require.Nil(t, d.snapshotWorkerCancel)
+	workerCancel := d.snapshotWorkerCancel
 	d.snapshotWorkerMu.Unlock()
+	require.Nil(t, workerCancel)
 }
 func TestCountingOutputTransportCountsOpaquePayloadAndRejectsShortPayload(t *testing.T) {