chore(review): clarify allocation budget diagnostic
- commit
- 95dd00976f98dbc5df09f1e0283188f3833394cb
- author
- brice · · 2026-08-04 02:19 UTC
- parent
- cea36cd
- signature
- GPG Verified
CD88F9E564E0102646FB6077A1A07C7C7C3E349D· arch-gpg Verified for the committer email
2 files · +7 -3
M .coderabbit.yaml +6 -2
| @@ -1,7 +1,11 @@ | |||
| 1 | 1 | # Temporary PR #173 review scope; remove after the clean reviewed-head merge. | |
| 2 | 2 | reviews: | |
| 3 | 3 | path_filters: | |
| 4 | - | - "!internal/usecase/daemon/copy_enter_allocation_budget_race_test.go" | |
| 5 | - | - "!internal/usecase/daemon/copy_enter_allocation_budget_test.go" | |
| 4 | + | - "!internal/usecase/daemon/move_atomicity_test.go" | |
| 5 | + | - "!internal/usecase/daemon/move_final_source_attachment_race_test.go" | |
| 6 | 6 | - "!internal/usecase/daemon/pane_sync_owner_test.go" | |
| 7 | + | - "!internal/usecase/daemon/role_effect_gate_test.go" | |
| 7 | 8 | - "!internal/usecase/daemon/snatched_client_test.go" | |
| 9 | + | - "!internal/usecase/daemon/snatched_reclaim_test.go" | |
| 10 | + | - "!internal/usecase/daemon/snatched_render_test.go" | |
| 11 | + | - "!internal/usecase/daemon/stalled_attachment_test.go" | |
| @@ -1,7 +1,11 @@ | |||||
| 1 | # Temporary PR #173 review scope; remove after the clean reviewed-head merge. | 1 | # Temporary PR #173 review scope; remove after the clean reviewed-head merge. | ||
| 2 | reviews: | 2 | reviews: | ||
| 3 | path_filters: | 3 | path_filters: | ||
| 4 | - | - "!internal/usecase/daemon/copy_enter_allocation_budget_race_test.go" | 4 | + | - "!internal/usecase/daemon/move_atomicity_test.go" |
| 5 | - | - "!internal/usecase/daemon/copy_enter_allocation_budget_test.go" | 5 | + | - "!internal/usecase/daemon/move_final_source_attachment_race_test.go" |
| 6 | - "!internal/usecase/daemon/pane_sync_owner_test.go" | 6 | - "!internal/usecase/daemon/pane_sync_owner_test.go" | ||
| 7 | + | - "!internal/usecase/daemon/role_effect_gate_test.go" | |||
| 7 | - "!internal/usecase/daemon/snatched_client_test.go" | 8 | - "!internal/usecase/daemon/snatched_client_test.go" | ||
| 9 | + | - "!internal/usecase/daemon/snatched_reclaim_test.go" | |||
| 10 | + | - "!internal/usecase/daemon/snatched_render_test.go" | |||
| 11 | + | - "!internal/usecase/daemon/stalled_attachment_test.go" | |||
M internal/usecase/daemon/performance_benchmark_test.go +1 -1
| @@ -1278,7 +1278,7 @@ func TestCopyEnterAllocationBudget(t *testing.T) { | |||
| 1278 | 1278 | } | |
| 1279 | 1279 | ||
| 1280 | 1280 | allocs := testing.AllocsPerRun(20, run) | |
| 1281 | - | require.LessOrEqual(t, allocs, float64(tt.max), "copy enter must stay within 10%% of the attachment-aware allocation baseline") | |
| 1281 | + | require.LessOrEqual(t, allocs, float64(tt.max), "copy enter must stay within 10% of the attachment-aware allocation baseline") | |
| 1282 | 1282 | }) | |
| 1283 | 1283 | } | |
| 1284 | 1284 | } | |
| @@ -1278,7 +1278,7 @@ func TestCopyEnterAllocationBudget(t *testing.T) { | |||||
| 1278 | } | 1278 | } | ||
| 1279 | 1279 | ||||
| 1280 | allocs := testing.AllocsPerRun(20, run) | 1280 | allocs := testing.AllocsPerRun(20, run) | ||
| 1281 | - | require.LessOrEqual(t, allocs, float64(tt.max), "copy enter must stay within 10%% of the attachment-aware allocation baseline") | 1281 | + | require.LessOrEqual(t, allocs, float64(tt.max), "copy enter must stay within 10% of the attachment-aware allocation baseline") |
| 1282 | }) | 1282 | }) | ||
| 1283 | } | 1283 | } | ||
| 1284 | } | 1284 | } | ||