detached 0f2b5db

fix(daemon): log pending-notice drain failures at startup

A failed Drain() at startup previously vanished silently, undercutting
the notice feature's own purpose of surfacing lost state. Log it like
the shutdown-append path does.
commit
0f2b5db77f8c734e990f6c2c9cb3c910361042c3
author
brice · · 2026-07-21 04:51 UTC
parent
db7ba0d
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
1 file · +4 -1
M internal/usecase/daemon/snapshot.go +4 -1
@@ -67,7 +67,10 @@ func (d *Daemon) restoreSnapshots(ctx context.Context) {
6767 return
6868 }
6969 if ns := d.noticeStore; ns != nil {
70- drained, _ := ns.Drain()
70+ drained, err := ns.Drain()
71+ if err != nil {
72+ d.log.Warn("draining pending notices failed", "err", err)
73+ }
7174 for _, n := range drained {
7275 d.notices.record(n)
7376 d.notices.queueGlobal(n)
@@ -67,7 +67,10 @@ func (d *Daemon) restoreSnapshots(ctx context.Context) {
67 return67 return
68 }68 }
69 if ns := d.noticeStore; ns != nil {69 if ns := d.noticeStore; ns != nil {
70- drained, _ := ns.Drain()70+ drained, err := ns.Drain()
71+ if err != nil {
72+ d.log.Warn("draining pending notices failed", "err", err)
73+ }
71 for _, n := range drained {74 for _, n := range drained {
72 d.notices.record(n)75 d.notices.record(n)
73 d.notices.queueGlobal(n)76 d.notices.queueGlobal(n)

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 12

Tags 11

↑↓ moveenter openesc close