detached 129ef59

refactor(daemon): clarify attachment session accessors

commit
129ef590b39b0e5a534b045dbdd15fc82b1fc6b5
author
brice · · 2026-08-09 16:45 UTC
parent
032899b
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
1 file · +6 -6
M internal/usecase/daemon/client.go +6 -6
@@ -210,18 +210,18 @@ func (ac *attachedClient) clearGeometryClaim() {
210210 ac.sizeMu.Unlock()
211211 }
212212
213-func (ac *attachedClient) currentAttachmentSession() *session {
213+// currentSession returns the attachment's owning local session.
214+func (ac *attachedClient) currentSession() *session {
214215 if ac == nil {
215216 return nil
216217 }
217218 return ac.sess.Get()
218219 }
219220
220-// currentSession is the legacy local-session shorthand used by input and
221-// overlay paths; attachment-boundary code uses currentAttachmentSession to
222-// make ownership checks explicit.
223-func (ac *attachedClient) currentSession() *session {
224- return ac.currentAttachmentSession()
221+// currentAttachmentSession is the explicit ownership-boundary alias used by
222+// transition and rendering paths.
223+func (ac *attachedClient) currentAttachmentSession() *session {
224+ return ac.currentSession()
225225 }
226226
227227 func (ac *attachedClient) setSession(sess *session) { ac.sess.Set(sess) }
@@ -210,18 +210,18 @@ func (ac *attachedClient) clearGeometryClaim() {
210 ac.sizeMu.Unlock()210 ac.sizeMu.Unlock()
211 }211 }
212 212
213-func (ac *attachedClient) currentAttachmentSession() *session {213+// currentSession returns the attachment's owning local session.
214+func (ac *attachedClient) currentSession() *session {
214 if ac == nil {215 if ac == nil {
215 return nil216 return nil
216 }217 }
217 return ac.sess.Get()218 return ac.sess.Get()
218 }219 }
219 220
220-// currentSession is the legacy local-session shorthand used by input and221+// currentAttachmentSession is the explicit ownership-boundary alias used by
221-// overlay paths; attachment-boundary code uses currentAttachmentSession to222+// transition and rendering paths.
222-// make ownership checks explicit.223+func (ac *attachedClient) currentAttachmentSession() *session {
223-func (ac *attachedClient) currentSession() *session {224+ return ac.currentSession()
224- return ac.currentAttachmentSession()
225 }225 }
226 226
227 func (ac *attachedClient) setSession(sess *session) { ac.sess.Set(sess) }227 func (ac *attachedClient) setSession(sess *session) { ac.sess.Set(sess) }

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 12

Tags 11

↑↓ moveenter openesc close