detached 24d8746

fix(daemon): preserve standalone floating launch ownership

commit
24d8746de82d53ea9742dfb138fd8d04d7ea5bf1
author
brice · · 2026-07-12 09:46 UTC
parent
2f744a4
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
1 file · +4 -1
M internal/usecase/daemon/floating.go +4 -1
@@ -315,7 +315,10 @@ func (d *Daemon) openAndInstallFloating(sess *session, tb *tab, spec floatingLau
315315 default:
316316 }
317317 d.mu.Lock()
318- live := !d.closing && d.sessions[sess.id] == sess
318+ // Unit-scoped launch paths may use a session without registering it in the
319+ // daemon map. Production sessions have an ID and must still be owned by
320+ // the map until teardown removes them.
321+ live := !d.closing && (sess.id == "" || d.sessions[sess.id] == sess)
319322 d.mu.Unlock()
320323 if !live {
321324 return
@@ -315,7 +315,10 @@ func (d *Daemon) openAndInstallFloating(sess *session, tb *tab, spec floatingLau
315 default:315 default:
316 }316 }
317 d.mu.Lock()317 d.mu.Lock()
318- live := !d.closing && d.sessions[sess.id] == sess318+ // Unit-scoped launch paths may use a session without registering it in the
319+ // daemon map. Production sessions have an ID and must still be owned by
320+ // the map until teardown removes them.
321+ live := !d.closing && (sess.id == "" || d.sessions[sess.id] == sess)
319 d.mu.Unlock()322 d.mu.Unlock()
320 if !live {323 if !live {
321 return324 return

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 12

Tags 11

↑↓ moveenter openesc close