detached 4441ea3

refactor(daemon): simplify target membership check

commit
4441ea376e21a61a2a6adb3335b1efa33eb8ac0d
author
brice · · 2026-07-28 16:20 UTC
parent
52e1724
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
1 file · +3 -8
M internal/usecase/daemon/layout_mutation.go +3 -8
@@ -1,6 +1,8 @@
11 package daemon
22
33 import (
4+ "slices"
5+
46 "github.com/bnema/vev/internal/domain"
57 "github.com/bnema/vev/internal/usecase/layout"
68 )
@@ -31,14 +33,7 @@ func (d *Daemon) mutateTargetLayoutChanged(target daemonActionTarget, requirePan
3133 return false, layout.ErrNotFound
3234 }
3335 target.session.mu.Lock()
34- foundTab := false
35- for _, tb := range target.session.tabs {
36- if tb == target.tab {
37- foundTab = true
38- break
39- }
40- }
41- if !foundTab {
36+ if !slices.Contains(target.session.tabs, target.tab) {
4237 target.session.mu.Unlock()
4338 d.mu.Unlock()
4439 return false, layout.ErrNotFound
@@ -1,6 +1,8 @@
1 package daemon1 package daemon
2 2
3 import (3 import (
4+ "slices"
5+
4 "github.com/bnema/vev/internal/domain"6 "github.com/bnema/vev/internal/domain"
5 "github.com/bnema/vev/internal/usecase/layout"7 "github.com/bnema/vev/internal/usecase/layout"
6 )8 )
@@ -31,14 +33,7 @@ func (d *Daemon) mutateTargetLayoutChanged(target daemonActionTarget, requirePan
31 return false, layout.ErrNotFound33 return false, layout.ErrNotFound
32 }34 }
33 target.session.mu.Lock()35 target.session.mu.Lock()
34- foundTab := false36+ if !slices.Contains(target.session.tabs, target.tab) {
35- for _, tb := range target.session.tabs {
36- if tb == target.tab {
37- foundTab = true
38- break
39- }
40- }
41- if !foundTab {
42 target.session.mu.Unlock()37 target.session.mu.Unlock()
43 d.mu.Unlock()38 d.mu.Unlock()
44 return false, layout.ErrNotFound39 return false, layout.ErrNotFound

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 12

Tags 11

↑↓ moveenter openesc close