test(tabs): tighten rename tab persistence coverage

commit: 4b56f28eb5eeda59fdb919e6d1d445250a6addb9
author: brice · 3mo ago · 2026-07-04 02:10 UTC
parent: 2112549
signature: GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email

2 files · +10 -1

M internal/usecase/daemon/session.go +3 -0


@@ -222,6 +222,9 @@ func (d Daemon) createTab(sess session, sz domain.Size) error {
222	222		if err := d.persist.Save(record); err != nil {
223	223		sess.tabs = sess.tabs[:len(sess.tabs)-1]
224	224		sess.active = oldActive
	225	+	if tb.cancel != nil {
	226	+	tb.cancel()
	227	+	}
225	228		sess.mu.Unlock()
226	229		d.mu.Unlock()
227	230		_ = pty.Close()


@@ -222,6 +222,9 @@ func (d Daemon) createTab(sess session, sz domain.Size) error {
222	if err := d.persist.Save(record); err != nil {	222		if err := d.persist.Save(record); err != nil {
223	sess.tabs = sess.tabs[:len(sess.tabs)-1]	223		sess.tabs = sess.tabs[:len(sess.tabs)-1]
224	sess.active = oldActive	224		sess.active = oldActive
		225	+	if tb.cancel != nil {
		226	+	tb.cancel()
		227	+	}
225	sess.mu.Unlock()	228		sess.mu.Unlock()
226	d.mu.Unlock()	229		d.mu.Unlock()
227	_ = pty.Close()	230		_ = pty.Close()

M internal/usecase/daemon/session_test.go +7 -1


@@ -693,7 +693,12 @@ func TestRenameTabPersistsForNamedSession(t *testing.T) {
693	693
694	694		records, err := d.persist.LoadAll()
695	695		require.NoError(t, err)
696		-	require.Equal(t, []persist.Record{{Name: "work", Cwd: "/tmp/work", CreatedAt: sess.createdAt, UpdatedAt: records[0].UpdatedAt, TabNames: []string{"shell"}}}, records)
	696	+	require.Len(t, records, 1)
	697	+	require.Equal(t, "work", records[0].Name)
	698	+	require.Equal(t, "/tmp/work", records[0].Cwd)
	699	+	require.Equal(t, sess.createdAt, records[0].CreatedAt)
	700	+	require.GreaterOrEqual(t, records[0].UpdatedAt, records[0].CreatedAt)
	701	+	require.Equal(t, []string{"shell"}, records[0].TabNames)
697	702		}
698	703
699	704		func TestRenameTabDoesNotPersistForEphemeralSession(t *testing.T) {

@@ -707,6 +712,7 @@ func TestRenameTabDoesNotPersistForEphemeralSession(t *testing.T) {
707	712		sess, err := d.createSessionLocked("0", true, "/tmp/work", sz, nil)
708	713		require.NoError(t, err)
709	714		require.NoError(t, d.renameTab(sess, sess.tabs[0], "shell"))
	715	+	require.Equal(t, "shell", sess.tabs[0].name)
710	716
711	717		require.False(t, state.has("0"))
712	718		records, err := d.persist.LoadAll()

 	records, err := d.persist.LoadAll()
 	require.NoError(t, err)
-	require.Equal(t, []persist.Record{{Name: "work", Cwd: "/tmp/work", CreatedAt: sess.createdAt, UpdatedAt: records[0].UpdatedAt, TabNames: []string{"shell"}}}, records)
+	require.Len(t, records, 1)
+	require.Equal(t, "work", records[0].Name)
+	require.Equal(t, "/tmp/work", records[0].Cwd)
+	require.Equal(t, sess.createdAt, records[0].CreatedAt)
+	require.GreaterOrEqual(t, records[0].UpdatedAt, records[0].CreatedAt)
+	require.Equal(t, []string{"shell"}, records[0].TabNames)
 }
 func TestRenameTabDoesNotPersistForEphemeralSession(t *testing.T) {
 	sess, err := d.createSessionLocked("0", true, "/tmp/work", sz, nil)
 	require.NoError(t, err)
 	require.NoError(t, d.renameTab(sess, sess.tabs[0], "shell"))
+	require.Equal(t, "shell", sess.tabs[0].name)
 	require.False(t, state.has("0"))
 	records, err := d.persist.LoadAll()