detached 5dc1d38

fix(tabs): preserve current close lock order

commit
5dc1d38c6d8517408e261ef970c5d53f2fc72c1e
author
brice · · 2026-07-09 18:37 UTC
parent
bc467a6
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
1 file · +0 -6
M internal/usecase/daemon/session.go +0 -6
@@ -568,11 +568,6 @@ func (s *session) persistRecordLocked(updatedAt int64) persist.Record {
568568 }
569569
570570 func (d *Daemon) closeTab(sess *session, tb *tab, repaint bool) {
571- d.mu.Lock()
572- if d.sessions[sess.id] != sess {
573- d.mu.Unlock()
574- return
575- }
576571 sess.mu.Lock()
577572 idx := -1
578573 for i, w := range sess.tabs {
@@ -583,7 +578,6 @@ func (d *Daemon) closeTab(sess *session, tb *tab, repaint bool) {
583578 }
584579 if idx == -1 {
585580 sess.mu.Unlock()
586- d.mu.Unlock()
587581 return
588582 }
589583 if len(sess.tabs) == 1 {
@@ -568,11 +568,6 @@ func (s *session) persistRecordLocked(updatedAt int64) persist.Record {
568 }568 }
569 569
570 func (d *Daemon) closeTab(sess *session, tb *tab, repaint bool) {570 func (d *Daemon) closeTab(sess *session, tb *tab, repaint bool) {
571- d.mu.Lock()
572- if d.sessions[sess.id] != sess {
573- d.mu.Unlock()
574- return
575- }
576 sess.mu.Lock()571 sess.mu.Lock()
577 idx := -1572 idx := -1
578 for i, w := range sess.tabs {573 for i, w := range sess.tabs {
@@ -583,7 +578,6 @@ func (d *Daemon) closeTab(sess *session, tb *tab, repaint bool) {
583 }578 }
584 if idx == -1 {579 if idx == -1 {
585 sess.mu.Unlock()580 sess.mu.Unlock()
586- d.mu.Unlock()
587 return581 return
588 }582 }
589 if len(sess.tabs) == 1 {583 if len(sess.tabs) == 1 {

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 12

Tags 11

↑↓ moveenter openesc close