test(daemon): assert notification action errors

commit: 707278a49fdcb9805f6b445b4d704410c2ae67b4
author: brice · 3mo ago · 2026-07-21 11:04 UTC
parent: 89abebd
signature: GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email

3 files · +8 -4

M internal/usecase/daemon/attention_test.go +1 -1


@@ -511,7 +511,7 @@ func TestJumpAttentionCrossesSessionsWhenNoLocalBells(t *testing.T) {
511	511		}
512	512		d.sessions[sess2.id] = sess2
513	513
514		-	d.jumpAttention(sess1, ac)
	514	+	require.NoError(t, d.jumpAttention(sess1, ac))
515	515
516	516		require.Same(t, sess2, ac.currentSession())
517	517		require.Same(t, ac, sess2.client)


@@ -511,7 +511,7 @@ func TestJumpAttentionCrossesSessionsWhenNoLocalBells(t *testing.T) {
511		}	511		}
512		d.sessions[sess2.id] = sess2	512		d.sessions[sess2.id] = sess2
513			513
514	-	d.jumpAttention(sess1, ac)	514	+	require.NoError(t, d.jumpAttention(sess1, ac))
515			515
516		require.Same(t, sess2, ac.currentSession())	516		require.Same(t, sess2, ac.currentSession())
517		require.Same(t, ac, sess2.client)	517		require.Same(t, ac, sess2.client)

M internal/usecase/daemon/input_test.go +6 -2


@@ -618,7 +618,7 @@ func TestPaletteBackSessionTogglesPreviousSession(t *testing.T) {
618	618		recent := d.sessions[domain.SessionID("recent")]
619	619
620	620		// Picker-style successful transition records its origin.
621		-	d.switchToTarget(current, ac, picker.Target{Session: recent.id, TabIndex: -1})
	621	+	require.NoError(t, d.switchToTarget(current, ac, picker.Target{Session: recent.id, TabIndex: -1}))
622	622		for _, sess := range []*session{current, recent, current} {
623	623		runPaletteCommand(t, d, ac.currentSession(), ac, "BSK")
624	624		require.Same(t, sess, ac.currentSession())

@@ -746,7 +746,11 @@ func TestSwitchSourcePreviousSessionContracts(t *testing.T) {
746	746		defer releaseAll(releases)
747	747		recent := d.sessions[domain.SessionID("recent")]
748	748
749		-	d.switchToTarget(current, ac, tc.target(current, recent))
	749	+	if tc.name == "missing target does not record" {
	750	+	require.Error(t, d.switchToTarget(current, ac, tc.target(current, recent)))
	751	+	} else {
	752	+	require.NoError(t, d.switchToTarget(current, ac, tc.target(current, recent)))
	753	+	}
750	754		require.Equal(t, domain.SessionID(tc.wantCurrent), ac.currentSession().id)
751	755		if tc.wantPrev == "" {
752	756		require.Nil(t, ac.previousSession.Get())

 	recent := d.sessions[domain.SessionID("recent")]
 	// Picker-style successful transition records its origin.
-	d.switchToTarget(current, ac, picker.Target{Session: recent.id, TabIndex: -1})
+	require.NoError(t, d.switchToTarget(current, ac, picker.Target{Session: recent.id, TabIndex: -1}))
 	for _, sess := range []*session{current, recent, current} {
 		runPaletteCommand(t, d, ac.currentSession(), ac, "BSK")
 		require.Same(t, sess, ac.currentSession())
 			defer releaseAll(releases)
 			recent := d.sessions[domain.SessionID("recent")]
-			d.switchToTarget(current, ac, tc.target(current, recent))
+			if tc.name == "missing target does not record" {
+				require.Error(t, d.switchToTarget(current, ac, tc.target(current, recent)))
+			} else {
+				require.NoError(t, d.switchToTarget(current, ac, tc.target(current, recent)))
+			}
 			require.Equal(t, domain.SessionID(tc.wantCurrent), ac.currentSession().id)
 			if tc.wantPrev == "" {
 				require.Nil(t, ac.previousSession.Get())

M internal/usecase/daemon/session_test.go +1 -1


@@ -1211,7 +1211,7 @@ func TestPickerStoppedTargetKillPurges(t *testing.T) {
1211	1211		WithStore(store)(d)
1212	1212		require.NoError(t, d.persist.Save(persist.Record{Name: "old", Cwd: "/tmp", CreatedAt: 1, UpdatedAt: 1}))
1213	1213		d.stopped["old"] = stoppedSession{name: "old", cwd: "/tmp", createdAt: 1}
1214		-	d.killPickerTarget(picker.Target{Name: "old", Stopped: true})
	1214	+	require.NoError(t, d.killPickerTarget(picker.Target{Name: "old", Stopped: true}))
1215	1215		require.False(t, state.has("old"))
1216	1216		d.mu.Lock()
1217	1217		_, ok := d.stopped["old"]


@@ -1211,7 +1211,7 @@ func TestPickerStoppedTargetKillPurges(t *testing.T) {
1211		WithStore(store)(d)	1211		WithStore(store)(d)
1212		require.NoError(t, d.persist.Save(persist.Record{Name: "old", Cwd: "/tmp", CreatedAt: 1, UpdatedAt: 1}))	1212		require.NoError(t, d.persist.Save(persist.Record{Name: "old", Cwd: "/tmp", CreatedAt: 1, UpdatedAt: 1}))
1213		d.stopped["old"] = stoppedSession{name: "old", cwd: "/tmp", createdAt: 1}	1213		d.stopped["old"] = stoppedSession{name: "old", cwd: "/tmp", createdAt: 1}
1214	-	d.killPickerTarget(picker.Target{Name: "old", Stopped: true})	1214	+	require.NoError(t, d.killPickerTarget(picker.Target{Name: "old", Stopped: true}))
1215		require.False(t, state.has("old"))	1215		require.False(t, state.has("old"))
1216		d.mu.Lock()	1216		d.mu.Lock()
1217		_, ok := d.stopped["old"]	1217		_, ok := d.stopped["old"]