detached 72230e6

refactor(daemon): remove obsolete picker composer

commit
72230e6c9e396989b5b455a3e0f6f526c9d95ad0
author
brice · · 2026-07-12 05:19 UTC
parent
ef057e1
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
2 files · +0 -23
M internal/usecase/daemon/picker.go +0 -15
@@ -496,21 +496,6 @@ func (d *Daemon) refreshPicker(ac *attachedClient) {
496496 d.registerPreviewForSelection(ac)
497497 }
498498
499-func composePickerClientFrame(model *picker.Model, preview picker.Preview, base renderer.Frame, styles ...themeStyles) (renderer.Frame, []renderer.Damage) {
500- styleSet := resolveThemeStyles(styles)
501- renderStyles := picker.RenderStyles{
502- Selection: styleSet.selection,
503- SelectionName: styleSet.pickerSelectionName,
504- SelectionMuted: styleSet.pickerSelectionMuted,
505- Name: styleSet.pickerName,
506- Detail: styleSet.paletteDesc,
507- Base: renderer.DefaultStyle(),
508- }
509- return composeModalClientFrame(base, pickerModal, styleSet, styleSet.selection, func(size domain.Size, _ ...renderer.Style) renderer.Frame {
510- return model.Render(size, preview, renderStyles)
511- })
512-}
513-
514499 func snapshotPickerPreview(tb *tab) picker.Preview {
515500 if tb == nil {
516501 return picker.Preview{}
@@ -496,21 +496,6 @@ func (d *Daemon) refreshPicker(ac *attachedClient) {
496 d.registerPreviewForSelection(ac)496 d.registerPreviewForSelection(ac)
497 }497 }
498 498
499-func composePickerClientFrame(model *picker.Model, preview picker.Preview, base renderer.Frame, styles ...themeStyles) (renderer.Frame, []renderer.Damage) {
500- styleSet := resolveThemeStyles(styles)
501- renderStyles := picker.RenderStyles{
502- Selection: styleSet.selection,
503- SelectionName: styleSet.pickerSelectionName,
504- SelectionMuted: styleSet.pickerSelectionMuted,
505- Name: styleSet.pickerName,
506- Detail: styleSet.paletteDesc,
507- Base: renderer.DefaultStyle(),
508- }
509- return composeModalClientFrame(base, pickerModal, styleSet, styleSet.selection, func(size domain.Size, _ ...renderer.Style) renderer.Frame {
510- return model.Render(size, preview, renderStyles)
511- })
512-}
513-
514 func snapshotPickerPreview(tb *tab) picker.Preview {499 func snapshotPickerPreview(tb *tab) picker.Preview {
515 if tb == nil {500 if tb == nil {
516 return picker.Preview{}501 return picker.Preview{}
M internal/usecase/daemon/render_legacy_test.go +0 -8
@@ -47,14 +47,6 @@ type composedFrameCache struct {
4747 floatingCaptured capturedPaneRenderState
4848 }
4949
50-func (c *composedFrameCache) invalidate() {
51- c.valid = false
52- c.floating = nil
53- c.floatingGeneration = 0
54- c.floatingGeometry = floatingGeometry{}
55- c.floatingTitleGeneration = 0
56-}
57-
5850 func composeClientFrame(sess *session, tb *tab, full bool, rightStatus string, caches ...*barCache) (renderer.Frame, []renderer.Damage) {
5951 return composeClientFrameWithState(barState{status: sess.statusSegments(true), copyFeedback: rightStatus}, tb, full, caches...)
6052 }
@@ -47,14 +47,6 @@ type composedFrameCache struct {
47 floatingCaptured capturedPaneRenderState47 floatingCaptured capturedPaneRenderState
48 }48 }
49 49
50-func (c *composedFrameCache) invalidate() {
51- c.valid = false
52- c.floating = nil
53- c.floatingGeneration = 0
54- c.floatingGeometry = floatingGeometry{}
55- c.floatingTitleGeneration = 0
56-}
57-
58 func composeClientFrame(sess *session, tb *tab, full bool, rightStatus string, caches ...*barCache) (renderer.Frame, []renderer.Damage) {50 func composeClientFrame(sess *session, tb *tab, full bool, rightStatus string, caches ...*barCache) (renderer.Frame, []renderer.Damage) {
59 return composeClientFrameWithState(barState{status: sess.statusSegments(true), copyFeedback: rightStatus}, tb, full, caches...)51 return composeClientFrameWithState(barState{status: sess.statusSegments(true), copyFeedback: rightStatus}, tb, full, caches...)
60 }52 }

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 12

Tags 11

↑↓ moveenter openesc close