test(term): synchronize failed resize signal

commit: af99e02b86219463fed2b9198e342bc32b930313
author: brice · 3mo ago · 2026-07-25 08:13 UTC
parent: f9e1be4
signature: GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email

1 file · +3 -0

M internal/adapters/term/resize_test.go +3 -0


@@ -58,9 +58,11 @@ func TestResizeLoop_GetSizeErrorSkipsEmission(t *testing.T) {
58	58		quit := make(chan struct{})
59	59
60	60		var calls int
	61	+	firstGetSize := make(chan struct{})
61	62		getSize := func() (domain.Size, error) {
62	63		calls++
63	64		if calls == 1 {
	65	+	close(firstGetSize)
64	66		return domain.Size{}, errors.New("boom")
65	67		}
66	68		return domain.Size{Cols: 10, Rows: 5}, nil

@@ -69,6 +71,7 @@ func TestResizeLoop_GetSizeErrorSkipsEmission(t *testing.T) {
69	71		go resizeLoop(sig, out, quit, getSize)
70	72
71	73		sig <- syscall.SIGWINCH // errors; no emission
	74	+	<-firstGetSize // wait until the failed signal has been handled
72	75		sig <- syscall.SIGWINCH // succeeds
73	76
74	77		got := <-out


@@ -58,9 +58,11 @@ func TestResizeLoop_GetSizeErrorSkipsEmission(t *testing.T) {
58	quit := make(chan struct{})	58		quit := make(chan struct{})
59		59
60	var calls int	60		var calls int
		61	+	firstGetSize := make(chan struct{})
61	getSize := func() (domain.Size, error) {	62		getSize := func() (domain.Size, error) {
62	calls++	63		calls++
63	if calls == 1 {	64		if calls == 1 {
		65	+	close(firstGetSize)
64	return domain.Size{}, errors.New("boom")	66		return domain.Size{}, errors.New("boom")
65	}	67		}
66	return domain.Size{Cols: 10, Rows: 5}, nil	68		return domain.Size{Cols: 10, Rows: 5}, nil

@@ -69,6 +71,7 @@ func TestResizeLoop_GetSizeErrorSkipsEmission(t *testing.T) {
69	go resizeLoop(sig, out, quit, getSize)	71		go resizeLoop(sig, out, quit, getSize)
70		72
71	sig <- syscall.SIGWINCH // errors; no emission	73		sig <- syscall.SIGWINCH // errors; no emission
		74	+	<-firstGetSize // wait until the failed signal has been handled
72	sig <- syscall.SIGWINCH // succeeds	75		sig <- syscall.SIGWINCH // succeeds
73		76
74	got := <-out	77		got := <-out