fix(daemon): word color downgrade notice per mode
- commit
- b37521290671a0eb17ab8e10ffd9fe3115ef8fa2
- author
- brice · · 2026-10-03 13:23 UTC
- committer
- brice · · 2026-10-03 14:14 UTC
- parent
- da842a4
- signature
- GPG Verified
CD88F9E564E0102646FB6077A1A07C7C7C3E349D· arch-gpg Verified for the committer email
2 files · +8 -8
M internal/usecase/daemon/client.go +3 -3
| @@ -702,11 +702,11 @@ func colorDowngradeNotice(color terminalcap.ColorCapabilities) (string, bool) { | |||
| 702 | 702 | } | |
| 703 | 703 | switch color.Mode { | |
| 704 | 704 | case terminalcap.ANSI256: | |
| 705 | - | return "TrueColor was not detected; rendering with 256 colors.", true | |
| 705 | + | return "Terminal supports 256 colors; vev UI colors are reduced.", true | |
| 706 | 706 | case terminalcap.ANSI16: | |
| 707 | - | return "TrueColor was not detected; rendering with 16 colors.", true | |
| 707 | + | return "Terminal supports 16 colors; vev UI colors are reduced.", true | |
| 708 | 708 | case terminalcap.Monochrome: | |
| 709 | - | return "TrueColor was not detected; rendering without colors.", true | |
| 709 | + | return "Terminal has no color support; vev UI uses bold and reverse.", true | |
| 710 | 710 | default: | |
| 711 | 711 | return "", false | |
| 712 | 712 | } | |
| @@ -702,11 +702,11 @@ func colorDowngradeNotice(color terminalcap.ColorCapabilities) (string, bool) { | |||||
| 702 | } | 702 | } | ||
| 703 | switch color.Mode { | 703 | switch color.Mode { | ||
| 704 | case terminalcap.ANSI256: | 704 | case terminalcap.ANSI256: | ||
| 705 | - | return "TrueColor was not detected; rendering with 256 colors.", true | 705 | + | return "Terminal supports 256 colors; vev UI colors are reduced.", true |
| 706 | case terminalcap.ANSI16: | 706 | case terminalcap.ANSI16: | ||
| 707 | - | return "TrueColor was not detected; rendering with 16 colors.", true | 707 | + | return "Terminal supports 16 colors; vev UI colors are reduced.", true |
| 708 | case terminalcap.Monochrome: | 708 | case terminalcap.Monochrome: | ||
| 709 | - | return "TrueColor was not detected; rendering without colors.", true | 709 | + | return "Terminal has no color support; vev UI uses bold and reverse.", true |
| 710 | default: | 710 | default: | ||
| 711 | return "", false | 711 | return "", false | ||
| 712 | } | 712 | } | ||
M internal/usecase/daemon/color_notice_test.go +5 -5
| @@ -14,9 +14,9 @@ func TestColorDowngradeNotice(t *testing.T) { | |||
| 14 | 14 | color terminalcap.ColorCapabilities | |
| 15 | 15 | want string | |
| 16 | 16 | }{ | |
| 17 | - | {name: "declared 256 colors", color: terminalcap.ColorCapabilities{Mode: terminalcap.ANSI256, Source: terminalcap.SourceDeclared}, want: "TrueColor was not detected; rendering with 256 colors."}, | |
| 18 | - | {name: "declared 16 colors", color: terminalcap.ColorCapabilities{Mode: terminalcap.ANSI16, Source: terminalcap.SourceDeclared}, want: "TrueColor was not detected; rendering with 16 colors."}, | |
| 19 | - | {name: "declared monochrome", color: terminalcap.ColorCapabilities{Mode: terminalcap.Monochrome, Source: terminalcap.SourceDeclared}, want: "TrueColor was not detected; rendering without colors."}, | |
| 17 | + | {name: "declared 256 colors", color: terminalcap.ColorCapabilities{Mode: terminalcap.ANSI256, Source: terminalcap.SourceDeclared}, want: "Terminal supports 256 colors; vev UI colors are reduced."}, | |
| 18 | + | {name: "declared 16 colors", color: terminalcap.ColorCapabilities{Mode: terminalcap.ANSI16, Source: terminalcap.SourceDeclared}, want: "Terminal supports 16 colors; vev UI colors are reduced."}, | |
| 19 | + | {name: "declared monochrome", color: terminalcap.ColorCapabilities{Mode: terminalcap.Monochrome, Source: terminalcap.SourceDeclared}, want: "Terminal has no color support; vev UI uses bold and reverse."}, | |
| 20 | 20 | {name: "declared truecolor", color: terminalcap.ColorCapabilities{Mode: terminalcap.TrueColor, Source: terminalcap.SourceDeclared}}, | |
| 21 | 21 | {name: "forced 256 colors", color: terminalcap.ColorCapabilities{Mode: terminalcap.ANSI256, Source: terminalcap.SourceForced}}, | |
| 22 | 22 | {name: "forced 16 colors", color: terminalcap.ColorCapabilities{Mode: terminalcap.ANSI16, Source: terminalcap.SourceForced}}, | |
| @@ -42,8 +42,8 @@ func TestFinishAttachedClientColorToast(t *testing.T) { | |||
| 42 | 42 | color terminalcap.ColorCapabilities | |
| 43 | 43 | wantToast string | |
| 44 | 44 | }{ | |
| 45 | - | {name: "declared 256 colors toasts", color: terminalcap.ColorCapabilities{Mode: terminalcap.ANSI256, Source: terminalcap.SourceDeclared}, wantToast: "TrueColor was not detected; rendering with 256 colors."}, | |
| 46 | - | {name: "declared 16 colors toasts", color: terminalcap.ColorCapabilities{Mode: terminalcap.ANSI16, Source: terminalcap.SourceDeclared}, wantToast: "TrueColor was not detected; rendering with 16 colors."}, | |
| 45 | + | {name: "declared 256 colors toasts", color: terminalcap.ColorCapabilities{Mode: terminalcap.ANSI256, Source: terminalcap.SourceDeclared}, wantToast: "Terminal supports 256 colors; vev UI colors are reduced."}, | |
| 46 | + | {name: "declared 16 colors toasts", color: terminalcap.ColorCapabilities{Mode: terminalcap.ANSI16, Source: terminalcap.SourceDeclared}, wantToast: "Terminal supports 16 colors; vev UI colors are reduced."}, | |
| 47 | 47 | {name: "forced 16 colors is silent", color: terminalcap.ColorCapabilities{Mode: terminalcap.ANSI16, Source: terminalcap.SourceForced}}, | |
| 48 | 48 | {name: "declared truecolor is silent", color: terminalcap.ColorCapabilities{Mode: terminalcap.TrueColor, Source: terminalcap.SourceDeclared}}, | |
| 49 | 49 | } | |
| @@ -14,9 +14,9 @@ func TestColorDowngradeNotice(t *testing.T) { | |||||
| 14 | color terminalcap.ColorCapabilities | 14 | color terminalcap.ColorCapabilities | ||
| 15 | want string | 15 | want string | ||
| 16 | }{ | 16 | }{ | ||
| 17 | - | {name: "declared 256 colors", color: terminalcap.ColorCapabilities{Mode: terminalcap.ANSI256, Source: terminalcap.SourceDeclared}, want: "TrueColor was not detected; rendering with 256 colors."}, | 17 | + | {name: "declared 256 colors", color: terminalcap.ColorCapabilities{Mode: terminalcap.ANSI256, Source: terminalcap.SourceDeclared}, want: "Terminal supports 256 colors; vev UI colors are reduced."}, |
| 18 | - | {name: "declared 16 colors", color: terminalcap.ColorCapabilities{Mode: terminalcap.ANSI16, Source: terminalcap.SourceDeclared}, want: "TrueColor was not detected; rendering with 16 colors."}, | 18 | + | {name: "declared 16 colors", color: terminalcap.ColorCapabilities{Mode: terminalcap.ANSI16, Source: terminalcap.SourceDeclared}, want: "Terminal supports 16 colors; vev UI colors are reduced."}, |
| 19 | - | {name: "declared monochrome", color: terminalcap.ColorCapabilities{Mode: terminalcap.Monochrome, Source: terminalcap.SourceDeclared}, want: "TrueColor was not detected; rendering without colors."}, | 19 | + | {name: "declared monochrome", color: terminalcap.ColorCapabilities{Mode: terminalcap.Monochrome, Source: terminalcap.SourceDeclared}, want: "Terminal has no color support; vev UI uses bold and reverse."}, |
| 20 | {name: "declared truecolor", color: terminalcap.ColorCapabilities{Mode: terminalcap.TrueColor, Source: terminalcap.SourceDeclared}}, | 20 | {name: "declared truecolor", color: terminalcap.ColorCapabilities{Mode: terminalcap.TrueColor, Source: terminalcap.SourceDeclared}}, | ||
| 21 | {name: "forced 256 colors", color: terminalcap.ColorCapabilities{Mode: terminalcap.ANSI256, Source: terminalcap.SourceForced}}, | 21 | {name: "forced 256 colors", color: terminalcap.ColorCapabilities{Mode: terminalcap.ANSI256, Source: terminalcap.SourceForced}}, | ||
| 22 | {name: "forced 16 colors", color: terminalcap.ColorCapabilities{Mode: terminalcap.ANSI16, Source: terminalcap.SourceForced}}, | 22 | {name: "forced 16 colors", color: terminalcap.ColorCapabilities{Mode: terminalcap.ANSI16, Source: terminalcap.SourceForced}}, | ||
| @@ -42,8 +42,8 @@ func TestFinishAttachedClientColorToast(t *testing.T) { | |||||
| 42 | color terminalcap.ColorCapabilities | 42 | color terminalcap.ColorCapabilities | ||
| 43 | wantToast string | 43 | wantToast string | ||
| 44 | }{ | 44 | }{ | ||
| 45 | - | {name: "declared 256 colors toasts", color: terminalcap.ColorCapabilities{Mode: terminalcap.ANSI256, Source: terminalcap.SourceDeclared}, wantToast: "TrueColor was not detected; rendering with 256 colors."}, | 45 | + | {name: "declared 256 colors toasts", color: terminalcap.ColorCapabilities{Mode: terminalcap.ANSI256, Source: terminalcap.SourceDeclared}, wantToast: "Terminal supports 256 colors; vev UI colors are reduced."}, |
| 46 | - | {name: "declared 16 colors toasts", color: terminalcap.ColorCapabilities{Mode: terminalcap.ANSI16, Source: terminalcap.SourceDeclared}, wantToast: "TrueColor was not detected; rendering with 16 colors."}, | 46 | + | {name: "declared 16 colors toasts", color: terminalcap.ColorCapabilities{Mode: terminalcap.ANSI16, Source: terminalcap.SourceDeclared}, wantToast: "Terminal supports 16 colors; vev UI colors are reduced."}, |
| 47 | {name: "forced 16 colors is silent", color: terminalcap.ColorCapabilities{Mode: terminalcap.ANSI16, Source: terminalcap.SourceForced}}, | 47 | {name: "forced 16 colors is silent", color: terminalcap.ColorCapabilities{Mode: terminalcap.ANSI16, Source: terminalcap.SourceForced}}, | ||
| 48 | {name: "declared truecolor is silent", color: terminalcap.ColorCapabilities{Mode: terminalcap.TrueColor, Source: terminalcap.SourceDeclared}}, | 48 | {name: "declared truecolor is silent", color: terminalcap.ColorCapabilities{Mode: terminalcap.TrueColor, Source: terminalcap.SourceDeclared}}, | ||
| 49 | } | 49 | } | ||