skip to content

detached d79b562

fix(brokeripc): drop an admitted carriage from pending before its session runs

commit: d79b56214cc47cd8b2b99cfd1356797ac38a4dd7
author: brice · 14d ago · 2026-10-08 09:40 UTC
parent: df9a5fb
signature: GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email

1 file · +4 -0

M internal/adapters/brokeripc/server.go +4 -0


@@ -364,6 +364,10 @@ func (l *listener) startSession(transport wire.BoundedTransport, release func())
364	364		session.shutdown()
365	365		return nil, ErrListenerClosed
366	366		}
	367	+	// The session owns the carriage from here: drop it from pending in the
	368	+	// same critical section, so a Register racing admit's own untrack never
	369	+	// sees a stale pending carriage and refuses to retire.
	370	+	delete(l.pending, transport)
367	371		l.sessions[session] = struct{}{}
368	372		l.mu.Unlock()
369	373		go session.run()


@@ -364,6 +364,10 @@ func (l *listener) startSession(transport wire.BoundedTransport, release func())
364		session.shutdown()	364		session.shutdown()
365		return nil, ErrListenerClosed	365		return nil, ErrListenerClosed
366		}	366		}
			367	+	// The session owns the carriage from here: drop it from pending in the
			368	+	// same critical section, so a Register racing admit's own untrack never
			369	+	// sees a stale pending carriage and refuses to retire.
			370	+	delete(l.pending, transport)
367		l.sessions[session] = struct{}{}	371		l.sessions[session] = struct{}{}
368		l.mu.Unlock()	372		l.mu.Unlock()
369		go session.run()	373		go session.run()