test(app): drop sandbox-only broker tests
- commit
- f97fa3a509bd469d93f4224260d4e37826cff244
- author
- brice · · 2026-09-23 14:48 UTC
- parent
- 3b243bf
- signature
- GPG Verified
CD88F9E564E0102646FB6077A1A07C7C7C3E349D· arch-gpg Verified for the committer email
2 files · +0 -27
M internal/app/broker_production_test.go +0 -16
| @@ -11,22 +11,6 @@ import ( | |||
| 11 | 11 | "github.com/stretchr/testify/require" | |
| 12 | 12 | ) | |
| 13 | 13 | ||
| 14 | - | func TestProductionBrokerHiddenCommandsRejectSandboxOptions(t *testing.T) { | |
| 15 | - | serve, err := parseArgs([]string{productionBrokerServeCommand}) | |
| 16 | - | require.NoError(t, err) | |
| 17 | - | require.Equal(t, kindProductionBrokerServe, serve.kind) | |
| 18 | - | require.True(t, serve.brokerServe.production) | |
| 19 | - | ||
| 20 | - | launcher, err := parseArgs([]string{productionBrokerLauncherCommand}) | |
| 21 | - | require.NoError(t, err) | |
| 22 | - | require.Equal(t, kindProductionBrokerLauncher, launcher.kind) | |
| 23 | - | ||
| 24 | - | for _, name := range []string{productionBrokerServeCommand, productionBrokerLauncherCommand} { | |
| 25 | - | _, err = parseArgs([]string{name, "--offline-root", t.TempDir()}) | |
| 26 | - | require.Error(t, err) | |
| 27 | - | } | |
| 28 | - | } | |
| 29 | - | ||
| 30 | 14 | func TestEnsureProductionBrokerConfigCreatesPrivateEmptyBootstrapWithoutReplacingExisting(t *testing.T) { | |
| 31 | 15 | configHome := t.TempDir() | |
| 32 | 16 | t.Setenv("XDG_CONFIG_HOME", configHome) | |
| @@ -11,22 +11,6 @@ import ( | |||||
| 11 | "github.com/stretchr/testify/require" | 11 | "github.com/stretchr/testify/require" | ||
| 12 | ) | 12 | ) | ||
| 13 | 13 | ||||
| 14 | - | func TestProductionBrokerHiddenCommandsRejectSandboxOptions(t *testing.T) { | |||
| 15 | - | serve, err := parseArgs([]string{productionBrokerServeCommand}) | |||
| 16 | - | require.NoError(t, err) | |||
| 17 | - | require.Equal(t, kindProductionBrokerServe, serve.kind) | |||
| 18 | - | require.True(t, serve.brokerServe.production) | |||
| 19 | - | ||||
| 20 | - | launcher, err := parseArgs([]string{productionBrokerLauncherCommand}) | |||
| 21 | - | require.NoError(t, err) | |||
| 22 | - | require.Equal(t, kindProductionBrokerLauncher, launcher.kind) | |||
| 23 | - | ||||
| 24 | - | for _, name := range []string{productionBrokerServeCommand, productionBrokerLauncherCommand} { | |||
| 25 | - | _, err = parseArgs([]string{name, "--offline-root", t.TempDir()}) | |||
| 26 | - | require.Error(t, err) | |||
| 27 | - | } | |||
| 28 | - | } | |||
| 29 | - | ||||
| 30 | func TestEnsureProductionBrokerConfigCreatesPrivateEmptyBootstrapWithoutReplacingExisting(t *testing.T) { | 14 | func TestEnsureProductionBrokerConfigCreatesPrivateEmptyBootstrapWithoutReplacingExisting(t *testing.T) { | ||
| 31 | configHome := t.TempDir() | 15 | configHome := t.TempDir() | ||
| 32 | t.Setenv("XDG_CONFIG_HOME", configHome) | 16 | t.Setenv("XDG_CONFIG_HOME", configHome) | ||
M internal/app/ui_driver_test.go +0 -11
| @@ -109,17 +109,6 @@ func TestParseArgsUIOptionsAreAttachOnly(t *testing.T) { | |||
| 109 | 109 | require.Error(t, err) | |
| 110 | 110 | } | |
| 111 | 111 | ||
| 112 | - | // TestOfflineClientHarnessRejectsPickerForTheTerminalHarness pins the sandbox | |
| 113 | - | // option boundary: --picker is a UI-driver start, never a terminal-harness one. | |
| 114 | - | func TestOfflineClientHarnessRejectsPickerForTheTerminalHarness(t *testing.T) { | |
| 115 | - | _, err := parseArgs([]string{brokerClientCommand, "--offline-root", "/tmp/offline", "--picker"}) | |
| 116 | - | require.Error(t, err) | |
| 117 | - | command, err := parseArgs([]string{brokerClientCommand, "--offline-root", "/tmp/offline", "--harness", offlineClientUIDriver, "--picker"}) | |
| 118 | - | require.NoError(t, err) | |
| 119 | - | require.Equal(t, kindBrokerClient, command.kind) | |
| 120 | - | require.True(t, command.brokerClient.picker) | |
| 121 | - | } | |
| 122 | - | ||
| 123 | 112 | // TestInteractiveObservedCompositionUsesTheBrokerConnector pins that the | |
| 124 | 113 | // interactive observed path and the headless driver keep no daemon dialer, no | |
| 125 | 114 | // remote factory, and no launch configuration: both compose the shared broker | |
| @@ -109,17 +109,6 @@ func TestParseArgsUIOptionsAreAttachOnly(t *testing.T) { | |||||
| 109 | require.Error(t, err) | 109 | require.Error(t, err) | ||
| 110 | } | 110 | } | ||
| 111 | 111 | ||||
| 112 | - | // TestOfflineClientHarnessRejectsPickerForTheTerminalHarness pins the sandbox | |||
| 113 | - | // option boundary: --picker is a UI-driver start, never a terminal-harness one. | |||
| 114 | - | func TestOfflineClientHarnessRejectsPickerForTheTerminalHarness(t *testing.T) { | |||
| 115 | - | _, err := parseArgs([]string{brokerClientCommand, "--offline-root", "/tmp/offline", "--picker"}) | |||
| 116 | - | require.Error(t, err) | |||
| 117 | - | command, err := parseArgs([]string{brokerClientCommand, "--offline-root", "/tmp/offline", "--harness", offlineClientUIDriver, "--picker"}) | |||
| 118 | - | require.NoError(t, err) | |||
| 119 | - | require.Equal(t, kindBrokerClient, command.kind) | |||
| 120 | - | require.True(t, command.brokerClient.picker) | |||
| 121 | - | } | |||
| 122 | - | ||||
| 123 | // TestInteractiveObservedCompositionUsesTheBrokerConnector pins that the | 112 | // TestInteractiveObservedCompositionUsesTheBrokerConnector pins that the | ||
| 124 | // interactive observed path and the headless driver keep no daemon dialer, no | 113 | // interactive observed path and the headless driver keep no daemon dialer, no | ||
| 125 | // remote factory, and no launch configuration: both compose the shared broker | 114 | // remote factory, and no launch configuration: both compose the shared broker | ||