detached d367610

feat(disk): enhance selection with model, serial, and vendor info using JSON

commit
d367610afb6c57d0068d253b2b24930b07e3b289
author
bnema · · 2025-10-21 21:38 UTC
committer
bnema · · 2025-10-21 17:46 UTC
parent
c693e8f
signature
unsigned
1 file · +11 -2
M install/partitioning/detect-disk.sh +11 -2
@@ -4,8 +4,17 @@
44 gum style --foreground 6 --padding "1 0 0 $PADDING_LEFT" "Disk Selection"
55 echo
66
7-# List available disks
8-mapfile -t disks < <(lsblk -dno NAME,SIZE,TYPE | grep disk | awk '{print "/dev/" $1 " (" $2 ")"}')
7+# List available disks with detailed information using JSON output
8+mapfile -t disks < <(lsblk -J -d -o NAME,SIZE,TYPE,MODEL,SERIAL,VENDOR | jq -r '
9+ .blockdevices[] |
10+ select(.type == "disk") |
11+ (
12+ "/dev/\(.name) (\(.size))" +
13+ (if .model then " \(.model)" else "" end) +
14+ (if .serial then " [\(.serial)]" else "" end) +
15+ (if .vendor then " \(.vendor)" else "" end)
16+ )
17+')
918
1019 if [ ${#disks[@]} -eq 0 ]; then
1120 gum style --foreground 1 --padding "0 0 0 $PADDING_LEFT" "No disks found!"
@@ -4,8 +4,17 @@
4 gum style --foreground 6 --padding "1 0 0 $PADDING_LEFT" "Disk Selection"4 gum style --foreground 6 --padding "1 0 0 $PADDING_LEFT" "Disk Selection"
5 echo5 echo
6 6
7-# List available disks7+# List available disks with detailed information using JSON output
8-mapfile -t disks < <(lsblk -dno NAME,SIZE,TYPE | grep disk | awk '{print "/dev/" $1 " (" $2 ")"}')8+mapfile -t disks < <(lsblk -J -d -o NAME,SIZE,TYPE,MODEL,SERIAL,VENDOR | jq -r '
9+ .blockdevices[] |
10+ select(.type == "disk") |
11+ (
12+ "/dev/\(.name) (\(.size))" +
13+ (if .model then " \(.model)" else "" end) +
14+ (if .serial then " [\(.serial)]" else "" end) +
15+ (if .vendor then " \(.vendor)" else "" end)
16+ )
17+')
9 18
10 if [ ${#disks[@]} -eq 0 ]; then19 if [ ${#disks[@]} -eq 0 ]; then
11 gum style --foreground 1 --padding "0 0 0 $PADDING_LEFT" "No disks found!"20 gum style --foreground 1 --padding "0 0 0 $PADDING_LEFT" "No disks found!"

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 1

Tags 0

    ↑↓ moveenter openesc close