fix: address Greptile review feedback

- Fix color-picker.svelte: use $state instead of $derived.by() for bindable hex value
- Fix keybindings_gateway.go: add bounds checking for non-global modes in getDefaultKeys
- Fix watcher.go: reorder log and unlock for consistency (not a deadlock but cleaner)

commit: 026a7ae9c93e31ea9c7437d7ba6618bcebf0d861
author: brice · 9mo ago · 2026-01-24 16:32 UTC
parent: 381a26d
signature: GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email

3 files · +20 -7

M internal/infrastructure/config/keybindings_gateway.go +12 -4


@@ -229,13 +229,21 @@ func (KeybindingsGateway) getDefaultKeys(defaults Config, mode, action string)
229	229		return binding.Keys
230	230		}
231	231		case "pane":
232		-	return defaults.Workspace.PaneMode.Actions[action].Keys
	232	+	if binding, ok := defaults.Workspace.PaneMode.Actions[action]; ok {
	233	+	return binding.Keys
	234	+	}
233	235		case "tab":
234		-	return defaults.Workspace.TabMode.Actions[action].Keys
	236	+	if binding, ok := defaults.Workspace.TabMode.Actions[action]; ok {
	237	+	return binding.Keys
	238	+	}
235	239		case "resize":
236		-	return defaults.Workspace.ResizeMode.Actions[action].Keys
	240	+	if binding, ok := defaults.Workspace.ResizeMode.Actions[action]; ok {
	241	+	return binding.Keys
	242	+	}
237	243		case "session":
238		-	return defaults.Session.SessionMode.Actions[action].Keys
	244	+	if binding, ok := defaults.Session.SessionMode.Actions[action]; ok {
	245	+	return binding.Keys
	246	+	}
239	247		}
240	248		return nil
241	249		}

 			return binding.Keys
 		}
 	case "pane":
-		return defaults.Workspace.PaneMode.Actions[action].Keys
+		if binding, ok := defaults.Workspace.PaneMode.Actions[action]; ok {
+			return binding.Keys
+		}
 	case "tab":
-		return defaults.Workspace.TabMode.Actions[action].Keys
+		if binding, ok := defaults.Workspace.TabMode.Actions[action]; ok {
+			return binding.Keys
+		}
 	case "resize":
-		return defaults.Workspace.ResizeMode.Actions[action].Keys
+		if binding, ok := defaults.Workspace.ResizeMode.Actions[action]; ok {
+			return binding.Keys
+		}
 	case "session":
-		return defaults.Session.SessionMode.Actions[action].Keys
+		if binding, ok := defaults.Session.SessionMode.Actions[action]; ok {
+			return binding.Keys
+		}
 	}
 	return nil
 }

M internal/infrastructure/config/watcher.go +1 -1


@@ -40,8 +40,8 @@ func (m *Manager) Watch() error {
40	40
41	41		log.Debug().Msg("reloading config from external change")
42	42		if err := m.reload(); err != nil {
43		-	m.mu.Unlock()
44	43		log.Warn().Err(err).Msg("failed to reload config")
	44	+	m.mu.Unlock()
45	45		return
46	46		}
47	47		m.notifyCallbacksLocked()

 		log.Debug().Msg("reloading config from external change")
 		if err := m.reload(); err != nil {
-			m.mu.Unlock()
 			log.Warn().Err(err).Msg("failed to reload config")
+			m.mu.Unlock()
 			return
 		}
 		m.notifyCallbacksLocked()

M webui/src/lib/components/ui/color-picker/color-picker.svelte +7 -2


@@ -21,8 +21,13 @@
21	21
22	22		let open = $state(false);
23	23
24		-	// svelte-awesome-color-picker uses hex binding - use writable derived to sync with value
25		-	let hex = $derived.by(() => value);
	24	+	// svelte-awesome-color-picker uses hex binding - use state to sync with value
	25	+	let hex = $state(value);
	26	+
	27	+	// Sync hex when value changes externally
	28	+	$effect(() => {
	29	+	hex = value;
	30	+	});
26	31
27	32		function handleInput(event: { hex: string \| null }) {
28	33		if (event.hex) {

 	let open = $state(false);
-	// svelte-awesome-color-picker uses hex binding - use writable derived to sync with value
+	// svelte-awesome-color-picker uses hex binding - use state to sync with value
-	let hex = $derived.by(() => value);
+	let hex = $state(value);
+	// Sync hex when value changes externally
+	$effect(() => {
+		hex = value;
+	});
 	function handleInput(event: { hex: string | null }) {
 		if (event.hex) {