detached 07d6e36

fix(filtering): use HEAD request for version storage to match check

commit
07d6e368a9609c9b3dba86967e2281317dd7c613
author
bnema · · 2025-11-29 14:04 UTC
parent
3d12277
signature
unsigned
1 file · +3 -7
M internal/filtering/updater.go +3 -7
@@ -252,13 +252,9 @@ func (fu *FilterUpdater) downloadUpdate(ctx context.Context, url, lastModified,
252252 // Calculate content hash
253253 hash := fmt.Sprintf("%x", sha256.Sum256(currentContent))
254254
255- // Use HTTP headers as version identifier (same as fetchRemoteVersion)
256- version := ""
257- if etag := resp.Header.Get("ETag"); etag != "" {
258- version = etag
259- } else if lastMod := resp.Header.Get("Last-Modified"); lastMod != "" {
260- version = lastMod
261- }
255+ // Fetch version with HEAD request (same method as fetchRemoteVersion)
256+ // This ensures consistency - HEAD may return different ETag than GET
257+ version, _ := fu.fetchRemoteVersion(ctx, url)
262258
263259 // Create update object
264260 update := &FilterUpdate{
@@ -252,13 +252,9 @@ func (fu *FilterUpdater) downloadUpdate(ctx context.Context, url, lastModified,
252 // Calculate content hash252 // Calculate content hash
253 hash := fmt.Sprintf("%x", sha256.Sum256(currentContent))253 hash := fmt.Sprintf("%x", sha256.Sum256(currentContent))
254 254
255- // Use HTTP headers as version identifier (same as fetchRemoteVersion)255+ // Fetch version with HEAD request (same method as fetchRemoteVersion)
256- version := ""256+ // This ensures consistency - HEAD may return different ETag than GET
257- if etag := resp.Header.Get("ETag"); etag != "" {257+ version, _ := fu.fetchRemoteVersion(ctx, url)
258- version = etag
259- } else if lastMod := resp.Header.Get("Last-Modified"); lastMod != "" {
260- version = lastMod
261- }
262 258
263 // Create update object259 // Create update object
264 update := &FilterUpdate{260 update := &FilterUpdate{

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 8

Tags 42

↑↓ moveenter openesc close