13cc5a8 fix: address runtime config review findings · dumber

M internal/application/port/engine.go +3 -36


@@ -6,6 +6,8 @@ package port
6	6		import (
7	7		"context"
8	8		"encoding/json"
	9	+
	10	+	"github.com/bnema/dumber/internal/domain/entity"
9	11		)
10	12
11	13		// CookiePolicy controls cookie acceptance behavior for the engine's network session.

@@ -136,47 +138,12 @@ type Engine interface {
136	138		UpdateAppearance(ctx context.Context, r, g, b, alpha float64) error
137	139
138	140		// UpdateSettings applies runtime config changes to engine internals.
139		-	UpdateSettings(ctx context.Context, update EngineSettingsUpdate) error
	141	+	UpdateSettings(ctx context.Context, update entity.EngineSettingsUpdate) error
140	142
141	143		// SetHandlerContext sets the base context for message handler dispatch.
142	144		SetHandlerContext(ctx context.Context)
143	145		}
144	146
145		-	// EngineHardwareDecodingMode controls engine-facing video hardware acceleration.
146		-	type EngineHardwareDecodingMode string
147		-
148		-	const (
149		-	EngineHardwareDecodingAuto EngineHardwareDecodingMode = "auto"
150		-	EngineHardwareDecodingForce EngineHardwareDecodingMode = "force"
151		-	EngineHardwareDecodingDisable EngineHardwareDecodingMode = "disable"
152		-	)
153		-
154		-	// EngineWebContentSettingsPayload is the engine-facing runtime view of web
155		-	// content settings that can be applied to newly-created or existing webviews.
156		-	type EngineWebContentSettingsPayload struct {
157		-	SansFont string
158		-	SerifFont string
159		-	MonospaceFont string
160		-	DefaultFontSize int
161		-	EnableDevTools bool
162		-	CaptureConsole bool
163		-	DrawCompositingIndicators bool
164		-	HardwareDecoding EngineHardwareDecodingMode
165		-	AutoCopyOnSelection bool
166		-	}
167		-
168		-	// EngineSettingsPayload is the engine-facing boundary view of runtime config.
169		-	// Add fields here only when an engine needs to react to them at runtime.
170		-	type EngineSettingsPayload struct {
171		-	DefaultUIScale float64
172		-	WebContent EngineWebContentSettingsPayload
173		-	}
174		-
175		-	// EngineSettingsUpdate carries a runtime config change to the engine.
176		-	type EngineSettingsUpdate struct {
177		-	Settings EngineSettingsPayload
178		-	}
179		-
180	147		// WebUIMessageHandler handles a decoded message payload from the JS bridge.
181	148		// Used by both WebKit and CEF message routers via the shared handlers package.
182	149		type WebUIMessageHandler interface {


@@ -6,6 +6,8 @@ package port
6		import (	6		import (
7		"context"	7		"context"
8		"encoding/json"	8		"encoding/json"
			9	+
			10	+	"github.com/bnema/dumber/internal/domain/entity"
9		)	11		)
10			12
11		// CookiePolicy controls cookie acceptance behavior for the engine's network session.	13		// CookiePolicy controls cookie acceptance behavior for the engine's network session.

@@ -136,47 +138,12 @@ type Engine interface {
136		UpdateAppearance(ctx context.Context, r, g, b, alpha float64) error	138		UpdateAppearance(ctx context.Context, r, g, b, alpha float64) error
137			139
138		// UpdateSettings applies runtime config changes to engine internals.	140		// UpdateSettings applies runtime config changes to engine internals.
139	-	UpdateSettings(ctx context.Context, update EngineSettingsUpdate) error	141	+	UpdateSettings(ctx context.Context, update entity.EngineSettingsUpdate) error
140			142
141		// SetHandlerContext sets the base context for message handler dispatch.	143		// SetHandlerContext sets the base context for message handler dispatch.
142		SetHandlerContext(ctx context.Context)	144		SetHandlerContext(ctx context.Context)
143		}	145		}
144			146
145	-	// EngineHardwareDecodingMode controls engine-facing video hardware acceleration.
146	-	type EngineHardwareDecodingMode string
147	-
148	-	const (
149	-	EngineHardwareDecodingAuto EngineHardwareDecodingMode = "auto"
150	-	EngineHardwareDecodingForce EngineHardwareDecodingMode = "force"
151	-	EngineHardwareDecodingDisable EngineHardwareDecodingMode = "disable"
152	-	)
153	-
154	-	// EngineWebContentSettingsPayload is the engine-facing runtime view of web
155	-	// content settings that can be applied to newly-created or existing webviews.
156	-	type EngineWebContentSettingsPayload struct {
157	-	SansFont string
158	-	SerifFont string
159	-	MonospaceFont string
160	-	DefaultFontSize int
161	-	EnableDevTools bool
162	-	CaptureConsole bool
163	-	DrawCompositingIndicators bool
164	-	HardwareDecoding EngineHardwareDecodingMode
165	-	AutoCopyOnSelection bool
166	-	}
167	-
168	-	// EngineSettingsPayload is the engine-facing boundary view of runtime config.
169	-	// Add fields here only when an engine needs to react to them at runtime.
170	-	type EngineSettingsPayload struct {
171	-	DefaultUIScale float64
172	-	WebContent EngineWebContentSettingsPayload
173	-	}
174	-
175	-	// EngineSettingsUpdate carries a runtime config change to the engine.
176	-	type EngineSettingsUpdate struct {
177	-	Settings EngineSettingsPayload
178	-	}
179	-
180		// WebUIMessageHandler handles a decoded message payload from the JS bridge.	147		// WebUIMessageHandler handles a decoded message payload from the JS bridge.
181		// Used by both WebKit and CEF message routers via the shared handlers package.	148		// Used by both WebKit and CEF message routers via the shared handlers package.
182		type WebUIMessageHandler interface {	149		type WebUIMessageHandler interface {

M internal/application/port/mocks/engine.go +8 -7


@@ -9,6 +9,7 @@ import (
9	9		"encoding/json"
10	10
11	11		"github.com/bnema/dumber/internal/application/port"
	12	+	"github.com/bnema/dumber/internal/domain/entity"
12	13		mock "github.com/stretchr/testify/mock"
13	14		)
14	15

@@ -905,7 +906,7 @@ func (_c *MockEngine_UpdateAppearance_Call) RunAndReturn(run func(ctx context.Co
905	906		}
906	907
907	908		// UpdateSettings provides a mock function for the type MockEngine
908		-	func (_mock *MockEngine) UpdateSettings(ctx context.Context, update port.EngineSettingsUpdate) error {
	909	+	func (_mock *MockEngine) UpdateSettings(ctx context.Context, update entity.EngineSettingsUpdate) error {
909	910		ret := _mock.Called(ctx, update)
910	911
911	912		if len(ret) == 0 {

@@ -913,7 +914,7 @@ func (_mock *MockEngine) UpdateSettings(ctx context.Context, update port.EngineS
913	914		}
914	915
915	916		var r0 error
916		-	if returnFunc, ok := ret.Get(0).(func(context.Context, port.EngineSettingsUpdate) error); ok {
	917	+	if returnFunc, ok := ret.Get(0).(func(context.Context, entity.EngineSettingsUpdate) error); ok {
917	918		r0 = returnFunc(ctx, update)
918	919		} else {
919	920		r0 = ret.Error(0)

@@ -928,20 +929,20 @@ type MockEngine_UpdateSettings_Call struct {
928	929
929	930		// UpdateSettings is a helper method to define mock.On call
930	931		// - ctx context.Context
931		-	// - update port.EngineSettingsUpdate
	932	+	// - update entity.EngineSettingsUpdate
932	933		func (_e MockEngine_Expecter) UpdateSettings(ctx any, update any) MockEngine_UpdateSettings_Call {
933	934		return &MockEngine_UpdateSettings_Call{Call: _e.mock.On("UpdateSettings", ctx, update)}
934	935		}
935	936
936		-	func (_c MockEngine_UpdateSettings_Call) Run(run func(ctx context.Context, update port.EngineSettingsUpdate)) MockEngine_UpdateSettings_Call {
	937	+	func (_c MockEngine_UpdateSettings_Call) Run(run func(ctx context.Context, update entity.EngineSettingsUpdate)) MockEngine_UpdateSettings_Call {
937	938		_c.Call.Run(func(args mock.Arguments) {
938	939		var arg0 context.Context
939	940		if args[0] != nil {
940	941		arg0 = args[0].(context.Context)
941	942		}
942		-	var arg1 port.EngineSettingsUpdate
	943	+	var arg1 entity.EngineSettingsUpdate
943	944		if args[1] != nil {
944		-	arg1 = args[1].(port.EngineSettingsUpdate)
	945	+	arg1 = args[1].(entity.EngineSettingsUpdate)
945	946		}
946	947		run(
947	948		arg0,

@@ -956,7 +957,7 @@ func (_c MockEngine_UpdateSettings_Call) Return(err error) MockEngine_UpdateSe
956	957		return _c
957	958		}
958	959
959		-	func (_c MockEngine_UpdateSettings_Call) RunAndReturn(run func(ctx context.Context, update port.EngineSettingsUpdate) error) MockEngine_UpdateSettings_Call {
	960	+	func (_c MockEngine_UpdateSettings_Call) RunAndReturn(run func(ctx context.Context, update entity.EngineSettingsUpdate) error) MockEngine_UpdateSettings_Call {
960	961		_c.Call.Return(run)
961	962		return _c
962	963		}

 	"encoding/json"
 	"github.com/bnema/dumber/internal/application/port"
+	"github.com/bnema/dumber/internal/domain/entity"
 	mock "github.com/stretchr/testify/mock"
 )
 }
 // UpdateSettings provides a mock function for the type MockEngine
-func (_mock *MockEngine) UpdateSettings(ctx context.Context, update port.EngineSettingsUpdate) error {
+func (_mock *MockEngine) UpdateSettings(ctx context.Context, update entity.EngineSettingsUpdate) error {
 	ret := _mock.Called(ctx, update)
 	if len(ret) == 0 {
 	}
 	var r0 error
-	if returnFunc, ok := ret.Get(0).(func(context.Context, port.EngineSettingsUpdate) error); ok {
+	if returnFunc, ok := ret.Get(0).(func(context.Context, entity.EngineSettingsUpdate) error); ok {
 		r0 = returnFunc(ctx, update)
 	} else {
 		r0 = ret.Error(0)
 // UpdateSettings is a helper method to define mock.On call
 //   - ctx context.Context
-//   - update port.EngineSettingsUpdate
+//   - update entity.EngineSettingsUpdate
 func (_e *MockEngine_Expecter) UpdateSettings(ctx any, update any) *MockEngine_UpdateSettings_Call {
 	return &MockEngine_UpdateSettings_Call{Call: _e.mock.On("UpdateSettings", ctx, update)}
 }
-func (_c *MockEngine_UpdateSettings_Call) Run(run func(ctx context.Context, update port.EngineSettingsUpdate)) *MockEngine_UpdateSettings_Call {
+func (_c *MockEngine_UpdateSettings_Call) Run(run func(ctx context.Context, update entity.EngineSettingsUpdate)) *MockEngine_UpdateSettings_Call {
 	_c.Call.Run(func(args mock.Arguments) {
 		var arg0 context.Context
 		if args[0] != nil {
 			arg0 = args[0].(context.Context)
 		}
-		var arg1 port.EngineSettingsUpdate
+		var arg1 entity.EngineSettingsUpdate
 		if args[1] != nil {
-			arg1 = args[1].(port.EngineSettingsUpdate)
+			arg1 = args[1].(entity.EngineSettingsUpdate)
 		}
 		run(
 			arg0,
 	return _c
 }
-func (_c *MockEngine_UpdateSettings_Call) RunAndReturn(run func(ctx context.Context, update port.EngineSettingsUpdate) error) *MockEngine_UpdateSettings_Call {
+func (_c *MockEngine_UpdateSettings_Call) RunAndReturn(run func(ctx context.Context, update entity.EngineSettingsUpdate) error) *MockEngine_UpdateSettings_Call {
 	_c.Call.Return(run)
 	return _c
 }

M internal/application/port/mocks/runtime_config.go +13 -13


@@ -5,7 +5,7 @@
5	5		package mocks
6	6
7	7		import (
8		-	"github.com/bnema/dumber/internal/application/port"
	8	+	"github.com/bnema/dumber/internal/domain/entity"
9	9		mock "github.com/stretchr/testify/mock"
10	10		)
11	11

@@ -37,18 +37,18 @@ func (_m MockRuntimeConfigProvider) EXPECT() MockRuntimeConfigProvider_Expecte
37	37		}
38	38
39	39		// Current provides a mock function for the type MockRuntimeConfigProvider
40		-	func (_mock *MockRuntimeConfigProvider) Current() port.RuntimeConfigSnapshot {
	40	+	func (_mock *MockRuntimeConfigProvider) Current() entity.RuntimeConfigSnapshot {
41	41		ret := _mock.Called()
42	42
43	43		if len(ret) == 0 {
44	44		panic("no return value specified for Current")
45	45		}
46	46
47		-	var r0 port.RuntimeConfigSnapshot
48		-	if returnFunc, ok := ret.Get(0).(func() port.RuntimeConfigSnapshot); ok {
	47	+	var r0 entity.RuntimeConfigSnapshot
	48	+	if returnFunc, ok := ret.Get(0).(func() entity.RuntimeConfigSnapshot); ok {
49	49		r0 = returnFunc()
50	50		} else {
51		-	r0 = ret.Get(0).(port.RuntimeConfigSnapshot)
	51	+	r0 = ret.Get(0).(entity.RuntimeConfigSnapshot)
52	52		}
53	53		return r0
54	54		}

@@ -70,18 +70,18 @@ func (_c MockRuntimeConfigProvider_Current_Call) Run(run func()) MockRuntimeCo
70	70		return _c
71	71		}
72	72
73		-	func (_c MockRuntimeConfigProvider_Current_Call) Return(runtimeConfigSnapshot port.RuntimeConfigSnapshot) MockRuntimeConfigProvider_Current_Call {
	73	+	func (_c MockRuntimeConfigProvider_Current_Call) Return(runtimeConfigSnapshot entity.RuntimeConfigSnapshot) MockRuntimeConfigProvider_Current_Call {
74	74		_c.Call.Return(runtimeConfigSnapshot)
75	75		return _c
76	76		}
77	77
78		-	func (_c MockRuntimeConfigProvider_Current_Call) RunAndReturn(run func() port.RuntimeConfigSnapshot) MockRuntimeConfigProvider_Current_Call {
	78	+	func (_c MockRuntimeConfigProvider_Current_Call) RunAndReturn(run func() entity.RuntimeConfigSnapshot) MockRuntimeConfigProvider_Current_Call {
79	79		_c.Call.Return(run)
80	80		return _c
81	81		}
82	82
83	83		// OnChange provides a mock function for the type MockRuntimeConfigProvider
84		-	func (_mock *MockRuntimeConfigProvider) OnChange(fn func(port.RuntimeConfigSnapshot)) {
	84	+	func (_mock *MockRuntimeConfigProvider) OnChange(fn func(entity.RuntimeConfigSnapshot)) {
85	85		_mock.Called(fn)
86	86		return
87	87		}

@@ -92,16 +92,16 @@ type MockRuntimeConfigProvider_OnChange_Call struct {
92	92		}
93	93
94	94		// OnChange is a helper method to define mock.On call
95		-	// - fn func(port.RuntimeConfigSnapshot)
	95	+	// - fn func(entity.RuntimeConfigSnapshot)
96	96		func (_e MockRuntimeConfigProvider_Expecter) OnChange(fn any) MockRuntimeConfigProvider_OnChange_Call {
97	97		return &MockRuntimeConfigProvider_OnChange_Call{Call: _e.mock.On("OnChange", fn)}
98	98		}
99	99
100		-	func (_c MockRuntimeConfigProvider_OnChange_Call) Run(run func(fn func(port.RuntimeConfigSnapshot))) MockRuntimeConfigProvider_OnChange_Call {
	100	+	func (_c MockRuntimeConfigProvider_OnChange_Call) Run(run func(fn func(entity.RuntimeConfigSnapshot))) MockRuntimeConfigProvider_OnChange_Call {
101	101		_c.Call.Run(func(args mock.Arguments) {
102		-	var arg0 func(port.RuntimeConfigSnapshot)
	102	+	var arg0 func(entity.RuntimeConfigSnapshot)
103	103		if args[0] != nil {
104		-	arg0 = args[0].(func(port.RuntimeConfigSnapshot))
	104	+	arg0 = args[0].(func(entity.RuntimeConfigSnapshot))
105	105		}
106	106		run(
107	107		arg0,

@@ -115,7 +115,7 @@ func (_c MockRuntimeConfigProvider_OnChange_Call) Return() MockRuntimeConfigPr
115	115		return _c
116	116		}
117	117
118		-	func (_c MockRuntimeConfigProvider_OnChange_Call) RunAndReturn(run func(fn func(port.RuntimeConfigSnapshot))) MockRuntimeConfigProvider_OnChange_Call {
	118	+	func (_c MockRuntimeConfigProvider_OnChange_Call) RunAndReturn(run func(fn func(entity.RuntimeConfigSnapshot))) MockRuntimeConfigProvider_OnChange_Call {
119	119		_c.Run(run)
120	120		return _c
121	121		}


@@ -5,7 +5,7 @@
5		package mocks	5		package mocks
6			6
7		import (	7		import (
8	-	"github.com/bnema/dumber/internal/application/port"	8	+	"github.com/bnema/dumber/internal/domain/entity"
9		mock "github.com/stretchr/testify/mock"	9		mock "github.com/stretchr/testify/mock"
10		)	10		)
11			11

@@ -37,18 +37,18 @@ func (_m MockRuntimeConfigProvider) EXPECT() MockRuntimeConfigProvider_Expecte
37		}	37		}
38			38
39		// Current provides a mock function for the type MockRuntimeConfigProvider	39		// Current provides a mock function for the type MockRuntimeConfigProvider
40	-	func (_mock *MockRuntimeConfigProvider) Current() port.RuntimeConfigSnapshot {	40	+	func (_mock *MockRuntimeConfigProvider) Current() entity.RuntimeConfigSnapshot {
41		ret := _mock.Called()	41		ret := _mock.Called()
42			42
43		if len(ret) == 0 {	43		if len(ret) == 0 {
44		panic("no return value specified for Current")	44		panic("no return value specified for Current")
45		}	45		}
46			46
47	-	var r0 port.RuntimeConfigSnapshot	47	+	var r0 entity.RuntimeConfigSnapshot
48	-	if returnFunc, ok := ret.Get(0).(func() port.RuntimeConfigSnapshot); ok {	48	+	if returnFunc, ok := ret.Get(0).(func() entity.RuntimeConfigSnapshot); ok {
49		r0 = returnFunc()	49		r0 = returnFunc()
50		} else {	50		} else {
51	-	r0 = ret.Get(0).(port.RuntimeConfigSnapshot)	51	+	r0 = ret.Get(0).(entity.RuntimeConfigSnapshot)
52		}	52		}
53		return r0	53		return r0
54		}	54		}

@@ -70,18 +70,18 @@ func (_c MockRuntimeConfigProvider_Current_Call) Run(run func()) MockRuntimeCo
70		return _c	70		return _c
71		}	71		}
72			72
73	-	func (_c MockRuntimeConfigProvider_Current_Call) Return(runtimeConfigSnapshot port.RuntimeConfigSnapshot) MockRuntimeConfigProvider_Current_Call {	73	+	func (_c MockRuntimeConfigProvider_Current_Call) Return(runtimeConfigSnapshot entity.RuntimeConfigSnapshot) MockRuntimeConfigProvider_Current_Call {
74		_c.Call.Return(runtimeConfigSnapshot)	74		_c.Call.Return(runtimeConfigSnapshot)
75		return _c	75		return _c
76		}	76		}
77			77
78	-	func (_c MockRuntimeConfigProvider_Current_Call) RunAndReturn(run func() port.RuntimeConfigSnapshot) MockRuntimeConfigProvider_Current_Call {	78	+	func (_c MockRuntimeConfigProvider_Current_Call) RunAndReturn(run func() entity.RuntimeConfigSnapshot) MockRuntimeConfigProvider_Current_Call {
79		_c.Call.Return(run)	79		_c.Call.Return(run)
80		return _c	80		return _c
81		}	81		}
82			82
83		// OnChange provides a mock function for the type MockRuntimeConfigProvider	83		// OnChange provides a mock function for the type MockRuntimeConfigProvider
84	-	func (_mock *MockRuntimeConfigProvider) OnChange(fn func(port.RuntimeConfigSnapshot)) {	84	+	func (_mock *MockRuntimeConfigProvider) OnChange(fn func(entity.RuntimeConfigSnapshot)) {
85		_mock.Called(fn)	85		_mock.Called(fn)
86		return	86		return
87		}	87		}

@@ -92,16 +92,16 @@ type MockRuntimeConfigProvider_OnChange_Call struct {
92		}	92		}
93			93
94		// OnChange is a helper method to define mock.On call	94		// OnChange is a helper method to define mock.On call
95	-	// - fn func(port.RuntimeConfigSnapshot)	95	+	// - fn func(entity.RuntimeConfigSnapshot)
96		func (_e MockRuntimeConfigProvider_Expecter) OnChange(fn any) MockRuntimeConfigProvider_OnChange_Call {	96		func (_e MockRuntimeConfigProvider_Expecter) OnChange(fn any) MockRuntimeConfigProvider_OnChange_Call {
97		return &MockRuntimeConfigProvider_OnChange_Call{Call: _e.mock.On("OnChange", fn)}	97		return &MockRuntimeConfigProvider_OnChange_Call{Call: _e.mock.On("OnChange", fn)}
98		}	98		}
99			99
100	-	func (_c MockRuntimeConfigProvider_OnChange_Call) Run(run func(fn func(port.RuntimeConfigSnapshot))) MockRuntimeConfigProvider_OnChange_Call {	100	+	func (_c MockRuntimeConfigProvider_OnChange_Call) Run(run func(fn func(entity.RuntimeConfigSnapshot))) MockRuntimeConfigProvider_OnChange_Call {
101		_c.Call.Run(func(args mock.Arguments) {	101		_c.Call.Run(func(args mock.Arguments) {
102	-	var arg0 func(port.RuntimeConfigSnapshot)	102	+	var arg0 func(entity.RuntimeConfigSnapshot)
103		if args[0] != nil {	103		if args[0] != nil {
104	-	arg0 = args[0].(func(port.RuntimeConfigSnapshot))	104	+	arg0 = args[0].(func(entity.RuntimeConfigSnapshot))
105		}	105		}
106		run(	106		run(
107		arg0,	107		arg0,

@@ -115,7 +115,7 @@ func (_c MockRuntimeConfigProvider_OnChange_Call) Return() MockRuntimeConfigPr
115		return _c	115		return _c
116		}	116		}
117			117
118	-	func (_c MockRuntimeConfigProvider_OnChange_Call) RunAndReturn(run func(fn func(port.RuntimeConfigSnapshot))) MockRuntimeConfigProvider_OnChange_Call {	118	+	func (_c MockRuntimeConfigProvider_OnChange_Call) RunAndReturn(run func(fn func(entity.RuntimeConfigSnapshot))) MockRuntimeConfigProvider_OnChange_Call {
119		_c.Run(run)	119		_c.Run(run)
120		return _c	120		return _c
121		}	121		}

M internal/application/port/runtime_config.go +2 -46


@@ -3,51 +3,7 @@ package port
3	3		import "github.com/bnema/dumber/internal/domain/entity"
4	4
5	5		type RuntimeConfigProvider interface {
6		-	Current() RuntimeConfigSnapshot
	6	+	Current() entity.RuntimeConfigSnapshot
7	7		Watch() error
8		-	OnChange(func(RuntimeConfigSnapshot))
9		-	}
10		-
11		-	type RuntimeConfigSnapshot struct {
12		-	EngineSettings EngineSettingsPayload
13		-	UI RuntimeUIConfig
14		-	}
15		-
16		-	type RuntimeUIConfig struct {
17		-	DefaultUIScale float64
18		-	SidebarWidth int
19		-	Appearance entity.AppearanceConfig
20		-	Workspace entity.WorkspaceConfig
21		-	Session entity.SessionConfig
22		-	Clipboard RuntimeClipboardConfig
23		-	SearchShortcuts map[string]RuntimeSearchShortcut
24		-	DefaultSearchEngine string
25		-	Omnibox RuntimeOmniboxConfig
26		-	Update RuntimeUpdateConfig
27		-	Downloads RuntimeDownloadsConfig
28		-	}
29		-
30		-	type RuntimeClipboardConfig struct {
31		-	AutoCopyOnSelection bool
32		-	}
33		-
34		-	type RuntimeSearchShortcut struct {
35		-	URL string
36		-	Description string
37		-	}
38		-
39		-	type RuntimeOmniboxConfig struct {
40		-	InitialBehavior entity.OmniboxInitialBehavior
41		-	MostVisitedDays int
42		-	AutoOpenOnNewPane bool
43		-	}
44		-
45		-	type RuntimeUpdateConfig struct {
46		-	EnableOnStartup bool
47		-	AutoDownload bool
48		-	NotifyOnNewSettings bool
49		-	}
50		-
51		-	type RuntimeDownloadsConfig struct {
52		-	Path string
	8	+	OnChange(func(entity.RuntimeConfigSnapshot))
53	9		}


@@ -3,51 +3,7 @@ package port
3		import "github.com/bnema/dumber/internal/domain/entity"	3		import "github.com/bnema/dumber/internal/domain/entity"
4			4
5		type RuntimeConfigProvider interface {	5		type RuntimeConfigProvider interface {
6	-	Current() RuntimeConfigSnapshot	6	+	Current() entity.RuntimeConfigSnapshot
7		Watch() error	7		Watch() error
8	-	OnChange(func(RuntimeConfigSnapshot))	8	+	OnChange(func(entity.RuntimeConfigSnapshot))
9	-	}
10	-
11	-	type RuntimeConfigSnapshot struct {
12	-	EngineSettings EngineSettingsPayload
13	-	UI RuntimeUIConfig
14	-	}
15	-
16	-	type RuntimeUIConfig struct {
17	-	DefaultUIScale float64
18	-	SidebarWidth int
19	-	Appearance entity.AppearanceConfig
20	-	Workspace entity.WorkspaceConfig
21	-	Session entity.SessionConfig
22	-	Clipboard RuntimeClipboardConfig
23	-	SearchShortcuts map[string]RuntimeSearchShortcut
24	-	DefaultSearchEngine string
25	-	Omnibox RuntimeOmniboxConfig
26	-	Update RuntimeUpdateConfig
27	-	Downloads RuntimeDownloadsConfig
28	-	}
29	-
30	-	type RuntimeClipboardConfig struct {
31	-	AutoCopyOnSelection bool
32	-	}
33	-
34	-	type RuntimeSearchShortcut struct {
35	-	URL string
36	-	Description string
37	-	}
38	-
39	-	type RuntimeOmniboxConfig struct {
40	-	InitialBehavior entity.OmniboxInitialBehavior
41	-	MostVisitedDays int
42	-	AutoOpenOnNewPane bool
43	-	}
44	-
45	-	type RuntimeUpdateConfig struct {
46	-	EnableOnStartup bool
47	-	AutoDownload bool
48	-	NotifyOnNewSettings bool
49	-	}
50	-
51	-	type RuntimeDownloadsConfig struct {
52	-	Path string
53		}	9		}

M internal/bootstrap/runtime_config.go +35 -27


@@ -13,7 +13,7 @@ type configChangeManager interface {
13	13		}
14	14
15	15		type runtimeConfigProvider struct {
16		-	fallback port.RuntimeConfigSnapshot
	16	+	fallback entity.RuntimeConfigSnapshot
17	17		manager configChangeManager
18	18		}
19	19

@@ -24,14 +24,18 @@ func NewRuntimeConfigProvider(cfg *config.Config, manager configChangeManager) p
24	24		}
25	25		}
26	26
27		-	func (p *runtimeConfigProvider) Current() port.RuntimeConfigSnapshot {
	27	+	func (p *runtimeConfigProvider) Current() entity.RuntimeConfigSnapshot {
28	28		if p == nil {
29		-	return port.RuntimeConfigSnapshot{}
	29	+	return entity.RuntimeConfigSnapshot{}
30	30		}
31	31		if p.manager == nil {
32	32		return cloneRuntimeConfigSnapshot(p.fallback)
33	33		}
34		-	return RuntimeConfigSnapshotFromConfig(p.manager.Get())
	34	+	cfg := p.manager.Get()
	35	+	if cfg == nil {
	36	+	return cloneRuntimeConfigSnapshot(p.fallback)
	37	+	}
	38	+	return RuntimeConfigSnapshotFromConfig(cfg)
35	39		}
36	40
37	41		func (p *runtimeConfigProvider) Watch() error {

@@ -41,22 +45,26 @@ func (p *runtimeConfigProvider) Watch() error {
41	45		return p.manager.Watch()
42	46		}
43	47
44		-	func (p *runtimeConfigProvider) OnChange(callback func(port.RuntimeConfigSnapshot)) {
	48	+	func (p *runtimeConfigProvider) OnChange(callback func(entity.RuntimeConfigSnapshot)) {
45	49		if p == nil \|\| p.manager == nil \|\| callback == nil {
46	50		return
47	51		}
48	52		p.manager.OnConfigChange(func(cfg *config.Config) {
	53	+	if cfg == nil {
	54	+	callback(cloneRuntimeConfigSnapshot(p.fallback))
	55	+	return
	56	+	}
49	57		callback(RuntimeConfigSnapshotFromConfig(cfg))
50	58		})
51	59		}
52	60
53		-	func EngineSettingsPayloadFromConfig(cfg *config.Config) port.EngineSettingsPayload {
	61	+	func EngineSettingsPayloadFromConfig(cfg *config.Config) entity.EngineSettingsPayload {
54	62		if cfg == nil {
55		-	return port.EngineSettingsPayload{}
	63	+	return entity.EngineSettingsPayload{}
56	64		}
57		-	return port.EngineSettingsPayload{
	65	+	return entity.EngineSettingsPayload{
58	66		DefaultUIScale: cfg.DefaultUIScale,
59		-	WebContent: port.EngineWebContentSettingsPayload{
	67	+	WebContent: entity.EngineWebContentSettingsPayload{
60	68		SansFont: cfg.Appearance.SansFont,
61	69		SerifFont: cfg.Appearance.SerifFont,
62	70		MonospaceFont: cfg.Appearance.MonospaceFont,

@@ -70,40 +78,40 @@ func EngineSettingsPayloadFromConfig(cfg *config.Config) port.EngineSettingsPayl
70	78		}
71	79		}
72	80
73		-	func RuntimeConfigSnapshotFromConfig(cfg *config.Config) port.RuntimeConfigSnapshot {
	81	+	func RuntimeConfigSnapshotFromConfig(cfg *config.Config) entity.RuntimeConfigSnapshot {
74	82		if cfg == nil {
75		-	return port.RuntimeConfigSnapshot{}
	83	+	return entity.RuntimeConfigSnapshot{}
76	84		}
77		-	return port.RuntimeConfigSnapshot{
	85	+	return entity.RuntimeConfigSnapshot{
78	86		EngineSettings: EngineSettingsPayloadFromConfig(cfg),
79		-	UI: port.RuntimeUIConfig{
	87	+	UI: entity.RuntimeUIConfig{
80	88		DefaultUIScale: cfg.DefaultUIScale,
81	89		SidebarWidth: cfg.SidebarWidth,
82	90		Appearance: cfg.Appearance,
83	91		Workspace: cloneWorkspaceConfig(cfg.Workspace),
84	92		Session: cloneSessionConfig(cfg.Session),
85		-	Clipboard: port.RuntimeClipboardConfig{AutoCopyOnSelection: cfg.Clipboard.AutoCopyOnSelection},
	93	+	Clipboard: entity.RuntimeClipboardConfig{AutoCopyOnSelection: cfg.Clipboard.AutoCopyOnSelection},
86	94		SearchShortcuts: runtimeSearchShortcutsFromConfig(cfg.SearchShortcuts),
87	95		DefaultSearchEngine: cfg.DefaultSearchEngine,
88		-	Omnibox: port.RuntimeOmniboxConfig{
	96	+	Omnibox: entity.RuntimeOmniboxConfig{
89	97		InitialBehavior: cfg.Omnibox.InitialBehavior,
90	98		MostVisitedDays: cfg.Omnibox.MostVisitedDays,
91	99		AutoOpenOnNewPane: cfg.Omnibox.AutoOpenOnNewPane,
92	100		},
93		-	Update: port.RuntimeUpdateConfig{
	101	+	Update: entity.RuntimeUpdateConfig{
94	102		EnableOnStartup: cfg.Update.EnableOnStartup,
95	103		AutoDownload: cfg.Update.AutoDownload,
96	104		NotifyOnNewSettings: cfg.Update.NotifyOnNewSettings,
97	105		},
98		-	Downloads: port.RuntimeDownloadsConfig{Path: cfg.Downloads.Path},
	106	+	Downloads: entity.RuntimeDownloadsConfig{Path: cfg.Downloads.Path},
99	107		},
100	108		}
101	109		}
102	110
103		-	func runtimeSearchShortcutsFromConfig(in map[string]config.SearchShortcut) map[string]port.RuntimeSearchShortcut {
104		-	out := make(map[string]port.RuntimeSearchShortcut, len(in))
	111	+	func runtimeSearchShortcutsFromConfig(in map[string]config.SearchShortcut) map[string]entity.RuntimeSearchShortcut {
	112	+	out := make(map[string]entity.RuntimeSearchShortcut, len(in))
105	113		for key, shortcut := range in {
106		-	out[key] = port.RuntimeSearchShortcut{
	114	+	out[key] = entity.RuntimeSearchShortcut{
107	115		URL: shortcut.URL,
108	116		Description: shortcut.Description,
109	117		}

@@ -111,18 +119,18 @@ func runtimeSearchShortcutsFromConfig(in map[string]config.SearchShortcut) map[s
111	119		return out
112	120		}
113	121
114		-	func cloneRuntimeConfigSnapshot(snapshot port.RuntimeConfigSnapshot) port.RuntimeConfigSnapshot {
	122	+	func cloneRuntimeConfigSnapshot(snapshot entity.RuntimeConfigSnapshot) entity.RuntimeConfigSnapshot {
115	123		snapshot.UI.SearchShortcuts = cloneRuntimeSearchShortcuts(snapshot.UI.SearchShortcuts)
116	124		snapshot.UI.Workspace = cloneWorkspaceConfig(snapshot.UI.Workspace)
117	125		snapshot.UI.Session = cloneSessionConfig(snapshot.UI.Session)
118	126		return snapshot
119	127		}
120	128
121		-	func cloneRuntimeSearchShortcuts(in map[string]port.RuntimeSearchShortcut) map[string]port.RuntimeSearchShortcut {
	129	+	func cloneRuntimeSearchShortcuts(in map[string]entity.RuntimeSearchShortcut) map[string]entity.RuntimeSearchShortcut {
122	130		if in == nil {
123	131		return nil
124	132		}
125		-	out := make(map[string]port.RuntimeSearchShortcut, len(in))
	133	+	out := make(map[string]entity.RuntimeSearchShortcut, len(in))
126	134		for key, shortcut := range in {
127	135		out[key] = shortcut
128	136		}

@@ -176,13 +184,13 @@ func cloneStringSlice(in []string) []string {
176	184		return out
177	185		}
178	186
179		-	func engineHardwareDecodingModeFromConfig(mode config.HardwareDecodingMode) port.EngineHardwareDecodingMode {
	187	+	func engineHardwareDecodingModeFromConfig(mode config.HardwareDecodingMode) entity.EngineHardwareDecodingMode {
180	188		switch mode {
181	189		case config.HardwareDecodingForce:
182		-	return port.EngineHardwareDecodingForce
	190	+	return entity.EngineHardwareDecodingForce
183	191		case config.HardwareDecodingDisable:
184		-	return port.EngineHardwareDecodingDisable
	192	+	return entity.EngineHardwareDecodingDisable
185	193		default:
186		-	return port.EngineHardwareDecodingAuto
	194	+	return entity.EngineHardwareDecodingAuto
187	195		}
188	196		}

 }
 type runtimeConfigProvider struct {
-	fallback port.RuntimeConfigSnapshot
+	fallback entity.RuntimeConfigSnapshot
 	manager  configChangeManager
 }
 	}
 }
-func (p *runtimeConfigProvider) Current() port.RuntimeConfigSnapshot {
+func (p *runtimeConfigProvider) Current() entity.RuntimeConfigSnapshot {
 	if p == nil {
-		return port.RuntimeConfigSnapshot{}
+		return entity.RuntimeConfigSnapshot{}
 	}
 	if p.manager == nil {
 		return cloneRuntimeConfigSnapshot(p.fallback)
 	}
-	return RuntimeConfigSnapshotFromConfig(p.manager.Get())
+	cfg := p.manager.Get()
+	if cfg == nil {
+		return cloneRuntimeConfigSnapshot(p.fallback)
+	}
+	return RuntimeConfigSnapshotFromConfig(cfg)
 }
 func (p *runtimeConfigProvider) Watch() error {
 	return p.manager.Watch()
 }
-func (p *runtimeConfigProvider) OnChange(callback func(port.RuntimeConfigSnapshot)) {
+func (p *runtimeConfigProvider) OnChange(callback func(entity.RuntimeConfigSnapshot)) {
 	if p == nil || p.manager == nil || callback == nil {
 		return
 	}
 	p.manager.OnConfigChange(func(cfg *config.Config) {
+		if cfg == nil {
+			callback(cloneRuntimeConfigSnapshot(p.fallback))
+			return
+		}
 		callback(RuntimeConfigSnapshotFromConfig(cfg))
 	})
 }
-func EngineSettingsPayloadFromConfig(cfg *config.Config) port.EngineSettingsPayload {
+func EngineSettingsPayloadFromConfig(cfg *config.Config) entity.EngineSettingsPayload {
 	if cfg == nil {
-		return port.EngineSettingsPayload{}
+		return entity.EngineSettingsPayload{}
 	}
-	return port.EngineSettingsPayload{
+	return entity.EngineSettingsPayload{
 		DefaultUIScale: cfg.DefaultUIScale,
-		WebContent: port.EngineWebContentSettingsPayload{
+		WebContent: entity.EngineWebContentSettingsPayload{
 			SansFont:                  cfg.Appearance.SansFont,
 			SerifFont:                 cfg.Appearance.SerifFont,
 			MonospaceFont:             cfg.Appearance.MonospaceFont,
 	}
 }
-func RuntimeConfigSnapshotFromConfig(cfg *config.Config) port.RuntimeConfigSnapshot {
+func RuntimeConfigSnapshotFromConfig(cfg *config.Config) entity.RuntimeConfigSnapshot {
 	if cfg == nil {
-		return port.RuntimeConfigSnapshot{}
+		return entity.RuntimeConfigSnapshot{}
 	}
-	return port.RuntimeConfigSnapshot{
+	return entity.RuntimeConfigSnapshot{
 		EngineSettings: EngineSettingsPayloadFromConfig(cfg),
-		UI: port.RuntimeUIConfig{
+		UI: entity.RuntimeUIConfig{
 			DefaultUIScale:      cfg.DefaultUIScale,
 			SidebarWidth:        cfg.SidebarWidth,
 			Appearance:          cfg.Appearance,
 			Workspace:           cloneWorkspaceConfig(cfg.Workspace),
 			Session:             cloneSessionConfig(cfg.Session),
-			Clipboard:           port.RuntimeClipboardConfig{AutoCopyOnSelection: cfg.Clipboard.AutoCopyOnSelection},
+			Clipboard:           entity.RuntimeClipboardConfig{AutoCopyOnSelection: cfg.Clipboard.AutoCopyOnSelection},
 			SearchShortcuts:     runtimeSearchShortcutsFromConfig(cfg.SearchShortcuts),
 			DefaultSearchEngine: cfg.DefaultSearchEngine,
-			Omnibox: port.RuntimeOmniboxConfig{
+			Omnibox: entity.RuntimeOmniboxConfig{
 				InitialBehavior:   cfg.Omnibox.InitialBehavior,
 				MostVisitedDays:   cfg.Omnibox.MostVisitedDays,
 				AutoOpenOnNewPane: cfg.Omnibox.AutoOpenOnNewPane,
 			},
-			Update: port.RuntimeUpdateConfig{
+			Update: entity.RuntimeUpdateConfig{
 				EnableOnStartup:     cfg.Update.EnableOnStartup,
 				AutoDownload:        cfg.Update.AutoDownload,
 				NotifyOnNewSettings: cfg.Update.NotifyOnNewSettings,
 			},
-			Downloads: port.RuntimeDownloadsConfig{Path: cfg.Downloads.Path},
+			Downloads: entity.RuntimeDownloadsConfig{Path: cfg.Downloads.Path},
 		},
 	}
 }
-func runtimeSearchShortcutsFromConfig(in map[string]config.SearchShortcut) map[string]port.RuntimeSearchShortcut {
+func runtimeSearchShortcutsFromConfig(in map[string]config.SearchShortcut) map[string]entity.RuntimeSearchShortcut {
-	out := make(map[string]port.RuntimeSearchShortcut, len(in))
+	out := make(map[string]entity.RuntimeSearchShortcut, len(in))
 	for key, shortcut := range in {
-		out[key] = port.RuntimeSearchShortcut{
+		out[key] = entity.RuntimeSearchShortcut{
 			URL:         shortcut.URL,
 			Description: shortcut.Description,
 		}
 	return out
 }
-func cloneRuntimeConfigSnapshot(snapshot port.RuntimeConfigSnapshot) port.RuntimeConfigSnapshot {
+func cloneRuntimeConfigSnapshot(snapshot entity.RuntimeConfigSnapshot) entity.RuntimeConfigSnapshot {
 	snapshot.UI.SearchShortcuts = cloneRuntimeSearchShortcuts(snapshot.UI.SearchShortcuts)
 	snapshot.UI.Workspace = cloneWorkspaceConfig(snapshot.UI.Workspace)
 	snapshot.UI.Session = cloneSessionConfig(snapshot.UI.Session)
 	return snapshot
 }
-func cloneRuntimeSearchShortcuts(in map[string]port.RuntimeSearchShortcut) map[string]port.RuntimeSearchShortcut {
+func cloneRuntimeSearchShortcuts(in map[string]entity.RuntimeSearchShortcut) map[string]entity.RuntimeSearchShortcut {
 	if in == nil {
 		return nil
 	}
-	out := make(map[string]port.RuntimeSearchShortcut, len(in))
+	out := make(map[string]entity.RuntimeSearchShortcut, len(in))
 	for key, shortcut := range in {
 		out[key] = shortcut
 	}
 	return out
 }
-func engineHardwareDecodingModeFromConfig(mode config.HardwareDecodingMode) port.EngineHardwareDecodingMode {
+func engineHardwareDecodingModeFromConfig(mode config.HardwareDecodingMode) entity.EngineHardwareDecodingMode {
 	switch mode {
 	case config.HardwareDecodingForce:
-		return port.EngineHardwareDecodingForce
+		return entity.EngineHardwareDecodingForce
 	case config.HardwareDecodingDisable:
-		return port.EngineHardwareDecodingDisable
+		return entity.EngineHardwareDecodingDisable
 	default:
-		return port.EngineHardwareDecodingAuto
+		return entity.EngineHardwareDecodingAuto
 	}
 }

M internal/bootstrap/runtime_config_test.go +52 -20


@@ -4,7 +4,6 @@ import (
4	4		"reflect"
5	5		"testing"
6	6
7		-	"github.com/bnema/dumber/internal/application/port"
8	7		bootstrapmocks "github.com/bnema/dumber/internal/bootstrap/mocks"
9	8		"github.com/bnema/dumber/internal/domain/entity"
10	9		"github.com/bnema/dumber/internal/infrastructure/config"

@@ -76,8 +75,8 @@ func TestEngineSettingsPayloadFromConfigMapsRuntimeFields(t *testing.T) {
76	75		!got.WebContent.DrawCompositingIndicators {
77	76		t.Fatalf("debug settings not mapped: %#v", got.WebContent)
78	77		}
79		-	if got.WebContent.HardwareDecoding != port.EngineHardwareDecodingForce {
80		-	t.Fatalf("HardwareDecoding=%q, want %q", got.WebContent.HardwareDecoding, port.EngineHardwareDecodingForce)
	78	+	if got.WebContent.HardwareDecoding != entity.EngineHardwareDecodingForce {
	79	+	t.Fatalf("HardwareDecoding=%q, want %q", got.WebContent.HardwareDecoding, entity.EngineHardwareDecodingForce)
81	80		}
82	81		autoCopyField := reflect.ValueOf(got.WebContent).FieldByName("AutoCopyOnSelection")
83	82		if !autoCopyField.IsValid() \|\| !autoCopyField.Bool() {

@@ -91,8 +90,8 @@ func TestRuntimeConfigProviderUpdatesSnapshotBeforeCallback(t *testing.T) {
91	90		manager := &configManagerState{}
92	91		provider := NewRuntimeConfigProvider(initial, newMockConfigManager(t, manager))
93	92
94		-	var seen port.RuntimeConfigSnapshot
95		-	provider.OnChange(func(snapshot port.RuntimeConfigSnapshot) {
	93	+	var seen entity.RuntimeConfigSnapshot
	94	+	provider.OnChange(func(snapshot entity.RuntimeConfigSnapshot) {
96	95		seen = snapshot
97	96		})
98	97

@@ -123,6 +122,20 @@ func TestRuntimeConfigProviderCurrentReflectsManagerGetWithoutSubscription(t *te
123	122		}
124	123		}
125	124
	125	+	func TestRuntimeConfigProviderCurrentFallsBackWhenManagerGetReturnsNil(t *testing.T) {
	126	+	initial := config.DefaultConfig()
	127	+	initial.DefaultUIScale = 1.35
	128	+	manager := &configManagerState{}
	129	+	provider := NewRuntimeConfigProvider(initial, newMockConfigManager(t, manager))
	130	+
	131	+	got := provider.Current()
	132	+	want := RuntimeConfigSnapshotFromConfig(initial)
	133	+
	134	+	if !reflect.DeepEqual(got, want) {
	135	+	t.Fatalf("Current()=%#v, want initial fallback %#v", got, want)
	136	+	}
	137	+	}
	138	+
126	139		func TestRuntimeConfigProviderOnChangeCallbackCanCallCurrent(t *testing.T) {
127	140		initial := config.DefaultConfig()
128	141		initial.DefaultUIScale = 1

@@ -130,8 +143,8 @@ func TestRuntimeConfigProviderOnChangeCallbackCanCallCurrent(t *testing.T) {
130	143		provider := NewRuntimeConfigProvider(initial, newMockConfigManager(t, manager))
131	144
132	145		completed := false
133		-	var seen port.RuntimeConfigSnapshot
134		-	provider.OnChange(func(port.RuntimeConfigSnapshot) {
	146	+	var seen entity.RuntimeConfigSnapshot
	147	+	provider.OnChange(func(entity.RuntimeConfigSnapshot) {
135	148		seen = provider.Current()
136	149		completed = true
137	150		})

@@ -148,6 +161,25 @@ func TestRuntimeConfigProviderOnChangeCallbackCanCallCurrent(t *testing.T) {
148	161		}
149	162		}
150	163
	164	+	func TestRuntimeConfigProviderOnChangeFallsBackWhenPayloadIsNil(t *testing.T) {
	165	+	initial := config.DefaultConfig()
	166	+	initial.DefaultUIScale = 1.35
	167	+	manager := &configManagerState{current: initial}
	168	+	provider := NewRuntimeConfigProvider(initial, newMockConfigManager(t, manager))
	169	+
	170	+	var seen entity.RuntimeConfigSnapshot
	171	+	provider.OnChange(func(snapshot entity.RuntimeConfigSnapshot) {
	172	+	seen = snapshot
	173	+	})
	174	+
	175	+	manager.emit(nil)
	176	+	want := RuntimeConfigSnapshotFromConfig(initial)
	177	+
	178	+	if !reflect.DeepEqual(seen, want) {
	179	+	t.Fatalf("callback snapshot=%#v, want initial fallback %#v", seen, want)
	180	+	}
	181	+	}
	182	+
151	183		func TestRuntimeConfigProviderOnChangeNilCallbackDoesNotRegister(t *testing.T) {
152	184		manager := &configManagerState{current: config.DefaultConfig()}
153	185		provider := NewRuntimeConfigProvider(config.DefaultConfig(), newMockConfigManager(t, manager))

@@ -179,7 +211,7 @@ func TestRuntimeConfigProviderCurrentReturnsMapClone(t *testing.T) {
179	211		provider := NewRuntimeConfigProvider(cfg, newMockConfigManager(t, &configManagerState{current: cfg}))
180	212
181	213		first := provider.Current()
182		-	first.UI.SearchShortcuts["gh"] = port.RuntimeSearchShortcut{URL: "mutated"}
	214	+	first.UI.SearchShortcuts["gh"] = entity.RuntimeSearchShortcut{URL: "mutated"}
183	215		second := provider.Current()
184	216
185	217		if second.UI.SearchShortcuts["gh"].URL == "mutated" {

@@ -202,7 +234,7 @@ func TestRuntimeConfigProviderOnChangePassesNestedConfigClone(t *testing.T) {
202	234		manager := &configManagerState{}
203	235		provider := NewRuntimeConfigProvider(config.DefaultConfig(), newMockConfigManager(t, manager))
204	236
205		-	provider.OnChange(func(snapshot port.RuntimeConfigSnapshot) {
	237	+	provider.OnChange(func(snapshot entity.RuntimeConfigSnapshot) {
206	238		mutateNestedRuntimeConfigSnapshot(snapshot)
207	239		})
208	240

@@ -213,7 +245,7 @@ func TestRuntimeConfigProviderOnChangePassesNestedConfigClone(t *testing.T) {
213	245
214	246		func TestEngineSettingsPayloadFromNilConfigReturnsZeroPayload(t *testing.T) {
215	247		got := EngineSettingsPayloadFromConfig(nil)
216		-	if got != (port.EngineSettingsPayload{}) {
	248	+	if got != (entity.EngineSettingsPayload{}) {
217	249		t.Fatalf("payload=%#v, want zero value", got)
218	250		}
219	251		}

@@ -241,7 +273,7 @@ func runtimeConfigWithNestedMutableFields() *config.Config {
241	273		return cfg
242	274		}
243	275
244		-	func mutateNestedRuntimeConfigSnapshot(snapshot port.RuntimeConfigSnapshot) {
	276	+	func mutateNestedRuntimeConfigSnapshot(snapshot entity.RuntimeConfigSnapshot) {
245	277		mutateActionBinding(snapshot.UI.Workspace.PaneMode.Actions, "split-right", "mutated-pane")
246	278		snapshot.UI.Workspace.PaneMode.Actions["added-pane"] = entity.ActionBinding{Keys: []string{"added"}}
247	279

@@ -269,7 +301,7 @@ func mutateActionBinding(actions map[string]entity.ActionBinding, action, key st
269	301		actions[action] = binding
270	302		}
271	303
272		-	func assertNestedRuntimeConfigSnapshotUnchanged(t *testing.T, snapshot port.RuntimeConfigSnapshot) {
	304	+	func assertNestedRuntimeConfigSnapshotUnchanged(t *testing.T, snapshot entity.RuntimeConfigSnapshot) {
273	305		t.Helper()
274	306
275	307		assertActionBinding(t, snapshot.UI.Workspace.PaneMode.Actions, "split-right", "r")

@@ -377,7 +409,7 @@ func TestRuntimeConfigSnapshotFromConfigMapsUIRuntimeFields(t *testing.T) {
377	409		if got.UI.SearchShortcuts["gh"].URL != "https://github.com/search?q=%s" {
378	410		t.Fatalf("search shortcut not mapped: %#v", got.UI.SearchShortcuts)
379	411		}
380		-	got.UI.SearchShortcuts["gh"] = port.RuntimeSearchShortcut{URL: "mutated"}
	412	+	got.UI.SearchShortcuts["gh"] = entity.RuntimeSearchShortcut{URL: "mutated"}
381	413		if cfg.SearchShortcuts["gh"].URL == "mutated" {
382	414		t.Fatal("snapshot must deep-copy search shortcut map")
383	415		}

@@ -394,7 +426,7 @@ func TestRuntimeConfigSnapshotFromConfigDetachesNestedMutableFields(t *testing.T
394	426
395	427		func TestRuntimeConfigSnapshotFromNilConfigReturnsZeroSnapshot(t *testing.T) {
396	428		got := RuntimeConfigSnapshotFromConfig(nil)
397		-	if !reflect.DeepEqual(got, port.RuntimeConfigSnapshot{}) {
	429	+	if !reflect.DeepEqual(got, entity.RuntimeConfigSnapshot{}) {
398	430		t.Fatalf("snapshot=%#v, want zero value", got)
399	431		}
400	432		}

@@ -403,32 +435,32 @@ func TestEngineSettingsPayloadFromConfigMapsHardwareDecodingModes(t *testing.T)
403	435		tests := []struct {
404	436		name string
405	437		mode config.HardwareDecodingMode
406		-	want port.EngineHardwareDecodingMode
	438	+	want entity.EngineHardwareDecodingMode
407	439		}{
408	440		{
409	441		name: "auto",
410	442		mode: config.HardwareDecodingAuto,
411		-	want: port.EngineHardwareDecodingAuto,
	443	+	want: entity.EngineHardwareDecodingAuto,
412	444		},
413	445		{
414	446		name: "force",
415	447		mode: config.HardwareDecodingForce,
416		-	want: port.EngineHardwareDecodingForce,
	448	+	want: entity.EngineHardwareDecodingForce,
417	449		},
418	450		{
419	451		name: "disable",
420	452		mode: config.HardwareDecodingDisable,
421		-	want: port.EngineHardwareDecodingDisable,
	453	+	want: entity.EngineHardwareDecodingDisable,
422	454		},
423	455		{
424	456		name: "unknown",
425	457		mode: config.HardwareDecodingMode("surprise"),
426		-	want: port.EngineHardwareDecodingAuto,
	458	+	want: entity.EngineHardwareDecodingAuto,
427	459		},
428	460		{
429	461		name: "zero value",
430	462		mode: "",
431		-	want: port.EngineHardwareDecodingAuto,
	463	+	want: entity.EngineHardwareDecodingAuto,
432	464		},
433	465		}
434	466

 	"reflect"
 	"testing"
-	"github.com/bnema/dumber/internal/application/port"
 	bootstrapmocks "github.com/bnema/dumber/internal/bootstrap/mocks"
 	"github.com/bnema/dumber/internal/domain/entity"
 	"github.com/bnema/dumber/internal/infrastructure/config"
 		!got.WebContent.DrawCompositingIndicators {
 		t.Fatalf("debug settings not mapped: %#v", got.WebContent)
 	}
-	if got.WebContent.HardwareDecoding != port.EngineHardwareDecodingForce {
+	if got.WebContent.HardwareDecoding != entity.EngineHardwareDecodingForce {
-		t.Fatalf("HardwareDecoding=%q, want %q", got.WebContent.HardwareDecoding, port.EngineHardwareDecodingForce)
+		t.Fatalf("HardwareDecoding=%q, want %q", got.WebContent.HardwareDecoding, entity.EngineHardwareDecodingForce)
 	}
 	autoCopyField := reflect.ValueOf(got.WebContent).FieldByName("AutoCopyOnSelection")
 	if !autoCopyField.IsValid() || !autoCopyField.Bool() {
 	manager := &configManagerState{}
 	provider := NewRuntimeConfigProvider(initial, newMockConfigManager(t, manager))
-	var seen port.RuntimeConfigSnapshot
+	var seen entity.RuntimeConfigSnapshot
-	provider.OnChange(func(snapshot port.RuntimeConfigSnapshot) {
+	provider.OnChange(func(snapshot entity.RuntimeConfigSnapshot) {
 		seen = snapshot
 	})
 	}
 }
+func TestRuntimeConfigProviderCurrentFallsBackWhenManagerGetReturnsNil(t *testing.T) {
+	initial := config.DefaultConfig()
+	initial.DefaultUIScale = 1.35
+	manager := &configManagerState{}
+	provider := NewRuntimeConfigProvider(initial, newMockConfigManager(t, manager))
+	got := provider.Current()
+	want := RuntimeConfigSnapshotFromConfig(initial)
+	if !reflect.DeepEqual(got, want) {
+		t.Fatalf("Current()=%#v, want initial fallback %#v", got, want)
+	}
+}
 func TestRuntimeConfigProviderOnChangeCallbackCanCallCurrent(t *testing.T) {
 	initial := config.DefaultConfig()
 	initial.DefaultUIScale = 1
 	provider := NewRuntimeConfigProvider(initial, newMockConfigManager(t, manager))
 	completed := false
-	var seen port.RuntimeConfigSnapshot
+	var seen entity.RuntimeConfigSnapshot
-	provider.OnChange(func(port.RuntimeConfigSnapshot) {
+	provider.OnChange(func(entity.RuntimeConfigSnapshot) {
 		seen = provider.Current()
 		completed = true
 	})
 	}
 }
+func TestRuntimeConfigProviderOnChangeFallsBackWhenPayloadIsNil(t *testing.T) {
+	initial := config.DefaultConfig()
+	initial.DefaultUIScale = 1.35
+	manager := &configManagerState{current: initial}
+	provider := NewRuntimeConfigProvider(initial, newMockConfigManager(t, manager))
+	var seen entity.RuntimeConfigSnapshot
+	provider.OnChange(func(snapshot entity.RuntimeConfigSnapshot) {
+		seen = snapshot
+	})
+	manager.emit(nil)
+	want := RuntimeConfigSnapshotFromConfig(initial)
+	if !reflect.DeepEqual(seen, want) {
+		t.Fatalf("callback snapshot=%#v, want initial fallback %#v", seen, want)
+	}
+}
 func TestRuntimeConfigProviderOnChangeNilCallbackDoesNotRegister(t *testing.T) {
 	manager := &configManagerState{current: config.DefaultConfig()}
 	provider := NewRuntimeConfigProvider(config.DefaultConfig(), newMockConfigManager(t, manager))
 	provider := NewRuntimeConfigProvider(cfg, newMockConfigManager(t, &configManagerState{current: cfg}))
 	first := provider.Current()
-	first.UI.SearchShortcuts["gh"] = port.RuntimeSearchShortcut{URL: "mutated"}
+	first.UI.SearchShortcuts["gh"] = entity.RuntimeSearchShortcut{URL: "mutated"}
 	second := provider.Current()
 	if second.UI.SearchShortcuts["gh"].URL == "mutated" {
 	manager := &configManagerState{}
 	provider := NewRuntimeConfigProvider(config.DefaultConfig(), newMockConfigManager(t, manager))
-	provider.OnChange(func(snapshot port.RuntimeConfigSnapshot) {
+	provider.OnChange(func(snapshot entity.RuntimeConfigSnapshot) {
 		mutateNestedRuntimeConfigSnapshot(snapshot)
 	})
 func TestEngineSettingsPayloadFromNilConfigReturnsZeroPayload(t *testing.T) {
 	got := EngineSettingsPayloadFromConfig(nil)
-	if got != (port.EngineSettingsPayload{}) {
+	if got != (entity.EngineSettingsPayload{}) {
 		t.Fatalf("payload=%#v, want zero value", got)
 	}
 }
 	return cfg
 }
-func mutateNestedRuntimeConfigSnapshot(snapshot port.RuntimeConfigSnapshot) {
+func mutateNestedRuntimeConfigSnapshot(snapshot entity.RuntimeConfigSnapshot) {
 	mutateActionBinding(snapshot.UI.Workspace.PaneMode.Actions, "split-right", "mutated-pane")
 	snapshot.UI.Workspace.PaneMode.Actions["added-pane"] = entity.ActionBinding{Keys: []string{"added"}}
 	actions[action] = binding
 }
-func assertNestedRuntimeConfigSnapshotUnchanged(t *testing.T, snapshot port.RuntimeConfigSnapshot) {
+func assertNestedRuntimeConfigSnapshotUnchanged(t *testing.T, snapshot entity.RuntimeConfigSnapshot) {
 	t.Helper()
 	assertActionBinding(t, snapshot.UI.Workspace.PaneMode.Actions, "split-right", "r")
 	if got.UI.SearchShortcuts["gh"].URL != "https://github.com/search?q=%s" {
 		t.Fatalf("search shortcut not mapped: %#v", got.UI.SearchShortcuts)
 	}
-	got.UI.SearchShortcuts["gh"] = port.RuntimeSearchShortcut{URL: "mutated"}
+	got.UI.SearchShortcuts["gh"] = entity.RuntimeSearchShortcut{URL: "mutated"}
 	if cfg.SearchShortcuts["gh"].URL == "mutated" {
 		t.Fatal("snapshot must deep-copy search shortcut map")
 	}
 func TestRuntimeConfigSnapshotFromNilConfigReturnsZeroSnapshot(t *testing.T) {
 	got := RuntimeConfigSnapshotFromConfig(nil)
-	if !reflect.DeepEqual(got, port.RuntimeConfigSnapshot{}) {
+	if !reflect.DeepEqual(got, entity.RuntimeConfigSnapshot{}) {
 		t.Fatalf("snapshot=%#v, want zero value", got)
 	}
 }
 	tests := []struct {
 		name string
 		mode config.HardwareDecodingMode
-		want port.EngineHardwareDecodingMode
+		want entity.EngineHardwareDecodingMode
 	}{
 		{
 			name: "auto",
 			mode: config.HardwareDecodingAuto,
-			want: port.EngineHardwareDecodingAuto,
+			want: entity.EngineHardwareDecodingAuto,
 		},
 		{
 			name: "force",
 			mode: config.HardwareDecodingForce,
-			want: port.EngineHardwareDecodingForce,
+			want: entity.EngineHardwareDecodingForce,
 		},
 		{
 			name: "disable",
 			mode: config.HardwareDecodingDisable,
-			want: port.EngineHardwareDecodingDisable,
+			want: entity.EngineHardwareDecodingDisable,
 		},
 		{
 			name: "unknown",
 			mode: config.HardwareDecodingMode("surprise"),
-			want: port.EngineHardwareDecodingAuto,
+			want: entity.EngineHardwareDecodingAuto,
 		},
 		{
 			name: "zero value",
 			mode: "",
-			want: port.EngineHardwareDecodingAuto,
+			want: entity.EngineHardwareDecodingAuto,
 		},
 	}

R internal/application/port/engine_settings_test.go → internal/domain/entity/engine_settings_test.go +1 -1 renamed, 98% similar

@@ -1,4 +1,4 @@
1		-	package port
	1	+	package entity
2	2
3	3		import (
4	4		"reflect"

@@ -1,4 +1,4 @@
1	-	package port	1	+	package entity
2			2
3		import (	3		import (
4		"reflect"	4		"reflect"

A internal/domain/entity/runtime_config.go +80 -0

@@ -0,0 +1,80 @@
	1	+	package entity
	2	+
	3	+	// EngineHardwareDecodingMode controls engine-facing video hardware acceleration.
	4	+	type EngineHardwareDecodingMode string
	5	+
	6	+	const (
	7	+	EngineHardwareDecodingAuto EngineHardwareDecodingMode = "auto"
	8	+	EngineHardwareDecodingForce EngineHardwareDecodingMode = "force"
	9	+	EngineHardwareDecodingDisable EngineHardwareDecodingMode = "disable"
	10	+	)
	11	+
	12	+	// EngineWebContentSettingsPayload is the engine-facing runtime view of web
	13	+	// content settings that can be applied to newly-created or existing webviews.
	14	+	type EngineWebContentSettingsPayload struct {
	15	+	SansFont string
	16	+	SerifFont string
	17	+	MonospaceFont string
	18	+	DefaultFontSize int
	19	+	EnableDevTools bool
	20	+	CaptureConsole bool
	21	+	DrawCompositingIndicators bool
	22	+	HardwareDecoding EngineHardwareDecodingMode
	23	+	AutoCopyOnSelection bool
	24	+	}
	25	+
	26	+	// EngineSettingsPayload is the engine-facing boundary view of runtime config.
	27	+	// Add fields here only when an engine needs to react to them at runtime.
	28	+	type EngineSettingsPayload struct {
	29	+	DefaultUIScale float64
	30	+	WebContent EngineWebContentSettingsPayload
	31	+	}
	32	+
	33	+	// EngineSettingsUpdate carries a runtime config change to the engine.
	34	+	type EngineSettingsUpdate struct {
	35	+	Settings EngineSettingsPayload
	36	+	}
	37	+
	38	+	type RuntimeConfigSnapshot struct {
	39	+	EngineSettings EngineSettingsPayload
	40	+	UI RuntimeUIConfig
	41	+	}
	42	+
	43	+	type RuntimeUIConfig struct {
	44	+	DefaultUIScale float64
	45	+	SidebarWidth int
	46	+	Appearance AppearanceConfig
	47	+	Workspace WorkspaceConfig
	48	+	Session SessionConfig
	49	+	Clipboard RuntimeClipboardConfig
	50	+	SearchShortcuts map[string]RuntimeSearchShortcut
	51	+	DefaultSearchEngine string
	52	+	Omnibox RuntimeOmniboxConfig
	53	+	Update RuntimeUpdateConfig
	54	+	Downloads RuntimeDownloadsConfig
	55	+	}
	56	+
	57	+	type RuntimeClipboardConfig struct {
	58	+	AutoCopyOnSelection bool
	59	+	}
	60	+
	61	+	type RuntimeSearchShortcut struct {
	62	+	URL string
	63	+	Description string
	64	+	}
	65	+
	66	+	type RuntimeOmniboxConfig struct {
	67	+	InitialBehavior OmniboxInitialBehavior
	68	+	MostVisitedDays int
	69	+	AutoOpenOnNewPane bool
	70	+	}
	71	+
	72	+	type RuntimeUpdateConfig struct {
	73	+	EnableOnStartup bool
	74	+	AutoDownload bool
	75	+	NotifyOnNewSettings bool
	76	+	}
	77	+
	78	+	type RuntimeDownloadsConfig struct {
	79	+	Path string
	80	+	}

@@ -0,0 +1,80 @@
	1	+	package entity
	2	+
	3	+	// EngineHardwareDecodingMode controls engine-facing video hardware acceleration.
	4	+	type EngineHardwareDecodingMode string
	5	+
	6	+	const (
	7	+	EngineHardwareDecodingAuto EngineHardwareDecodingMode = "auto"
	8	+	EngineHardwareDecodingForce EngineHardwareDecodingMode = "force"
	9	+	EngineHardwareDecodingDisable EngineHardwareDecodingMode = "disable"
	10	+	)
	11	+
	12	+	// EngineWebContentSettingsPayload is the engine-facing runtime view of web
	13	+	// content settings that can be applied to newly-created or existing webviews.
	14	+	type EngineWebContentSettingsPayload struct {
	15	+	SansFont string
	16	+	SerifFont string
	17	+	MonospaceFont string
	18	+	DefaultFontSize int
	19	+	EnableDevTools bool
	20	+	CaptureConsole bool
	21	+	DrawCompositingIndicators bool
	22	+	HardwareDecoding EngineHardwareDecodingMode
	23	+	AutoCopyOnSelection bool
	24	+	}
	25	+
	26	+	// EngineSettingsPayload is the engine-facing boundary view of runtime config.
	27	+	// Add fields here only when an engine needs to react to them at runtime.
	28	+	type EngineSettingsPayload struct {
	29	+	DefaultUIScale float64
	30	+	WebContent EngineWebContentSettingsPayload
	31	+	}
	32	+
	33	+	// EngineSettingsUpdate carries a runtime config change to the engine.
	34	+	type EngineSettingsUpdate struct {
	35	+	Settings EngineSettingsPayload
	36	+	}
	37	+
	38	+	type RuntimeConfigSnapshot struct {
	39	+	EngineSettings EngineSettingsPayload
	40	+	UI RuntimeUIConfig
	41	+	}
	42	+
	43	+	type RuntimeUIConfig struct {
	44	+	DefaultUIScale float64
	45	+	SidebarWidth int
	46	+	Appearance AppearanceConfig
	47	+	Workspace WorkspaceConfig
	48	+	Session SessionConfig
	49	+	Clipboard RuntimeClipboardConfig
	50	+	SearchShortcuts map[string]RuntimeSearchShortcut
	51	+	DefaultSearchEngine string
	52	+	Omnibox RuntimeOmniboxConfig
	53	+	Update RuntimeUpdateConfig
	54	+	Downloads RuntimeDownloadsConfig
	55	+	}
	56	+
	57	+	type RuntimeClipboardConfig struct {
	58	+	AutoCopyOnSelection bool
	59	+	}
	60	+
	61	+	type RuntimeSearchShortcut struct {
	62	+	URL string
	63	+	Description string
	64	+	}
	65	+
	66	+	type RuntimeOmniboxConfig struct {
	67	+	InitialBehavior OmniboxInitialBehavior
	68	+	MostVisitedDays int
	69	+	AutoOpenOnNewPane bool
	70	+	}
	71	+
	72	+	type RuntimeUpdateConfig struct {
	73	+	EnableOnStartup bool
	74	+	AutoDownload bool
	75	+	NotifyOnNewSettings bool
	76	+	}
	77	+
	78	+	type RuntimeDownloadsConfig struct {
	79	+	Path string
	80	+	}

M internal/infrastructure/cef/engine.go +2 -1


@@ -15,6 +15,7 @@ import (
15	15
16	16		"github.com/bnema/dumber/internal/application/dto"
17	17		"github.com/bnema/dumber/internal/application/port"
	18	+	"github.com/bnema/dumber/internal/domain/entity"
18	19		"github.com/bnema/dumber/internal/logging"
19	20		)
20	21

@@ -355,7 +356,7 @@ func (e *Engine) UpdateAppearance(_ context.Context, r, g, b, alpha float64) err
355	356		// existing views continue using their construction-time scale until reload under
356	357		// a new engine lifetime. Browser zoom remains independently adjustable at
357	358		// runtime through SetZoomLevel.
358		-	func (e *Engine) UpdateSettings(ctx context.Context, update port.EngineSettingsUpdate) error {
	359	+	func (e *Engine) UpdateSettings(ctx context.Context, update entity.EngineSettingsUpdate) error {
359	360		newScale := normalizedApplicationScale(update.Settings.DefaultUIScale)
360	361		e.applicationScaleMu.Lock()
361	362		oldScale := e.applicationScale

 	"github.com/bnema/dumber/internal/application/dto"
 	"github.com/bnema/dumber/internal/application/port"
+	"github.com/bnema/dumber/internal/domain/entity"
 	"github.com/bnema/dumber/internal/logging"
 )
 // existing views continue using their construction-time scale until reload under
 // a new engine lifetime. Browser zoom remains independently adjustable at
 // runtime through SetZoomLevel.
-func (e *Engine) UpdateSettings(ctx context.Context, update port.EngineSettingsUpdate) error {
+func (e *Engine) UpdateSettings(ctx context.Context, update entity.EngineSettingsUpdate) error {
 	newScale := normalizedApplicationScale(update.Settings.DefaultUIScale)
 	e.applicationScaleMu.Lock()
 	oldScale := e.applicationScale

M internal/infrastructure/cef/engine_settings_test.go +6 -6


@@ -5,14 +5,14 @@ import (
5	5		"sync"
6	6		"testing"
7	7
8		-	"github.com/bnema/dumber/internal/application/port"
	8	+	"github.com/bnema/dumber/internal/domain/entity"
9	9		)
10	10
11	11		func TestEngineUpdateSettingsUpdatesApplicationScaleFromBoundaryPayload(t *testing.T) {
12	12		e := &Engine{applicationScale: 1}
13	13
14		-	if err := e.UpdateSettings(context.Background(), port.EngineSettingsUpdate{
15		-	Settings: port.EngineSettingsPayload{DefaultUIScale: 1.25},
	14	+	if err := e.UpdateSettings(context.Background(), entity.EngineSettingsUpdate{
	15	+	Settings: entity.EngineSettingsPayload{DefaultUIScale: 1.25},
16	16		}); err != nil {
17	17		t.Fatalf("UpdateSettings returned error: %v", err)
18	18		}

@@ -24,7 +24,7 @@ func TestEngineUpdateSettingsUpdatesApplicationScaleFromBoundaryPayload(t *testi
24	24		func TestEngineUpdateSettingsUsesZeroScaleWhenPayloadIsEmpty(t *testing.T) {
25	25		e := &Engine{applicationScale: 1.25}
26	26
27		-	if err := e.UpdateSettings(context.Background(), port.EngineSettingsUpdate{}); err != nil {
	27	+	if err := e.UpdateSettings(context.Background(), entity.EngineSettingsUpdate{}); err != nil {
28	28		t.Fatalf("UpdateSettings returned error: %v", err)
29	29		}
30	30		if got := e.currentApplicationScale(); got != 1 {

@@ -43,8 +43,8 @@ func TestEngineApplicationScaleConcurrentAccess(_ *testing.T) {
43	43		}()
44	44		go func(scale float64) {
45	45		defer wg.Done()
46		-	_ = e.UpdateSettings(context.Background(), port.EngineSettingsUpdate{
47		-	Settings: port.EngineSettingsPayload{DefaultUIScale: scale},
	46	+	_ = e.UpdateSettings(context.Background(), entity.EngineSettingsUpdate{
	47	+	Settings: entity.EngineSettingsPayload{DefaultUIScale: scale},
48	48		})
49	49		}(1 + float64(i)/10)
50	50		}


@@ -5,14 +5,14 @@ import (
5		"sync"	5		"sync"
6		"testing"	6		"testing"
7			7
8	-	"github.com/bnema/dumber/internal/application/port"	8	+	"github.com/bnema/dumber/internal/domain/entity"
9		)	9		)
10			10
11		func TestEngineUpdateSettingsUpdatesApplicationScaleFromBoundaryPayload(t *testing.T) {	11		func TestEngineUpdateSettingsUpdatesApplicationScaleFromBoundaryPayload(t *testing.T) {
12		e := &Engine{applicationScale: 1}	12		e := &Engine{applicationScale: 1}
13			13
14	-	if err := e.UpdateSettings(context.Background(), port.EngineSettingsUpdate{	14	+	if err := e.UpdateSettings(context.Background(), entity.EngineSettingsUpdate{
15	-	Settings: port.EngineSettingsPayload{DefaultUIScale: 1.25},	15	+	Settings: entity.EngineSettingsPayload{DefaultUIScale: 1.25},
16		}); err != nil {	16		}); err != nil {
17		t.Fatalf("UpdateSettings returned error: %v", err)	17		t.Fatalf("UpdateSettings returned error: %v", err)
18		}	18		}

@@ -24,7 +24,7 @@ func TestEngineUpdateSettingsUpdatesApplicationScaleFromBoundaryPayload(t *testi
24		func TestEngineUpdateSettingsUsesZeroScaleWhenPayloadIsEmpty(t *testing.T) {	24		func TestEngineUpdateSettingsUsesZeroScaleWhenPayloadIsEmpty(t *testing.T) {
25		e := &Engine{applicationScale: 1.25}	25		e := &Engine{applicationScale: 1.25}
26			26
27	-	if err := e.UpdateSettings(context.Background(), port.EngineSettingsUpdate{}); err != nil {	27	+	if err := e.UpdateSettings(context.Background(), entity.EngineSettingsUpdate{}); err != nil {
28		t.Fatalf("UpdateSettings returned error: %v", err)	28		t.Fatalf("UpdateSettings returned error: %v", err)
29		}	29		}
30		if got := e.currentApplicationScale(); got != 1 {	30		if got := e.currentApplicationScale(); got != 1 {

@@ -43,8 +43,8 @@ func TestEngineApplicationScaleConcurrentAccess(_ *testing.T) {
43		}()	43		}()
44		go func(scale float64) {	44		go func(scale float64) {
45		defer wg.Done()	45		defer wg.Done()
46	-	_ = e.UpdateSettings(context.Background(), port.EngineSettingsUpdate{	46	+	_ = e.UpdateSettings(context.Background(), entity.EngineSettingsUpdate{
47	-	Settings: port.EngineSettingsPayload{DefaultUIScale: scale},	47	+	Settings: entity.EngineSettingsPayload{DefaultUIScale: scale},
48		})	48		})
49		}(1 + float64(i)/10)	49		}(1 + float64(i)/10)
50		}	50		}

M internal/infrastructure/webkit/engine.go +2 -1


@@ -5,6 +5,7 @@ import (
5	5		"fmt"
6	6
7	7		"github.com/bnema/dumber/internal/application/port"
	8	+	"github.com/bnema/dumber/internal/domain/entity"
8	9		"github.com/bnema/dumber/internal/infrastructure/filtering"
9	10		"github.com/bnema/dumber/internal/infrastructure/handlers"
10	11		"github.com/rs/zerolog"

@@ -155,7 +156,7 @@ func (e *Engine) UpdateAppearance(_ context.Context, r, g, b, alpha float64) err
155	156		}
156	157
157	158		// UpdateSettings applies runtime config changes to engine settings.
158		-	func (e *Engine) UpdateSettings(ctx context.Context, update port.EngineSettingsUpdate) error {
	159	+	func (e *Engine) UpdateSettings(ctx context.Context, update entity.EngineSettingsUpdate) error {
159	160		if e.settings != nil {
160	161		e.settings.UpdateFromPayload(ctx, update.Settings)
161	162		}

 	"fmt"
 	"github.com/bnema/dumber/internal/application/port"
+	"github.com/bnema/dumber/internal/domain/entity"
 	"github.com/bnema/dumber/internal/infrastructure/filtering"
 	"github.com/bnema/dumber/internal/infrastructure/handlers"
 	"github.com/rs/zerolog"
 }
 // UpdateSettings applies runtime config changes to engine settings.
-func (e *Engine) UpdateSettings(ctx context.Context, update port.EngineSettingsUpdate) error {
+func (e *Engine) UpdateSettings(ctx context.Context, update entity.EngineSettingsUpdate) error {
 	if e.settings != nil {
 		e.settings.UpdateFromPayload(ctx, update.Settings)
 	}

M internal/infrastructure/webkit/engine_init.go +2 -1


@@ -7,6 +7,7 @@ import (
7	7		"github.com/bnema/dumber/assets"
8	8		"github.com/bnema/dumber/internal/application/port"
9	9		"github.com/bnema/dumber/internal/application/usecase"
	10	+	"github.com/bnema/dumber/internal/domain/entity"
10	11		"github.com/bnema/dumber/internal/infrastructure/config"
11	12		"github.com/bnema/dumber/internal/infrastructure/env"
12	13		"github.com/bnema/dumber/internal/infrastructure/filtering"

@@ -25,7 +26,7 @@ func NewEngine(
25	26		opts port.EngineOptions,
26	27		profile runtimeprofile.Profile,
27	28		wkCfg WebKitEngineConfig,
28		-	initialSettings port.EngineSettingsPayload,
	29	+	initialSettings entity.EngineSettingsPayload,
29	30		currentConfigPayload func() ([]byte, error),
30	31		defaultConfigPayload func() ([]byte, error),
31	32		themeManager *theme.Manager,

 	"github.com/bnema/dumber/assets"
 	"github.com/bnema/dumber/internal/application/port"
 	"github.com/bnema/dumber/internal/application/usecase"
+	"github.com/bnema/dumber/internal/domain/entity"
 	"github.com/bnema/dumber/internal/infrastructure/config"
 	"github.com/bnema/dumber/internal/infrastructure/env"
 	"github.com/bnema/dumber/internal/infrastructure/filtering"
 	opts port.EngineOptions,
 	profile runtimeprofile.Profile,
 	wkCfg WebKitEngineConfig,
-	initialSettings port.EngineSettingsPayload,
+	initialSettings entity.EngineSettingsPayload,
 	currentConfigPayload func() ([]byte, error),
 	defaultConfigPayload func() ([]byte, error),
 	themeManager *theme.Manager,

M internal/infrastructure/webkit/engine_runtime_test.go +11 -10


@@ -5,21 +5,22 @@ import (
5	5		"testing"
6	6
7	7		"github.com/bnema/dumber/internal/application/port"
	8	+	"github.com/bnema/dumber/internal/domain/entity"
8	9		"github.com/stretchr/testify/require"
9	10		)
10	11
11	12		func TestEngine_UpdateSettings_AcceptsTypedSettingsPayload(t *testing.T) {
12		-	e := &Engine{settings: NewSettingsManager(context.Background(), port.EngineSettingsPayload{})}
	13	+	e := &Engine{settings: NewSettingsManager(context.Background(), entity.EngineSettingsPayload{})}
13	14
14		-	err := e.UpdateSettings(context.Background(), port.EngineSettingsUpdate{
15		-	Settings: port.EngineSettingsPayload{
	15	+	err := e.UpdateSettings(context.Background(), entity.EngineSettingsUpdate{
	16	+	Settings: entity.EngineSettingsPayload{
16	17		DefaultUIScale: 1.25,
17		-	WebContent: port.EngineWebContentSettingsPayload{
	18	+	WebContent: entity.EngineWebContentSettingsPayload{
18	19		SansFont: "Inter",
19	20		EnableDevTools: true,
20	21		CaptureConsole: true,
21	22		DrawCompositingIndicators: true,
22		-	HardwareDecoding: port.EngineHardwareDecodingDisable,
	23	+	HardwareDecoding: entity.EngineHardwareDecodingDisable,
23	24		},
24	25		},
25	26		})

@@ -28,13 +29,13 @@ func TestEngine_UpdateSettings_AcceptsTypedSettingsPayload(t *testing.T) {
28	29		require.True(t, e.settings.current().WebContent.EnableDevTools)
29	30		require.True(t, e.settings.current().WebContent.CaptureConsole)
30	31		require.True(t, e.settings.current().WebContent.DrawCompositingIndicators)
31		-	require.Equal(t, port.EngineHardwareDecodingDisable, e.settings.current().WebContent.HardwareDecoding)
	32	+	require.Equal(t, entity.EngineHardwareDecodingDisable, e.settings.current().WebContent.HardwareDecoding)
32	33		}
33	34
34	35		func TestEngine_UpdateSettings_NilSettings(t *testing.T) {
35	36		// settings is nil — should not panic, just be a no-op.
36	37		e := &Engine{}
37		-	err := e.UpdateSettings(context.Background(), port.EngineSettingsUpdate{})
	38	+	err := e.UpdateSettings(context.Background(), entity.EngineSettingsUpdate{})
38	39		require.NoError(t, err)
39	40		}
40	41

@@ -74,7 +75,7 @@ func TestEngine_Close_NilPool(t *testing.T) {
74	75		}
75	76
76	77		func TestEngineConfigureContentInjectorAutoCopyGetterReadsCurrentPayload(t *testing.T) {
77		-	settings := NewSettingsManager(context.Background(), port.EngineSettingsPayload{})
	78	+	settings := NewSettingsManager(context.Background(), entity.EngineSettingsPayload{})
78	79		injector := NewContentInjector(nil)
79	80
80	81		engineConfigureContentInjectorRuntimeSettings(injector, settings)

@@ -82,8 +83,8 @@ func TestEngineConfigureContentInjectorAutoCopyGetterReadsCurrentPayload(t *test
82	83		require.NotNil(t, injector.autoCopyConfigGetter)
83	84		require.False(t, injector.autoCopyConfigGetter())
84	85
85		-	settings.UpdateFromPayload(context.Background(), port.EngineSettingsPayload{
86		-	WebContent: port.EngineWebContentSettingsPayload{
	86	+	settings.UpdateFromPayload(context.Background(), entity.EngineSettingsPayload{
	87	+	WebContent: entity.EngineWebContentSettingsPayload{
87	88		AutoCopyOnSelection: true,
88	89		},
89	90		})

 	"testing"
 	"github.com/bnema/dumber/internal/application/port"
+	"github.com/bnema/dumber/internal/domain/entity"
 	"github.com/stretchr/testify/require"
 )
 func TestEngine_UpdateSettings_AcceptsTypedSettingsPayload(t *testing.T) {
-	e := &Engine{settings: NewSettingsManager(context.Background(), port.EngineSettingsPayload{})}
+	e := &Engine{settings: NewSettingsManager(context.Background(), entity.EngineSettingsPayload{})}
-	err := e.UpdateSettings(context.Background(), port.EngineSettingsUpdate{
+	err := e.UpdateSettings(context.Background(), entity.EngineSettingsUpdate{
-		Settings: port.EngineSettingsPayload{
+		Settings: entity.EngineSettingsPayload{
 			DefaultUIScale: 1.25,
-			WebContent: port.EngineWebContentSettingsPayload{
+			WebContent: entity.EngineWebContentSettingsPayload{
 				SansFont:                  "Inter",
 				EnableDevTools:            true,
 				CaptureConsole:            true,
 				DrawCompositingIndicators: true,
-				HardwareDecoding:          port.EngineHardwareDecodingDisable,
+				HardwareDecoding:          entity.EngineHardwareDecodingDisable,
 			},
 		},
 	})
 	require.True(t, e.settings.current().WebContent.EnableDevTools)
 	require.True(t, e.settings.current().WebContent.CaptureConsole)
 	require.True(t, e.settings.current().WebContent.DrawCompositingIndicators)
-	require.Equal(t, port.EngineHardwareDecodingDisable, e.settings.current().WebContent.HardwareDecoding)
+	require.Equal(t, entity.EngineHardwareDecodingDisable, e.settings.current().WebContent.HardwareDecoding)
 }
 func TestEngine_UpdateSettings_NilSettings(t *testing.T) {
 	// settings is nil — should not panic, just be a no-op.
 	e := &Engine{}
-	err := e.UpdateSettings(context.Background(), port.EngineSettingsUpdate{})
+	err := e.UpdateSettings(context.Background(), entity.EngineSettingsUpdate{})
 	require.NoError(t, err)
 }
 }
 func TestEngineConfigureContentInjectorAutoCopyGetterReadsCurrentPayload(t *testing.T) {
-	settings := NewSettingsManager(context.Background(), port.EngineSettingsPayload{})
+	settings := NewSettingsManager(context.Background(), entity.EngineSettingsPayload{})
 	injector := NewContentInjector(nil)
 	engineConfigureContentInjectorRuntimeSettings(injector, settings)
 	require.NotNil(t, injector.autoCopyConfigGetter)
 	require.False(t, injector.autoCopyConfigGetter())
-	settings.UpdateFromPayload(context.Background(), port.EngineSettingsPayload{
+	settings.UpdateFromPayload(context.Background(), entity.EngineSettingsPayload{
-		WebContent: port.EngineWebContentSettingsPayload{
+		WebContent: entity.EngineWebContentSettingsPayload{
 			AutoCopyOnSelection: true,
 		},
 	})

M internal/infrastructure/webkit/pool_context_menu_test.go +2 -2


@@ -4,7 +4,7 @@ import (
4	4		"context"
5	5		"testing"
6	6
7		-	"github.com/bnema/dumber/internal/application/port"
	7	+	"github.com/bnema/dumber/internal/domain/entity"
8	8		"github.com/bnema/puregotk/v4/webkit"
9	9		)
10	10

@@ -32,7 +32,7 @@ func TestNeedsExplicitContextMenuSignalOnAcquire(t *testing.T) {
32	32		}
33	33
34	34		func TestShouldReapplySettingsOnAcquire(t *testing.T) {
35		-	settings := NewSettingsManager(context.Background(), port.EngineSettingsPayload{})
	35	+	settings := NewSettingsManager(context.Background(), entity.EngineSettingsPayload{})
36	36
37	37		tests := []struct {
38	38		name string


@@ -4,7 +4,7 @@ import (
4		"context"	4		"context"
5		"testing"	5		"testing"
6			6
7	-	"github.com/bnema/dumber/internal/application/port"	7	+	"github.com/bnema/dumber/internal/domain/entity"
8		"github.com/bnema/puregotk/v4/webkit"	8		"github.com/bnema/puregotk/v4/webkit"
9		)	9		)
10			10

@@ -32,7 +32,7 @@ func TestNeedsExplicitContextMenuSignalOnAcquire(t *testing.T) {
32		}	32		}
33			33
34		func TestShouldReapplySettingsOnAcquire(t *testing.T) {	34		func TestShouldReapplySettingsOnAcquire(t *testing.T) {
35	-	settings := NewSettingsManager(context.Background(), port.EngineSettingsPayload{})	35	+	settings := NewSettingsManager(context.Background(), entity.EngineSettingsPayload{})
36			36
37		tests := []struct {	37		tests := []struct {
38		name string	38		name string

M internal/infrastructure/webkit/settings.go +11 -11


@@ -4,7 +4,7 @@ import (
4	4		"context"
5	5		"sync"
6	6
7		-	"github.com/bnema/dumber/internal/application/port"
	7	+	"github.com/bnema/dumber/internal/domain/entity"
8	8		"github.com/bnema/dumber/internal/logging"
9	9		"github.com/bnema/puregotk/v4/webkit"
10	10		"github.com/rs/zerolog"

@@ -27,18 +27,18 @@ type mediaSettings interface {
27	27
28	28		// SettingsManager creates and manages WebKit Settings instances from payloads.
29	29		type SettingsManager struct {
30		-	settings port.EngineSettingsPayload
	30	+	settings entity.EngineSettingsPayload
31	31		mu sync.RWMutex
32	32		}
33	33
34	34		// NewSettingsManager creates a new SettingsManager with the given payload.
35		-	func NewSettingsManager(ctx context.Context, settings port.EngineSettingsPayload) *SettingsManager {
	35	+	func NewSettingsManager(ctx context.Context, settings entity.EngineSettingsPayload) *SettingsManager {
36	36		log := logging.FromContext(ctx)
37	37		log.Debug().Msg("creating settings manager")
38	38		return &SettingsManager{settings: settings}
39	39		}
40	40
41		-	func (sm *SettingsManager) current() port.EngineSettingsPayload {
	41	+	func (sm *SettingsManager) current() entity.EngineSettingsPayload {
42	42		sm.mu.RLock()
43	43		defer sm.mu.RUnlock()
44	44		return sm.settings

@@ -60,7 +60,7 @@ func (sm SettingsManager) CreateSettings(ctx context.Context) webkit.Settings
60	60		}
61	61
62	62		// applySettings applies settings payload to a webkit.Settings instance.
63		-	func (sm SettingsManager) applySettings(ctx context.Context, settings webkit.Settings, payload port.EngineSettingsPayload) {
	63	+	func (sm SettingsManager) applySettings(ctx context.Context, settings webkit.Settings, payload entity.EngineSettingsPayload) {
64	64		if sm == nil {
65	65		return
66	66		}

@@ -91,7 +91,7 @@ func applyJavaScriptSettings(settings *webkit.Settings) {
91	91		settings.SetEnableJavascriptMarkup(true)
92	92		}
93	93
94		-	func applyFontSettings(settings *webkit.Settings, payload port.EngineWebContentSettingsPayload) {
	94	+	func applyFontSettings(settings *webkit.Settings, payload entity.EngineWebContentSettingsPayload) {
95	95		if payload.SansFont != "" {
96	96		settings.SetDefaultFontFamily(payload.SansFont)
97	97		settings.SetSansSerifFontFamily(payload.SansFont)

@@ -107,7 +107,7 @@ func applyFontSettings(settings *webkit.Settings, payload port.EngineWebContentS
107	107		}
108	108		}
109	109
110		-	func applyDebugSettings(settings *webkit.Settings, payload port.EngineWebContentSettingsPayload) {
	110	+	func applyDebugSettings(settings *webkit.Settings, payload entity.EngineWebContentSettingsPayload) {
111	111		settings.SetEnableDeveloperExtras(payload.EnableDevTools)
112	112		settings.SetEnableWriteConsoleMessagesToStdout(payload.CaptureConsole)
113	113		settings.SetDrawCompositingIndicators(payload.DrawCompositingIndicators)

@@ -119,7 +119,7 @@ func applyBrowsingSettings(settings *webkit.Settings) {
119	119		settings.SetEnableSiteSpecificQuirks(true)
120	120		}
121	121
122		-	func applyMediaSettings(settings mediaSettings, mode port.EngineHardwareDecodingMode, log *zerolog.Logger) {
	122	+	func applyMediaSettings(settings mediaSettings, mode entity.EngineHardwareDecodingMode, log *zerolog.Logger) {
123	123		settings.SetEnableWebaudio(true)
124	124		settings.SetEnableWebgl(true)
125	125		settings.SetEnableMedia(true)

@@ -130,12 +130,12 @@ func applyMediaSettings(settings mediaSettings, mode port.EngineHardwareDecoding
130	130		settings.SetMediaPlaybackAllowsInline(true)
131	131
132	132		switch mode {
133		-	case port.EngineHardwareDecodingForce:
	133	+	case entity.EngineHardwareDecodingForce:
134	134		hwTypes := hardwareRequiredContentTypes
135	135		settings.SetHardwareAccelerationPolicy(webkit.HardwareAccelerationPolicyAlwaysValue)
136	136		settings.SetMediaContentTypesRequiringHardwareSupport(&hwTypes)
137	137		log.Debug().Msg("hardware decoding: forced (may fail without hw support)")
138		-	case port.EngineHardwareDecodingDisable:
	138	+	case entity.EngineHardwareDecodingDisable:
139	139		emptyTypes := ""
140	140		settings.SetHardwareAccelerationPolicy(webkit.HardwareAccelerationPolicyNeverValue)
141	141		settings.SetMediaContentTypesRequiringHardwareSupport(&emptyTypes)

@@ -174,7 +174,7 @@ func applyWebRTCSettings(settings *webkit.Settings) {
174	174		// UpdateFromPayload updates the manager with a new payload (for hot-reload).
175	175		// Note: This doesn't update already-created Settings instances.
176	176		// New WebViews will use the updated payload.
177		-	func (sm *SettingsManager) UpdateFromPayload(ctx context.Context, settings port.EngineSettingsPayload) {
	177	+	func (sm *SettingsManager) UpdateFromPayload(ctx context.Context, settings entity.EngineSettingsPayload) {
178	178		log := logging.FromContext(ctx)
179	179		sm.mu.Lock()
180	180		defer sm.mu.Unlock()


@@ -4,7 +4,7 @@ import (
4		"context"	4		"context"
5		"sync"	5		"sync"
6			6
7	-	"github.com/bnema/dumber/internal/application/port"	7	+	"github.com/bnema/dumber/internal/domain/entity"
8		"github.com/bnema/dumber/internal/logging"	8		"github.com/bnema/dumber/internal/logging"
9		"github.com/bnema/puregotk/v4/webkit"	9		"github.com/bnema/puregotk/v4/webkit"
10		"github.com/rs/zerolog"	10		"github.com/rs/zerolog"

@@ -27,18 +27,18 @@ type mediaSettings interface {
27			27
28		// SettingsManager creates and manages WebKit Settings instances from payloads.	28		// SettingsManager creates and manages WebKit Settings instances from payloads.
29		type SettingsManager struct {	29		type SettingsManager struct {
30	-	settings port.EngineSettingsPayload	30	+	settings entity.EngineSettingsPayload
31		mu sync.RWMutex	31		mu sync.RWMutex
32		}	32		}
33			33
34		// NewSettingsManager creates a new SettingsManager with the given payload.	34		// NewSettingsManager creates a new SettingsManager with the given payload.
35	-	func NewSettingsManager(ctx context.Context, settings port.EngineSettingsPayload) *SettingsManager {	35	+	func NewSettingsManager(ctx context.Context, settings entity.EngineSettingsPayload) *SettingsManager {
36		log := logging.FromContext(ctx)	36		log := logging.FromContext(ctx)
37		log.Debug().Msg("creating settings manager")	37		log.Debug().Msg("creating settings manager")
38		return &SettingsManager{settings: settings}	38		return &SettingsManager{settings: settings}
39		}	39		}
40			40
41	-	func (sm *SettingsManager) current() port.EngineSettingsPayload {	41	+	func (sm *SettingsManager) current() entity.EngineSettingsPayload {
42		sm.mu.RLock()	42		sm.mu.RLock()
43		defer sm.mu.RUnlock()	43		defer sm.mu.RUnlock()
44		return sm.settings	44		return sm.settings

@@ -60,7 +60,7 @@ func (sm SettingsManager) CreateSettings(ctx context.Context) webkit.Settings
60		}	60		}
61			61
62		// applySettings applies settings payload to a webkit.Settings instance.	62		// applySettings applies settings payload to a webkit.Settings instance.
63	-	func (sm SettingsManager) applySettings(ctx context.Context, settings webkit.Settings, payload port.EngineSettingsPayload) {	63	+	func (sm SettingsManager) applySettings(ctx context.Context, settings webkit.Settings, payload entity.EngineSettingsPayload) {
64		if sm == nil {	64		if sm == nil {
65		return	65		return
66		}	66		}

@@ -91,7 +91,7 @@ func applyJavaScriptSettings(settings *webkit.Settings) {
91		settings.SetEnableJavascriptMarkup(true)	91		settings.SetEnableJavascriptMarkup(true)
92		}	92		}
93			93
94	-	func applyFontSettings(settings *webkit.Settings, payload port.EngineWebContentSettingsPayload) {	94	+	func applyFontSettings(settings *webkit.Settings, payload entity.EngineWebContentSettingsPayload) {
95		if payload.SansFont != "" {	95		if payload.SansFont != "" {
96		settings.SetDefaultFontFamily(payload.SansFont)	96		settings.SetDefaultFontFamily(payload.SansFont)
97		settings.SetSansSerifFontFamily(payload.SansFont)	97		settings.SetSansSerifFontFamily(payload.SansFont)

@@ -107,7 +107,7 @@ func applyFontSettings(settings *webkit.Settings, payload port.EngineWebContentS
107		}	107		}
108		}	108		}
109			109
110	-	func applyDebugSettings(settings *webkit.Settings, payload port.EngineWebContentSettingsPayload) {	110	+	func applyDebugSettings(settings *webkit.Settings, payload entity.EngineWebContentSettingsPayload) {
111		settings.SetEnableDeveloperExtras(payload.EnableDevTools)	111		settings.SetEnableDeveloperExtras(payload.EnableDevTools)
112		settings.SetEnableWriteConsoleMessagesToStdout(payload.CaptureConsole)	112		settings.SetEnableWriteConsoleMessagesToStdout(payload.CaptureConsole)
113		settings.SetDrawCompositingIndicators(payload.DrawCompositingIndicators)	113		settings.SetDrawCompositingIndicators(payload.DrawCompositingIndicators)

@@ -119,7 +119,7 @@ func applyBrowsingSettings(settings *webkit.Settings) {
119		settings.SetEnableSiteSpecificQuirks(true)	119		settings.SetEnableSiteSpecificQuirks(true)
120		}	120		}
121			121
122	-	func applyMediaSettings(settings mediaSettings, mode port.EngineHardwareDecodingMode, log *zerolog.Logger) {	122	+	func applyMediaSettings(settings mediaSettings, mode entity.EngineHardwareDecodingMode, log *zerolog.Logger) {
123		settings.SetEnableWebaudio(true)	123		settings.SetEnableWebaudio(true)
124		settings.SetEnableWebgl(true)	124		settings.SetEnableWebgl(true)
125		settings.SetEnableMedia(true)	125		settings.SetEnableMedia(true)

@@ -130,12 +130,12 @@ func applyMediaSettings(settings mediaSettings, mode port.EngineHardwareDecoding
130		settings.SetMediaPlaybackAllowsInline(true)	130		settings.SetMediaPlaybackAllowsInline(true)
131			131
132		switch mode {	132		switch mode {
133	-	case port.EngineHardwareDecodingForce:	133	+	case entity.EngineHardwareDecodingForce:
134		hwTypes := hardwareRequiredContentTypes	134		hwTypes := hardwareRequiredContentTypes
135		settings.SetHardwareAccelerationPolicy(webkit.HardwareAccelerationPolicyAlwaysValue)	135		settings.SetHardwareAccelerationPolicy(webkit.HardwareAccelerationPolicyAlwaysValue)
136		settings.SetMediaContentTypesRequiringHardwareSupport(&hwTypes)	136		settings.SetMediaContentTypesRequiringHardwareSupport(&hwTypes)
137		log.Debug().Msg("hardware decoding: forced (may fail without hw support)")	137		log.Debug().Msg("hardware decoding: forced (may fail without hw support)")
138	-	case port.EngineHardwareDecodingDisable:	138	+	case entity.EngineHardwareDecodingDisable:
139		emptyTypes := ""	139		emptyTypes := ""
140		settings.SetHardwareAccelerationPolicy(webkit.HardwareAccelerationPolicyNeverValue)	140		settings.SetHardwareAccelerationPolicy(webkit.HardwareAccelerationPolicyNeverValue)
141		settings.SetMediaContentTypesRequiringHardwareSupport(&emptyTypes)	141		settings.SetMediaContentTypesRequiringHardwareSupport(&emptyTypes)

@@ -174,7 +174,7 @@ func applyWebRTCSettings(settings *webkit.Settings) {
174		// UpdateFromPayload updates the manager with a new payload (for hot-reload).	174		// UpdateFromPayload updates the manager with a new payload (for hot-reload).
175		// Note: This doesn't update already-created Settings instances.	175		// Note: This doesn't update already-created Settings instances.
176		// New WebViews will use the updated payload.	176		// New WebViews will use the updated payload.
177	-	func (sm *SettingsManager) UpdateFromPayload(ctx context.Context, settings port.EngineSettingsPayload) {	177	+	func (sm *SettingsManager) UpdateFromPayload(ctx context.Context, settings entity.EngineSettingsPayload) {
178		log := logging.FromContext(ctx)	178		log := logging.FromContext(ctx)
179		sm.mu.Lock()	179		sm.mu.Lock()
180		defer sm.mu.Unlock()	180		defer sm.mu.Unlock()

M internal/infrastructure/webkit/settings_runtime_test.go +14 -14


@@ -4,20 +4,20 @@ import (
4	4		"context"
5	5		"testing"
6	6
7		-	"github.com/bnema/dumber/internal/application/port"
	7	+	"github.com/bnema/dumber/internal/domain/entity"
8	8		"github.com/bnema/puregotk/v4/webkit"
9	9		"github.com/rs/zerolog"
10	10		)
11	11
12	12		func TestSettingsManagerUpdateFromPayloadStoresTypedRuntimeSettings(t *testing.T) {
13		-	sm := NewSettingsManager(context.Background(), port.EngineSettingsPayload{})
14		-	payload := port.EngineSettingsPayload{
15		-	WebContent: port.EngineWebContentSettingsPayload{
	13	+	sm := NewSettingsManager(context.Background(), entity.EngineSettingsPayload{})
	14	+	payload := entity.EngineSettingsPayload{
	15	+	WebContent: entity.EngineWebContentSettingsPayload{
16	16		SansFont: "Inter",
17	17		SerifFont: "Literata",
18	18		MonospaceFont: "Fira Code",
19	19		DefaultFontSize: 16,
20		-	HardwareDecoding: port.EngineHardwareDecodingForce,
	20	+	HardwareDecoding: entity.EngineHardwareDecodingForce,
21	21		},
22	22		}
23	23

@@ -28,7 +28,7 @@ func TestSettingsManagerUpdateFromPayloadStoresTypedRuntimeSettings(t *testing.T
28	28		got.WebContent.SerifFont != "Literata" \|\|
29	29		got.WebContent.MonospaceFont != "Fira Code" \|\|
30	30		got.WebContent.DefaultFontSize != 16 \|\|
31		-	got.WebContent.HardwareDecoding != port.EngineHardwareDecodingForce {
	31	+	got.WebContent.HardwareDecoding != entity.EngineHardwareDecodingForce {
32	32		t.Fatalf("stored payload=%#v", got)
33	33		}
34	34		}

@@ -36,30 +36,30 @@ func TestSettingsManagerUpdateFromPayloadStoresTypedRuntimeSettings(t *testing.T
36	36		func TestApplyMediaSettingsUpdatesHardwareDecodingKnobsOnSameSettingsObject(t *testing.T) {
37	37		tests := []struct {
38	38		name string
39		-	first port.EngineHardwareDecodingMode
40		-	next port.EngineHardwareDecodingMode
	39	+	first entity.EngineHardwareDecodingMode
	40	+	next entity.EngineHardwareDecodingMode
41	41		wantPolicy webkit.HardwareAccelerationPolicy
42	42		wantHWTypes string
43	43		wantEmptyHWT bool
44	44		}{
45	45		{
46	46		name: "disable to force resets acceleration policy",
47		-	first: port.EngineHardwareDecodingDisable,
48		-	next: port.EngineHardwareDecodingForce,
	47	+	first: entity.EngineHardwareDecodingDisable,
	48	+	next: entity.EngineHardwareDecodingForce,
49	49		wantPolicy: webkit.HardwareAccelerationPolicyAlwaysValue,
50	50		wantHWTypes: "video/av01;video/mp4;video/webm;video/x-h264;video/x-h265",
51	51		},
52	52		{
53	53		name: "force to disable clears required content types",
54		-	first: port.EngineHardwareDecodingForce,
55		-	next: port.EngineHardwareDecodingDisable,
	54	+	first: entity.EngineHardwareDecodingForce,
	55	+	next: entity.EngineHardwareDecodingDisable,
56	56		wantPolicy: webkit.HardwareAccelerationPolicyNeverValue,
57	57		wantEmptyHWT: true,
58	58		},
59	59		{
60	60		name: "disable to auto resets acceleration policy",
61		-	first: port.EngineHardwareDecodingDisable,
62		-	next: port.EngineHardwareDecodingAuto,
	61	+	first: entity.EngineHardwareDecodingDisable,
	62	+	next: entity.EngineHardwareDecodingAuto,
63	63		wantPolicy: webkit.HardwareAccelerationPolicyAlwaysValue,
64	64		wantEmptyHWT: true,
65	65		},


@@ -4,20 +4,20 @@ import (
4		"context"	4		"context"
5		"testing"	5		"testing"
6			6
7	-	"github.com/bnema/dumber/internal/application/port"	7	+	"github.com/bnema/dumber/internal/domain/entity"
8		"github.com/bnema/puregotk/v4/webkit"	8		"github.com/bnema/puregotk/v4/webkit"
9		"github.com/rs/zerolog"	9		"github.com/rs/zerolog"
10		)	10		)
11			11
12		func TestSettingsManagerUpdateFromPayloadStoresTypedRuntimeSettings(t *testing.T) {	12		func TestSettingsManagerUpdateFromPayloadStoresTypedRuntimeSettings(t *testing.T) {
13	-	sm := NewSettingsManager(context.Background(), port.EngineSettingsPayload{})	13	+	sm := NewSettingsManager(context.Background(), entity.EngineSettingsPayload{})
14	-	payload := port.EngineSettingsPayload{	14	+	payload := entity.EngineSettingsPayload{
15	-	WebContent: port.EngineWebContentSettingsPayload{	15	+	WebContent: entity.EngineWebContentSettingsPayload{
16		SansFont: "Inter",	16		SansFont: "Inter",
17		SerifFont: "Literata",	17		SerifFont: "Literata",
18		MonospaceFont: "Fira Code",	18		MonospaceFont: "Fira Code",
19		DefaultFontSize: 16,	19		DefaultFontSize: 16,
20	-	HardwareDecoding: port.EngineHardwareDecodingForce,	20	+	HardwareDecoding: entity.EngineHardwareDecodingForce,
21		},	21		},
22		}	22		}
23			23

@@ -28,7 +28,7 @@ func TestSettingsManagerUpdateFromPayloadStoresTypedRuntimeSettings(t *testing.T
28		got.WebContent.SerifFont != "Literata" \|\|	28		got.WebContent.SerifFont != "Literata" \|\|
29		got.WebContent.MonospaceFont != "Fira Code" \|\|	29		got.WebContent.MonospaceFont != "Fira Code" \|\|
30		got.WebContent.DefaultFontSize != 16 \|\|	30		got.WebContent.DefaultFontSize != 16 \|\|
31	-	got.WebContent.HardwareDecoding != port.EngineHardwareDecodingForce {	31	+	got.WebContent.HardwareDecoding != entity.EngineHardwareDecodingForce {
32		t.Fatalf("stored payload=%#v", got)	32		t.Fatalf("stored payload=%#v", got)
33		}	33		}
34		}	34		}

@@ -36,30 +36,30 @@ func TestSettingsManagerUpdateFromPayloadStoresTypedRuntimeSettings(t *testing.T
36		func TestApplyMediaSettingsUpdatesHardwareDecodingKnobsOnSameSettingsObject(t *testing.T) {	36		func TestApplyMediaSettingsUpdatesHardwareDecodingKnobsOnSameSettingsObject(t *testing.T) {
37		tests := []struct {	37		tests := []struct {
38		name string	38		name string
39	-	first port.EngineHardwareDecodingMode	39	+	first entity.EngineHardwareDecodingMode
40	-	next port.EngineHardwareDecodingMode	40	+	next entity.EngineHardwareDecodingMode
41		wantPolicy webkit.HardwareAccelerationPolicy	41		wantPolicy webkit.HardwareAccelerationPolicy
42		wantHWTypes string	42		wantHWTypes string
43		wantEmptyHWT bool	43		wantEmptyHWT bool
44		}{	44		}{
45		{	45		{
46		name: "disable to force resets acceleration policy",	46		name: "disable to force resets acceleration policy",
47	-	first: port.EngineHardwareDecodingDisable,	47	+	first: entity.EngineHardwareDecodingDisable,
48	-	next: port.EngineHardwareDecodingForce,	48	+	next: entity.EngineHardwareDecodingForce,
49		wantPolicy: webkit.HardwareAccelerationPolicyAlwaysValue,	49		wantPolicy: webkit.HardwareAccelerationPolicyAlwaysValue,
50		wantHWTypes: "video/av01;video/mp4;video/webm;video/x-h264;video/x-h265",	50		wantHWTypes: "video/av01;video/mp4;video/webm;video/x-h264;video/x-h265",
51		},	51		},
52		{	52		{
53		name: "force to disable clears required content types",	53		name: "force to disable clears required content types",
54	-	first: port.EngineHardwareDecodingForce,	54	+	first: entity.EngineHardwareDecodingForce,
55	-	next: port.EngineHardwareDecodingDisable,	55	+	next: entity.EngineHardwareDecodingDisable,
56		wantPolicy: webkit.HardwareAccelerationPolicyNeverValue,	56		wantPolicy: webkit.HardwareAccelerationPolicyNeverValue,
57		wantEmptyHWT: true,	57		wantEmptyHWT: true,
58		},	58		},
59		{	59		{
60		name: "disable to auto resets acceleration policy",	60		name: "disable to auto resets acceleration policy",
61	-	first: port.EngineHardwareDecodingDisable,	61	+	first: entity.EngineHardwareDecodingDisable,
62	-	next: port.EngineHardwareDecodingAuto,	62	+	next: entity.EngineHardwareDecodingAuto,
63		wantPolicy: webkit.HardwareAccelerationPolicyAlwaysValue,	63		wantPolicy: webkit.HardwareAccelerationPolicyAlwaysValue,
64		wantEmptyHWT: true,	64		wantEmptyHWT: true,
65		},	65		},

M internal/ui/app.go +10 -10


@@ -255,9 +255,9 @@ func New(deps Dependencies) (App, error) {
255	255		return app, nil
256	256		}
257	257
258		-	func (a *App) runtimeConfigSnapshot() port.RuntimeConfigSnapshot {
	258	+	func (a *App) runtimeConfigSnapshot() entity.RuntimeConfigSnapshot {
259	259		if a == nil {
260		-	return port.RuntimeConfigSnapshot{}
	260	+	return entity.RuntimeConfigSnapshot{}
261	261		}
262	262		if a.runtimeConfig != nil {
263	263		return a.runtimeConfig.Current()

@@ -265,7 +265,7 @@ func (a *App) runtimeConfigSnapshot() port.RuntimeConfigSnapshot {
265	265		if a.deps != nil && a.deps.RuntimeConfig != nil {
266	266		return a.deps.RuntimeConfig.Current()
267	267		}
268		-	return port.RuntimeConfigSnapshot{}
	268	+	return entity.RuntimeConfigSnapshot{}
269	269		}
270	270
271	271		// Run starts the GTK application and blocks until it exits.

@@ -506,7 +506,7 @@ func (a App) createBrowserWindow(ctx context.Context, initialURL string) (brow
506	506		return browserWindow, nil
507	507		}
508	508
509		-	func (a App) initBrowserWindowOverlays(mainWindow window.MainWindow, browserWindow *browserWindow, runtimeCfg port.RuntimeUIConfig) {
	509	+	func (a App) initBrowserWindowOverlays(mainWindow window.MainWindow, browserWindow *browserWindow, runtimeCfg entity.RuntimeUIConfig) {
510	510		// Create permission popup and dialog presenter
511	511		if a.deps != nil && a.deps.PermissionUC != nil {
512	512		uiScale := runtimeCfg.DefaultUIScale

@@ -1435,7 +1435,7 @@ type omniboxCallbacks struct {
1435	1435
1436	1436		func buildOmniboxConfig(
1437	1437		deps *Dependencies,
1438		-	runtimeCfg port.RuntimeUIConfig,
	1438	+	runtimeCfg entity.RuntimeUIConfig,
1439	1439		faviconAdapter *adapter.FaviconAdapter,
1440	1440		callbacks omniboxCallbacks,
1441	1441		) component.OmniboxConfig {

@@ -1490,7 +1490,7 @@ func NewStandaloneOmniboxRuntime(
1490	1490		registerFaviconInvalidator(deps.FaviconResolver, faviconAdapter)
1491	1491		}
1492	1492
1493		-	var runtimeCfg port.RuntimeUIConfig
	1493	+	var runtimeCfg entity.RuntimeUIConfig
1494	1494		if deps != nil && deps.RuntimeConfig != nil {
1495	1495		runtimeCfg = deps.RuntimeConfig.Current().UI
1496	1496		}

@@ -5085,14 +5085,14 @@ func (a *App) initConfigWatcher(ctx context.Context) {
5085	5085		}
5086	5086
5087	5087		// Hot-reload appearance and keybindings on config change.
5088		-	a.deps.RuntimeConfig.OnChange(func(snapshot port.RuntimeConfigSnapshot) {
	5088	+	a.deps.RuntimeConfig.OnChange(func(snapshot entity.RuntimeConfigSnapshot) {
5089	5089		a.dispatchRuntimeConfigChange(ctx, snapshot)
5090	5090		})
5091	5091
5092	5092		log.Debug().Msg("config watcher initialized")
5093	5093		}
5094	5094
5095		-	func (a *App) dispatchRuntimeConfigChange(ctx context.Context, snapshot port.RuntimeConfigSnapshot) {
	5095	+	func (a *App) dispatchRuntimeConfigChange(ctx context.Context, snapshot entity.RuntimeConfigSnapshot) {
5096	5096		run := func() {
5097	5097		a.applyRuntimeConfigChange(ctx, snapshot)
5098	5098		}

@@ -5103,7 +5103,7 @@ func (a *App) dispatchRuntimeConfigChange(ctx context.Context, snapshot port.Run
5103	5103		run()
5104	5104		}
5105	5105
5106		-	func (a *App) applyRuntimeConfigChange(ctx context.Context, snapshot port.RuntimeConfigSnapshot) {
	5106	+	func (a *App) applyRuntimeConfigChange(ctx context.Context, snapshot entity.RuntimeConfigSnapshot) {
5107	5107		if a == nil {
5108	5108		return
5109	5109		}

@@ -5158,7 +5158,7 @@ func (a *App) applyAppearanceConfig(ctx context.Context) {
5158	5158		snapshot := a.runtimeConfigSnapshot()
5159	5159
5160	5160		if a.engine != nil {
5161		-	if err := a.engine.UpdateSettings(ctx, port.EngineSettingsUpdate{
	5161	+	if err := a.engine.UpdateSettings(ctx, entity.EngineSettingsUpdate{
5162	5162		Settings: snapshot.EngineSettings,
5163	5163		}); err != nil {
5164	5164		log.Warn().Err(err).Msg("failed to apply engine settings update")


@@ -255,9 +255,9 @@ func New(deps Dependencies) (App, error) {
255		return app, nil	255		return app, nil
256		}	256		}
257			257
258	-	func (a *App) runtimeConfigSnapshot() port.RuntimeConfigSnapshot {	258	+	func (a *App) runtimeConfigSnapshot() entity.RuntimeConfigSnapshot {
259		if a == nil {	259		if a == nil {
260	-	return port.RuntimeConfigSnapshot{}	260	+	return entity.RuntimeConfigSnapshot{}
261		}	261		}
262		if a.runtimeConfig != nil {	262		if a.runtimeConfig != nil {
263		return a.runtimeConfig.Current()	263		return a.runtimeConfig.Current()

@@ -265,7 +265,7 @@ func (a *App) runtimeConfigSnapshot() port.RuntimeConfigSnapshot {
265		if a.deps != nil && a.deps.RuntimeConfig != nil {	265		if a.deps != nil && a.deps.RuntimeConfig != nil {
266		return a.deps.RuntimeConfig.Current()	266		return a.deps.RuntimeConfig.Current()
267		}	267		}
268	-	return port.RuntimeConfigSnapshot{}	268	+	return entity.RuntimeConfigSnapshot{}
269		}	269		}
270			270
271		// Run starts the GTK application and blocks until it exits.	271		// Run starts the GTK application and blocks until it exits.

@@ -506,7 +506,7 @@ func (a App) createBrowserWindow(ctx context.Context, initialURL string) (brow
506		return browserWindow, nil	506		return browserWindow, nil
507		}	507		}
508			508
509	-	func (a App) initBrowserWindowOverlays(mainWindow window.MainWindow, browserWindow *browserWindow, runtimeCfg port.RuntimeUIConfig) {	509	+	func (a App) initBrowserWindowOverlays(mainWindow window.MainWindow, browserWindow *browserWindow, runtimeCfg entity.RuntimeUIConfig) {
510		// Create permission popup and dialog presenter	510		// Create permission popup and dialog presenter
511		if a.deps != nil && a.deps.PermissionUC != nil {	511		if a.deps != nil && a.deps.PermissionUC != nil {
512		uiScale := runtimeCfg.DefaultUIScale	512		uiScale := runtimeCfg.DefaultUIScale

@@ -1435,7 +1435,7 @@ type omniboxCallbacks struct {
1435			1435
1436		func buildOmniboxConfig(	1436		func buildOmniboxConfig(
1437		deps *Dependencies,	1437		deps *Dependencies,
1438	-	runtimeCfg port.RuntimeUIConfig,	1438	+	runtimeCfg entity.RuntimeUIConfig,
1439		faviconAdapter *adapter.FaviconAdapter,	1439		faviconAdapter *adapter.FaviconAdapter,
1440		callbacks omniboxCallbacks,	1440		callbacks omniboxCallbacks,
1441		) component.OmniboxConfig {	1441		) component.OmniboxConfig {

@@ -1490,7 +1490,7 @@ func NewStandaloneOmniboxRuntime(
1490		registerFaviconInvalidator(deps.FaviconResolver, faviconAdapter)	1490		registerFaviconInvalidator(deps.FaviconResolver, faviconAdapter)
1491		}	1491		}
1492			1492
1493	-	var runtimeCfg port.RuntimeUIConfig	1493	+	var runtimeCfg entity.RuntimeUIConfig
1494		if deps != nil && deps.RuntimeConfig != nil {	1494		if deps != nil && deps.RuntimeConfig != nil {
1495		runtimeCfg = deps.RuntimeConfig.Current().UI	1495		runtimeCfg = deps.RuntimeConfig.Current().UI
1496		}	1496		}

@@ -5085,14 +5085,14 @@ func (a *App) initConfigWatcher(ctx context.Context) {
5085		}	5085		}
5086			5086
5087		// Hot-reload appearance and keybindings on config change.	5087		// Hot-reload appearance and keybindings on config change.
5088	-	a.deps.RuntimeConfig.OnChange(func(snapshot port.RuntimeConfigSnapshot) {	5088	+	a.deps.RuntimeConfig.OnChange(func(snapshot entity.RuntimeConfigSnapshot) {
5089		a.dispatchRuntimeConfigChange(ctx, snapshot)	5089		a.dispatchRuntimeConfigChange(ctx, snapshot)
5090		})	5090		})
5091			5091
5092		log.Debug().Msg("config watcher initialized")	5092		log.Debug().Msg("config watcher initialized")
5093		}	5093		}
5094			5094
5095	-	func (a *App) dispatchRuntimeConfigChange(ctx context.Context, snapshot port.RuntimeConfigSnapshot) {	5095	+	func (a *App) dispatchRuntimeConfigChange(ctx context.Context, snapshot entity.RuntimeConfigSnapshot) {
5096		run := func() {	5096		run := func() {
5097		a.applyRuntimeConfigChange(ctx, snapshot)	5097		a.applyRuntimeConfigChange(ctx, snapshot)
5098		}	5098		}

@@ -5103,7 +5103,7 @@ func (a *App) dispatchRuntimeConfigChange(ctx context.Context, snapshot port.Run
5103		run()	5103		run()
5104		}	5104		}
5105			5105
5106	-	func (a *App) applyRuntimeConfigChange(ctx context.Context, snapshot port.RuntimeConfigSnapshot) {	5106	+	func (a *App) applyRuntimeConfigChange(ctx context.Context, snapshot entity.RuntimeConfigSnapshot) {
5107		if a == nil {	5107		if a == nil {
5108		return	5108		return
5109		}	5109		}

@@ -5158,7 +5158,7 @@ func (a *App) applyAppearanceConfig(ctx context.Context) {
5158		snapshot := a.runtimeConfigSnapshot()	5158		snapshot := a.runtimeConfigSnapshot()
5159			5159
5160		if a.engine != nil {	5160		if a.engine != nil {
5161	-	if err := a.engine.UpdateSettings(ctx, port.EngineSettingsUpdate{	5161	+	if err := a.engine.UpdateSettings(ctx, entity.EngineSettingsUpdate{
5162		Settings: snapshot.EngineSettings,	5162		Settings: snapshot.EngineSettings,
5163		}); err != nil {	5163		}); err != nil {
5164		log.Warn().Err(err).Msg("failed to apply engine settings update")	5164		log.Warn().Err(err).Msg("failed to apply engine settings update")

M internal/ui/app_clipboard_test.go +2 -2


@@ -25,7 +25,7 @@ func TestNew_DoesNotWireClipboardOrchestratorWhenClipboardMissing(t *testing.T)
25	25		runtimeConfig := portmocks.NewMockRuntimeConfigProvider(t)
26	26		runtimeConfig.EXPECT().
27	27		Current().
28		-	Return(port.RuntimeConfigSnapshot{}).
	28	+	Return(entity.RuntimeConfigSnapshot{}).
29	29		Once()
30	30
31	31		deps := &Dependencies{

@@ -59,7 +59,7 @@ func TestNew_WiresClipboardOrchestratorWhenClipboardPresent(t *testing.T) {
59	59		runtimeConfig := portmocks.NewMockRuntimeConfigProvider(t)
60	60		runtimeConfig.EXPECT().
61	61		Current().
62		-	Return(port.RuntimeConfigSnapshot{}).
	62	+	Return(entity.RuntimeConfigSnapshot{}).
63	63		Once()
64	64
65	65		deps := &Dependencies{


@@ -25,7 +25,7 @@ func TestNew_DoesNotWireClipboardOrchestratorWhenClipboardMissing(t *testing.T)
25		runtimeConfig := portmocks.NewMockRuntimeConfigProvider(t)	25		runtimeConfig := portmocks.NewMockRuntimeConfigProvider(t)
26		runtimeConfig.EXPECT().	26		runtimeConfig.EXPECT().
27		Current().	27		Current().
28	-	Return(port.RuntimeConfigSnapshot{}).	28	+	Return(entity.RuntimeConfigSnapshot{}).
29		Once()	29		Once()
30			30
31		deps := &Dependencies{	31		deps := &Dependencies{

@@ -59,7 +59,7 @@ func TestNew_WiresClipboardOrchestratorWhenClipboardPresent(t *testing.T) {
59		runtimeConfig := portmocks.NewMockRuntimeConfigProvider(t)	59		runtimeConfig := portmocks.NewMockRuntimeConfigProvider(t)
60		runtimeConfig.EXPECT().	60		runtimeConfig.EXPECT().
61		Current().	61		Current().
62	-	Return(port.RuntimeConfigSnapshot{}).	62	+	Return(entity.RuntimeConfigSnapshot{}).
63		Once()	63		Once()
64			64
65		deps := &Dependencies{	65		deps := &Dependencies{

M internal/ui/app_omnibox_config_test.go +3 -4


@@ -3,22 +3,21 @@ package ui
3	3		import (
4	4		"testing"
5	5
6		-	"github.com/bnema/dumber/internal/application/port"
7	6		"github.com/bnema/dumber/internal/domain/entity"
8	7		)
9	8
10	9		func TestBuildOmniboxConfigUsesRuntimeUIConfig(t *testing.T) {
11	10		deps := &Dependencies{}
12		-	runtimeCfg := port.RuntimeUIConfig{
	11	+	runtimeCfg := entity.RuntimeUIConfig{
13	12		DefaultUIScale: 1.35,
14	13		DefaultSearchEngine: "https://search.example/?q=%s",
15		-	SearchShortcuts: map[string]port.RuntimeSearchShortcut{
	14	+	SearchShortcuts: map[string]entity.RuntimeSearchShortcut{
16	15		"gh": {
17	16		URL: "https://github.com/search?q=%s",
18	17		Description: "GitHub",
19	18		},
20	19		},
21		-	Omnibox: port.RuntimeOmniboxConfig{
	20	+	Omnibox: entity.RuntimeOmniboxConfig{
22	21		InitialBehavior: entity.OmniboxInitialBehaviorMostVisited,
23	22		MostVisitedDays: 7,
24	23		},

 import (
 	"testing"
-	"github.com/bnema/dumber/internal/application/port"
 	"github.com/bnema/dumber/internal/domain/entity"
 )
 func TestBuildOmniboxConfigUsesRuntimeUIConfig(t *testing.T) {
 	deps := &Dependencies{}
-	runtimeCfg := port.RuntimeUIConfig{
+	runtimeCfg := entity.RuntimeUIConfig{
 		DefaultUIScale:      1.35,
 		DefaultSearchEngine: "https://search.example/?q=%s",
-		SearchShortcuts: map[string]port.RuntimeSearchShortcut{
+		SearchShortcuts: map[string]entity.RuntimeSearchShortcut{
 			"gh": {
 				URL:         "https://github.com/search?q=%s",
 				Description: "GitHub",
 			},
 		},
-		Omnibox: port.RuntimeOmniboxConfig{
+		Omnibox: entity.RuntimeOmniboxConfig{
 			InitialBehavior: entity.OmniboxInitialBehaviorMostVisited,
 			MostVisitedDays: 7,
 		},

M internal/ui/external_theme_reload_test.go +5 -6


@@ -8,7 +8,6 @@ import (
8	8		"github.com/stretchr/testify/mock"
9	9		"github.com/stretchr/testify/require"
10	10
11		-	"github.com/bnema/dumber/internal/application/port"
12	11		portmocks "github.com/bnema/dumber/internal/application/port/mocks"
13	12		"github.com/bnema/dumber/internal/application/usecase"
14	13		"github.com/bnema/dumber/internal/bootstrap"

@@ -83,9 +82,9 @@ func TestApplyAppearanceConfigSendsCompleteEngineSettingsPayload(t *testing.T) {
83	82		cfg.Engine.WebKit.DrawCompositingIndicators = true
84	83		cfg.Media.HardwareDecodingMode = config.HardwareDecodingForce
85	84		cfg.Clipboard.AutoCopyOnSelection = true
86		-	expected := port.EngineSettingsPayload{
	85	+	expected := entity.EngineSettingsPayload{
87	86		DefaultUIScale: cfg.DefaultUIScale,
88		-	WebContent: port.EngineWebContentSettingsPayload{
	87	+	WebContent: entity.EngineWebContentSettingsPayload{
89	88		SansFont: cfg.Appearance.SansFont,
90	89		SerifFont: cfg.Appearance.SerifFont,
91	90		MonospaceFont: cfg.Appearance.MonospaceFont,

@@ -93,14 +92,14 @@ func TestApplyAppearanceConfigSendsCompleteEngineSettingsPayload(t *testing.T) {
93	92		EnableDevTools: cfg.Debug.EnableDevTools,
94	93		CaptureConsole: cfg.Logging.CaptureConsole,
95	94		DrawCompositingIndicators: cfg.Engine.WebKit.DrawCompositingIndicators,
96		-	HardwareDecoding: port.EngineHardwareDecodingForce,
	95	+	HardwareDecoding: entity.EngineHardwareDecodingForce,
97	96		AutoCopyOnSelection: cfg.Clipboard.AutoCopyOnSelection,
98	97		},
99	98		}
100	99		engine := portmocks.NewMockEngine(t)
101		-	var captured port.EngineSettingsUpdate
	100	+	var captured entity.EngineSettingsUpdate
102	101		engine.EXPECT().UpdateSettings(mock.Anything, mock.Anything).
103		-	Run(func(_ context.Context, update port.EngineSettingsUpdate) {
	102	+	Run(func(_ context.Context, update entity.EngineSettingsUpdate) {
104	103		captured = update
105	104		}).
106	105		Return(nil).

 	"github.com/stretchr/testify/mock"
 	"github.com/stretchr/testify/require"
-	"github.com/bnema/dumber/internal/application/port"
 	portmocks "github.com/bnema/dumber/internal/application/port/mocks"
 	"github.com/bnema/dumber/internal/application/usecase"
 	"github.com/bnema/dumber/internal/bootstrap"
 	cfg.Engine.WebKit.DrawCompositingIndicators = true
 	cfg.Media.HardwareDecodingMode = config.HardwareDecodingForce
 	cfg.Clipboard.AutoCopyOnSelection = true
-	expected := port.EngineSettingsPayload{
+	expected := entity.EngineSettingsPayload{
 		DefaultUIScale: cfg.DefaultUIScale,
-		WebContent: port.EngineWebContentSettingsPayload{
+		WebContent: entity.EngineWebContentSettingsPayload{
 			SansFont:                  cfg.Appearance.SansFont,
 			SerifFont:                 cfg.Appearance.SerifFont,
 			MonospaceFont:             cfg.Appearance.MonospaceFont,
 			EnableDevTools:            cfg.Debug.EnableDevTools,
 			CaptureConsole:            cfg.Logging.CaptureConsole,
 			DrawCompositingIndicators: cfg.Engine.WebKit.DrawCompositingIndicators,
-			HardwareDecoding:          port.EngineHardwareDecodingForce,
+			HardwareDecoding:          entity.EngineHardwareDecodingForce,
 			AutoCopyOnSelection:       cfg.Clipboard.AutoCopyOnSelection,
 		},
 	}
 	engine := portmocks.NewMockEngine(t)
-	var captured port.EngineSettingsUpdate
+	var captured entity.EngineSettingsUpdate
 	engine.EXPECT().UpdateSettings(mock.Anything, mock.Anything).
-		Run(func(_ context.Context, update port.EngineSettingsUpdate) {
+		Run(func(_ context.Context, update entity.EngineSettingsUpdate) {
 			captured = update
 		}).
 		Return(nil).

M internal/ui/runtime_config_state.go +9 -6

@@ -1,10 +1,13 @@
1	1		package ui
2	2
3		-	import "github.com/bnema/dumber/internal/application/port"
	3	+	import (
	4	+	"github.com/bnema/dumber/internal/application/port"
	5	+	"github.com/bnema/dumber/internal/domain/entity"
	6	+	)
4	7
5	8		type runtimeConfigState struct {
6	9		provider port.RuntimeConfigProvider
7		-	snapshot port.RuntimeConfigSnapshot
	10	+	snapshot entity.RuntimeConfigSnapshot
8	11		loaded bool
9	12		}
10	13

@@ -16,9 +19,9 @@ func newRuntimeConfigState(provider port.RuntimeConfigProvider) *runtimeConfigSt
16	19		return state
17	20		}
18	21
19		-	func (s *runtimeConfigState) Current() port.RuntimeConfigSnapshot {
	22	+	func (s *runtimeConfigState) Current() entity.RuntimeConfigSnapshot {
20	23		if s == nil {
21		-	return port.RuntimeConfigSnapshot{}
	24	+	return entity.RuntimeConfigSnapshot{}
22	25		}
23	26		if s.loaded {
24	27		return s.snapshot

@@ -26,10 +29,10 @@ func (s *runtimeConfigState) Current() port.RuntimeConfigSnapshot {
26	29		if s.provider != nil {
27	30		return s.provider.Current()
28	31		}
29		-	return port.RuntimeConfigSnapshot{}
	32	+	return entity.RuntimeConfigSnapshot{}
30	33		}
31	34
32		-	func (s *runtimeConfigState) Update(snapshot port.RuntimeConfigSnapshot) {
	35	+	func (s *runtimeConfigState) Update(snapshot entity.RuntimeConfigSnapshot) {
33	36		if s == nil {
34	37		return
35	38		}

 package ui
-import "github.com/bnema/dumber/internal/application/port"
+import (
+	"github.com/bnema/dumber/internal/application/port"
+	"github.com/bnema/dumber/internal/domain/entity"
+)
 type runtimeConfigState struct {
 	provider port.RuntimeConfigProvider
-	snapshot port.RuntimeConfigSnapshot
+	snapshot entity.RuntimeConfigSnapshot
 	loaded   bool
 }
 	return state
 }
-func (s *runtimeConfigState) Current() port.RuntimeConfigSnapshot {
+func (s *runtimeConfigState) Current() entity.RuntimeConfigSnapshot {
 	if s == nil {
-		return port.RuntimeConfigSnapshot{}
+		return entity.RuntimeConfigSnapshot{}
 	}
 	if s.loaded {
 		return s.snapshot
 	if s.provider != nil {
 		return s.provider.Current()
 	}
-	return port.RuntimeConfigSnapshot{}
+	return entity.RuntimeConfigSnapshot{}
 }
-func (s *runtimeConfigState) Update(snapshot port.RuntimeConfigSnapshot) {
+func (s *runtimeConfigState) Update(snapshot entity.RuntimeConfigSnapshot) {
 	if s == nil {
 		return
 	}

M internal/ui/runtime_config_test.go +10 -10


@@ -40,8 +40,8 @@ func TestAppRuntimeConfigReturnsProviderSnapshot(t *testing.T) {
40	40		provider := portmocks.NewMockRuntimeConfigProvider(t)
41	41		provider.EXPECT().
42	42		Current().
43		-	Return(port.RuntimeConfigSnapshot{
44		-	UI: port.RuntimeUIConfig{DefaultUIScale: 1.6},
	43	+	Return(entity.RuntimeConfigSnapshot{
	44	+	UI: entity.RuntimeUIConfig{DefaultUIScale: 1.6},
45	45		}).
46	46		Once()
47	47		app := &App{deps: &Dependencies{RuntimeConfig: provider}}

@@ -55,8 +55,8 @@ func TestAppRuntimeConfigReturnsProviderSnapshot(t *testing.T) {
55	55
56	56		func TestAppRuntimeConfigStateStoresLatestSnapshot(t *testing.T) {
57	57		app := &App{}
58		-	setRuntimeConfigSnapshotForTest(app, port.RuntimeConfigSnapshot{
59		-	UI: port.RuntimeUIConfig{SidebarWidth: 340},
	58	+	setRuntimeConfigSnapshotForTest(app, entity.RuntimeConfigSnapshot{
	59	+	UI: entity.RuntimeUIConfig{SidebarWidth: 340},
60	60		})
61	61
62	62		got := app.runtimeConfigSnapshot()

@@ -69,16 +69,16 @@ func TestConfigWatcherOnChangeUpdatesRuntimeConfigState(t *testing.T) {
69	69		ctx := context.Background()
70	70		provider := portmocks.NewMockRuntimeConfigProvider(t)
71	71		provider.EXPECT().Watch().Return(nil).Once()
72		-	var onChange func(port.RuntimeConfigSnapshot)
	72	+	var onChange func(entity.RuntimeConfigSnapshot)
73	73		provider.EXPECT().
74	74		OnChange(mock.Anything).
75		-	Run(func(fn func(port.RuntimeConfigSnapshot)) {
	75	+	Run(func(fn func(entity.RuntimeConfigSnapshot)) {
76	76		onChange = fn
77	77		}).
78	78		Once()
79	79
80		-	initial := port.RuntimeConfigSnapshot{
81		-	UI: port.RuntimeUIConfig{
	80	+	initial := entity.RuntimeConfigSnapshot{
	81	+	UI: entity.RuntimeUIConfig{
82	82		Workspace: entity.WorkspaceConfig{
83	83		BrowsingContexts: entity.BrowsingContextConfig{OpenInNewPane: true},
84	84		},

@@ -104,8 +104,8 @@ func TestConfigWatcherOnChangeUpdatesRuntimeConfigState(t *testing.T) {
104	104		t.Fatal("runtime config OnChange callback was not registered")
105	105		}
106	106
107		-	onChange(port.RuntimeConfigSnapshot{
108		-	UI: port.RuntimeUIConfig{
	107	+	onChange(entity.RuntimeConfigSnapshot{
	108	+	UI: entity.RuntimeUIConfig{
109	109		SidebarWidth: 360,
110	110		Workspace: entity.WorkspaceConfig{
111	111		BrowsingContexts: entity.BrowsingContextConfig{OpenInNewPane: false, OAuthAutoClose: true},


@@ -40,8 +40,8 @@ func TestAppRuntimeConfigReturnsProviderSnapshot(t *testing.T) {
40		provider := portmocks.NewMockRuntimeConfigProvider(t)	40		provider := portmocks.NewMockRuntimeConfigProvider(t)
41		provider.EXPECT().	41		provider.EXPECT().
42		Current().	42		Current().
43	-	Return(port.RuntimeConfigSnapshot{	43	+	Return(entity.RuntimeConfigSnapshot{
44	-	UI: port.RuntimeUIConfig{DefaultUIScale: 1.6},	44	+	UI: entity.RuntimeUIConfig{DefaultUIScale: 1.6},
45		}).	45		}).
46		Once()	46		Once()
47		app := &App{deps: &Dependencies{RuntimeConfig: provider}}	47		app := &App{deps: &Dependencies{RuntimeConfig: provider}}

@@ -55,8 +55,8 @@ func TestAppRuntimeConfigReturnsProviderSnapshot(t *testing.T) {
55			55
56		func TestAppRuntimeConfigStateStoresLatestSnapshot(t *testing.T) {	56		func TestAppRuntimeConfigStateStoresLatestSnapshot(t *testing.T) {
57		app := &App{}	57		app := &App{}
58	-	setRuntimeConfigSnapshotForTest(app, port.RuntimeConfigSnapshot{	58	+	setRuntimeConfigSnapshotForTest(app, entity.RuntimeConfigSnapshot{
59	-	UI: port.RuntimeUIConfig{SidebarWidth: 340},	59	+	UI: entity.RuntimeUIConfig{SidebarWidth: 340},
60		})	60		})
61			61
62		got := app.runtimeConfigSnapshot()	62		got := app.runtimeConfigSnapshot()

@@ -69,16 +69,16 @@ func TestConfigWatcherOnChangeUpdatesRuntimeConfigState(t *testing.T) {
69		ctx := context.Background()	69		ctx := context.Background()
70		provider := portmocks.NewMockRuntimeConfigProvider(t)	70		provider := portmocks.NewMockRuntimeConfigProvider(t)
71		provider.EXPECT().Watch().Return(nil).Once()	71		provider.EXPECT().Watch().Return(nil).Once()
72	-	var onChange func(port.RuntimeConfigSnapshot)	72	+	var onChange func(entity.RuntimeConfigSnapshot)
73		provider.EXPECT().	73		provider.EXPECT().
74		OnChange(mock.Anything).	74		OnChange(mock.Anything).
75	-	Run(func(fn func(port.RuntimeConfigSnapshot)) {	75	+	Run(func(fn func(entity.RuntimeConfigSnapshot)) {
76		onChange = fn	76		onChange = fn
77		}).	77		}).
78		Once()	78		Once()
79			79
80	-	initial := port.RuntimeConfigSnapshot{	80	+	initial := entity.RuntimeConfigSnapshot{
81	-	UI: port.RuntimeUIConfig{	81	+	UI: entity.RuntimeUIConfig{
82		Workspace: entity.WorkspaceConfig{	82		Workspace: entity.WorkspaceConfig{
83		BrowsingContexts: entity.BrowsingContextConfig{OpenInNewPane: true},	83		BrowsingContexts: entity.BrowsingContextConfig{OpenInNewPane: true},
84		},	84		},

@@ -104,8 +104,8 @@ func TestConfigWatcherOnChangeUpdatesRuntimeConfigState(t *testing.T) {
104		t.Fatal("runtime config OnChange callback was not registered")	104		t.Fatal("runtime config OnChange callback was not registered")
105		}	105		}
106			106
107	-	onChange(port.RuntimeConfigSnapshot{	107	+	onChange(entity.RuntimeConfigSnapshot{
108	-	UI: port.RuntimeUIConfig{	108	+	UI: entity.RuntimeUIConfig{
109		SidebarWidth: 360,	109		SidebarWidth: 360,
110		Workspace: entity.WorkspaceConfig{	110		Workspace: entity.WorkspaceConfig{
111		BrowsingContexts: entity.BrowsingContextConfig{OpenInNewPane: false, OAuthAutoClose: true},	111		BrowsingContexts: entity.BrowsingContextConfig{OpenInNewPane: false, OAuthAutoClose: true},

M internal/ui/runtime_config_test_helpers_test.go +4 -4

@@ -1,16 +1,16 @@
1	1		package ui
2	2
3	3		import (
4		-	"github.com/bnema/dumber/internal/application/port"
5	4		"github.com/bnema/dumber/internal/bootstrap"
	5	+	"github.com/bnema/dumber/internal/domain/entity"
6	6		"github.com/bnema/dumber/internal/infrastructure/config"
7	7		)
8	8
9		-	func runtimeConfigSnapshotForTest(cfg *config.Config) port.RuntimeConfigSnapshot {
	9	+	func runtimeConfigSnapshotForTest(cfg *config.Config) entity.RuntimeConfigSnapshot {
10	10		return bootstrap.RuntimeConfigSnapshotFromConfig(cfg)
11	11		}
12	12
13		-	func runtimeConfigStateFromSnapshotForTest(snapshot port.RuntimeConfigSnapshot) *runtimeConfigState {
	13	+	func runtimeConfigStateFromSnapshotForTest(snapshot entity.RuntimeConfigSnapshot) *runtimeConfigState {
14	14		state := newRuntimeConfigState(nil)
15	15		state.Update(snapshot)
16	16		return state

@@ -20,7 +20,7 @@ func runtimeConfigStateForTest(cfg config.Config) runtimeConfigState {
20	20		return runtimeConfigStateFromSnapshotForTest(runtimeConfigSnapshotForTest(cfg))
21	21		}
22	22
23		-	func setRuntimeConfigSnapshotForTest(app *App, snapshot port.RuntimeConfigSnapshot) {
	23	+	func setRuntimeConfigSnapshotForTest(app *App, snapshot entity.RuntimeConfigSnapshot) {
24	24		if app.runtimeConfig == nil {
25	25		app.runtimeConfig = newRuntimeConfigState(nil)
26	26		}

 package ui
 import (
-	"github.com/bnema/dumber/internal/application/port"
 	"github.com/bnema/dumber/internal/bootstrap"
+	"github.com/bnema/dumber/internal/domain/entity"
 	"github.com/bnema/dumber/internal/infrastructure/config"
 )
-func runtimeConfigSnapshotForTest(cfg *config.Config) port.RuntimeConfigSnapshot {
+func runtimeConfigSnapshotForTest(cfg *config.Config) entity.RuntimeConfigSnapshot {
 	return bootstrap.RuntimeConfigSnapshotFromConfig(cfg)
 }
-func runtimeConfigStateFromSnapshotForTest(snapshot port.RuntimeConfigSnapshot) *runtimeConfigState {
+func runtimeConfigStateFromSnapshotForTest(snapshot entity.RuntimeConfigSnapshot) *runtimeConfigState {
 	state := newRuntimeConfigState(nil)
 	state.Update(snapshot)
 	return state
 	return runtimeConfigStateFromSnapshotForTest(runtimeConfigSnapshotForTest(cfg))
 }
-func setRuntimeConfigSnapshotForTest(app *App, snapshot port.RuntimeConfigSnapshot) {
+func setRuntimeConfigSnapshotForTest(app *App, snapshot entity.RuntimeConfigSnapshot) {
 	if app.runtimeConfig == nil {
 		app.runtimeConfig = newRuntimeConfigState(nil)
 	}