detached 14868d8

chore: replace oauth close magic number with named delay

Extract the 500ms OAuth popup close delay into a named constant
so lint passes and the intent of the delay is explicit.
commit
14868d8cff99f66ca7d4a36c915117d0a324abe7
author
brice · · 2026-02-16 14:27 UTC
parent
495353a
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
1 file · +2 -1
M internal/ui/coordinator/content.go +2 -1
@@ -1799,6 +1799,7 @@ func (c *ContentCoordinator) setupOAuthAutoClose(
17991799 var cancelSafetyTimerOnce sync.Once
18001800 var requestCloseOnce sync.Once
18011801 const oauthSafetyTimeout = 30 * time.Second
1802+ const oauthCloseDelay = 500 * time.Millisecond
18021803
18031804 startSafetyTimer := func() {
18041805 safetyTimerMu.Lock()
@@ -1837,7 +1838,7 @@ func (c *ContentCoordinator) setupOAuthAutoClose(
18371838 Str("reason", reason).
18381839 Msg("oauth callback detected, closing")
18391840 requestCloseOnce.Do(func() {
1840- time.AfterFunc(500*time.Millisecond, func() {
1841+ time.AfterFunc(oauthCloseDelay, func() {
18411842 cb := glib.SourceFunc(func(_ uintptr) bool {
18421843 if wv != nil && !wv.IsDestroyed() {
18431844 wv.Close()
@@ -1799,6 +1799,7 @@ func (c *ContentCoordinator) setupOAuthAutoClose(
1799 var cancelSafetyTimerOnce sync.Once1799 var cancelSafetyTimerOnce sync.Once
1800 var requestCloseOnce sync.Once1800 var requestCloseOnce sync.Once
1801 const oauthSafetyTimeout = 30 * time.Second1801 const oauthSafetyTimeout = 30 * time.Second
1802+ const oauthCloseDelay = 500 * time.Millisecond
1802 1803
1803 startSafetyTimer := func() {1804 startSafetyTimer := func() {
1804 safetyTimerMu.Lock()1805 safetyTimerMu.Lock()
@@ -1837,7 +1838,7 @@ func (c *ContentCoordinator) setupOAuthAutoClose(
1837 Str("reason", reason).1838 Str("reason", reason).
1838 Msg("oauth callback detected, closing")1839 Msg("oauth callback detected, closing")
1839 requestCloseOnce.Do(func() {1840 requestCloseOnce.Do(func() {
1840- time.AfterFunc(500*time.Millisecond, func() {1841+ time.AfterFunc(oauthCloseDelay, func() {
1841 cb := glib.SourceFunc(func(_ uintptr) bool {1842 cb := glib.SourceFunc(func(_ uintptr) bool {
1842 if wv != nil && !wv.IsDestroyed() {1843 if wv != nil && !wv.IsDestroyed() {
1843 wv.Close()1844 wv.Close()

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 8

Tags 42

↑↓ moveenter openesc close