detached 2619383

fix(gui): prevent find mode persistence when reopening omnibox with Ctrl+L

commit
2619383bcf47a9718702743f5dd2e248caf73224
author
bamen · · 2025-09-15 08:41 UTC
parent
650deb5
signature
unsigned
2 files · +8 -1
M CHANGELOG.md +1 -0
@@ -26,6 +26,7 @@ All notable changes to this project will be documented in this file.
2626 - **State persistence**: Proper cleanup when switching between Ctrl+L and Ctrl+F modes
2727 - **Homepage protocol**: Fixed dumb://homepage not working after GUI migration with proper Svelte 5 component and API integration
2828 - **Omnibox positioning on homepage**: Fixed omnibox stuck in top-left corner by isolating homepage CSS styles and strengthening omnibox positioning with explicit fixed positioning and CSS isolation
29+- **Find mode persistence**: Fixed find view persisting after pressing Esc when reopening with Ctrl+L by ensuring toggle() resets mode to 'omnibox'
2930
3031 ## [0.7.0] - 2025-09-14
3132
@@ -26,6 +26,7 @@ All notable changes to this project will be documented in this file.
26 - **State persistence**: Proper cleanup when switching between Ctrl+L and Ctrl+F modes26 - **State persistence**: Proper cleanup when switching between Ctrl+L and Ctrl+F modes
27 - **Homepage protocol**: Fixed dumb://homepage not working after GUI migration with proper Svelte 5 component and API integration27 - **Homepage protocol**: Fixed dumb://homepage not working after GUI migration with proper Svelte 5 component and API integration
28 - **Omnibox positioning on homepage**: Fixed omnibox stuck in top-left corner by isolating homepage CSS styles and strengthening omnibox positioning with explicit fixed positioning and CSS isolation28 - **Omnibox positioning on homepage**: Fixed omnibox stuck in top-left corner by isolating homepage CSS styles and strengthening omnibox positioning with explicit fixed positioning and CSS isolation
29+- **Find mode persistence**: Fixed find view persisting after pressing Esc when reopening with Ctrl+L by ensuring toggle() resets mode to 'omnibox'
29 30
30 ## [0.7.0] - 2025-09-1431 ## [0.7.0] - 2025-09-14
31 32
M gui/src/components/omnibox/stores.svelte.ts +7 -1
@@ -142,7 +142,13 @@ export const omniboxStore = {
142142 },
143143
144144 toggle() {
145- this.setVisible(!visible);
145+ if (!visible) {
146+ // When opening via toggle (Ctrl+L), always open in omnibox mode
147+ this.setMode('omnibox');
148+ this.setVisible(true);
149+ } else {
150+ this.setVisible(false);
151+ }
146152 },
147153
148154 updateSuggestions(newSuggestions: Suggestion[]) {
@@ -142,7 +142,13 @@ export const omniboxStore = {
142 },142 },
143 143
144 toggle() {144 toggle() {
145- this.setVisible(!visible);145+ if (!visible) {
146+ // When opening via toggle (Ctrl+L), always open in omnibox mode
147+ this.setMode('omnibox');
148+ this.setVisible(true);
149+ } else {
150+ this.setVisible(false);
151+ }
146 },152 },
147 153
148 updateSuggestions(newSuggestions: Suggestion[]) {154 updateSuggestions(newSuggestions: Suggestion[]) {

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 8

Tags 42

↑↓ moveenter openesc close