test: use temp log dir for session cleanup
- commit
- 314ee29c9ca4e317ae750cb3d88bd7d0758fdf0a
- author
- brice · · 2026-04-25 05:51 UTC
- parent
- a83b7b9
- signature
- GPG Verified
CD88F9E564E0102646FB6077A1A07C7C7C3E349D· arch-gpg Verified for the committer email
1 file · +4 -2
M internal/bootstrap/session_test.go +4 -2
| @@ -21,6 +21,7 @@ func TestRunSessionCleanup_SkipsCurrentActiveSession(t *testing.T) { | |||
| 21 | 21 | sessionUC := usecase.NewManageSessionUseCase(repo, nil) | |
| 22 | 22 | cleanupUC := usecase.NewCleanupSessionsUseCase(repo) | |
| 23 | 23 | cfg := config.DefaultConfig() | |
| 24 | + | logDir := t.TempDir() | |
| 24 | 25 | ||
| 25 | 26 | now := time.Now().UTC() | |
| 26 | 27 | current := &entity.Session{ | |
| @@ -45,7 +46,7 @@ func TestRunSessionCleanup_SkipsCurrentActiveSession(t *testing.T) { | |||
| 45 | 46 | repo.EXPECT().DeleteExitedBefore(mock.Anything, mock.MatchedBy(func(time.Time) bool { return true })).Return(int64(0), nil).Once() | |
| 46 | 47 | repo.EXPECT().DeleteOldestExited(mock.Anything, cfg.Session.MaxExitedSessions).Return(int64(0), nil).Once() | |
| 47 | 48 | ||
| 48 | - | runSessionCleanup(ctx, sessionUC, cleanupUC, cfg, cfg.Logging.LogDir, current.ID, nil) | |
| 49 | + | runSessionCleanup(ctx, sessionUC, cleanupUC, cfg, logDir, current.ID, nil) | |
| 49 | 50 | } | |
| 50 | 51 | ||
| 51 | 52 | func TestRunSessionCleanup_NoPanicOnNilSessions(t *testing.T) { | |
| @@ -56,12 +57,13 @@ func TestRunSessionCleanup_NoPanicOnNilSessions(t *testing.T) { | |||
| 56 | 57 | sessionUC := usecase.NewManageSessionUseCase(repo, nil) | |
| 57 | 58 | cleanupUC := usecase.NewCleanupSessionsUseCase(repo) | |
| 58 | 59 | cfg := config.DefaultConfig() | |
| 60 | + | logDir := t.TempDir() | |
| 59 | 61 | ||
| 60 | 62 | repo.EXPECT().GetRecent(mock.Anything, recentSessionsLimit).Return([]*entity.Session{nil}, nil).Once() | |
| 61 | 63 | repo.EXPECT().DeleteExitedBefore(mock.Anything, mock.MatchedBy(func(time.Time) bool { return true })).Return(int64(0), nil).Once() | |
| 62 | 64 | repo.EXPECT().DeleteOldestExited(mock.Anything, cfg.Session.MaxExitedSessions).Return(int64(0), nil).Once() | |
| 63 | 65 | ||
| 64 | 66 | require.NotPanics(t, func() { | |
| 65 | - | runSessionCleanup(ctx, sessionUC, cleanupUC, cfg, cfg.Logging.LogDir, entity.SessionID("current"), nil) | |
| 67 | + | runSessionCleanup(ctx, sessionUC, cleanupUC, cfg, logDir, entity.SessionID("current"), nil) | |
| 66 | 68 | }) | |
| 67 | 69 | } | |
| @@ -21,6 +21,7 @@ func TestRunSessionCleanup_SkipsCurrentActiveSession(t *testing.T) { | |||||
| 21 | sessionUC := usecase.NewManageSessionUseCase(repo, nil) | 21 | sessionUC := usecase.NewManageSessionUseCase(repo, nil) | ||
| 22 | cleanupUC := usecase.NewCleanupSessionsUseCase(repo) | 22 | cleanupUC := usecase.NewCleanupSessionsUseCase(repo) | ||
| 23 | cfg := config.DefaultConfig() | 23 | cfg := config.DefaultConfig() | ||
| 24 | + | logDir := t.TempDir() | |||
| 24 | 25 | ||||
| 25 | now := time.Now().UTC() | 26 | now := time.Now().UTC() | ||
| 26 | current := &entity.Session{ | 27 | current := &entity.Session{ | ||
| @@ -45,7 +46,7 @@ func TestRunSessionCleanup_SkipsCurrentActiveSession(t *testing.T) { | |||||
| 45 | repo.EXPECT().DeleteExitedBefore(mock.Anything, mock.MatchedBy(func(time.Time) bool { return true })).Return(int64(0), nil).Once() | 46 | repo.EXPECT().DeleteExitedBefore(mock.Anything, mock.MatchedBy(func(time.Time) bool { return true })).Return(int64(0), nil).Once() | ||
| 46 | repo.EXPECT().DeleteOldestExited(mock.Anything, cfg.Session.MaxExitedSessions).Return(int64(0), nil).Once() | 47 | repo.EXPECT().DeleteOldestExited(mock.Anything, cfg.Session.MaxExitedSessions).Return(int64(0), nil).Once() | ||
| 47 | 48 | ||||
| 48 | - | runSessionCleanup(ctx, sessionUC, cleanupUC, cfg, cfg.Logging.LogDir, current.ID, nil) | 49 | + | runSessionCleanup(ctx, sessionUC, cleanupUC, cfg, logDir, current.ID, nil) |
| 49 | } | 50 | } | ||
| 50 | 51 | ||||
| 51 | func TestRunSessionCleanup_NoPanicOnNilSessions(t *testing.T) { | 52 | func TestRunSessionCleanup_NoPanicOnNilSessions(t *testing.T) { | ||
| @@ -56,12 +57,13 @@ func TestRunSessionCleanup_NoPanicOnNilSessions(t *testing.T) { | |||||
| 56 | sessionUC := usecase.NewManageSessionUseCase(repo, nil) | 57 | sessionUC := usecase.NewManageSessionUseCase(repo, nil) | ||
| 57 | cleanupUC := usecase.NewCleanupSessionsUseCase(repo) | 58 | cleanupUC := usecase.NewCleanupSessionsUseCase(repo) | ||
| 58 | cfg := config.DefaultConfig() | 59 | cfg := config.DefaultConfig() | ||
| 60 | + | logDir := t.TempDir() | |||
| 59 | 61 | ||||
| 60 | repo.EXPECT().GetRecent(mock.Anything, recentSessionsLimit).Return([]*entity.Session{nil}, nil).Once() | 62 | repo.EXPECT().GetRecent(mock.Anything, recentSessionsLimit).Return([]*entity.Session{nil}, nil).Once() | ||
| 61 | repo.EXPECT().DeleteExitedBefore(mock.Anything, mock.MatchedBy(func(time.Time) bool { return true })).Return(int64(0), nil).Once() | 63 | repo.EXPECT().DeleteExitedBefore(mock.Anything, mock.MatchedBy(func(time.Time) bool { return true })).Return(int64(0), nil).Once() | ||
| 62 | repo.EXPECT().DeleteOldestExited(mock.Anything, cfg.Session.MaxExitedSessions).Return(int64(0), nil).Once() | 64 | repo.EXPECT().DeleteOldestExited(mock.Anything, cfg.Session.MaxExitedSessions).Return(int64(0), nil).Once() | ||
| 63 | 65 | ||||
| 64 | require.NotPanics(t, func() { | 66 | require.NotPanics(t, func() { | ||
| 65 | - | runSessionCleanup(ctx, sessionUC, cleanupUC, cfg, cfg.Logging.LogDir, entity.SessionID("current"), nil) | 67 | + | runSessionCleanup(ctx, sessionUC, cleanupUC, cfg, logDir, entity.SessionID("current"), nil) |
| 66 | }) | 68 | }) | ||
| 67 | } | 69 | } | ||