detached 3737c79

test(hover): cover GLib scheduling lifecycle

commit
3737c79e9e8b240044322b91af8fdf2d3979ec32
author
brice · · 2026-07-14 06:15 UTC
committer
brice · · 2026-07-14 07:06 UTC
parent
a4de34e
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
1 file · +55 -0
A internal/ui/input/hover_test.go +55 -0
@@ -0,0 +1,55 @@
1+package input
2+
3+import (
4+ "context"
5+ "testing"
6+
7+ "github.com/bnema/dumber/internal/domain/entity"
8+)
9+
10+func TestHoverHandlerSchedulesCallbackOnGLibAndRejectsStaleGeneration(t *testing.T) {
11+ h := NewHoverHandler(context.Background(), entity.PaneID("pane-1"))
12+ var scheduled func(uintptr) bool
13+ h.schedule = func(_ uint, fn func(uintptr) bool) uint {
14+ scheduled = fn
15+ return 7
16+ }
17+
18+ var calls int
19+ h.SetOnEnter(func(entity.PaneID) { calls++ })
20+ h.handleEnter()
21+ first := scheduled
22+ h.handleEnter()
23+ if first(0) {
24+ t.Fatal("hover source must be one-shot")
25+ }
26+ if calls != 0 {
27+ t.Fatalf("stale hover callback ran %d times", calls)
28+ }
29+ if scheduled == nil {
30+ t.Fatal("current hover callback was not scheduled")
31+ }
32+ if scheduled(0) {
33+ t.Fatal("hover source must be one-shot")
34+ }
35+ if calls != 1 {
36+ t.Fatalf("current hover callback ran %d times, want 1", calls)
37+ }
38+}
39+
40+func TestHoverHandlerDetachInvalidatesScheduledCallbackAndRemovesSource(t *testing.T) {
41+ h := NewHoverHandler(context.Background(), entity.PaneID("pane-1"))
42+ var scheduled func(uintptr) bool
43+ var removed []uint
44+ h.schedule = func(_ uint, fn func(uintptr) bool) uint { scheduled = fn; return 9 }
45+ h.removeSource = func(id uint) bool { removed = append(removed, id); return true }
46+ h.SetOnEnter(func(entity.PaneID) { t.Fatal("detached hover callback ran") })
47+ h.handleEnter()
48+ h.Detach()
49+ if len(removed) != 1 || removed[0] != 9 {
50+ t.Fatalf("removed sources = %v, want [9]", removed)
51+ }
52+ if scheduled == nil || scheduled(0) {
53+ t.Fatal("detached callback must be rejected and one-shot")
54+ }
55+}
@@ -0,0 +1,55 @@
1+package input
2+
3+import (
4+ "context"
5+ "testing"
6+
7+ "github.com/bnema/dumber/internal/domain/entity"
8+)
9+
10+func TestHoverHandlerSchedulesCallbackOnGLibAndRejectsStaleGeneration(t *testing.T) {
11+ h := NewHoverHandler(context.Background(), entity.PaneID("pane-1"))
12+ var scheduled func(uintptr) bool
13+ h.schedule = func(_ uint, fn func(uintptr) bool) uint {
14+ scheduled = fn
15+ return 7
16+ }
17+
18+ var calls int
19+ h.SetOnEnter(func(entity.PaneID) { calls++ })
20+ h.handleEnter()
21+ first := scheduled
22+ h.handleEnter()
23+ if first(0) {
24+ t.Fatal("hover source must be one-shot")
25+ }
26+ if calls != 0 {
27+ t.Fatalf("stale hover callback ran %d times", calls)
28+ }
29+ if scheduled == nil {
30+ t.Fatal("current hover callback was not scheduled")
31+ }
32+ if scheduled(0) {
33+ t.Fatal("hover source must be one-shot")
34+ }
35+ if calls != 1 {
36+ t.Fatalf("current hover callback ran %d times, want 1", calls)
37+ }
38+}
39+
40+func TestHoverHandlerDetachInvalidatesScheduledCallbackAndRemovesSource(t *testing.T) {
41+ h := NewHoverHandler(context.Background(), entity.PaneID("pane-1"))
42+ var scheduled func(uintptr) bool
43+ var removed []uint
44+ h.schedule = func(_ uint, fn func(uintptr) bool) uint { scheduled = fn; return 9 }
45+ h.removeSource = func(id uint) bool { removed = append(removed, id); return true }
46+ h.SetOnEnter(func(entity.PaneID) { t.Fatal("detached hover callback ran") })
47+ h.handleEnter()
48+ h.Detach()
49+ if len(removed) != 1 || removed[0] != 9 {
50+ t.Fatalf("removed sources = %v, want [9]", removed)
51+ }
52+ if scheduled == nil || scheduled(0) {
53+ t.Fatal("detached callback must be rejected and one-shot")
54+ }
55+}

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 8

Tags 42

↑↓ moveenter openesc close