chore: address follow-up review comments

commit: 3a6271253c8506772b46f35e751725ee720c9f45
author: brice · 5mo ago · 2026-04-28 04:43 UTC
parent: 1c13f3e
signature: GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email

2 files · +5 -4

M README.md +3 -2


@@ -85,14 +85,15 @@ To use it on Arch:
85	85		sudo pacman -S cef
86	86		```
87	87
88		-	Dumber discovers CEF in the following order: `CEF_DIR` environment variable, `/usr/lib/cef`, or `~/.local/share/cef`. Override via:
	88	+	CEF runtime precedence is deterministic: `CEF_DIR` wins first, then `engine.cef.cef_dir`, then `/usr/lib/cef`, then `~/.local/share/cef`.
	89	+	Set `engine.cef.cef_dir` in config when `CEF_DIR` is unset:
89	90
90	91		```toml
91	92		[engine.cef]
92	93		cef_dir = "/custom/path"
93	94		```
94	95
95		-	Or set the `CEF_DIR` environment variable:
	96	+	Or set the higher-precedence `CEF_DIR` environment variable:
96	97
97	98		```bash
98	99		CEF_DIR=/custom/path dumber browse

 sudo pacman -S cef
 ```
-Dumber discovers CEF in the following order: `CEF_DIR` environment variable, `/usr/lib/cef`, or `~/.local/share/cef`. Override via:
+CEF runtime precedence is deterministic: `CEF_DIR` wins first, then `engine.cef.cef_dir`, then `/usr/lib/cef`, then `~/.local/share/cef`.
+Set `engine.cef.cef_dir` in config when `CEF_DIR` is unset:
 ```toml
 [engine.cef]
 cef_dir = "/custom/path"
 ```
-Or set the `CEF_DIR` environment variable:
+Or set the higher-precedence `CEF_DIR` environment variable:
 ```bash
 CEF_DIR=/custom/path dumber browse

M internal/infrastructure/cef/scheme_handler_test.go +2 -2


@@ -173,7 +173,7 @@ func TestHandleMessageAPIRequiresTrustedOriginOrReferrer(t *testing.T) {
173	173		cefNewResourceHandler = func(impl purecef.ResourceHandler) purecef.ResourceHandler { return impl }
174	174		defer func() { cefNewResourceHandler = oldNewResourceHandler }()
175	175
176		-	h, err := newDumbSchemeHandler(context.Background(), NewMessageRouter(context.Background()), func() ([]byte, error) { return []byte(`{}`), nil }, func() ([]byte, error) { return []byte(`{}`), nil })
	176	+	h, err := newDumbSchemeHandler(context.Background(), NewMessageRouter(context.Background()), noopConfigPayload(), noopConfigPayload())
177	177		require.NoError(t, err)
178	178
179	179		trusted := cefmocks.NewMockRequest(t)

@@ -205,7 +205,7 @@ func TestHandleConfigAPIUsesPrivateNoCORSHeaders(t *testing.T) {
205	205		cefNewResourceHandler = func(impl purecef.ResourceHandler) purecef.ResourceHandler { return impl }
206	206		defer func() { cefNewResourceHandler = oldNewResourceHandler }()
207	207
208		-	h, err := newDumbSchemeHandler(context.Background(), nil, func() ([]byte, error) { return []byte(`{"ok":true}`), nil }, func() ([]byte, error) { return []byte(`{}`), nil })
	208	+	h, err := newDumbSchemeHandler(context.Background(), nil, func() ([]byte, error) { return []byte(`{"ok":true}`), nil }, noopConfigPayload())
209	209		require.NoError(t, err)
210	210
211	211		response := cefmocks.NewMockResponse(t)


@@ -173,7 +173,7 @@ func TestHandleMessageAPIRequiresTrustedOriginOrReferrer(t *testing.T) {
173		cefNewResourceHandler = func(impl purecef.ResourceHandler) purecef.ResourceHandler { return impl }	173		cefNewResourceHandler = func(impl purecef.ResourceHandler) purecef.ResourceHandler { return impl }
174		defer func() { cefNewResourceHandler = oldNewResourceHandler }()	174		defer func() { cefNewResourceHandler = oldNewResourceHandler }()
175			175
176	-	h, err := newDumbSchemeHandler(context.Background(), NewMessageRouter(context.Background()), func() ([]byte, error) { return []byte(`{}`), nil }, func() ([]byte, error) { return []byte(`{}`), nil })	176	+	h, err := newDumbSchemeHandler(context.Background(), NewMessageRouter(context.Background()), noopConfigPayload(), noopConfigPayload())
177		require.NoError(t, err)	177		require.NoError(t, err)
178			178
179		trusted := cefmocks.NewMockRequest(t)	179		trusted := cefmocks.NewMockRequest(t)

@@ -205,7 +205,7 @@ func TestHandleConfigAPIUsesPrivateNoCORSHeaders(t *testing.T) {
205		cefNewResourceHandler = func(impl purecef.ResourceHandler) purecef.ResourceHandler { return impl }	205		cefNewResourceHandler = func(impl purecef.ResourceHandler) purecef.ResourceHandler { return impl }
206		defer func() { cefNewResourceHandler = oldNewResourceHandler }()	206		defer func() { cefNewResourceHandler = oldNewResourceHandler }()
207			207
208	-	h, err := newDumbSchemeHandler(context.Background(), nil, func() ([]byte, error) { return []byte(`{"ok":true}`), nil }, func() ([]byte, error) { return []byte(`{}`), nil })	208	+	h, err := newDumbSchemeHandler(context.Background(), nil, func() ([]byte, error) { return []byte(`{"ok":true}`), nil }, noopConfigPayload())
209		require.NoError(t, err)	209		require.NoError(t, err)
210			210
211		response := cefmocks.NewMockResponse(t)	211		response := cefmocks.NewMockResponse(t)