detached 3c5cbdb

fix(webkit): stop async prewarm on ctx cancel

Avoid continuing GTK idle prewarm when the caller context is canceled; exit early and release the waitgroup.
commit
3c5cbdbce9c3f1dd3efb07f9de01d98fb6ac8187
author
brice · · 2025-12-27 08:40 UTC
parent
aaa4919
signature
unsigned
1 file · +13 -1
M internal/infrastructure/webkit/pool.go +13 -1
@@ -232,8 +232,20 @@ func (p *WebViewPool) PrewarmAsync(ctx context.Context, count int) {
232232
233233 var schedule func()
234234 schedule = func() {
235+ // Stop early if the caller canceled the operation.
236+ if err := ctx.Err(); err != nil {
237+ log.Debug().Err(err).Msg("async webview pool prewarm canceled")
238+ doneOnce.Do(p.wg.Done)
239+ return
240+ }
241+
235242 cb := glib.SourceFunc(func(_ uintptr) bool {
236- log := logging.FromContext(ctx)
243+ // Stop if the caller canceled the operation.
244+ if err := ctx.Err(); err != nil {
245+ log.Debug().Err(err).Msg("async webview pool prewarm canceled")
246+ doneOnce.Do(p.wg.Done)
247+ return false
248+ }
237249
238250 // Stop if pool is closing/closed.
239251 if p.closed.Load() {
@@ -232,8 +232,20 @@ func (p *WebViewPool) PrewarmAsync(ctx context.Context, count int) {
232 232
233 var schedule func()233 var schedule func()
234 schedule = func() {234 schedule = func() {
235+ // Stop early if the caller canceled the operation.
236+ if err := ctx.Err(); err != nil {
237+ log.Debug().Err(err).Msg("async webview pool prewarm canceled")
238+ doneOnce.Do(p.wg.Done)
239+ return
240+ }
241+
235 cb := glib.SourceFunc(func(_ uintptr) bool {242 cb := glib.SourceFunc(func(_ uintptr) bool {
236- log := logging.FromContext(ctx)243+ // Stop if the caller canceled the operation.
244+ if err := ctx.Err(); err != nil {
245+ log.Debug().Err(err).Msg("async webview pool prewarm canceled")
246+ doneOnce.Do(p.wg.Done)
247+ return false
248+ }
237 249
238 // Stop if pool is closing/closed.250 // Stop if pool is closing/closed.
239 if p.closed.Load() {251 if p.closed.Load() {

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 8

Tags 42

↑↓ moveenter openesc close