detached 483aebe

fix: log FetchIdentifiers error in Clear method

commit
483aebea1fef24cf6f001d3385fa1187a54e305d
author
brice · · 2026-03-27 06:15 UTC
parent
0d5633a
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
1 file · +4 -1
M internal/infrastructure/filtering/manager.go +4 -1
@@ -568,7 +568,10 @@ func (m *Manager) Clear(ctx context.Context) error {
568568 m.filterMu.Unlock()
569569
570570 // Remove all compiled filter parts
571- identifiers, _ := m.store.FetchIdentifiers(ctx)
571+ identifiers, err := m.store.FetchIdentifiers(ctx)
572+ if err != nil {
573+ log.Warn().Err(err).Msg("failed to fetch identifiers for cleanup")
574+ }
572575 for _, id := range identifiers {
573576 if strings.HasPrefix(id, FilterIdentifierPrefix) {
574577 if err := m.store.Remove(ctx, id); err != nil {
@@ -568,7 +568,10 @@ func (m *Manager) Clear(ctx context.Context) error {
568 m.filterMu.Unlock()568 m.filterMu.Unlock()
569 569
570 // Remove all compiled filter parts570 // Remove all compiled filter parts
571- identifiers, _ := m.store.FetchIdentifiers(ctx)571+ identifiers, err := m.store.FetchIdentifiers(ctx)
572+ if err != nil {
573+ log.Warn().Err(err).Msg("failed to fetch identifiers for cleanup")
574+ }
572 for _, id := range identifiers {575 for _, id := range identifiers {
573 if strings.HasPrefix(id, FilterIdentifierPrefix) {576 if strings.HasPrefix(id, FilterIdentifierPrefix) {
574 if err := m.store.Remove(ctx, id); err != nil {577 if err := m.store.Remove(ctx, id); err != nil {

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 8

Tags 42

↑↓ moveenter openesc close