detached 495353a

fix: dispatch oauth callback close to GTK main thread

Same thread-safety issue as the safety timeout - the go func()
with time.Sleep runs wv.Close() on a goroutine, triggering GTK
widget operations off the main thread.

Replace go+Sleep with time.AfterFunc+glib.IdleAdd for the same
500ms delay but dispatched safely to the GTK main loop.
commit
495353a727a0af9947892681d1db9fd759ae0b09
author
brice · · 2026-02-16 14:26 UTC
parent
89f346b
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
1 file · +9 -6
M internal/ui/coordinator/content.go +9 -6
@@ -1837,12 +1837,15 @@ func (c *ContentCoordinator) setupOAuthAutoClose(
18371837 Str("reason", reason).
18381838 Msg("oauth callback detected, closing")
18391839 requestCloseOnce.Do(func() {
1840- go func() {
1841- time.Sleep(500 * time.Millisecond)
1842- if wv != nil && !wv.IsDestroyed() {
1843- wv.Close()
1844- }
1845- }()
1840+ time.AfterFunc(500*time.Millisecond, func() {
1841+ cb := glib.SourceFunc(func(_ uintptr) bool {
1842+ if wv != nil && !wv.IsDestroyed() {
1843+ wv.Close()
1844+ }
1845+ return false
1846+ })
1847+ glib.IdleAdd(&cb, 0)
1848+ })
18461849 })
18471850 }
18481851
@@ -1837,12 +1837,15 @@ func (c *ContentCoordinator) setupOAuthAutoClose(
1837 Str("reason", reason).1837 Str("reason", reason).
1838 Msg("oauth callback detected, closing")1838 Msg("oauth callback detected, closing")
1839 requestCloseOnce.Do(func() {1839 requestCloseOnce.Do(func() {
1840- go func() {1840+ time.AfterFunc(500*time.Millisecond, func() {
1841- time.Sleep(500 * time.Millisecond)1841+ cb := glib.SourceFunc(func(_ uintptr) bool {
1842- if wv != nil && !wv.IsDestroyed() {1842+ if wv != nil && !wv.IsDestroyed() {
1843- wv.Close()1843+ wv.Close()
1844- }1844+ }
1845- }()1845+ return false
1846+ })
1847+ glib.IdleAdd(&cb, 0)
1848+ })
1846 })1849 })
1847 }1850 }
1848 1851

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 8

Tags 42

↑↓ moveenter openesc close