refactor(ui): add create method for tab

commit: 67011016ea758e4c3ed6c92dfef96e0dc48b92c5
author: brice · 6mo ago · 2026-04-11 18:40 UTC
parent: 1475275
signature: GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email

2 files · +19 -6

M internal/ui/coordinator/tab.go +14 -6


@@ -78,6 +78,10 @@ func (c *TabCoordinator) notifyStateChanged() {
78	78
79	79		// Create creates a new tab with the given initial URL.
80	80		func (c TabCoordinator) Create(ctx context.Context, initialURL string) (entity.Tab, error) {
	81	+	return c.create(ctx, initialURL, true)
	82	+	}
	83	+
	84	+	func (c TabCoordinator) create(ctx context.Context, initialURL string, activate bool) (entity.Tab, error) {
81	85		log := logging.FromContext(ctx)
82	86
83	87		output, err := c.tabsUC.Create(ctx, usecase.CreateTabInput{

@@ -90,13 +94,17 @@ func (c TabCoordinator) Create(ctx context.Context, initialURL string) (entity
90	94		return nil, err
91	95		}
92	96
93		-	// Set new tab as active (updates domain state and tracks previous)
94		-	c.tabs.SetActive(output.Tab.ID)
	97	+	if activate {
	98	+	// Set new tab as active (updates domain state and tracks previous)
	99	+	c.tabs.SetActive(output.Tab.ID)
	100	+	}
95	101
96	102		// Update tab bar
97	103		if c.mainWindow != nil && c.mainWindow.TabBar() != nil {
98	104		c.mainWindow.TabBar().AddTab(output.Tab)
99		-	c.mainWindow.TabBar().SetActive(output.Tab.ID)
	105	+	if activate {
	106	+	c.mainWindow.TabBar().SetActive(output.Tab.ID)
	107	+	}
100	108		}
101	109
102	110		// Update tab bar visibility

@@ -107,8 +115,8 @@ func (c TabCoordinator) Create(ctx context.Context, initialURL string) (entity
107	115		c.onTabCreated(ctx, output.Tab)
108	116		}
109	117
110		-	// Switch to the new tab's workspace view
111		-	if c.onTabSwitched != nil {
	118	+	// Switch to the new tab's workspace view when activation is requested.
	119	+	if activate && c.onTabSwitched != nil {
112	120		c.onTabSwitched(ctx, output.Tab)
113	121		}
114	122

@@ -294,7 +302,7 @@ func (c *TabCoordinator) EnsureTabByIndex(ctx context.Context, index int, initia
294	302		}
295	303
296	304		for c.tabs.Count() <= index {
297		-	if _, err := c.Create(ctx, initialURL); err != nil {
	305	+	if _, err := c.create(ctx, initialURL, false); err != nil {
298	306		log.Error().Err(err).Int("index", index).Msg("failed to create tab while ensuring tab index")
299	307		return err
300	308		}

 // Create creates a new tab with the given initial URL.
 func (c *TabCoordinator) Create(ctx context.Context, initialURL string) (*entity.Tab, error) {
+	return c.create(ctx, initialURL, true)
+}
+func (c *TabCoordinator) create(ctx context.Context, initialURL string, activate bool) (*entity.Tab, error) {
 	log := logging.FromContext(ctx)
 	output, err := c.tabsUC.Create(ctx, usecase.CreateTabInput{
 		return nil, err
 	}
-	// Set new tab as active (updates domain state and tracks previous)
+	if activate {
-	c.tabs.SetActive(output.Tab.ID)
+		// Set new tab as active (updates domain state and tracks previous)
+		c.tabs.SetActive(output.Tab.ID)
+	}
 	// Update tab bar
 	if c.mainWindow != nil && c.mainWindow.TabBar() != nil {
 		c.mainWindow.TabBar().AddTab(output.Tab)
-		c.mainWindow.TabBar().SetActive(output.Tab.ID)
+		if activate {
+			c.mainWindow.TabBar().SetActive(output.Tab.ID)
+		}
 	}
 	// Update tab bar visibility
 		c.onTabCreated(ctx, output.Tab)
 	}
-	// Switch to the new tab's workspace view
+	// Switch to the new tab's workspace view when activation is requested.
-	if c.onTabSwitched != nil {
+	if activate && c.onTabSwitched != nil {
 		c.onTabSwitched(ctx, output.Tab)
 	}
 	}
 	for c.tabs.Count() <= index {
-		if _, err := c.Create(ctx, initialURL); err != nil {
+		if _, err := c.create(ctx, initialURL, false); err != nil {
 			log.Error().Err(err).Int("index", index).Msg("failed to create tab while ensuring tab index")
 			return err
 		}

M internal/ui/dispatcher/keyboard_test.go +5 -0


@@ -43,9 +43,14 @@ func TestKeyboardDispatcher_AltNumberCreatesTabsUntilRequestedIndexExists(t *tes
43	43		require.Len(t, tabs.Tabs, 3)
44	44		require.NotNil(t, tabs.ActiveTab())
45	45		assert.Equal(t, tabs.TabAt(2).ID, tabs.ActiveTabID)
	46	+	assert.Equal(t, tabs.TabAt(0).ID, tabs.PreviousActiveTabID)
46	47		assert.Equal(t, 2, tabs.ActiveTab().Position)
47	48		assert.Equal(t, domainurl.Normalize("https://new.example"), tabs.TabAt(1).Workspace.Root.Pane.URI)
48	49		assert.Equal(t, domainurl.Normalize("https://new.example"), tabs.TabAt(2).Workspace.Root.Pane.URI)
	50	+
	51	+	err = tabCoord.SwitchToLastActive(ctx)
	52	+	require.NoError(t, err)
	53	+	assert.Equal(t, tabs.TabAt(0).ID, tabs.ActiveTabID)
49	54		}
50	55
51	56		func TestKeyboardDispatcher_AltNumberSwitchesToExistingTabWithoutNewPaneURL(t *testing.T) {


@@ -43,9 +43,14 @@ func TestKeyboardDispatcher_AltNumberCreatesTabsUntilRequestedIndexExists(t *tes
43	require.Len(t, tabs.Tabs, 3)	43		require.Len(t, tabs.Tabs, 3)
44	require.NotNil(t, tabs.ActiveTab())	44		require.NotNil(t, tabs.ActiveTab())
45	assert.Equal(t, tabs.TabAt(2).ID, tabs.ActiveTabID)	45		assert.Equal(t, tabs.TabAt(2).ID, tabs.ActiveTabID)
		46	+	assert.Equal(t, tabs.TabAt(0).ID, tabs.PreviousActiveTabID)
46	assert.Equal(t, 2, tabs.ActiveTab().Position)	47		assert.Equal(t, 2, tabs.ActiveTab().Position)
47	assert.Equal(t, domainurl.Normalize("https://new.example"), tabs.TabAt(1).Workspace.Root.Pane.URI)	48		assert.Equal(t, domainurl.Normalize("https://new.example"), tabs.TabAt(1).Workspace.Root.Pane.URI)
48	assert.Equal(t, domainurl.Normalize("https://new.example"), tabs.TabAt(2).Workspace.Root.Pane.URI)	49		assert.Equal(t, domainurl.Normalize("https://new.example"), tabs.TabAt(2).Workspace.Root.Pane.URI)
		50	+
		51	+	err = tabCoord.SwitchToLastActive(ctx)
		52	+	require.NoError(t, err)
		53	+	assert.Equal(t, tabs.TabAt(0).ID, tabs.ActiveTabID)
49	}	54		}
50		55
51	func TestKeyboardDispatcher_AltNumberSwitchesToExistingTabWithoutNewPaneURL(t *testing.T) {	56		func TestKeyboardDispatcher_AltNumberSwitchesToExistingTabWithoutNewPaneURL(t *testing.T) {