fix(omnibox): skip engine init in standalone mode

commit: 70e775c2e521f8f1b00cacf28382981ed0273e9e
author: brice · 6mo ago · 2026-04-16 03:15 UTC
parent: 2f5a6d2
signature: GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email

1 file · +20 -6

M cmd/dumber/main.go +20 -6


@@ -237,9 +237,15 @@ func runStandaloneOmnibox() int {
237	237
238	238		preInitializeAdwaitaForCEF(cfg, initResult, ui.EnsureAdwaitaInitialized)
239	239
240		-	engine, repos, dbCleanup, err := initStackAndRepos(ctx, cfg, initResult, false)
	240	+	// Standalone omnibox intentionally skips browser-engine initialization.
	241	+	// When the main browser is already running under CEF, spinning up another CEF
	242	+	// engine for the omnibox process triggers Chromium's already-running-app
	243	+	// relaunch path and can turn the `omnibox` subcommand into a bogus browser
	244	+	// URL (`omnibox/`). The standalone omnibox only needs repos/use cases/theme;
	245	+	// actual browser navigation is handed off via LaunchBrowserURL.
	246	+	repos, dbCleanup, err := initStandaloneOmniboxRepos()
241	247		if err != nil {
242		-	logging.FromContext(ctx).Error().Err(err).Msg("failed to initialize standalone omnibox runtime")
	248	+	logging.FromContext(ctx).Error().Err(err).Msg("failed to initialize standalone omnibox repositories")
243	249		return 1
244	250		}
245	251		if dbCleanup != nil {

@@ -253,7 +259,7 @@ func runStandaloneOmnibox() int {
253	259		initResult.ThemeManager,
254	260		initResult.ColorResolver,
255	261		initResult.AdwaitaDetector,
256		-	engine,
	262	+	nil,
257	263		repos,
258	264		useCases,
259	265		nil,

@@ -264,7 +270,7 @@ func runStandaloneOmnibox() int {
264	270		logging.FromContext(ctx).Error().Err(err).Msg("failed to initialize standalone omnibox UI dependencies")
265	271		return 1
266	272		}
267		-	runtimeCfg := ui.NewStandaloneOmniboxRuntime(ctx, uiDeps, engine.FaviconDatabase())
	273	+	runtimeCfg := ui.NewStandaloneOmniboxRuntime(ctx, uiDeps, nil)
268	274
269	275		return ui.RunStandaloneOmnibox(ctx, runtimeCfg)
270	276		}

@@ -444,12 +450,20 @@ func initStackAndRepos(
444	450		return nil, nil, nil, err
445	451		}
446	452
447		-	lazyDB, err := bootstrap.CreateLazyDatabase()
	453	+	repos, dbCleanup, err := initStandaloneOmniboxRepos()
448	454		if err != nil {
449	455		return nil, nil, nil, err
450	456		}
	457	+	return engine, repos, dbCleanup, nil
	458	+	}
	459	+
	460	+	func initStandaloneOmniboxRepos() (*repositories, func(), error) {
	461	+	lazyDB, err := bootstrap.CreateLazyDatabase()
	462	+	if err != nil {
	463	+	return nil, nil, err
	464	+	}
451	465		dbCleanup := func() { _ = lazyDB.Close() }
452		-	return engine, createLazyRepositories(lazyDB), dbCleanup, nil
	466	+	return createLazyRepositories(lazyDB), dbCleanup, nil
453	467		}
454	468
455	469		func configureDeferredInit(

 	preInitializeAdwaitaForCEF(cfg, initResult, ui.EnsureAdwaitaInitialized)
-	engine, repos, dbCleanup, err := initStackAndRepos(ctx, cfg, initResult, false)
+	// Standalone omnibox intentionally skips browser-engine initialization.
+	// When the main browser is already running under CEF, spinning up another CEF
+	// engine for the omnibox process triggers Chromium's already-running-app
+	// relaunch path and can turn the `omnibox` subcommand into a bogus browser
+	// URL (`omnibox/`). The standalone omnibox only needs repos/use cases/theme;
+	// actual browser navigation is handed off via LaunchBrowserURL.
+	repos, dbCleanup, err := initStandaloneOmniboxRepos()
 	if err != nil {
-		logging.FromContext(ctx).Error().Err(err).Msg("failed to initialize standalone omnibox runtime")
+		logging.FromContext(ctx).Error().Err(err).Msg("failed to initialize standalone omnibox repositories")
 		return 1
 	}
 	if dbCleanup != nil {
 		initResult.ThemeManager,
 		initResult.ColorResolver,
 		initResult.AdwaitaDetector,
-		engine,
+		nil,
 		repos,
 		useCases,
 		nil,
 		logging.FromContext(ctx).Error().Err(err).Msg("failed to initialize standalone omnibox UI dependencies")
 		return 1
 	}
-	runtimeCfg := ui.NewStandaloneOmniboxRuntime(ctx, uiDeps, engine.FaviconDatabase())
+	runtimeCfg := ui.NewStandaloneOmniboxRuntime(ctx, uiDeps, nil)
 	return ui.RunStandaloneOmnibox(ctx, runtimeCfg)
 }
 		return nil, nil, nil, err
 	}
-	lazyDB, err := bootstrap.CreateLazyDatabase()
+	repos, dbCleanup, err := initStandaloneOmniboxRepos()
 	if err != nil {
 		return nil, nil, nil, err
 	}
+	return engine, repos, dbCleanup, nil
+}
+func initStandaloneOmniboxRepos() (*repositories, func(), error) {
+	lazyDB, err := bootstrap.CreateLazyDatabase()
+	if err != nil {
+		return nil, nil, err
+	}
 	dbCleanup := func() { _ = lazyDB.Close() }
-	return engine, createLazyRepositories(lazyDB), dbCleanup, nil
+	return createLazyRepositories(lazyDB), dbCleanup, nil
 }
 func configureDeferredInit(