style(cef): satisfy safety marker lint
- commit
- 7351f415ae7d16fad3f6fdcb64da1b6e3407ae14
- author
- brice · · 2026-07-14 06:27 UTC
- committer
- brice · · 2026-07-14 07:06 UTC
- parent
- 2624fd3
- signature
- GPG Verified
CD88F9E564E0102646FB6077A1A07C7C7C3E349D· arch-gpg Verified for the committer email
1 file · +8 -4
M internal/infrastructure/cef/restart_safety.go +8 -4
| @@ -6,7 +6,11 @@ import ( | |||
| 6 | 6 | "path/filepath" | |
| 7 | 7 | ) | |
| 8 | 8 | ||
| 9 | - | const nextStartSafetyMarkerFile = "cef-next-start-safe" | |
| 9 | + | const ( | |
| 10 | + | nextStartSafetyMarkerFile = "cef-next-start-safe" | |
| 11 | + | safetyMarkerDirPerm = 0o700 | |
| 12 | + | safetyMarkerFilePerm = 0o600 | |
| 13 | + | ) | |
| 10 | 14 | ||
| 11 | 15 | // writeNextStartSafetyMarker records a one-shot recovery request for the next | |
| 12 | 16 | // CEF start. The marker lives beside CEF's root cache so it follows explicit | |
| @@ -15,7 +19,7 @@ func writeNextStartSafetyMarker(stateRoot string) error { | |||
| 15 | 19 | if stateRoot == "" { | |
| 16 | 20 | return errors.New("CEF state root is empty") | |
| 17 | 21 | } | |
| 18 | - | if err := os.MkdirAll(stateRoot, 0o700); err != nil { | |
| 22 | + | if err := os.MkdirAll(stateRoot, safetyMarkerDirPerm); err != nil { | |
| 19 | 23 | return err | |
| 20 | 24 | } | |
| 21 | 25 | ||
| @@ -25,8 +29,8 @@ func writeNextStartSafetyMarker(stateRoot string) error { | |||
| 25 | 29 | return err | |
| 26 | 30 | } | |
| 27 | 31 | temporaryName := temporary.Name() | |
| 28 | - | defer os.Remove(temporaryName) | |
| 29 | - | if err := temporary.Chmod(0o600); err != nil { | |
| 32 | + | defer func() { _ = os.Remove(temporaryName) }() | |
| 33 | + | if err := temporary.Chmod(safetyMarkerFilePerm); err != nil { | |
| 30 | 34 | _ = temporary.Close() | |
| 31 | 35 | return err | |
| 32 | 36 | } | |
| @@ -6,7 +6,11 @@ import ( | |||||
| 6 | "path/filepath" | 6 | "path/filepath" | ||
| 7 | ) | 7 | ) | ||
| 8 | 8 | ||||
| 9 | - | const nextStartSafetyMarkerFile = "cef-next-start-safe" | 9 | + | const ( |
| 10 | + | nextStartSafetyMarkerFile = "cef-next-start-safe" | |||
| 11 | + | safetyMarkerDirPerm = 0o700 | |||
| 12 | + | safetyMarkerFilePerm = 0o600 | |||
| 13 | + | ) | |||
| 10 | 14 | ||||
| 11 | // writeNextStartSafetyMarker records a one-shot recovery request for the next | 15 | // writeNextStartSafetyMarker records a one-shot recovery request for the next | ||
| 12 | // CEF start. The marker lives beside CEF's root cache so it follows explicit | 16 | // CEF start. The marker lives beside CEF's root cache so it follows explicit | ||
| @@ -15,7 +19,7 @@ func writeNextStartSafetyMarker(stateRoot string) error { | |||||
| 15 | if stateRoot == "" { | 19 | if stateRoot == "" { | ||
| 16 | return errors.New("CEF state root is empty") | 20 | return errors.New("CEF state root is empty") | ||
| 17 | } | 21 | } | ||
| 18 | - | if err := os.MkdirAll(stateRoot, 0o700); err != nil { | 22 | + | if err := os.MkdirAll(stateRoot, safetyMarkerDirPerm); err != nil { |
| 19 | return err | 23 | return err | ||
| 20 | } | 24 | } | ||
| 21 | 25 | ||||
| @@ -25,8 +29,8 @@ func writeNextStartSafetyMarker(stateRoot string) error { | |||||
| 25 | return err | 29 | return err | ||
| 26 | } | 30 | } | ||
| 27 | temporaryName := temporary.Name() | 31 | temporaryName := temporary.Name() | ||
| 28 | - | defer os.Remove(temporaryName) | 32 | + | defer func() { _ = os.Remove(temporaryName) }() |
| 29 | - | if err := temporary.Chmod(0o600); err != nil { | 33 | + | if err := temporary.Chmod(safetyMarkerFilePerm); err != nil { |
| 30 | _ = temporary.Close() | 34 | _ = temporary.Close() | ||
| 31 | return err | 35 | return err | ||
| 32 | } | 36 | } | ||