fix(id-gen): use monotonic counter to prevent pane ID collisions

Replace cycling ID scheme (a0, b0...z0, a1...) with monotonically increasing
counter (p1, p2, p3...). The cycling scheme would wrap around and create
duplicate IDs causing WebView corruption. Monotonic IDs guarantee uniqueness.

commit: 786d68a9adda0fa1495c47871939c9b1f296f6e6
author: brice · 10mo ago · 2025-12-17 21:50 UTC
committer: brice · 10mo ago · 2025-12-17 19:30 UTC
parent: 42ae348
signature: unsigned

1 file · +3 -1

M internal/ui/app.go +3 -1


@@ -3,6 +3,7 @@ package ui
3	3		import (
4	4		"context"
5	5		"errors"
	6	+	"fmt"
6	7		"os"
7	8		"sync"
8	9

@@ -392,11 +393,12 @@ func (a *App) initCoordinators(ctx context.Context) {
392	393		}
393	394
394	395		// generateID generates a unique ID for tabs and panes.
	396	+	// Uses monotonically increasing counter to avoid ID collisions.
395	397		func (a *App) generateID() string {
396	398		a.idMu.Lock()
397	399		defer a.idMu.Unlock()
398	400		a.idCounter++
399		-	return string(rune('a'+a.idCounter%26)) + string(rune('0'+a.idCounter/26))
	401	+	return fmt.Sprintf("p%d", a.idCounter)
400	402		}
401	403
402	404		// Tabs returns the tab list.

 import (
 	"context"
 	"errors"
+	"fmt"
 	"os"
 	"sync"
 }
 // generateID generates a unique ID for tabs and panes.
+// Uses monotonically increasing counter to avoid ID collisions.
 func (a *App) generateID() string {
 	a.idMu.Lock()
 	defer a.idMu.Unlock()
 	a.idCounter++
-	return string(rune('a'+a.idCounter%26)) + string(rune('0'+a.idCounter/26))
+	return fmt.Sprintf("p%d", a.idCounter)
 }
 // Tabs returns the tab list.