detached 81fd4c5

fix(workspace): properly quit GTK main loop when closing last webview

Replace window.Close() with webkit.QuitMainLoop() in cleanupAndExit
to ensure graceful application shutdown when the last pane is closed
via pane mode (Ctrl+P x). This ensures the GTK main loop terminates
properly instead of leaving the application running without windows.
commit
81fd4c55a2b9f0b15f57eea2d99bed082ab1be18
author
bamen · · 2025-10-14 18:20 UTC
parent
e4cf6a4
signature
unsigned
1 file · +3 -5
M internal/app/browser/workspace_pane_ops.go +3 -5
@@ -908,11 +908,9 @@ func (wm *WorkspaceManager) cleanupAndExit(node *paneNode) (*paneNode, error) {
908908 log.Printf("[workspace] closing final pane; exiting browser")
909909 wm.cleanupPane(node, wm.nextCleanupGeneration())
910910 wm.detachHover(node)
911- // TODO: Implement proper application quit mechanism
912- // For now, the window close will trigger GTK application quit
913- if wm.window != nil && wm.window.AsWindow() != nil {
914- wm.window.AsWindow().Close()
915- }
911+
912+ // Gracefully quit the GTK main loop
913+ webkit.QuitMainLoop()
916914 return nil, nil
917915 }
918916
@@ -908,11 +908,9 @@ func (wm *WorkspaceManager) cleanupAndExit(node *paneNode) (*paneNode, error) {
908 log.Printf("[workspace] closing final pane; exiting browser")908 log.Printf("[workspace] closing final pane; exiting browser")
909 wm.cleanupPane(node, wm.nextCleanupGeneration())909 wm.cleanupPane(node, wm.nextCleanupGeneration())
910 wm.detachHover(node)910 wm.detachHover(node)
911- // TODO: Implement proper application quit mechanism911+
912- // For now, the window close will trigger GTK application quit912+ // Gracefully quit the GTK main loop
913- if wm.window != nil && wm.window.AsWindow() != nil {913+ webkit.QuitMainLoop()
914- wm.window.AsWindow().Close()
915- }
916 return nil, nil914 return nil, nil
917 }915 }
918 916

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 8

Tags 42

↑↓ moveenter openesc close