fix(config): simplify runtime provider snapshots

commit: 82561bc5411dbacdb19de0281fea6f558104a396
author: brice · 4mo ago · 2026-06-23 14:33 UTC
committer: brice · 4mo ago · 2026-06-23 20:01 UTC
parent: 035c4f0
signature: GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email

2 files · +14 -6

M internal/bootstrap/runtime_config.go +3 -6


@@ -31,7 +31,7 @@ func (p *runtimeConfigProvider) Current() port.RuntimeConfigSnapshot {
31	31		if p.manager == nil {
32	32		return cloneRuntimeConfigSnapshot(p.fallback)
33	33		}
34		-	return cloneRuntimeConfigSnapshot(RuntimeConfigSnapshotFromConfig(p.manager.Get()))
	34	+	return RuntimeConfigSnapshotFromConfig(p.manager.Get())
35	35		}
36	36
37	37		func (p *runtimeConfigProvider) Watch() error {

@@ -42,14 +42,11 @@ func (p *runtimeConfigProvider) Watch() error {
42	42		}
43	43
44	44		func (p *runtimeConfigProvider) OnChange(callback func(port.RuntimeConfigSnapshot)) {
45		-	if p == nil \|\| p.manager == nil {
	45	+	if p == nil \|\| p.manager == nil \|\| callback == nil {
46	46		return
47	47		}
48	48		p.manager.OnConfigChange(func(cfg *config.Config) {
49		-	snapshot := RuntimeConfigSnapshotFromConfig(cfg)
50		-	if callback != nil {
51		-	callback(cloneRuntimeConfigSnapshot(snapshot))
52		-	}
	49	+	callback(RuntimeConfigSnapshotFromConfig(cfg))
53	50		})
54	51		}
55	52

 	if p.manager == nil {
 		return cloneRuntimeConfigSnapshot(p.fallback)
 	}
-	return cloneRuntimeConfigSnapshot(RuntimeConfigSnapshotFromConfig(p.manager.Get()))
+	return RuntimeConfigSnapshotFromConfig(p.manager.Get())
 }
 func (p *runtimeConfigProvider) Watch() error {
 }
 func (p *runtimeConfigProvider) OnChange(callback func(port.RuntimeConfigSnapshot)) {
-	if p == nil || p.manager == nil {
+	if p == nil || p.manager == nil || callback == nil {
 		return
 	}
 	p.manager.OnConfigChange(func(cfg *config.Config) {
-		snapshot := RuntimeConfigSnapshotFromConfig(cfg)
+		callback(RuntimeConfigSnapshotFromConfig(cfg))
-		if callback != nil {
-			callback(cloneRuntimeConfigSnapshot(snapshot))
-		}
 	})
 }

M internal/bootstrap/runtime_config_test.go +11 -0


@@ -131,6 +131,17 @@ func TestRuntimeConfigProviderOnChangeCallbackCanCallCurrent(t *testing.T) {
131	131		}
132	132		}
133	133
	134	+	func TestRuntimeConfigProviderOnChangeNilCallbackDoesNotRegister(t *testing.T) {
	135	+	manager := &fakeConfigManager{current: config.DefaultConfig()}
	136	+	provider := NewRuntimeConfigProvider(config.DefaultConfig(), manager)
	137	+
	138	+	provider.OnChange(nil)
	139	+
	140	+	if len(manager.callbacks) != 0 {
	141	+	t.Fatalf("callbacks=%d, want 0", len(manager.callbacks))
	142	+	}
	143	+	}
	144	+
134	145		func TestRuntimeConfigProviderWatchDelegatesToManager(t *testing.T) {
135	146		manager := &fakeConfigManager{}
136	147		provider := NewRuntimeConfigProvider(config.DefaultConfig(), manager)


@@ -131,6 +131,17 @@ func TestRuntimeConfigProviderOnChangeCallbackCanCallCurrent(t *testing.T) {
131	}	131		}
132	}	132		}
133		133
		134	+	func TestRuntimeConfigProviderOnChangeNilCallbackDoesNotRegister(t *testing.T) {
		135	+	manager := &fakeConfigManager{current: config.DefaultConfig()}
		136	+	provider := NewRuntimeConfigProvider(config.DefaultConfig(), manager)
		137	+
		138	+	provider.OnChange(nil)
		139	+
		140	+	if len(manager.callbacks) != 0 {
		141	+	t.Fatalf("callbacks=%d, want 0", len(manager.callbacks))
		142	+	}
		143	+	}
		144	+
134	func TestRuntimeConfigProviderWatchDelegatesToManager(t *testing.T) {	145		func TestRuntimeConfigProviderWatchDelegatesToManager(t *testing.T) {
135	manager := &fakeConfigManager{}	146		manager := &fakeConfigManager{}
136	provider := NewRuntimeConfigProvider(config.DefaultConfig(), manager)	147		provider := NewRuntimeConfigProvider(config.DefaultConfig(), manager)