detached 83a2b1b

fix: make navigate usecase close idempotent

commit
83a2b1bb325259d19ce2c82d1c42d1feef0882c2
author
brice · · 2026-02-07 08:26 UTC
parent
c948582
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
1 file · +4 -1
M internal/application/usecase/navigate.go +4 -1
@@ -56,6 +56,7 @@ type NavigateUseCase struct {
5656 defaultZoom float64
5757 recentMu sync.Mutex
5858 recentVisits map[string]paneHistoryState // key: pane ID, value: per-pane history state
59+ closeOnce sync.Once
5960
6061 // Async history recording
6162 historyQueue chan historyRecord
@@ -95,7 +96,9 @@ func NewNavigateUseCase(
9596 // Close shuts down the background history worker and drains any pending records.
9697 // This should be called when the application is shutting down.
9798 func (uc *NavigateUseCase) Close() {
98- close(uc.done)
99+ uc.closeOnce.Do(func() {
100+ close(uc.done)
101+ })
99102 uc.wg.Wait()
100103 }
101104
@@ -56,6 +56,7 @@ type NavigateUseCase struct {
56 defaultZoom float6456 defaultZoom float64
57 recentMu sync.Mutex57 recentMu sync.Mutex
58 recentVisits map[string]paneHistoryState // key: pane ID, value: per-pane history state58 recentVisits map[string]paneHistoryState // key: pane ID, value: per-pane history state
59+ closeOnce sync.Once
59 60
60 // Async history recording61 // Async history recording
61 historyQueue chan historyRecord62 historyQueue chan historyRecord
@@ -95,7 +96,9 @@ func NewNavigateUseCase(
95 // Close shuts down the background history worker and drains any pending records.96 // Close shuts down the background history worker and drains any pending records.
96 // This should be called when the application is shutting down.97 // This should be called when the application is shutting down.
97 func (uc *NavigateUseCase) Close() {98 func (uc *NavigateUseCase) Close() {
98- close(uc.done)99+ uc.closeOnce.Do(func() {
100+ close(uc.done)
101+ })
99 uc.wg.Wait()102 uc.wg.Wait()
100 }103 }
101 104

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 8

Tags 42

↑↓ moveenter openesc close