skip to content

detached 8769cd0

docs(input): clarify global hold suppression

commit: 8769cd0375a2bea0f024b6246c84b1106f9f9bf2
author: brice · 5mo ago · 2026-05-24 13:33 UTC
parent: baf031a
signature: GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email

1 file · +2 -0

M internal/ui/input/global_shortcuts.go +2 -0


@@ -556,6 +556,8 @@ func (h *GlobalShortcutHandler) suppressHeldShortcut(action Action, info globalS
556	556		return false
557	557		}
558	558		if h.heldShortcuts == nil {
	559	+	// Defensive: if hold tracking is unavailable during detach/reload,
	560	+	// suppress rather than risk dispatching a stale global callback.
559	561		return true
560	562		}
561	563		key := globalShortcutHoldKey{keyval: normalizeKeyval(info.eventKeyval), keycode: info.eventKeycode}


@@ -556,6 +556,8 @@ func (h *GlobalShortcutHandler) suppressHeldShortcut(action Action, info globalS
556		return false	556		return false
557		}	557		}
558		if h.heldShortcuts == nil {	558		if h.heldShortcuts == nil {
			559	+	// Defensive: if hold tracking is unavailable during detach/reload,
			560	+	// suppress rather than risk dispatching a stale global callback.
559		return true	561		return true
560		}	562		}
561		key := globalShortcutHoldKey{keyval: normalizeKeyval(info.eventKeyval), keycode: info.eventKeycode}	563		key := globalShortcutHoldKey{keyval: normalizeKeyval(info.eventKeyval), keycode: info.eventKeycode}