detached 899908d

feat(domain): add validation for search shortcut keys, urls, and descriptions

commit
899908d296e1aa336c66666cfd65759af3555686
author
bnema · · 2025-12-21 13:53 UTC
parent
7831cd5
signature
unsigned
1 file · +55 -0
A internal/domain/validation/shortcuts.go +55 -0
@@ -0,0 +1,55 @@
1+package validation
2+
3+import (
4+ "net/url"
5+ "regexp"
6+ "strings"
7+)
8+
9+var shortcutKeyRE = regexp.MustCompile(`^[A-Za-z][A-Za-z0-9]{0,19}$`)
10+
11+func ValidateShortcutKey(value string) []string {
12+ var errs []string
13+ value = strings.TrimSpace(value)
14+ if value == "" {
15+ errs = append(errs, "shortcut key cannot be empty")
16+ return errs
17+ }
18+ if !shortcutKeyRE.MatchString(value) {
19+ errs = append(errs, "shortcut key must start with a letter and be 1-20 alphanumeric characters")
20+ }
21+ return errs
22+}
23+
24+func ValidateShortcutURL(value string) []string {
25+ var errs []string
26+ value = strings.TrimSpace(value)
27+ if value == "" {
28+ errs = append(errs, "shortcut url cannot be empty")
29+ return errs
30+ }
31+ if !strings.Contains(value, "%s") {
32+ errs = append(errs, "shortcut url must contain %s placeholder for the search query")
33+ return errs
34+ }
35+
36+ candidate := strings.ReplaceAll(value, "%s", "query")
37+ parsed, err := url.Parse(candidate)
38+ if err != nil || parsed.Scheme == "" || parsed.Host == "" {
39+ errs = append(errs, "shortcut url must be a valid absolute URL")
40+ }
41+
42+ return errs
43+}
44+
45+func ValidateShortcutDescription(value string) []string {
46+ var errs []string
47+ value = strings.TrimSpace(value)
48+ if strings.ContainsAny(value, "\r\n") {
49+ errs = append(errs, "shortcut description must not contain newlines")
50+ }
51+ if len(value) > 200 {
52+ errs = append(errs, "shortcut description is too long")
53+ }
54+ return errs
55+}
@@ -0,0 +1,55 @@
1+package validation
2+
3+import (
4+ "net/url"
5+ "regexp"
6+ "strings"
7+)
8+
9+var shortcutKeyRE = regexp.MustCompile(`^[A-Za-z][A-Za-z0-9]{0,19}$`)
10+
11+func ValidateShortcutKey(value string) []string {
12+ var errs []string
13+ value = strings.TrimSpace(value)
14+ if value == "" {
15+ errs = append(errs, "shortcut key cannot be empty")
16+ return errs
17+ }
18+ if !shortcutKeyRE.MatchString(value) {
19+ errs = append(errs, "shortcut key must start with a letter and be 1-20 alphanumeric characters")
20+ }
21+ return errs
22+}
23+
24+func ValidateShortcutURL(value string) []string {
25+ var errs []string
26+ value = strings.TrimSpace(value)
27+ if value == "" {
28+ errs = append(errs, "shortcut url cannot be empty")
29+ return errs
30+ }
31+ if !strings.Contains(value, "%s") {
32+ errs = append(errs, "shortcut url must contain %s placeholder for the search query")
33+ return errs
34+ }
35+
36+ candidate := strings.ReplaceAll(value, "%s", "query")
37+ parsed, err := url.Parse(candidate)
38+ if err != nil || parsed.Scheme == "" || parsed.Host == "" {
39+ errs = append(errs, "shortcut url must be a valid absolute URL")
40+ }
41+
42+ return errs
43+}
44+
45+func ValidateShortcutDescription(value string) []string {
46+ var errs []string
47+ value = strings.TrimSpace(value)
48+ if strings.ContainsAny(value, "\r\n") {
49+ errs = append(errs, "shortcut description must not contain newlines")
50+ }
51+ if len(value) > 200 {
52+ errs = append(errs, "shortcut description is too long")
53+ }
54+ return errs
55+}

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 8

Tags 42

↑↓ moveenter openesc close