detached 89f346b

fix: dispatch oauth safety timeout close to GTK main thread

time.AfterFunc runs on a Go goroutine. wv.Close() triggers
handlePopupClose which does GTK widget reparenting (unparent,
reparent, grab focus). GTK is not thread-safe - calling widget
operations from a non-main thread causes undefined behavior and
delayed segfaults.

Wrap in glib.IdleAdd to ensure the close runs on the GTK main loop.

Fixes: session 20260216_134851_baf8 crash
commit
89f346b98a50c66331b839dede7df66a64109889
author
brice · · 2026-02-16 14:26 UTC
parent
f71271c
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
1 file · +8 -4
M internal/ui/coordinator/content.go +8 -4
@@ -1807,10 +1807,14 @@ func (c *ContentCoordinator) setupOAuthAutoClose(
18071807 safetyTimer.Stop()
18081808 }
18091809 safetyTimer = time.AfterFunc(oauthSafetyTimeout, func() {
1810- if wv != nil && !wv.IsDestroyed() {
1811- log.Warn().Str("pane", string(paneID)).Msg("oauth safety timeout, closing stuck popup")
1812- wv.Close()
1813- }
1810+ cb := glib.SourceFunc(func(_ uintptr) bool {
1811+ if wv != nil && !wv.IsDestroyed() {
1812+ log.Warn().Str("pane", string(paneID)).Msg("oauth safety timeout, closing stuck popup")
1813+ wv.Close()
1814+ }
1815+ return false
1816+ })
1817+ glib.IdleAdd(&cb, 0)
18141818 })
18151819 }
18161820
@@ -1807,10 +1807,14 @@ func (c *ContentCoordinator) setupOAuthAutoClose(
1807 safetyTimer.Stop()1807 safetyTimer.Stop()
1808 }1808 }
1809 safetyTimer = time.AfterFunc(oauthSafetyTimeout, func() {1809 safetyTimer = time.AfterFunc(oauthSafetyTimeout, func() {
1810- if wv != nil && !wv.IsDestroyed() {1810+ cb := glib.SourceFunc(func(_ uintptr) bool {
1811- log.Warn().Str("pane", string(paneID)).Msg("oauth safety timeout, closing stuck popup")1811+ if wv != nil && !wv.IsDestroyed() {
1812- wv.Close()1812+ log.Warn().Str("pane", string(paneID)).Msg("oauth safety timeout, closing stuck popup")
1813- }1813+ wv.Close()
1814+ }
1815+ return false
1816+ })
1817+ glib.IdleAdd(&cb, 0)
1814 })1818 })
1815 }1819 }
1816 1820

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 8

Tags 42

↑↓ moveenter openesc close