detached 8b5f874

test(startup): satisfy collector lint

commit
8b5f874030814dca20ce0c9bf34c17f7c4f45c14
author
brice · · 2026-07-14 10:02 UTC
parent
1dd2cab
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
1 file · +3 -3
M internal/logging/first_presentation_collector_test.go +3 -3
@@ -134,9 +134,9 @@ func TestFirstPresentationCollectorSanitizesMachineLocalValues(t *testing.T) {
134134
135135 var artifacts strings.Builder
136136 for _, name := range append([]string{"metadata.json", "baseline.json"}, runArtifactNames()...) {
137- contents, err := os.ReadFile(filepath.Join(output, name))
138- require.NoError(t, err)
139- artifacts.Write(contents)
137+ artifactContents, readErr := os.ReadFile(filepath.Join(output, name))
138+ require.NoError(t, readErr)
139+ artifacts.Write(artifactContents)
140140 }
141141 for _, forbidden := range []string{"/home/", temp, "alice", "machine_path", `"time"`} {
142142 require.NotContainsf(t, artifacts.String(), forbidden, "committed artifact leaked %q", forbidden)
@@ -134,9 +134,9 @@ func TestFirstPresentationCollectorSanitizesMachineLocalValues(t *testing.T) {
134 134
135 var artifacts strings.Builder135 var artifacts strings.Builder
136 for _, name := range append([]string{"metadata.json", "baseline.json"}, runArtifactNames()...) {136 for _, name := range append([]string{"metadata.json", "baseline.json"}, runArtifactNames()...) {
137- contents, err := os.ReadFile(filepath.Join(output, name))137+ artifactContents, readErr := os.ReadFile(filepath.Join(output, name))
138- require.NoError(t, err)138+ require.NoError(t, readErr)
139- artifacts.Write(contents)139+ artifacts.Write(artifactContents)
140 }140 }
141 for _, forbidden := range []string{"/home/", temp, "alice", "machine_path", `"time"`} {141 for _, forbidden := range []string{"/home/", temp, "alice", "machine_path", `"time"`} {
142 require.NotContainsf(t, artifacts.String(), forbidden, "committed artifact leaked %q", forbidden)142 require.NotContainsf(t, artifacts.String(), forbidden, "committed artifact leaked %q", forbidden)

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 8

Tags 42

↑↓ moveenter openesc close