chore(dx): verify generated assets in check
- commit
- 9db7836c6e1e307df22f75e01353bd40286abbfd
- author
- brice · · 2026-06-24 12:20 UTC
- committer
- brice · · 2026-06-24 12:43 UTC
- parent
- eba3182
- signature
- GPG Verified
CD88F9E564E0102646FB6077A1A07C7C7C3E349D· arch-gpg Verified for the committer email
3 files · +5 -2
M CONTRIBUTING.md +1 -1
| @@ -36,7 +36,7 @@ git push origin my-fix | |||
| 36 | 36 | ||
| 37 | 37 | **Systemviews assets:** | |
| 38 | 38 | 1. If you modified systemviews files such as `cmd/systemviews/` or `.templ` components, run `make build-systemviews` to regenerate embedded WASM assets | |
| 39 | - | 2. Run `make check` to verify build, tests, and tools before committing | |
| 39 | + | 2. Run `make check` to verify tool versions, build, generated assets, tests, and constraints before committing | |
| 40 | 40 | ||
| 41 | 41 | Keep commits focused and use single-line commit messages. | |
| 42 | 42 | ||
| @@ -36,7 +36,7 @@ git push origin my-fix | |||||
| 36 | 36 | ||||
| 37 | **Systemviews assets:** | 37 | **Systemviews assets:** | ||
| 38 | 1. If you modified systemviews files such as `cmd/systemviews/` or `.templ` components, run `make build-systemviews` to regenerate embedded WASM assets | 38 | 1. If you modified systemviews files such as `cmd/systemviews/` or `.templ` components, run `make build-systemviews` to regenerate embedded WASM assets | ||
| 39 | - | 2. Run `make check` to verify build, tests, and tools before committing | 39 | + | 2. Run `make check` to verify tool versions, build, generated assets, tests, and constraints before committing |
| 40 | 40 | ||||
| 41 | Keep commits focused and use single-line commit messages. | 41 | Keep commits focused and use single-line commit messages. | ||
| 42 | 42 | ||||
M Makefile +3 -1
| @@ -189,7 +189,7 @@ init: install-tools ## Initialize project dependencies and tools | |||
| 189 | 189 | @echo "Project initialized! Run 'make help' for available commands." | |
| 190 | 190 | ||
| 191 | 191 | # Check setup | |
| 192 | - | check: ## Check that all tools and dependencies are working | |
| 192 | + | check: ## Run local all-clear checks (tools, build, generated assets, tests, constraints) | |
| 193 | 193 | @echo "Checking project setup..." | |
| 194 | 194 | @echo "Go version:" | |
| 195 | 195 | @go version | |
| @@ -199,6 +199,8 @@ check: ## Check that all tools and dependencies are working | |||
| 199 | 199 | @golangci-lint version | |
| 200 | 200 | @echo "\nBuilding project..." | |
| 201 | 201 | @$(MAKE) build-quick | |
| 202 | + | @echo "\nVerifying generated systemviews artifacts..." | |
| 203 | + | @$(MAKE) verify-generated | |
| 202 | 204 | @echo "\nRunning tests..." | |
| 203 | 205 | @$(MAKE) test | |
| 204 | 206 | @echo "\nVerifying purego-only constraints..." | |
| @@ -189,7 +189,7 @@ init: install-tools ## Initialize project dependencies and tools | |||||
| 189 | @echo "Project initialized! Run 'make help' for available commands." | 189 | @echo "Project initialized! Run 'make help' for available commands." | ||
| 190 | 190 | ||||
| 191 | # Check setup | 191 | # Check setup | ||
| 192 | - | check: ## Check that all tools and dependencies are working | 192 | + | check: ## Run local all-clear checks (tools, build, generated assets, tests, constraints) |
| 193 | @echo "Checking project setup..." | 193 | @echo "Checking project setup..." | ||
| 194 | @echo "Go version:" | 194 | @echo "Go version:" | ||
| 195 | @go version | 195 | @go version | ||
| @@ -199,6 +199,8 @@ check: ## Check that all tools and dependencies are working | |||||
| 199 | @golangci-lint version | 199 | @golangci-lint version | ||
| 200 | @echo "\nBuilding project..." | 200 | @echo "\nBuilding project..." | ||
| 201 | @$(MAKE) build-quick | 201 | @$(MAKE) build-quick | ||
| 202 | + | @echo "\nVerifying generated systemviews artifacts..." | |||
| 203 | + | @$(MAKE) verify-generated | |||
| 202 | @echo "\nRunning tests..." | 204 | @echo "\nRunning tests..." | ||
| 203 | @$(MAKE) test | 205 | @$(MAKE) test | ||
| 204 | @echo "\nVerifying purego-only constraints..." | 206 | @echo "\nVerifying purego-only constraints..." | ||
M README.md +1 -0
| @@ -227,6 +227,7 @@ make build | |||
| 227 | 227 | |--------|-------------| | |
| 228 | 228 | | `make build` | Build systemviews assets and binary | | |
| 229 | 229 | | `make build-quick` | Build binary only, skipping systemviews assets | | |
| 230 | + | | `make check` | Run local all-clear checks for tools, build, generated assets, tests, and constraints | | |
| 230 | 231 | | `make dev` | Run with `go run` | | |
| 231 | 232 | | `make test` | Run tests | | |
| 232 | 233 | | `make lint` | Run the pinned golangci-lint version | | |
| @@ -227,6 +227,7 @@ make build | |||||
| 227 | |--------|-------------| | 227 | |--------|-------------| | ||
| 228 | | `make build` | Build systemviews assets and binary | | 228 | | `make build` | Build systemviews assets and binary | | ||
| 229 | | `make build-quick` | Build binary only, skipping systemviews assets | | 229 | | `make build-quick` | Build binary only, skipping systemviews assets | | ||
| 230 | + | | `make check` | Run local all-clear checks for tools, build, generated assets, tests, and constraints | | |||
| 230 | | `make dev` | Run with `go run` | | 231 | | `make dev` | Run with `go run` | | ||
| 231 | | `make test` | Run tests | | 232 | | `make test` | Run tests | | ||
| 232 | | `make lint` | Run the pinned golangci-lint version | | 233 | | `make lint` | Run the pinned golangci-lint version | | ||