chore: fix lint failures
Address the current golangci-lint findings in omnibox and modal sizing tests.
- commit
- a25cbb9fd677cd8a5b749a75b185ed5f912046e2
- author
- brice · · 2026-04-07 17:43 UTC
- parent
- 861c372
- signature
- GPG Verified
CD88F9E564E0102646FB6077A1A07C7C7C3E349D· arch-gpg Verified for the committer email
2 files · +2 -2
M internal/ui/component/modal_sizing_test.go +1 -1
| @@ -120,7 +120,7 @@ func TestResolveModalSizeConfig_MergesDefaultsAndOverrides(t *testing.T) { | |||
| 120 | 120 | ||
| 121 | 121 | resolved := ResolveModalSizeConfig(override, defaults) | |
| 122 | 122 | ||
| 123 | - | assert.Equal(t, defaults.WidthPct, resolved.WidthPct) | |
| 123 | + | assert.InDelta(t, defaults.WidthPct, resolved.WidthPct, 0) | |
| 124 | 124 | assert.Equal(t, defaults.MaxWidth, resolved.MaxWidth) | |
| 125 | 125 | assert.Equal(t, defaults.FallbackWidth, resolved.FallbackWidth) | |
| 126 | 126 | assert.Equal(t, defaults.FallbackHeight, resolved.FallbackHeight) | |
| @@ -120,7 +120,7 @@ func TestResolveModalSizeConfig_MergesDefaultsAndOverrides(t *testing.T) { | |||||
| 120 | 120 | ||||
| 121 | resolved := ResolveModalSizeConfig(override, defaults) | 121 | resolved := ResolveModalSizeConfig(override, defaults) | ||
| 122 | 122 | ||||
| 123 | - | assert.Equal(t, defaults.WidthPct, resolved.WidthPct) | 123 | + | assert.InDelta(t, defaults.WidthPct, resolved.WidthPct, 0) |
| 124 | assert.Equal(t, defaults.MaxWidth, resolved.MaxWidth) | 124 | assert.Equal(t, defaults.MaxWidth, resolved.MaxWidth) | ||
| 125 | assert.Equal(t, defaults.FallbackWidth, resolved.FallbackWidth) | 125 | assert.Equal(t, defaults.FallbackWidth, resolved.FallbackWidth) | ||
| 126 | assert.Equal(t, defaults.FallbackHeight, resolved.FallbackHeight) | 126 | assert.Equal(t, defaults.FallbackHeight, resolved.FallbackHeight) | ||
M internal/ui/component/omnibox.go +1 -1
| @@ -323,7 +323,7 @@ func (o *Omnibox) estimateRowHeight() int { | |||
| 323 | 323 | return ScaleValue(DefaultRowHeights.Standard, o.uiScale) | |
| 324 | 324 | } | |
| 325 | 325 | ||
| 326 | - | func resultsContainerState(rowCount int) (visible bool, expand bool, listVisible bool) { | |
| 326 | + | func resultsContainerState(rowCount int) (visible, expand, listVisible bool) { | |
| 327 | 327 | return rowCount > 0, rowCount > 0, rowCount > 0 | |
| 328 | 328 | } | |
| 329 | 329 | ||
| @@ -323,7 +323,7 @@ func (o *Omnibox) estimateRowHeight() int { | |||||
| 323 | return ScaleValue(DefaultRowHeights.Standard, o.uiScale) | 323 | return ScaleValue(DefaultRowHeights.Standard, o.uiScale) | ||
| 324 | } | 324 | } | ||
| 325 | 325 | ||||
| 326 | - | func resultsContainerState(rowCount int) (visible bool, expand bool, listVisible bool) { | 326 | + | func resultsContainerState(rowCount int) (visible, expand, listVisible bool) { |
| 327 | return rowCount > 0, rowCount > 0, rowCount > 0 | 327 | return rowCount > 0, rowCount > 0, rowCount > 0 | ||
| 328 | } | 328 | } | ||
| 329 | 329 | ||||