a4e770b fix(systemviews): address PR review feedback · dumber

M CONTRIBUTING.md +1 -0


@@ -36,6 +36,7 @@ git push origin my-fix
36	36
37	37		Systemviews assets:
38	38		1. If you modified systemviews files such as `cmd/systemviews/` or `.templ` components, run `make build-systemviews` to regenerate embedded WASM assets
	39	+	2. Run `make check` to verify build, tests, and tools before committing
39	40
40	41		Keep commits focused and use single-line commit messages.
41	42


@@ -36,6 +36,7 @@ git push origin my-fix
36		36
37	Systemviews assets:	37		Systemviews assets:
38	1. If you modified systemviews files such as `cmd/systemviews/` or `.templ` components, run `make build-systemviews` to regenerate embedded WASM assets	38		1. If you modified systemviews files such as `cmd/systemviews/` or `.templ` components, run `make build-systemviews` to regenerate embedded WASM assets
		39	+	2. Run `make check` to verify build, tests, and tools before committing
39		40
40	Keep commits focused and use single-line commit messages.	41		Keep commits focused and use single-line commit messages.
41		42

M Makefile +2 -2


@@ -56,8 +56,8 @@ build-systemviews: generate-systemviews ## Build the WASM systemviews runtime
56	56		@command -v brotli >/dev/null 2>&1 \|\| { echo "Error: brotli is required to build compressed systemviews assets. Install brotli and retry."; exit 1; }
57	57		@mkdir -p assets/systemviews
58	58		@cp "$$(go env GOROOT)/lib/wasm/wasm_exec.js" assets/systemviews/wasm_exec.js
59		-	GOOS=js GOARCH=wasm go build -ldflags="-s -w" -o assets/systemviews/systemviews.wasm ./cmd/systemviews
60		-	brotli -f assets/systemviews/systemviews.wasm -o assets/systemviews/systemviews.wasm.br
	59	+	GOOS=js GOARCH=wasm go build -buildvcs=false -ldflags="-s -w" -o assets/systemviews/systemviews.wasm ./cmd/systemviews
	60	+	brotli -f -o assets/systemviews/systemviews.wasm.br assets/systemviews/systemviews.wasm
61	61		@echo "Systemviews build complete"
62	62
63	63		build-quick: ## Build quickly for backend development


@@ -56,8 +56,8 @@ build-systemviews: generate-systemviews ## Build the WASM systemviews runtime
56		@command -v brotli >/dev/null 2>&1 \|\| { echo "Error: brotli is required to build compressed systemviews assets. Install brotli and retry."; exit 1; }	56		@command -v brotli >/dev/null 2>&1 \|\| { echo "Error: brotli is required to build compressed systemviews assets. Install brotli and retry."; exit 1; }
57		@mkdir -p assets/systemviews	57		@mkdir -p assets/systemviews
58		@cp "$$(go env GOROOT)/lib/wasm/wasm_exec.js" assets/systemviews/wasm_exec.js	58		@cp "$$(go env GOROOT)/lib/wasm/wasm_exec.js" assets/systemviews/wasm_exec.js
59	-	GOOS=js GOARCH=wasm go build -ldflags="-s -w" -o assets/systemviews/systemviews.wasm ./cmd/systemviews	59	+	GOOS=js GOARCH=wasm go build -buildvcs=false -ldflags="-s -w" -o assets/systemviews/systemviews.wasm ./cmd/systemviews
60	-	brotli -f assets/systemviews/systemviews.wasm -o assets/systemviews/systemviews.wasm.br	60	+	brotli -f -o assets/systemviews/systemviews.wasm.br assets/systemviews/systemviews.wasm
61		@echo "Systemviews build complete"	61		@echo "Systemviews build complete"
62			62
63		build-quick: ## Build quickly for backend development	63		build-quick: ## Build quickly for backend development

M assets/webui_embed.go +1 -0


@@ -5,6 +5,7 @@ import (
5	5		)
6	6
7	7		// WebUIAssets contains the embedded systemviews build output.
	8	+	// The legacy WebUIAssets name is kept for compatibility with existing callers.
8	9		// Used by the scheme handlers to serve dumb://error, dumb://config,
9	10		// dumb://history, and dumb://favorites.
10	11		//


@@ -5,6 +5,7 @@ import (
5	)	5		)
6		6
7	// WebUIAssets contains the embedded systemviews build output.	7		// WebUIAssets contains the embedded systemviews build output.
		8	+	// The legacy WebUIAssets name is kept for compatibility with existing callers.
8	// Used by the scheme handlers to serve dumb://error, dumb://config,	9		// Used by the scheme handlers to serve dumb://error, dumb://config,
9	// dumb://history, and dumb://favorites.	10		// dumb://history, and dumb://favorites.
10	//	11		//

M cmd/systemviews/bootstrap.go +4 -3


@@ -3,6 +3,7 @@ package main
3	3		import (
4	4		"context"
5	5
	6	+	"github.com/bnema/dumber/internal/application/dto"
6	7		"github.com/bnema/dumber/internal/application/port"
7	8		"github.com/bnema/dumber/internal/ui/systemviews"
8	9		)

@@ -29,15 +30,15 @@ type bridgeConfigProxy struct {
29	30		route systemviews.Route
30	31		}
31	32
32		-	func (p bridgeConfigProxy) Current(ctx context.Context) (port.SystemviewConfigPayload, error) {
	33	+	func (p bridgeConfigProxy) Current(ctx context.Context) (dto.SystemviewConfigPayload, error) {
33	34		return p.bridge.Current(ctx)
34	35		}
35	36
36		-	func (p bridgeConfigProxy) Default(ctx context.Context) (port.SystemviewConfigPayload, error) {
	37	+	func (p bridgeConfigProxy) Default(ctx context.Context) (dto.SystemviewConfigPayload, error) {
37	38		return p.bridge.Default(ctx)
38	39		}
39	40
40		-	func (p bridgeConfigProxy) Save(ctx context.Context, cfg port.WebUIConfig) error {
	41	+	func (p bridgeConfigProxy) Save(ctx context.Context, cfg dto.WebUIConfig) error {
41	42		return p.bridge.Save(ctx, cfg)
42	43		}
43	44

 import (
 	"context"
+	"github.com/bnema/dumber/internal/application/dto"
 	"github.com/bnema/dumber/internal/application/port"
 	"github.com/bnema/dumber/internal/ui/systemviews"
 )
 	route  systemviews.Route
 }
-func (p bridgeConfigProxy) Current(ctx context.Context) (port.SystemviewConfigPayload, error) {
+func (p bridgeConfigProxy) Current(ctx context.Context) (dto.SystemviewConfigPayload, error) {
 	return p.bridge.Current(ctx)
 }
-func (p bridgeConfigProxy) Default(ctx context.Context) (port.SystemviewConfigPayload, error) {
+func (p bridgeConfigProxy) Default(ctx context.Context) (dto.SystemviewConfigPayload, error) {
 	return p.bridge.Default(ctx)
 }
-func (p bridgeConfigProxy) Save(ctx context.Context, cfg port.WebUIConfig) error {
+func (p bridgeConfigProxy) Save(ctx context.Context, cfg dto.WebUIConfig) error {
 	return p.bridge.Save(ctx, cfg)
 }

M cmd/systemviews/bootstrap_test.go +10 -9


@@ -4,6 +4,7 @@ import (
4	4		"context"
5	5		"testing"
6	6
	7	+	"github.com/bnema/dumber/internal/application/dto"
7	8		"github.com/bnema/dumber/internal/application/port"
8	9		"github.com/bnema/dumber/internal/domain/entity"
9	10		"github.com/stretchr/testify/assert"

@@ -28,10 +29,10 @@ func TestNewBridgeApp_UsesCurrentConfigForNonConfigRoutes(t *testing.T) {
28	29
29	30		bridge := &fakeBridgeService{
30	31		historyEntries: []*entity.HistoryEntry{{Title: "Example", URL: "https://example.com"}},
31		-	currentConfig: port.SystemviewConfigPayload{
32		-	Appearance: port.WebUIAppearanceConfig{
	32	+	currentConfig: dto.SystemviewConfigPayload{
	33	+	Appearance: dto.WebUIAppearanceConfig{
33	34		ColorScheme: "prefer-dark",
34		-	DarkPalette: port.ColorPalette{
	35	+	DarkPalette: dto.ColorPalette{
35	36		Background: "#111111",
36	37		Surface: "#1a1a1a",
37	38		SurfaceVariant: "#2a2a2a",

@@ -75,7 +76,7 @@ func TestNewBridgeApp_WiresConfigService(t *testing.T) {
75	76		t.Parallel()
76	77
77	78		bridge := &fakeBridgeService{
78		-	currentConfig: port.SystemviewConfigPayload{EngineType: "webkit"},
	79	+	currentConfig: dto.SystemviewConfigPayload{EngineType: "webkit"},
79	80		keybindings: port.KeybindingsConfig{Groups: []port.KeybindingGroup{{DisplayName: "Default"}}},
80	81		}
81	82		app := newBridgeApp(&fakeDOM{}, "dumb://config", bridge)

@@ -108,7 +109,7 @@ type fakeBridgeService struct {
108	109		favorites []*entity.Favorite
109	110		folders []*entity.Folder
110	111		tags []*entity.Tag
111		-	currentConfig port.SystemviewConfigPayload
	112	+	currentConfig dto.SystemviewConfigPayload
112	113		keybindings port.KeybindingsConfig
113	114		}
114	115

@@ -187,16 +188,16 @@ func (*fakeBridgeService) AssignTag(context.Context, int64, int64) error { retur
187	188
188	189		func (*fakeBridgeService) RemoveTag(context.Context, int64, int64) error { return nil }
189	190
190		-	func (f *fakeBridgeService) Current(context.Context) (port.SystemviewConfigPayload, error) {
	191	+	func (f *fakeBridgeService) Current(context.Context) (dto.SystemviewConfigPayload, error) {
191	192		f.calledConfig = true
192	193		return f.currentConfig, nil
193	194		}
194	195
195		-	func (*fakeBridgeService) Default(context.Context) (port.SystemviewConfigPayload, error) {
196		-	return port.SystemviewConfigPayload{}, nil
	196	+	func (*fakeBridgeService) Default(context.Context) (dto.SystemviewConfigPayload, error) {
	197	+	return dto.SystemviewConfigPayload{}, nil
197	198		}
198	199
199		-	func (*fakeBridgeService) Save(context.Context, port.WebUIConfig) error { return nil }
	200	+	func (*fakeBridgeService) Save(context.Context, dto.WebUIConfig) error { return nil }
200	201
201	202		func (f *fakeBridgeService) GetKeybindings(context.Context) (port.KeybindingsConfig, error) {
202	203		f.calledKeybindings = true

 	"context"
 	"testing"
+	"github.com/bnema/dumber/internal/application/dto"
 	"github.com/bnema/dumber/internal/application/port"
 	"github.com/bnema/dumber/internal/domain/entity"
 	"github.com/stretchr/testify/assert"
 	bridge := &fakeBridgeService{
 		historyEntries: []*entity.HistoryEntry{{Title: "Example", URL: "https://example.com"}},
-		currentConfig: port.SystemviewConfigPayload{
+		currentConfig: dto.SystemviewConfigPayload{
-			Appearance: port.WebUIAppearanceConfig{
+			Appearance: dto.WebUIAppearanceConfig{
 				ColorScheme: "prefer-dark",
-				DarkPalette: port.ColorPalette{
+				DarkPalette: dto.ColorPalette{
 					Background:     "#111111",
 					Surface:        "#1a1a1a",
 					SurfaceVariant: "#2a2a2a",
 	t.Parallel()
 	bridge := &fakeBridgeService{
-		currentConfig: port.SystemviewConfigPayload{EngineType: "webkit"},
+		currentConfig: dto.SystemviewConfigPayload{EngineType: "webkit"},
 		keybindings:   port.KeybindingsConfig{Groups: []port.KeybindingGroup{{DisplayName: "Default"}}},
 	}
 	app := newBridgeApp(&fakeDOM{}, "dumb://config", bridge)
 	favorites      []*entity.Favorite
 	folders        []*entity.Folder
 	tags           []*entity.Tag
-	currentConfig  port.SystemviewConfigPayload
+	currentConfig  dto.SystemviewConfigPayload
 	keybindings    port.KeybindingsConfig
 }
 func (*fakeBridgeService) RemoveTag(context.Context, int64, int64) error { return nil }
-func (f *fakeBridgeService) Current(context.Context) (port.SystemviewConfigPayload, error) {
+func (f *fakeBridgeService) Current(context.Context) (dto.SystemviewConfigPayload, error) {
 	f.calledConfig = true
 	return f.currentConfig, nil
 }
-func (*fakeBridgeService) Default(context.Context) (port.SystemviewConfigPayload, error) {
+func (*fakeBridgeService) Default(context.Context) (dto.SystemviewConfigPayload, error) {
-	return port.SystemviewConfigPayload{}, nil
+	return dto.SystemviewConfigPayload{}, nil
 }
-func (*fakeBridgeService) Save(context.Context, port.WebUIConfig) error { return nil }
+func (*fakeBridgeService) Save(context.Context, dto.WebUIConfig) error { return nil }
 func (f *fakeBridgeService) GetKeybindings(context.Context) (port.KeybindingsConfig, error) {
 	f.calledKeybindings = true

A internal/application/dto/webui_config.go +92 -0

@@ -0,0 +1,92 @@
	1	+	package dto
	2	+
	3	+	// WebUIConfig represents the subset of configuration editable in dumb://config.
	4	+	type WebUIConfig struct {
	5	+	Appearance WebUIAppearanceConfig `json:"appearance"`
	6	+	Performance WebUIPerformanceConfig `json:"performance"`
	7	+	DefaultUIScale float64 `json:"default_ui_scale"`
	8	+	DefaultSearchEngine string `json:"default_search_engine"`
	9	+	SearchShortcuts map[string]SearchShortcut `json:"search_shortcuts"`
	10	+	}
	11	+
	12	+	// SystemviewCustomPerformancePayload is the editable custom performance profile shape.
	13	+	type SystemviewCustomPerformancePayload = WebUICustomPerformanceConfig
	14	+
	15	+	// SystemviewResolvedPerformancePayload is the resolved effective performance shape.
	16	+	type SystemviewResolvedPerformancePayload struct {
	17	+	SkiaCPUThreads int `json:"skia_cpu_threads"`
	18	+	SkiaGPUThreads int `json:"skia_gpu_threads"`
	19	+	WebProcessMemoryMB int `json:"web_process_memory_mb"`
	20	+	NetworkProcessMemoryMB int `json:"network_process_memory_mb"`
	21	+	WebViewPoolPrewarm int `json:"webview_pool_prewarm"`
	22	+	ConservativeThreshold float64 `json:"conservative_threshold"`
	23	+	StrictThreshold float64 `json:"strict_threshold"`
	24	+	}
	25	+
	26	+	// SystemviewHardwarePayload exposes detected hardware to the settings UI.
	27	+	type SystemviewHardwarePayload struct {
	28	+	CPUCores int `json:"cpu_cores"`
	29	+	CPUThreads int `json:"cpu_threads"`
	30	+	TotalRAMMB int `json:"total_ram_mb"`
	31	+	GPUVendor string `json:"gpu_vendor"`
	32	+	GPUName string `json:"gpu_name"`
	33	+	VRAMMB int `json:"vram_mb"`
	34	+	}
	35	+
	36	+	// SystemviewPerformancePayload is the performance tab payload expected by the UI.
	37	+	type SystemviewPerformancePayload struct {
	38	+	Profile string `json:"profile"`
	39	+	Custom SystemviewCustomPerformancePayload `json:"custom"`
	40	+	Resolved SystemviewResolvedPerformancePayload `json:"resolved"`
	41	+	Hardware SystemviewHardwarePayload `json:"hardware"`
	42	+	}
	43	+
	44	+	// SystemviewConfigPayload is the full JSON shape expected by dumb://config.
	45	+	type SystemviewConfigPayload struct {
	46	+	Appearance WebUIAppearanceConfig `json:"appearance"`
	47	+	Performance SystemviewPerformancePayload `json:"performance"`
	48	+	DefaultUIScale float64 `json:"default_ui_scale"`
	49	+	DefaultSearchEngine string `json:"default_search_engine"`
	50	+	SearchShortcuts map[string]SearchShortcut `json:"search_shortcuts"`
	51	+	EngineType string `json:"engine_type"`
	52	+	}
	53	+
	54	+	// WebUIPerformanceConfig represents performance settings editable in dumb://config.
	55	+	type WebUIPerformanceConfig struct {
	56	+	Profile string `json:"profile"`
	57	+	Custom WebUICustomPerformanceConfig `json:"custom"`
	58	+	}
	59	+
	60	+	// WebUICustomPerformanceConfig holds user-editable fields for custom profile.
	61	+	type WebUICustomPerformanceConfig struct {
	62	+	SkiaCPUThreads int `json:"skia_cpu_threads"`
	63	+	SkiaGPUThreads int `json:"skia_gpu_threads"`
	64	+	WebProcessMemoryMB int `json:"web_process_memory_mb"`
	65	+	NetworkProcessMemoryMB int `json:"network_process_memory_mb"`
	66	+	WebViewPoolPrewarm int `json:"webview_pool_prewarm"`
	67	+	}
	68	+
	69	+	type WebUIAppearanceConfig struct {
	70	+	SansFont string `json:"sans_font"`
	71	+	SerifFont string `json:"serif_font"`
	72	+	MonospaceFont string `json:"monospace_font"`
	73	+	DefaultFontSize int `json:"default_font_size"`
	74	+	ColorScheme string `json:"color_scheme"`
	75	+	LightPalette ColorPalette `json:"light_palette"`
	76	+	DarkPalette ColorPalette `json:"dark_palette"`
	77	+	}
	78	+
	79	+	type ColorPalette struct {
	80	+	Background string `json:"background"`
	81	+	Surface string `json:"surface"`
	82	+	SurfaceVariant string `json:"surface_variant"`
	83	+	Text string `json:"text"`
	84	+	Muted string `json:"muted"`
	85	+	Accent string `json:"accent"`
	86	+	Border string `json:"border"`
	87	+	}
	88	+
	89	+	type SearchShortcut struct {
	90	+	URL string `json:"url"`
	91	+	Description string `json:"description"`
	92	+	}

@@ -0,0 +1,92 @@
	1	+	package dto
	2	+
	3	+	// WebUIConfig represents the subset of configuration editable in dumb://config.
	4	+	type WebUIConfig struct {
	5	+	Appearance WebUIAppearanceConfig `json:"appearance"`
	6	+	Performance WebUIPerformanceConfig `json:"performance"`
	7	+	DefaultUIScale float64 `json:"default_ui_scale"`
	8	+	DefaultSearchEngine string `json:"default_search_engine"`
	9	+	SearchShortcuts map[string]SearchShortcut `json:"search_shortcuts"`
	10	+	}
	11	+
	12	+	// SystemviewCustomPerformancePayload is the editable custom performance profile shape.
	13	+	type SystemviewCustomPerformancePayload = WebUICustomPerformanceConfig
	14	+
	15	+	// SystemviewResolvedPerformancePayload is the resolved effective performance shape.
	16	+	type SystemviewResolvedPerformancePayload struct {
	17	+	SkiaCPUThreads int `json:"skia_cpu_threads"`
	18	+	SkiaGPUThreads int `json:"skia_gpu_threads"`
	19	+	WebProcessMemoryMB int `json:"web_process_memory_mb"`
	20	+	NetworkProcessMemoryMB int `json:"network_process_memory_mb"`
	21	+	WebViewPoolPrewarm int `json:"webview_pool_prewarm"`
	22	+	ConservativeThreshold float64 `json:"conservative_threshold"`
	23	+	StrictThreshold float64 `json:"strict_threshold"`
	24	+	}
	25	+
	26	+	// SystemviewHardwarePayload exposes detected hardware to the settings UI.
	27	+	type SystemviewHardwarePayload struct {
	28	+	CPUCores int `json:"cpu_cores"`
	29	+	CPUThreads int `json:"cpu_threads"`
	30	+	TotalRAMMB int `json:"total_ram_mb"`
	31	+	GPUVendor string `json:"gpu_vendor"`
	32	+	GPUName string `json:"gpu_name"`
	33	+	VRAMMB int `json:"vram_mb"`
	34	+	}
	35	+
	36	+	// SystemviewPerformancePayload is the performance tab payload expected by the UI.
	37	+	type SystemviewPerformancePayload struct {
	38	+	Profile string `json:"profile"`
	39	+	Custom SystemviewCustomPerformancePayload `json:"custom"`
	40	+	Resolved SystemviewResolvedPerformancePayload `json:"resolved"`
	41	+	Hardware SystemviewHardwarePayload `json:"hardware"`
	42	+	}
	43	+
	44	+	// SystemviewConfigPayload is the full JSON shape expected by dumb://config.
	45	+	type SystemviewConfigPayload struct {
	46	+	Appearance WebUIAppearanceConfig `json:"appearance"`
	47	+	Performance SystemviewPerformancePayload `json:"performance"`
	48	+	DefaultUIScale float64 `json:"default_ui_scale"`
	49	+	DefaultSearchEngine string `json:"default_search_engine"`
	50	+	SearchShortcuts map[string]SearchShortcut `json:"search_shortcuts"`
	51	+	EngineType string `json:"engine_type"`
	52	+	}
	53	+
	54	+	// WebUIPerformanceConfig represents performance settings editable in dumb://config.
	55	+	type WebUIPerformanceConfig struct {
	56	+	Profile string `json:"profile"`
	57	+	Custom WebUICustomPerformanceConfig `json:"custom"`
	58	+	}
	59	+
	60	+	// WebUICustomPerformanceConfig holds user-editable fields for custom profile.
	61	+	type WebUICustomPerformanceConfig struct {
	62	+	SkiaCPUThreads int `json:"skia_cpu_threads"`
	63	+	SkiaGPUThreads int `json:"skia_gpu_threads"`
	64	+	WebProcessMemoryMB int `json:"web_process_memory_mb"`
	65	+	NetworkProcessMemoryMB int `json:"network_process_memory_mb"`
	66	+	WebViewPoolPrewarm int `json:"webview_pool_prewarm"`
	67	+	}
	68	+
	69	+	type WebUIAppearanceConfig struct {
	70	+	SansFont string `json:"sans_font"`
	71	+	SerifFont string `json:"serif_font"`
	72	+	MonospaceFont string `json:"monospace_font"`
	73	+	DefaultFontSize int `json:"default_font_size"`
	74	+	ColorScheme string `json:"color_scheme"`
	75	+	LightPalette ColorPalette `json:"light_palette"`
	76	+	DarkPalette ColorPalette `json:"dark_palette"`
	77	+	}
	78	+
	79	+	type ColorPalette struct {
	80	+	Background string `json:"background"`
	81	+	Surface string `json:"surface"`
	82	+	SurfaceVariant string `json:"surface_variant"`
	83	+	Text string `json:"text"`
	84	+	Muted string `json:"muted"`
	85	+	Accent string `json:"accent"`
	86	+	Border string `json:"border"`
	87	+	}
	88	+
	89	+	type SearchShortcut struct {
	90	+	URL string `json:"url"`
	91	+	Description string `json:"description"`
	92	+	}

M internal/application/port/handler_deps.go +2 -1


@@ -3,6 +3,7 @@ package port
3	3		import (
4	4		"context"
5	5
	6	+	"github.com/bnema/dumber/internal/application/dto"
6	7		"github.com/bnema/dumber/internal/domain/entity"
7	8		)
8	9

@@ -43,7 +44,7 @@ type AutoCopyConfig interface {
43	44		// A struct is used here to avoid reverse dependencies between the bootstrap and
44	45		// UI layers, which both need to reference this shared dependency container.
45	46		type HandlerDeps struct {
46		-	SaveConfig func(context.Context, WebUIConfig) error
	47	+	SaveConfig func(context.Context, dto.WebUIConfig) error
47	48		SaveOmniboxInitialBehavior func(context.Context, entity.OmniboxInitialBehavior) error
48	49		KeybindingsGetter KeybindingsGetter
49	50		KeybindingSetter KeybindingSetter

 import (
 	"context"
+	"github.com/bnema/dumber/internal/application/dto"
 	"github.com/bnema/dumber/internal/domain/entity"
 )
 // A struct is used here to avoid reverse dependencies between the bootstrap and
 // UI layers, which both need to reference this shared dependency container.
 type HandlerDeps struct {
-	SaveConfig                 func(context.Context, WebUIConfig) error
+	SaveConfig                 func(context.Context, dto.WebUIConfig) error
 	SaveOmniboxInitialBehavior func(context.Context, entity.OmniboxInitialBehavior) error
 	KeybindingsGetter          KeybindingsGetter
 	KeybindingSetter           KeybindingSetter

M internal/application/port/mocks/mocks.go +21 -21


@@ -12113,22 +12113,22 @@ func (_m MockSystemviewConfigReader) EXPECT() MockSystemviewConfigReader_Expec
12113	12113		}
12114	12114
12115	12115		// Current provides a mock function for the type MockSystemviewConfigReader
12116		-	func (_mock *MockSystemviewConfigReader) Current(ctx context.Context) (port.SystemviewConfigPayload, error) {
	12116	+	func (_mock *MockSystemviewConfigReader) Current(ctx context.Context) (dto.SystemviewConfigPayload, error) {
12117	12117		ret := _mock.Called(ctx)
12118	12118
12119	12119		if len(ret) == 0 {
12120	12120		panic("no return value specified for Current")
12121	12121		}
12122	12122
12123		-	var r0 port.SystemviewConfigPayload
	12123	+	var r0 dto.SystemviewConfigPayload
12124	12124		var r1 error
12125		-	if returnFunc, ok := ret.Get(0).(func(context.Context) (port.SystemviewConfigPayload, error)); ok {
	12125	+	if returnFunc, ok := ret.Get(0).(func(context.Context) (dto.SystemviewConfigPayload, error)); ok {
12126	12126		return returnFunc(ctx)
12127	12127		}
12128		-	if returnFunc, ok := ret.Get(0).(func(context.Context) port.SystemviewConfigPayload); ok {
	12128	+	if returnFunc, ok := ret.Get(0).(func(context.Context) dto.SystemviewConfigPayload); ok {
12129	12129		r0 = returnFunc(ctx)
12130	12130		} else {
12131		-	r0 = ret.Get(0).(port.SystemviewConfigPayload)
	12131	+	r0 = ret.Get(0).(dto.SystemviewConfigPayload)
12132	12132		}
12133	12133		if returnFunc, ok := ret.Get(1).(func(context.Context) error); ok {
12134	12134		r1 = returnFunc(ctx)

@@ -12162,33 +12162,33 @@ func (_c *MockSystemviewConfigReader_Current_Call) Run(run func(ctx context.Cont
12162	12162		return _c
12163	12163		}
12164	12164
12165		-	func (_c MockSystemviewConfigReader_Current_Call) Return(systemviewConfigPayload port.SystemviewConfigPayload, err error) MockSystemviewConfigReader_Current_Call {
	12165	+	func (_c MockSystemviewConfigReader_Current_Call) Return(systemviewConfigPayload dto.SystemviewConfigPayload, err error) MockSystemviewConfigReader_Current_Call {
12166	12166		_c.Call.Return(systemviewConfigPayload, err)
12167	12167		return _c
12168	12168		}
12169	12169
12170		-	func (_c MockSystemviewConfigReader_Current_Call) RunAndReturn(run func(ctx context.Context) (port.SystemviewConfigPayload, error)) MockSystemviewConfigReader_Current_Call {
	12170	+	func (_c MockSystemviewConfigReader_Current_Call) RunAndReturn(run func(ctx context.Context) (dto.SystemviewConfigPayload, error)) MockSystemviewConfigReader_Current_Call {
12171	12171		_c.Call.Return(run)
12172	12172		return _c
12173	12173		}
12174	12174
12175	12175		// Default provides a mock function for the type MockSystemviewConfigReader
12176		-	func (_mock *MockSystemviewConfigReader) Default(ctx context.Context) (port.SystemviewConfigPayload, error) {
	12176	+	func (_mock *MockSystemviewConfigReader) Default(ctx context.Context) (dto.SystemviewConfigPayload, error) {
12177	12177		ret := _mock.Called(ctx)
12178	12178
12179	12179		if len(ret) == 0 {
12180	12180		panic("no return value specified for Default")
12181	12181		}
12182	12182
12183		-	var r0 port.SystemviewConfigPayload
	12183	+	var r0 dto.SystemviewConfigPayload
12184	12184		var r1 error
12185		-	if returnFunc, ok := ret.Get(0).(func(context.Context) (port.SystemviewConfigPayload, error)); ok {
	12185	+	if returnFunc, ok := ret.Get(0).(func(context.Context) (dto.SystemviewConfigPayload, error)); ok {
12186	12186		return returnFunc(ctx)
12187	12187		}
12188		-	if returnFunc, ok := ret.Get(0).(func(context.Context) port.SystemviewConfigPayload); ok {
	12188	+	if returnFunc, ok := ret.Get(0).(func(context.Context) dto.SystemviewConfigPayload); ok {
12189	12189		r0 = returnFunc(ctx)
12190	12190		} else {
12191		-	r0 = ret.Get(0).(port.SystemviewConfigPayload)
	12191	+	r0 = ret.Get(0).(dto.SystemviewConfigPayload)
12192	12192		}
12193	12193		if returnFunc, ok := ret.Get(1).(func(context.Context) error); ok {
12194	12194		r1 = returnFunc(ctx)

@@ -12222,12 +12222,12 @@ func (_c *MockSystemviewConfigReader_Default_Call) Run(run func(ctx context.Cont
12222	12222		return _c
12223	12223		}
12224	12224
12225		-	func (_c MockSystemviewConfigReader_Default_Call) Return(systemviewConfigPayload port.SystemviewConfigPayload, err error) MockSystemviewConfigReader_Default_Call {
	12225	+	func (_c MockSystemviewConfigReader_Default_Call) Return(systemviewConfigPayload dto.SystemviewConfigPayload, err error) MockSystemviewConfigReader_Default_Call {
12226	12226		_c.Call.Return(systemviewConfigPayload, err)
12227	12227		return _c
12228	12228		}
12229	12229
12230		-	func (_c MockSystemviewConfigReader_Default_Call) RunAndReturn(run func(ctx context.Context) (port.SystemviewConfigPayload, error)) MockSystemviewConfigReader_Default_Call {
	12230	+	func (_c MockSystemviewConfigReader_Default_Call) RunAndReturn(run func(ctx context.Context) (dto.SystemviewConfigPayload, error)) MockSystemviewConfigReader_Default_Call {
12231	12231		_c.Call.Return(run)
12232	12232		return _c
12233	12233		}

@@ -12260,7 +12260,7 @@ func (_m MockWebUIConfigSaver) EXPECT() MockWebUIConfigSaver_Expecter {
12260	12260		}
12261	12261
12262	12262		// SaveWebUIConfig provides a mock function for the type MockWebUIConfigSaver
12263		-	func (_mock *MockWebUIConfigSaver) SaveWebUIConfig(ctx context.Context, cfg port.WebUIConfig) error {
	12263	+	func (_mock *MockWebUIConfigSaver) SaveWebUIConfig(ctx context.Context, cfg dto.WebUIConfig) error {
12264	12264		ret := _mock.Called(ctx, cfg)
12265	12265
12266	12266		if len(ret) == 0 {

@@ -12268,7 +12268,7 @@ func (_mock *MockWebUIConfigSaver) SaveWebUIConfig(ctx context.Context, cfg port
12268	12268		}
12269	12269
12270	12270		var r0 error
12271		-	if returnFunc, ok := ret.Get(0).(func(context.Context, port.WebUIConfig) error); ok {
	12271	+	if returnFunc, ok := ret.Get(0).(func(context.Context, dto.WebUIConfig) error); ok {
12272	12272		r0 = returnFunc(ctx, cfg)
12273	12273		} else {
12274	12274		r0 = ret.Error(0)

@@ -12283,20 +12283,20 @@ type MockWebUIConfigSaver_SaveWebUIConfig_Call struct {
12283	12283
12284	12284		// SaveWebUIConfig is a helper method to define mock.On call
12285	12285		// - ctx context.Context
12286		-	// - cfg port.WebUIConfig
	12286	+	// - cfg dto.WebUIConfig
12287	12287		func (_e MockWebUIConfigSaver_Expecter) SaveWebUIConfig(ctx interface{}, cfg interface{}) MockWebUIConfigSaver_SaveWebUIConfig_Call {
12288	12288		return &MockWebUIConfigSaver_SaveWebUIConfig_Call{Call: _e.mock.On("SaveWebUIConfig", ctx, cfg)}
12289	12289		}
12290	12290
12291		-	func (_c MockWebUIConfigSaver_SaveWebUIConfig_Call) Run(run func(ctx context.Context, cfg port.WebUIConfig)) MockWebUIConfigSaver_SaveWebUIConfig_Call {
	12291	+	func (_c MockWebUIConfigSaver_SaveWebUIConfig_Call) Run(run func(ctx context.Context, cfg dto.WebUIConfig)) MockWebUIConfigSaver_SaveWebUIConfig_Call {
12292	12292		_c.Call.Run(func(args mock.Arguments) {
12293	12293		var arg0 context.Context
12294	12294		if args[0] != nil {
12295	12295		arg0 = args[0].(context.Context)
12296	12296		}
12297		-	var arg1 port.WebUIConfig
	12297	+	var arg1 dto.WebUIConfig
12298	12298		if args[1] != nil {
12299		-	arg1 = args[1].(port.WebUIConfig)
	12299	+	arg1 = args[1].(dto.WebUIConfig)
12300	12300		}
12301	12301		run(
12302	12302		arg0,

@@ -12311,7 +12311,7 @@ func (_c MockWebUIConfigSaver_SaveWebUIConfig_Call) Return(err error) MockWebU
12311	12311		return _c
12312	12312		}
12313	12313
12314		-	func (_c MockWebUIConfigSaver_SaveWebUIConfig_Call) RunAndReturn(run func(ctx context.Context, cfg port.WebUIConfig) error) MockWebUIConfigSaver_SaveWebUIConfig_Call {
	12314	+	func (_c MockWebUIConfigSaver_SaveWebUIConfig_Call) RunAndReturn(run func(ctx context.Context, cfg dto.WebUIConfig) error) MockWebUIConfigSaver_SaveWebUIConfig_Call {
12315	12315		_c.Call.Return(run)
12316	12316		return _c
12317	12317		}


@@ -12113,22 +12113,22 @@ func (_m MockSystemviewConfigReader) EXPECT() MockSystemviewConfigReader_Expec
12113		}	12113		}
12114			12114
12115		// Current provides a mock function for the type MockSystemviewConfigReader	12115		// Current provides a mock function for the type MockSystemviewConfigReader
12116	-	func (_mock *MockSystemviewConfigReader) Current(ctx context.Context) (port.SystemviewConfigPayload, error) {	12116	+	func (_mock *MockSystemviewConfigReader) Current(ctx context.Context) (dto.SystemviewConfigPayload, error) {
12117		ret := _mock.Called(ctx)	12117		ret := _mock.Called(ctx)
12118			12118
12119		if len(ret) == 0 {	12119		if len(ret) == 0 {
12120		panic("no return value specified for Current")	12120		panic("no return value specified for Current")
12121		}	12121		}
12122			12122
12123	-	var r0 port.SystemviewConfigPayload	12123	+	var r0 dto.SystemviewConfigPayload
12124		var r1 error	12124		var r1 error
12125	-	if returnFunc, ok := ret.Get(0).(func(context.Context) (port.SystemviewConfigPayload, error)); ok {	12125	+	if returnFunc, ok := ret.Get(0).(func(context.Context) (dto.SystemviewConfigPayload, error)); ok {
12126		return returnFunc(ctx)	12126		return returnFunc(ctx)
12127		}	12127		}
12128	-	if returnFunc, ok := ret.Get(0).(func(context.Context) port.SystemviewConfigPayload); ok {	12128	+	if returnFunc, ok := ret.Get(0).(func(context.Context) dto.SystemviewConfigPayload); ok {
12129		r0 = returnFunc(ctx)	12129		r0 = returnFunc(ctx)
12130		} else {	12130		} else {
12131	-	r0 = ret.Get(0).(port.SystemviewConfigPayload)	12131	+	r0 = ret.Get(0).(dto.SystemviewConfigPayload)
12132		}	12132		}
12133		if returnFunc, ok := ret.Get(1).(func(context.Context) error); ok {	12133		if returnFunc, ok := ret.Get(1).(func(context.Context) error); ok {
12134		r1 = returnFunc(ctx)	12134		r1 = returnFunc(ctx)

@@ -12162,33 +12162,33 @@ func (_c *MockSystemviewConfigReader_Current_Call) Run(run func(ctx context.Cont
12162		return _c	12162		return _c
12163		}	12163		}
12164			12164
12165	-	func (_c MockSystemviewConfigReader_Current_Call) Return(systemviewConfigPayload port.SystemviewConfigPayload, err error) MockSystemviewConfigReader_Current_Call {	12165	+	func (_c MockSystemviewConfigReader_Current_Call) Return(systemviewConfigPayload dto.SystemviewConfigPayload, err error) MockSystemviewConfigReader_Current_Call {
12166		_c.Call.Return(systemviewConfigPayload, err)	12166		_c.Call.Return(systemviewConfigPayload, err)
12167		return _c	12167		return _c
12168		}	12168		}
12169			12169
12170	-	func (_c MockSystemviewConfigReader_Current_Call) RunAndReturn(run func(ctx context.Context) (port.SystemviewConfigPayload, error)) MockSystemviewConfigReader_Current_Call {	12170	+	func (_c MockSystemviewConfigReader_Current_Call) RunAndReturn(run func(ctx context.Context) (dto.SystemviewConfigPayload, error)) MockSystemviewConfigReader_Current_Call {
12171		_c.Call.Return(run)	12171		_c.Call.Return(run)
12172		return _c	12172		return _c
12173		}	12173		}
12174			12174
12175		// Default provides a mock function for the type MockSystemviewConfigReader	12175		// Default provides a mock function for the type MockSystemviewConfigReader
12176	-	func (_mock *MockSystemviewConfigReader) Default(ctx context.Context) (port.SystemviewConfigPayload, error) {	12176	+	func (_mock *MockSystemviewConfigReader) Default(ctx context.Context) (dto.SystemviewConfigPayload, error) {
12177		ret := _mock.Called(ctx)	12177		ret := _mock.Called(ctx)
12178			12178
12179		if len(ret) == 0 {	12179		if len(ret) == 0 {
12180		panic("no return value specified for Default")	12180		panic("no return value specified for Default")
12181		}	12181		}
12182			12182
12183	-	var r0 port.SystemviewConfigPayload	12183	+	var r0 dto.SystemviewConfigPayload
12184		var r1 error	12184		var r1 error
12185	-	if returnFunc, ok := ret.Get(0).(func(context.Context) (port.SystemviewConfigPayload, error)); ok {	12185	+	if returnFunc, ok := ret.Get(0).(func(context.Context) (dto.SystemviewConfigPayload, error)); ok {
12186		return returnFunc(ctx)	12186		return returnFunc(ctx)
12187		}	12187		}
12188	-	if returnFunc, ok := ret.Get(0).(func(context.Context) port.SystemviewConfigPayload); ok {	12188	+	if returnFunc, ok := ret.Get(0).(func(context.Context) dto.SystemviewConfigPayload); ok {
12189		r0 = returnFunc(ctx)	12189		r0 = returnFunc(ctx)
12190		} else {	12190		} else {
12191	-	r0 = ret.Get(0).(port.SystemviewConfigPayload)	12191	+	r0 = ret.Get(0).(dto.SystemviewConfigPayload)
12192		}	12192		}
12193		if returnFunc, ok := ret.Get(1).(func(context.Context) error); ok {	12193		if returnFunc, ok := ret.Get(1).(func(context.Context) error); ok {
12194		r1 = returnFunc(ctx)	12194		r1 = returnFunc(ctx)

@@ -12222,12 +12222,12 @@ func (_c *MockSystemviewConfigReader_Default_Call) Run(run func(ctx context.Cont
12222		return _c	12222		return _c
12223		}	12223		}
12224			12224
12225	-	func (_c MockSystemviewConfigReader_Default_Call) Return(systemviewConfigPayload port.SystemviewConfigPayload, err error) MockSystemviewConfigReader_Default_Call {	12225	+	func (_c MockSystemviewConfigReader_Default_Call) Return(systemviewConfigPayload dto.SystemviewConfigPayload, err error) MockSystemviewConfigReader_Default_Call {
12226		_c.Call.Return(systemviewConfigPayload, err)	12226		_c.Call.Return(systemviewConfigPayload, err)
12227		return _c	12227		return _c
12228		}	12228		}
12229			12229
12230	-	func (_c MockSystemviewConfigReader_Default_Call) RunAndReturn(run func(ctx context.Context) (port.SystemviewConfigPayload, error)) MockSystemviewConfigReader_Default_Call {	12230	+	func (_c MockSystemviewConfigReader_Default_Call) RunAndReturn(run func(ctx context.Context) (dto.SystemviewConfigPayload, error)) MockSystemviewConfigReader_Default_Call {
12231		_c.Call.Return(run)	12231		_c.Call.Return(run)
12232		return _c	12232		return _c
12233		}	12233		}

@@ -12260,7 +12260,7 @@ func (_m MockWebUIConfigSaver) EXPECT() MockWebUIConfigSaver_Expecter {
12260		}	12260		}
12261			12261
12262		// SaveWebUIConfig provides a mock function for the type MockWebUIConfigSaver	12262		// SaveWebUIConfig provides a mock function for the type MockWebUIConfigSaver
12263	-	func (_mock *MockWebUIConfigSaver) SaveWebUIConfig(ctx context.Context, cfg port.WebUIConfig) error {	12263	+	func (_mock *MockWebUIConfigSaver) SaveWebUIConfig(ctx context.Context, cfg dto.WebUIConfig) error {
12264		ret := _mock.Called(ctx, cfg)	12264		ret := _mock.Called(ctx, cfg)
12265			12265
12266		if len(ret) == 0 {	12266		if len(ret) == 0 {

@@ -12268,7 +12268,7 @@ func (_mock *MockWebUIConfigSaver) SaveWebUIConfig(ctx context.Context, cfg port
12268		}	12268		}
12269			12269
12270		var r0 error	12270		var r0 error
12271	-	if returnFunc, ok := ret.Get(0).(func(context.Context, port.WebUIConfig) error); ok {	12271	+	if returnFunc, ok := ret.Get(0).(func(context.Context, dto.WebUIConfig) error); ok {
12272		r0 = returnFunc(ctx, cfg)	12272		r0 = returnFunc(ctx, cfg)
12273		} else {	12273		} else {
12274		r0 = ret.Error(0)	12274		r0 = ret.Error(0)

@@ -12283,20 +12283,20 @@ type MockWebUIConfigSaver_SaveWebUIConfig_Call struct {
12283			12283
12284		// SaveWebUIConfig is a helper method to define mock.On call	12284		// SaveWebUIConfig is a helper method to define mock.On call
12285		// - ctx context.Context	12285		// - ctx context.Context
12286	-	// - cfg port.WebUIConfig	12286	+	// - cfg dto.WebUIConfig
12287		func (_e MockWebUIConfigSaver_Expecter) SaveWebUIConfig(ctx interface{}, cfg interface{}) MockWebUIConfigSaver_SaveWebUIConfig_Call {	12287		func (_e MockWebUIConfigSaver_Expecter) SaveWebUIConfig(ctx interface{}, cfg interface{}) MockWebUIConfigSaver_SaveWebUIConfig_Call {
12288		return &MockWebUIConfigSaver_SaveWebUIConfig_Call{Call: _e.mock.On("SaveWebUIConfig", ctx, cfg)}	12288		return &MockWebUIConfigSaver_SaveWebUIConfig_Call{Call: _e.mock.On("SaveWebUIConfig", ctx, cfg)}
12289		}	12289		}
12290			12290
12291	-	func (_c MockWebUIConfigSaver_SaveWebUIConfig_Call) Run(run func(ctx context.Context, cfg port.WebUIConfig)) MockWebUIConfigSaver_SaveWebUIConfig_Call {	12291	+	func (_c MockWebUIConfigSaver_SaveWebUIConfig_Call) Run(run func(ctx context.Context, cfg dto.WebUIConfig)) MockWebUIConfigSaver_SaveWebUIConfig_Call {
12292		_c.Call.Run(func(args mock.Arguments) {	12292		_c.Call.Run(func(args mock.Arguments) {
12293		var arg0 context.Context	12293		var arg0 context.Context
12294		if args[0] != nil {	12294		if args[0] != nil {
12295		arg0 = args[0].(context.Context)	12295		arg0 = args[0].(context.Context)
12296		}	12296		}
12297	-	var arg1 port.WebUIConfig	12297	+	var arg1 dto.WebUIConfig
12298		if args[1] != nil {	12298		if args[1] != nil {
12299	-	arg1 = args[1].(port.WebUIConfig)	12299	+	arg1 = args[1].(dto.WebUIConfig)
12300		}	12300		}
12301		run(	12301		run(
12302		arg0,	12302		arg0,

@@ -12311,7 +12311,7 @@ func (_c MockWebUIConfigSaver_SaveWebUIConfig_Call) Return(err error) MockWebU
12311		return _c	12311		return _c
12312		}	12312		}
12313			12313
12314	-	func (_c MockWebUIConfigSaver_SaveWebUIConfig_Call) RunAndReturn(run func(ctx context.Context, cfg port.WebUIConfig) error) MockWebUIConfigSaver_SaveWebUIConfig_Call {	12314	+	func (_c MockWebUIConfigSaver_SaveWebUIConfig_Call) RunAndReturn(run func(ctx context.Context, cfg dto.WebUIConfig) error) MockWebUIConfigSaver_SaveWebUIConfig_Call {
12315		_c.Call.Return(run)	12315		_c.Call.Return(run)
12316		return _c	12316		return _c
12317		}	12317		}

M internal/application/port/systemviews.go +4 -3


@@ -3,6 +3,7 @@ package port
3	3		import (
4	4		"context"
5	5
	6	+	"github.com/bnema/dumber/internal/application/dto"
6	7		"github.com/bnema/dumber/internal/domain/entity"
7	8		)
8	9

@@ -40,9 +41,9 @@ type SystemviewFavoritesService interface {
40	41
41	42		// SystemviewConfigService exposes config and keybinding operations for the systemviews UI.
42	43		type SystemviewConfigService interface {
43		-	Current(ctx context.Context) (SystemviewConfigPayload, error)
44		-	Default(ctx context.Context) (SystemviewConfigPayload, error)
45		-	Save(ctx context.Context, cfg WebUIConfig) error
	44	+	Current(ctx context.Context) (dto.SystemviewConfigPayload, error)
	45	+	Default(ctx context.Context) (dto.SystemviewConfigPayload, error)
	46	+	Save(ctx context.Context, cfg dto.WebUIConfig) error
46	47		GetKeybindings(ctx context.Context) (KeybindingsConfig, error)
47	48		SetKeybinding(ctx context.Context, req SetKeybindingRequest) (SetKeybindingResponse, error)
48	49		ResetKeybinding(ctx context.Context, req ResetKeybindingRequest) error

 import (
 	"context"
+	"github.com/bnema/dumber/internal/application/dto"
 	"github.com/bnema/dumber/internal/domain/entity"
 )
 // SystemviewConfigService exposes config and keybinding operations for the systemviews UI.
 type SystemviewConfigService interface {
-	Current(ctx context.Context) (SystemviewConfigPayload, error)
+	Current(ctx context.Context) (dto.SystemviewConfigPayload, error)
-	Default(ctx context.Context) (SystemviewConfigPayload, error)
+	Default(ctx context.Context) (dto.SystemviewConfigPayload, error)
-	Save(ctx context.Context, cfg WebUIConfig) error
+	Save(ctx context.Context, cfg dto.WebUIConfig) error
 	GetKeybindings(ctx context.Context) (KeybindingsConfig, error)
 	SetKeybinding(ctx context.Context, req SetKeybindingRequest) (SetKeybindingResponse, error)
 	ResetKeybinding(ctx context.Context, req ResetKeybindingRequest) error

M internal/application/port/webui_config.go +7 -94

@@ -1,105 +1,18 @@
1	1		package port
2	2
3		-	import "context"
	3	+	import (
	4	+	"context"
4	5
5		-	// WebUIConfig represents the subset of configuration editable in dumb://config.
6		-	type WebUIConfig struct {
7		-	Appearance WebUIAppearanceConfig `json:"appearance"`
8		-	Performance WebUIPerformanceConfig `json:"performance"`
9		-	DefaultUIScale float64 `json:"default_ui_scale"`
10		-	DefaultSearchEngine string `json:"default_search_engine"`
11		-	SearchShortcuts map[string]SearchShortcut `json:"search_shortcuts"`
12		-	}
13		-
14		-	// SystemviewCustomPerformancePayload is the editable custom performance profile shape.
15		-	type SystemviewCustomPerformancePayload = WebUICustomPerformanceConfig
16		-
17		-	// SystemviewResolvedPerformancePayload is the resolved effective performance shape.
18		-	type SystemviewResolvedPerformancePayload struct {
19		-	SkiaCPUThreads int `json:"skia_cpu_threads"`
20		-	SkiaGPUThreads int `json:"skia_gpu_threads"`
21		-	WebProcessMemoryMB int `json:"web_process_memory_mb"`
22		-	NetworkProcessMemoryMB int `json:"network_process_memory_mb"`
23		-	WebViewPoolPrewarm int `json:"webview_pool_prewarm"`
24		-	ConservativeThreshold float64 `json:"conservative_threshold"`
25		-	StrictThreshold float64 `json:"strict_threshold"`
26		-	}
27		-
28		-	// SystemviewHardwarePayload exposes detected hardware to the settings UI.
29		-	type SystemviewHardwarePayload struct {
30		-	CPUCores int `json:"cpu_cores"`
31		-	CPUThreads int `json:"cpu_threads"`
32		-	TotalRAMMB int `json:"total_ram_mb"`
33		-	GPUVendor string `json:"gpu_vendor"`
34		-	GPUName string `json:"gpu_name"`
35		-	VRAMMB int `json:"vram_mb"`
36		-	}
37		-
38		-	// SystemviewPerformancePayload is the performance tab payload expected by the UI.
39		-	type SystemviewPerformancePayload struct {
40		-	Profile string `json:"profile"`
41		-	Custom SystemviewCustomPerformancePayload `json:"custom"`
42		-	Resolved SystemviewResolvedPerformancePayload `json:"resolved"`
43		-	Hardware SystemviewHardwarePayload `json:"hardware"`
44		-	}
45		-
46		-	// SystemviewConfigPayload is the full JSON shape expected by dumb://config.
47		-	type SystemviewConfigPayload struct {
48		-	Appearance WebUIAppearanceConfig `json:"appearance"`
49		-	Performance SystemviewPerformancePayload `json:"performance"`
50		-	DefaultUIScale float64 `json:"default_ui_scale"`
51		-	DefaultSearchEngine string `json:"default_search_engine"`
52		-	SearchShortcuts map[string]SearchShortcut `json:"search_shortcuts"`
53		-	EngineType string `json:"engine_type"`
54		-	}
55		-
56		-	// WebUIPerformanceConfig represents performance settings editable in dumb://config.
57		-	type WebUIPerformanceConfig struct {
58		-	Profile string `json:"profile"`
59		-	Custom WebUICustomPerformanceConfig `json:"custom"`
60		-	}
61		-
62		-	// WebUICustomPerformanceConfig holds user-editable fields for custom profile.
63		-	type WebUICustomPerformanceConfig struct {
64		-	SkiaCPUThreads int `json:"skia_cpu_threads"`
65		-	SkiaGPUThreads int `json:"skia_gpu_threads"`
66		-	WebProcessMemoryMB int `json:"web_process_memory_mb"`
67		-	NetworkProcessMemoryMB int `json:"network_process_memory_mb"`
68		-	WebViewPoolPrewarm int `json:"webview_pool_prewarm"`
69		-	}
70		-
71		-	type WebUIAppearanceConfig struct {
72		-	SansFont string `json:"sans_font"`
73		-	SerifFont string `json:"serif_font"`
74		-	MonospaceFont string `json:"monospace_font"`
75		-	DefaultFontSize int `json:"default_font_size"`
76		-	ColorScheme string `json:"color_scheme"`
77		-	LightPalette ColorPalette `json:"light_palette"`
78		-	DarkPalette ColorPalette `json:"dark_palette"`
79		-	}
80		-
81		-	type ColorPalette struct {
82		-	Background string `json:"background"`
83		-	Surface string `json:"surface"`
84		-	SurfaceVariant string `json:"surface_variant"`
85		-	Text string `json:"text"`
86		-	Muted string `json:"muted"`
87		-	Accent string `json:"accent"`
88		-	Border string `json:"border"`
89		-	}
90		-
91		-	type SearchShortcut struct {
92		-	URL string `json:"url"`
93		-	Description string `json:"description"`
94		-	}
	6	+	"github.com/bnema/dumber/internal/application/dto"
	7	+	)
95	8
96	9		// SystemviewConfigReader reads the current and default systemview config payloads.
97	10		type SystemviewConfigReader interface {
98		-	Current(ctx context.Context) (SystemviewConfigPayload, error)
99		-	Default(ctx context.Context) (SystemviewConfigPayload, error)
	11	+	Current(ctx context.Context) (dto.SystemviewConfigPayload, error)
	12	+	Default(ctx context.Context) (dto.SystemviewConfigPayload, error)
100	13		}
101	14
102	15		// WebUIConfigSaver persists WebUI configuration changes.
103	16		type WebUIConfigSaver interface {
104		-	SaveWebUIConfig(ctx context.Context, cfg WebUIConfig) error
	17	+	SaveWebUIConfig(ctx context.Context, cfg dto.WebUIConfig) error
105	18		}

@@ -1,105 +1,18 @@
1		package port	1		package port
2			2
3	-	import "context"	3	+	import (
			4	+	"context"
4			5
5	-	// WebUIConfig represents the subset of configuration editable in dumb://config.	6	+	"github.com/bnema/dumber/internal/application/dto"
6	-	type WebUIConfig struct {	7	+	)
7	-	Appearance WebUIAppearanceConfig `json:"appearance"`
8	-	Performance WebUIPerformanceConfig `json:"performance"`
9	-	DefaultUIScale float64 `json:"default_ui_scale"`
10	-	DefaultSearchEngine string `json:"default_search_engine"`
11	-	SearchShortcuts map[string]SearchShortcut `json:"search_shortcuts"`
12	-	}
13	-
14	-	// SystemviewCustomPerformancePayload is the editable custom performance profile shape.
15	-	type SystemviewCustomPerformancePayload = WebUICustomPerformanceConfig
16	-
17	-	// SystemviewResolvedPerformancePayload is the resolved effective performance shape.
18	-	type SystemviewResolvedPerformancePayload struct {
19	-	SkiaCPUThreads int `json:"skia_cpu_threads"`
20	-	SkiaGPUThreads int `json:"skia_gpu_threads"`
21	-	WebProcessMemoryMB int `json:"web_process_memory_mb"`
22	-	NetworkProcessMemoryMB int `json:"network_process_memory_mb"`
23	-	WebViewPoolPrewarm int `json:"webview_pool_prewarm"`
24	-	ConservativeThreshold float64 `json:"conservative_threshold"`
25	-	StrictThreshold float64 `json:"strict_threshold"`
26	-	}
27	-
28	-	// SystemviewHardwarePayload exposes detected hardware to the settings UI.
29	-	type SystemviewHardwarePayload struct {
30	-	CPUCores int `json:"cpu_cores"`
31	-	CPUThreads int `json:"cpu_threads"`
32	-	TotalRAMMB int `json:"total_ram_mb"`
33	-	GPUVendor string `json:"gpu_vendor"`
34	-	GPUName string `json:"gpu_name"`
35	-	VRAMMB int `json:"vram_mb"`
36	-	}
37	-
38	-	// SystemviewPerformancePayload is the performance tab payload expected by the UI.
39	-	type SystemviewPerformancePayload struct {
40	-	Profile string `json:"profile"`
41	-	Custom SystemviewCustomPerformancePayload `json:"custom"`
42	-	Resolved SystemviewResolvedPerformancePayload `json:"resolved"`
43	-	Hardware SystemviewHardwarePayload `json:"hardware"`
44	-	}
45	-
46	-	// SystemviewConfigPayload is the full JSON shape expected by dumb://config.
47	-	type SystemviewConfigPayload struct {
48	-	Appearance WebUIAppearanceConfig `json:"appearance"`
49	-	Performance SystemviewPerformancePayload `json:"performance"`
50	-	DefaultUIScale float64 `json:"default_ui_scale"`
51	-	DefaultSearchEngine string `json:"default_search_engine"`
52	-	SearchShortcuts map[string]SearchShortcut `json:"search_shortcuts"`
53	-	EngineType string `json:"engine_type"`
54	-	}
55	-
56	-	// WebUIPerformanceConfig represents performance settings editable in dumb://config.
57	-	type WebUIPerformanceConfig struct {
58	-	Profile string `json:"profile"`
59	-	Custom WebUICustomPerformanceConfig `json:"custom"`
60	-	}
61	-
62	-	// WebUICustomPerformanceConfig holds user-editable fields for custom profile.
63	-	type WebUICustomPerformanceConfig struct {
64	-	SkiaCPUThreads int `json:"skia_cpu_threads"`
65	-	SkiaGPUThreads int `json:"skia_gpu_threads"`
66	-	WebProcessMemoryMB int `json:"web_process_memory_mb"`
67	-	NetworkProcessMemoryMB int `json:"network_process_memory_mb"`
68	-	WebViewPoolPrewarm int `json:"webview_pool_prewarm"`
69	-	}
70	-
71	-	type WebUIAppearanceConfig struct {
72	-	SansFont string `json:"sans_font"`
73	-	SerifFont string `json:"serif_font"`
74	-	MonospaceFont string `json:"monospace_font"`
75	-	DefaultFontSize int `json:"default_font_size"`
76	-	ColorScheme string `json:"color_scheme"`
77	-	LightPalette ColorPalette `json:"light_palette"`
78	-	DarkPalette ColorPalette `json:"dark_palette"`
79	-	}
80	-
81	-	type ColorPalette struct {
82	-	Background string `json:"background"`
83	-	Surface string `json:"surface"`
84	-	SurfaceVariant string `json:"surface_variant"`
85	-	Text string `json:"text"`
86	-	Muted string `json:"muted"`
87	-	Accent string `json:"accent"`
88	-	Border string `json:"border"`
89	-	}
90	-
91	-	type SearchShortcut struct {
92	-	URL string `json:"url"`
93	-	Description string `json:"description"`
94	-	}
95			8
96		// SystemviewConfigReader reads the current and default systemview config payloads.	9		// SystemviewConfigReader reads the current and default systemview config payloads.
97		type SystemviewConfigReader interface {	10		type SystemviewConfigReader interface {
98	-	Current(ctx context.Context) (SystemviewConfigPayload, error)	11	+	Current(ctx context.Context) (dto.SystemviewConfigPayload, error)
99	-	Default(ctx context.Context) (SystemviewConfigPayload, error)	12	+	Default(ctx context.Context) (dto.SystemviewConfigPayload, error)
100		}	13		}
101			14
102		// WebUIConfigSaver persists WebUI configuration changes.	15		// WebUIConfigSaver persists WebUI configuration changes.
103		type WebUIConfigSaver interface {	16		type WebUIConfigSaver interface {
104	-	SaveWebUIConfig(ctx context.Context, cfg WebUIConfig) error	17	+	SaveWebUIConfig(ctx context.Context, cfg dto.WebUIConfig) error
105		}	18		}

M internal/application/usecase/read_systemview_config.go +5 -4


@@ -4,6 +4,7 @@ import (
4	4		"context"
5	5		"errors"
6	6
	7	+	"github.com/bnema/dumber/internal/application/dto"
7	8		"github.com/bnema/dumber/internal/application/port"
8	9		)
9	10

@@ -24,17 +25,17 @@ func NewReadSystemviewConfigUseCase(reader port.SystemviewConfigReader) *ReadSys
24	25		var ErrNilSystemviewConfigReader = errors.New("systemview config reader is nil")
25	26
26	27		// Current returns the current systemview config payload.
27		-	func (uc *ReadSystemviewConfigUseCase) Current(ctx context.Context) (port.SystemviewConfigPayload, error) {
	28	+	func (uc *ReadSystemviewConfigUseCase) Current(ctx context.Context) (dto.SystemviewConfigPayload, error) {
28	29		if uc == nil \|\| uc.reader == nil {
29		-	return port.SystemviewConfigPayload{}, ErrNilSystemviewConfigReader
	30	+	return dto.SystemviewConfigPayload{}, ErrNilSystemviewConfigReader
30	31		}
31	32		return uc.reader.Current(ctx)
32	33		}
33	34
34	35		// Default returns the default systemview config payload.
35		-	func (uc *ReadSystemviewConfigUseCase) Default(ctx context.Context) (port.SystemviewConfigPayload, error) {
	36	+	func (uc *ReadSystemviewConfigUseCase) Default(ctx context.Context) (dto.SystemviewConfigPayload, error) {
36	37		if uc == nil \|\| uc.reader == nil {
37		-	return port.SystemviewConfigPayload{}, ErrNilSystemviewConfigReader
	38	+	return dto.SystemviewConfigPayload{}, ErrNilSystemviewConfigReader
38	39		}
39	40		return uc.reader.Default(ctx)
40	41		}

 	"context"
 	"errors"
+	"github.com/bnema/dumber/internal/application/dto"
 	"github.com/bnema/dumber/internal/application/port"
 )
 var ErrNilSystemviewConfigReader = errors.New("systemview config reader is nil")
 // Current returns the current systemview config payload.
-func (uc *ReadSystemviewConfigUseCase) Current(ctx context.Context) (port.SystemviewConfigPayload, error) {
+func (uc *ReadSystemviewConfigUseCase) Current(ctx context.Context) (dto.SystemviewConfigPayload, error) {
 	if uc == nil || uc.reader == nil {
-		return port.SystemviewConfigPayload{}, ErrNilSystemviewConfigReader
+		return dto.SystemviewConfigPayload{}, ErrNilSystemviewConfigReader
 	}
 	return uc.reader.Current(ctx)
 }
 // Default returns the default systemview config payload.
-func (uc *ReadSystemviewConfigUseCase) Default(ctx context.Context) (port.SystemviewConfigPayload, error) {
+func (uc *ReadSystemviewConfigUseCase) Default(ctx context.Context) (dto.SystemviewConfigPayload, error) {
 	if uc == nil || uc.reader == nil {
-		return port.SystemviewConfigPayload{}, ErrNilSystemviewConfigReader
+		return dto.SystemviewConfigPayload{}, ErrNilSystemviewConfigReader
 	}
 	return uc.reader.Default(ctx)
 }

M internal/application/usecase/read_systemview_config_test.go +3 -3


@@ -4,7 +4,7 @@ import (
4	4		"context"
5	5		"testing"
6	6
7		-	"github.com/bnema/dumber/internal/application/port"
	7	+	"github.com/bnema/dumber/internal/application/dto"
8	8		portmocks "github.com/bnema/dumber/internal/application/port/mocks"
9	9		"github.com/stretchr/testify/mock"
10	10		"github.com/stretchr/testify/require"

@@ -12,7 +12,7 @@ import (
12	12
13	13		func TestReadSystemviewConfigUseCase_Current(t *testing.T) {
14	14		reader := portmocks.NewMockSystemviewConfigReader(t)
15		-	want := port.SystemviewConfigPayload{EngineType: "webkit"}
	15	+	want := dto.SystemviewConfigPayload{EngineType: "webkit"}
16	16		reader.EXPECT().Current(mock.Anything).Return(want, nil).Once()
17	17
18	18		uc := NewReadSystemviewConfigUseCase(reader)

@@ -24,7 +24,7 @@ func TestReadSystemviewConfigUseCase_Current(t *testing.T) {
24	24
25	25		func TestReadSystemviewConfigUseCase_Default(t *testing.T) {
26	26		reader := portmocks.NewMockSystemviewConfigReader(t)
27		-	want := port.SystemviewConfigPayload{EngineType: "webkit"}
	27	+	want := dto.SystemviewConfigPayload{EngineType: "webkit"}
28	28		reader.EXPECT().Default(mock.Anything).Return(want, nil).Once()
29	29
30	30		uc := NewReadSystemviewConfigUseCase(reader)


@@ -4,7 +4,7 @@ import (
4		"context"	4		"context"
5		"testing"	5		"testing"
6			6
7	-	"github.com/bnema/dumber/internal/application/port"	7	+	"github.com/bnema/dumber/internal/application/dto"
8		portmocks "github.com/bnema/dumber/internal/application/port/mocks"	8		portmocks "github.com/bnema/dumber/internal/application/port/mocks"
9		"github.com/stretchr/testify/mock"	9		"github.com/stretchr/testify/mock"
10		"github.com/stretchr/testify/require"	10		"github.com/stretchr/testify/require"

@@ -12,7 +12,7 @@ import (
12			12
13		func TestReadSystemviewConfigUseCase_Current(t *testing.T) {	13		func TestReadSystemviewConfigUseCase_Current(t *testing.T) {
14		reader := portmocks.NewMockSystemviewConfigReader(t)	14		reader := portmocks.NewMockSystemviewConfigReader(t)
15	-	want := port.SystemviewConfigPayload{EngineType: "webkit"}	15	+	want := dto.SystemviewConfigPayload{EngineType: "webkit"}
16		reader.EXPECT().Current(mock.Anything).Return(want, nil).Once()	16		reader.EXPECT().Current(mock.Anything).Return(want, nil).Once()
17			17
18		uc := NewReadSystemviewConfigUseCase(reader)	18		uc := NewReadSystemviewConfigUseCase(reader)

@@ -24,7 +24,7 @@ func TestReadSystemviewConfigUseCase_Current(t *testing.T) {
24			24
25		func TestReadSystemviewConfigUseCase_Default(t *testing.T) {	25		func TestReadSystemviewConfigUseCase_Default(t *testing.T) {
26		reader := portmocks.NewMockSystemviewConfigReader(t)	26		reader := portmocks.NewMockSystemviewConfigReader(t)
27	-	want := port.SystemviewConfigPayload{EngineType: "webkit"}	27	+	want := dto.SystemviewConfigPayload{EngineType: "webkit"}
28		reader.EXPECT().Default(mock.Anything).Return(want, nil).Once()	28		reader.EXPECT().Default(mock.Anything).Return(want, nil).Once()
29			29
30		uc := NewReadSystemviewConfigUseCase(reader)	30		uc := NewReadSystemviewConfigUseCase(reader)

M internal/application/usecase/save_webui_config.go +8 -4


@@ -6,6 +6,7 @@ import (
6	6		"math"
7	7		"strings"
8	8
	9	+	"github.com/bnema/dumber/internal/application/dto"
9	10		"github.com/bnema/dumber/internal/application/port"
10	11		"github.com/bnema/dumber/internal/domain/validation"
11	12		)

@@ -18,7 +19,7 @@ func NewSaveWebUIConfigUseCase(saver port.WebUIConfigSaver) *SaveWebUIConfigUseC
18	19		return &SaveWebUIConfigUseCase{saver: saver}
19	20		}
20	21
21		-	func (uc *SaveWebUIConfigUseCase) Execute(ctx context.Context, cfg port.WebUIConfig) error {
	22	+	func (uc *SaveWebUIConfigUseCase) Execute(ctx context.Context, cfg dto.WebUIConfig) error {
22	23		if uc == nil \|\| uc.saver == nil {
23	24		return fmt.Errorf("config saver is nil")
24	25		}

@@ -31,16 +32,19 @@ func (uc *SaveWebUIConfigUseCase) Execute(ctx context.Context, cfg port.WebUICon
31	32		return uc.saver.SaveWebUIConfig(ctx, normalized)
32	33		}
33	34
34		-	func normalizeWebUIConfig(cfg port.WebUIConfig) port.WebUIConfig {
	35	+	func normalizeWebUIConfig(cfg dto.WebUIConfig) dto.WebUIConfig {
35	36		cfg.Appearance.SansFont = strings.TrimSpace(cfg.Appearance.SansFont)
36	37		cfg.Appearance.SerifFont = strings.TrimSpace(cfg.Appearance.SerifFont)
37	38		cfg.Appearance.MonospaceFont = strings.TrimSpace(cfg.Appearance.MonospaceFont)
38	39		cfg.Appearance.ColorScheme = strings.TrimSpace(cfg.Appearance.ColorScheme)
39	40		cfg.DefaultSearchEngine = strings.TrimSpace(cfg.DefaultSearchEngine)
40	41		if len(cfg.SearchShortcuts) > 0 {
41		-	normalized := make(map[string]port.SearchShortcut, len(cfg.SearchShortcuts))
	42	+	normalized := make(map[string]dto.SearchShortcut, len(cfg.SearchShortcuts))
42	43		for key, shortcut := range cfg.SearchShortcuts {
43	44		trimmedKey := strings.TrimSpace(key)
	45	+	if trimmedKey == "" {
	46	+	continue
	47	+	}
44	48		shortcut.URL = strings.TrimSpace(shortcut.URL)
45	49		shortcut.Description = strings.TrimSpace(shortcut.Description)
46	50		normalized[trimmedKey] = shortcut

@@ -50,7 +54,7 @@ func normalizeWebUIConfig(cfg port.WebUIConfig) port.WebUIConfig {
50	54		return cfg
51	55		}
52	56
53		-	func validateWebUIConfig(cfg port.WebUIConfig) error {
	57	+	func validateWebUIConfig(cfg dto.WebUIConfig) error {
54	58		var errs []string
55	59
56	60		if cfg.Appearance.DefaultFontSize < 1 \|\| cfg.Appearance.DefaultFontSize > 72 {

 	"math"
 	"strings"
+	"github.com/bnema/dumber/internal/application/dto"
 	"github.com/bnema/dumber/internal/application/port"
 	"github.com/bnema/dumber/internal/domain/validation"
 )
 	return &SaveWebUIConfigUseCase{saver: saver}
 }
-func (uc *SaveWebUIConfigUseCase) Execute(ctx context.Context, cfg port.WebUIConfig) error {
+func (uc *SaveWebUIConfigUseCase) Execute(ctx context.Context, cfg dto.WebUIConfig) error {
 	if uc == nil || uc.saver == nil {
 		return fmt.Errorf("config saver is nil")
 	}
 	return uc.saver.SaveWebUIConfig(ctx, normalized)
 }
-func normalizeWebUIConfig(cfg port.WebUIConfig) port.WebUIConfig {
+func normalizeWebUIConfig(cfg dto.WebUIConfig) dto.WebUIConfig {
 	cfg.Appearance.SansFont = strings.TrimSpace(cfg.Appearance.SansFont)
 	cfg.Appearance.SerifFont = strings.TrimSpace(cfg.Appearance.SerifFont)
 	cfg.Appearance.MonospaceFont = strings.TrimSpace(cfg.Appearance.MonospaceFont)
 	cfg.Appearance.ColorScheme = strings.TrimSpace(cfg.Appearance.ColorScheme)
 	cfg.DefaultSearchEngine = strings.TrimSpace(cfg.DefaultSearchEngine)
 	if len(cfg.SearchShortcuts) > 0 {
-		normalized := make(map[string]port.SearchShortcut, len(cfg.SearchShortcuts))
+		normalized := make(map[string]dto.SearchShortcut, len(cfg.SearchShortcuts))
 		for key, shortcut := range cfg.SearchShortcuts {
 			trimmedKey := strings.TrimSpace(key)
+			if trimmedKey == "" {
+				continue
+			}
 			shortcut.URL = strings.TrimSpace(shortcut.URL)
 			shortcut.Description = strings.TrimSpace(shortcut.Description)
 			normalized[trimmedKey] = shortcut
 	return cfg
 }
-func validateWebUIConfig(cfg port.WebUIConfig) error {
+func validateWebUIConfig(cfg dto.WebUIConfig) error {
 	var errs []string
 	if cfg.Appearance.DefaultFontSize < 1 || cfg.Appearance.DefaultFontSize > 72 {

M internal/application/usecase/save_webui_config_test.go +17 -22


@@ -5,7 +5,7 @@ import (
5	5		"math"
6	6		"testing"
7	7
8		-	"github.com/bnema/dumber/internal/application/port"
	8	+	"github.com/bnema/dumber/internal/application/dto"
9	9		portmocks "github.com/bnema/dumber/internal/application/port/mocks"
10	10		"github.com/bnema/dumber/internal/application/usecase"
11	11		"github.com/stretchr/testify/mock"

@@ -15,40 +15,33 @@ import (
15	15		func TestSaveWebUIConfigUseCase_Validation(t *testing.T) {
16	16		tests := []struct {
17	17		name string
18		-	mutate func(*port.WebUIConfig)
	18	+	mutate func(*dto.WebUIConfig)
19	19		wantErr string
20	20		}{
21	21		{
22	22		name: "rejects invalid default search URL",
23		-	mutate: func(cfg *port.WebUIConfig) {
	23	+	mutate: func(cfg *dto.WebUIConfig) {
24	24		cfg.DefaultSearchEngine = "not-a-url-%s"
25	25		},
26	26		wantErr: "default_search_engine",
27	27		},
28		-	{
29		-	name: "rejects blank search shortcut key",
30		-	mutate: func(cfg *port.WebUIConfig) {
31		-	cfg.SearchShortcuts[" "] = port.SearchShortcut{URL: "https://example.com?q=%s", Description: "Example"}
32		-	},
33		-	wantErr: "shortcut key cannot be empty",
34		-	},
35	28		{
36	29		name: "rejects invalid performance profile",
37		-	mutate: func(cfg *port.WebUIConfig) {
	30	+	mutate: func(cfg *dto.WebUIConfig) {
38	31		cfg.Performance.Profile = "turbo"
39	32		},
40	33		wantErr: "performance.profile",
41	34		},
42	35		{
43	36		name: "rejects NaN UI scale",
44		-	mutate: func(cfg *port.WebUIConfig) {
	37	+	mutate: func(cfg *dto.WebUIConfig) {
45	38		cfg.DefaultUIScale = math.NaN()
46	39		},
47	40		wantErr: "default_ui_scale must be a finite value",
48	41		},
49	42		{
50	43		name: "rejects infinite UI scale",
51		-	mutate: func(cfg *port.WebUIConfig) {
	44	+	mutate: func(cfg *dto.WebUIConfig) {
52	45		cfg.DefaultUIScale = math.Inf(1)
53	46		},
54	47		wantErr: "default_ui_scale must be a finite value",

@@ -72,25 +65,27 @@ func TestSaveWebUIConfigUseCase_Validation(t *testing.T) {
72	65
73	66		func TestSaveWebUIConfigUseCase_NormalizesAndSavesValidConfig(t *testing.T) {
74	67		saver := portmocks.NewMockWebUIConfigSaver(t)
75		-	var saved port.WebUIConfig
76		-	saver.EXPECT().SaveWebUIConfig(mock.Anything, mock.AnythingOfType("port.WebUIConfig")).Run(func(_ context.Context, cfg port.WebUIConfig) {
	68	+	var saved dto.WebUIConfig
	69	+	saver.EXPECT().SaveWebUIConfig(mock.Anything, mock.AnythingOfType("dto.WebUIConfig")).Run(func(_ context.Context, cfg dto.WebUIConfig) {
77	70		saved = cfg
78	71		}).Return(nil).Once()
79	72		uc := usecase.NewSaveWebUIConfigUseCase(saver)
80	73		cfg := validWebUIConfig()
81		-	cfg.SearchShortcuts[" ddg "] = port.SearchShortcut{URL: " https://duckduckgo.com/?q=%s ", Description: " DuckDuckGo "}
	74	+	cfg.SearchShortcuts[" ddg "] = dto.SearchShortcut{URL: " https://duckduckgo.com/?q=%s ", Description: " DuckDuckGo "}
	75	+	cfg.SearchShortcuts[" "] = dto.SearchShortcut{URL: "https://example.com?q=%s", Description: "Example"}
82	76
83	77		err := uc.Execute(context.Background(), cfg)
84	78
85	79		require.NoError(t, err)
86	80		require.NotContains(t, saved.SearchShortcuts, " ddg ")
	81	+	require.NotContains(t, saved.SearchShortcuts, "")
87	82		require.Contains(t, saved.SearchShortcuts, "ddg")
88	83		require.Equal(t, "https://duckduckgo.com/?q=%s", saved.SearchShortcuts["ddg"].URL)
89	84		require.Equal(t, "DuckDuckGo", saved.SearchShortcuts["ddg"].Description)
90	85		}
91	86
92		-	func validWebUIConfig() port.WebUIConfig {
93		-	palette := port.ColorPalette{
	87	+	func validWebUIConfig() dto.WebUIConfig {
	88	+	palette := dto.ColorPalette{
94	89		Background: "#ffffff",
95	90		Surface: "#f8f8f8",
96	91		SurfaceVariant: "#eeeeee",

@@ -99,8 +94,8 @@ func validWebUIConfig() port.WebUIConfig {
99	94		Accent: "#0055ff",
100	95		Border: "#dddddd",
101	96		}
102		-	return port.WebUIConfig{
103		-	Appearance: port.WebUIAppearanceConfig{
	97	+	return dto.WebUIConfig{
	98	+	Appearance: dto.WebUIAppearanceConfig{
104	99		SansFont: "Inter",
105	100		SerifFont: "Georgia",
106	101		MonospaceFont: "JetBrains Mono",

@@ -109,11 +104,11 @@ func validWebUIConfig() port.WebUIConfig {
109	104		LightPalette: palette,
110	105		DarkPalette: palette,
111	106		},
112		-	Performance: port.WebUIPerformanceConfig{
	107	+	Performance: dto.WebUIPerformanceConfig{
113	108		Profile: "default",
114	109		},
115	110		DefaultUIScale: 1,
116	111		DefaultSearchEngine: "https://duckduckgo.com/?q=%s",
117		-	SearchShortcuts: map[string]port.SearchShortcut{},
	112	+	SearchShortcuts: map[string]dto.SearchShortcut{},
118	113		}
119	114		}

 	"math"
 	"testing"
-	"github.com/bnema/dumber/internal/application/port"
+	"github.com/bnema/dumber/internal/application/dto"
 	portmocks "github.com/bnema/dumber/internal/application/port/mocks"
 	"github.com/bnema/dumber/internal/application/usecase"
 	"github.com/stretchr/testify/mock"
 func TestSaveWebUIConfigUseCase_Validation(t *testing.T) {
 	tests := []struct {
 		name    string
-		mutate  func(*port.WebUIConfig)
+		mutate  func(*dto.WebUIConfig)
 		wantErr string
 	}{
 		{
 			name: "rejects invalid default search URL",
-			mutate: func(cfg *port.WebUIConfig) {
+			mutate: func(cfg *dto.WebUIConfig) {
 				cfg.DefaultSearchEngine = "not-a-url-%s"
 			},
 			wantErr: "default_search_engine",
 		},
-		{
-			name: "rejects blank search shortcut key",
-			mutate: func(cfg *port.WebUIConfig) {
-				cfg.SearchShortcuts[" "] = port.SearchShortcut{URL: "https://example.com?q=%s", Description: "Example"}
-			},
-			wantErr: "shortcut key cannot be empty",
-		},
 		{
 			name: "rejects invalid performance profile",
-			mutate: func(cfg *port.WebUIConfig) {
+			mutate: func(cfg *dto.WebUIConfig) {
 				cfg.Performance.Profile = "turbo"
 			},
 			wantErr: "performance.profile",
 		},
 		{
 			name: "rejects NaN UI scale",
-			mutate: func(cfg *port.WebUIConfig) {
+			mutate: func(cfg *dto.WebUIConfig) {
 				cfg.DefaultUIScale = math.NaN()
 			},
 			wantErr: "default_ui_scale must be a finite value",
 		},
 		{
 			name: "rejects infinite UI scale",
-			mutate: func(cfg *port.WebUIConfig) {
+			mutate: func(cfg *dto.WebUIConfig) {
 				cfg.DefaultUIScale = math.Inf(1)
 			},
 			wantErr: "default_ui_scale must be a finite value",
 func TestSaveWebUIConfigUseCase_NormalizesAndSavesValidConfig(t *testing.T) {
 	saver := portmocks.NewMockWebUIConfigSaver(t)
-	var saved port.WebUIConfig
+	var saved dto.WebUIConfig
-	saver.EXPECT().SaveWebUIConfig(mock.Anything, mock.AnythingOfType("port.WebUIConfig")).Run(func(_ context.Context, cfg port.WebUIConfig) {
+	saver.EXPECT().SaveWebUIConfig(mock.Anything, mock.AnythingOfType("dto.WebUIConfig")).Run(func(_ context.Context, cfg dto.WebUIConfig) {
 		saved = cfg
 	}).Return(nil).Once()
 	uc := usecase.NewSaveWebUIConfigUseCase(saver)
 	cfg := validWebUIConfig()
-	cfg.SearchShortcuts[" ddg "] = port.SearchShortcut{URL: " https://duckduckgo.com/?q=%s ", Description: " DuckDuckGo "}
+	cfg.SearchShortcuts[" ddg "] = dto.SearchShortcut{URL: " https://duckduckgo.com/?q=%s ", Description: " DuckDuckGo "}
+	cfg.SearchShortcuts[" "] = dto.SearchShortcut{URL: "https://example.com?q=%s", Description: "Example"}
 	err := uc.Execute(context.Background(), cfg)
 	require.NoError(t, err)
 	require.NotContains(t, saved.SearchShortcuts, " ddg ")
+	require.NotContains(t, saved.SearchShortcuts, "")
 	require.Contains(t, saved.SearchShortcuts, "ddg")
 	require.Equal(t, "https://duckduckgo.com/?q=%s", saved.SearchShortcuts["ddg"].URL)
 	require.Equal(t, "DuckDuckGo", saved.SearchShortcuts["ddg"].Description)
 }
-func validWebUIConfig() port.WebUIConfig {
+func validWebUIConfig() dto.WebUIConfig {
-	palette := port.ColorPalette{
+	palette := dto.ColorPalette{
 		Background:     "#ffffff",
 		Surface:        "#f8f8f8",
 		SurfaceVariant: "#eeeeee",
 		Accent:         "#0055ff",
 		Border:         "#dddddd",
 	}
-	return port.WebUIConfig{
+	return dto.WebUIConfig{
-		Appearance: port.WebUIAppearanceConfig{
+		Appearance: dto.WebUIAppearanceConfig{
 			SansFont:        "Inter",
 			SerifFont:       "Georgia",
 			MonospaceFont:   "JetBrains Mono",
 			LightPalette:    palette,
 			DarkPalette:     palette,
 		},
-		Performance: port.WebUIPerformanceConfig{
+		Performance: dto.WebUIPerformanceConfig{
 			Profile: "default",
 		},
 		DefaultUIScale:      1,
 		DefaultSearchEngine: "https://duckduckgo.com/?q=%s",
-		SearchShortcuts:     map[string]port.SearchShortcut{},
+		SearchShortcuts:     map[string]dto.SearchShortcut{},
 	}
 }

M internal/application/usecase/search_history_test.go +6 -9


@@ -155,8 +155,10 @@ func TestSearchHistoryUseCase_GetMostVisited_ReturnsEmptyWhenNoHistory(t *testin
155	155		func TestSearchHistoryUseCase_ClearRange_RecentRangeDeletesSinceCutoff(t *testing.T) {
156	156		ctx := testContext()
157	157		historyRepo := repomocks.NewMockHistoryRepository(t)
	158	+	now := time.Now()
	159	+	expectedCutoff := now.Add(-time.Hour)
158	160		historyRepo.EXPECT().DeleteSince(mock.Anything, mock.MatchedBy(func(since time.Time) bool {
159		-	return !since.IsZero() && time.Since(since) <= time.Hour+time.Minute
	161	+	return since.After(expectedCutoff.Add(-time.Minute)) && since.Before(expectedCutoff.Add(time.Minute))
160	162		})).Return(nil).Once()
161	163
162	164		uc := usecase.NewSearchHistoryUseCase(historyRepo)

@@ -168,15 +170,10 @@ func TestSearchHistoryUseCase_ClearRange_RecentRangeDeletesSinceCutoff(t *testin
168	170		func TestSearchHistoryUseCase_ClearRange_TodayDeletesSinceLocalMidnight(t *testing.T) {
169	171		ctx := testContext()
170	172		historyRepo := repomocks.NewMockHistoryRepository(t)
171		-	today := time.Now()
	173	+	now := time.Now()
	174	+	expectedCutoff := time.Date(now.Year(), now.Month(), now.Day(), 0, 0, 0, 0, now.Location())
172	175		historyRepo.EXPECT().DeleteSince(mock.Anything, mock.MatchedBy(func(since time.Time) bool {
173		-	return since.Year() == today.Year() &&
174		-	since.Month() == today.Month() &&
175		-	since.Day() == today.Day() &&
176		-	since.Hour() == 0 &&
177		-	since.Minute() == 0 &&
178		-	since.Second() == 0 &&
179		-	since.Nanosecond() == 0
	176	+	return since.Equal(expectedCutoff)
180	177		})).Return(nil).Once()
181	178
182	179		uc := usecase.NewSearchHistoryUseCase(historyRepo)

 func TestSearchHistoryUseCase_ClearRange_RecentRangeDeletesSinceCutoff(t *testing.T) {
 	ctx := testContext()
 	historyRepo := repomocks.NewMockHistoryRepository(t)
+	now := time.Now()
+	expectedCutoff := now.Add(-time.Hour)
 	historyRepo.EXPECT().DeleteSince(mock.Anything, mock.MatchedBy(func(since time.Time) bool {
-		return !since.IsZero() && time.Since(since) <= time.Hour+time.Minute
+		return since.After(expectedCutoff.Add(-time.Minute)) && since.Before(expectedCutoff.Add(time.Minute))
 	})).Return(nil).Once()
 	uc := usecase.NewSearchHistoryUseCase(historyRepo)
 func TestSearchHistoryUseCase_ClearRange_TodayDeletesSinceLocalMidnight(t *testing.T) {
 	ctx := testContext()
 	historyRepo := repomocks.NewMockHistoryRepository(t)
-	today := time.Now()
+	now := time.Now()
+	expectedCutoff := time.Date(now.Year(), now.Month(), now.Day(), 0, 0, 0, 0, now.Location())
 	historyRepo.EXPECT().DeleteSince(mock.Anything, mock.MatchedBy(func(since time.Time) bool {
-		return since.Year() == today.Year() &&
+		return since.Equal(expectedCutoff)
-			since.Month() == today.Month() &&
-			since.Day() == today.Day() &&
-			since.Hour() == 0 &&
-			since.Minute() == 0 &&
-			since.Second() == 0 &&
-			since.Nanosecond() == 0
 	})).Return(nil).Once()
 	uc := usecase.NewSearchHistoryUseCase(historyRepo)

M internal/bootstrap/engine.go +2 -1


@@ -5,6 +5,7 @@ import (
5	5		"encoding/json"
6	6		"fmt"
7	7
	8	+	"github.com/bnema/dumber/internal/application/dto"
8	9		"github.com/bnema/dumber/internal/application/port"
9	10		"github.com/bnema/dumber/internal/application/usecase"
10	11		audiofactory "github.com/bnema/dumber/internal/infrastructure/audio/factory"

@@ -35,7 +36,7 @@ func BuildEngine(input EngineInput) (port.Engine, error) {
35	36		cfg := input.Config
36	37		systemviewReader := config.NewSystemviewConfigReader(env.NewHardwareSurveyor())
37	38		systemviewUC := usecase.NewReadSystemviewConfigUseCase(systemviewReader)
38		-	buildConfigPayload := func(read func(context.Context) (port.SystemviewConfigPayload, error)) func() ([]byte, error) {
	39	+	buildConfigPayload := func(read func(context.Context) (dto.SystemviewConfigPayload, error)) func() ([]byte, error) {
39	40		return func() ([]byte, error) {
40	41		payload, err := read(input.Ctx)
41	42		if err != nil {

 	"encoding/json"
 	"fmt"
+	"github.com/bnema/dumber/internal/application/dto"
 	"github.com/bnema/dumber/internal/application/port"
 	"github.com/bnema/dumber/internal/application/usecase"
 	audiofactory "github.com/bnema/dumber/internal/infrastructure/audio/factory"
 	cfg := input.Config
 	systemviewReader := config.NewSystemviewConfigReader(env.NewHardwareSurveyor())
 	systemviewUC := usecase.NewReadSystemviewConfigUseCase(systemviewReader)
-	buildConfigPayload := func(read func(context.Context) (port.SystemviewConfigPayload, error)) func() ([]byte, error) {
+	buildConfigPayload := func(read func(context.Context) (dto.SystemviewConfigPayload, error)) func() ([]byte, error) {
 		return func() ([]byte, error) {
 			payload, err := read(input.Ctx)
 			if err != nil {

M internal/infrastructure/cef/scheme_handler.go +3 -4


@@ -279,10 +279,6 @@ func (h *dumbSchemeHandler) handleTranscodeAPI(request purecef.Request) purecef.
279	279		if err != nil \|\| sourceParsed.Host == "" \|\| (sourceParsed.Scheme != "http" && sourceParsed.Scheme != actualInternalScheme) {
280	280		return h.newAPIJSONResourceHandler(http.StatusBadRequest, map[string]string{"error": "invalid src"})
281	281		}
282		-	if err := validateTranscodeSourceURL(h.ctx, sourceParsed); err != nil {
283		-	return h.newAPIJSONResourceHandler(http.StatusForbidden, map[string]string{"error": err.Error()})
284		-	}
285		-
286	282		headers := make(map[string]string)
287	283		if userAgent := request.GetHeaderByName("User-Agent"); userAgent != "" {
288	284		headers["User-Agent"] = userAgent

@@ -308,6 +304,9 @@ func (h *dumbSchemeHandler) handleTranscodeAPI(request purecef.Request) purecef.
308	304		headers: headers,
309	305		ctx: ctx,
310	306		cancel: cancel,
	307	+	validateSource: func(ctx context.Context) error {
	308	+	return validateTranscodeSourceURL(ctx, sourceParsed)
	309	+	},
311	310		logf: func() zerolog.Logger {
312	311		return h.logger.With().Str("component", "scheme-transcoding").Logger()
313	312		},

 	if err != nil || sourceParsed.Host == "" || (sourceParsed.Scheme != "http" && sourceParsed.Scheme != actualInternalScheme) {
 		return h.newAPIJSONResourceHandler(http.StatusBadRequest, map[string]string{"error": "invalid src"})
 	}
-	if err := validateTranscodeSourceURL(h.ctx, sourceParsed); err != nil {
-		return h.newAPIJSONResourceHandler(http.StatusForbidden, map[string]string{"error": err.Error()})
-	}
 	headers := make(map[string]string)
 	if userAgent := request.GetHeaderByName("User-Agent"); userAgent != "" {
 		headers["User-Agent"] = userAgent
 		headers:    headers,
 		ctx:        ctx,
 		cancel:     cancel,
+		validateSource: func(ctx context.Context) error {
+			return validateTranscodeSourceURL(ctx, sourceParsed)
+		},
 		logf: func() zerolog.Logger {
 			return h.logger.With().Str("component", "scheme-transcoding").Logger()
 		},

M internal/infrastructure/cef/transcoding_handler.go +68 -12


@@ -24,6 +24,8 @@ var _ purecef.ResourceRequestHandler = (*transcodingRequestHandler)(nil)
24	24		const (
25	25		maxTranscodingURLLength = 240
26	26		httpStatusOK = 200
	27	+	httpStatusForbidden = 403
	28	+	httpStatusBadGateway = 502
27	29		)
28	30
29	31		// transcodingResourceHandler is checked indirectly: purecef.NewResourceHandler

@@ -34,14 +36,18 @@ const (
34	36		// ---------------------------------------------------------------------------
35	37
36	38		type transcodingResourceHandler struct {
37		-	transcoder port.MediaTranscoder
38		-	sourceURL string
39		-	headers map[string]string
40		-	session port.TranscodeSession
41		-	ctx context.Context
42		-	cancel context.CancelFunc
43		-	logf func() zerolog.Logger
44		-	totalBytes int64
	39	+	transcoder port.MediaTranscoder
	40	+	sourceURL string
	41	+	headers map[string]string
	42	+	session port.TranscodeSession
	43	+	ctx context.Context
	44	+	cancel context.CancelFunc
	45	+	logf func() zerolog.Logger
	46	+	validateSource func(context.Context) error
	47	+	mu sync.Mutex
	48	+	startErr error
	49	+	startErrStatus int
	50	+	totalBytes int64
45	51		}
46	52
47	53		// Open starts the transcode session asynchronously. CEF will call

@@ -62,6 +68,18 @@ func (rh *transcodingResourceHandler) Open(
62	68		Msg("cef: starting transcoding resource stream")
63	69
64	70		go func() {
	71	+	if rh.validateSource != nil {
	72	+	if err := rh.validateSource(rh.ctx); err != nil {
	73	+	log.Warn().
	74	+	Err(err).
	75	+	Str("source_url", sourceURL).
	76	+	Msg("cef: rejected transcoding source")
	77	+	rh.setStartErr(err, httpStatusForbidden)
	78	+	callback.Cont()
	79	+	return
	80	+	}
	81	+	}
	82	+
65	83		session, err := rh.transcoder.Start(rh.ctx, rh.sourceURL, rh.headers)
66	84		if err != nil {
67	85		log.Error().

@@ -69,11 +87,14 @@ func (rh *transcodingResourceHandler) Open(
69	87		Str("source_url", sourceURL).
70	88		Msg("cef: failed to start transcoding resource stream")
71	89		// Let CEF know we failed — Cancel will be called.
	90	+	rh.setStartErr(err, httpStatusBadGateway)
72	91		rh.cancel()
73	92		callback.Cont()
74	93		return
75	94		}
	95	+	rh.mu.Lock()
76	96		rh.session = session
	97	+	rh.mu.Unlock()
77	98		log.Info().
78	99		Str("source_url", sourceURL).
79	100		Str("content_type", session.ContentType()).

@@ -84,10 +105,39 @@ func (rh *transcodingResourceHandler) Open(
84	105		return 1
85	106		}
86	107
	108	+	func (rh *transcodingResourceHandler) setStartErr(err error, status int) {
	109	+	rh.mu.Lock()
	110	+	defer rh.mu.Unlock()
	111	+	rh.startErr = err
	112	+	rh.startErrStatus = status
	113	+	}
	114	+
	115	+	func (rh *transcodingResourceHandler) getStartErr() (error, int) {
	116	+	rh.mu.Lock()
	117	+	defer rh.mu.Unlock()
	118	+	return rh.startErr, rh.startErrStatus
	119	+	}
	120	+
87	121		// GetResponseHeaders sets the streaming response metadata.
88	122		func (rh *transcodingResourceHandler) GetResponseHeaders(
89	123		response purecef.Response, responseLength *int64, _ uintptr,
90	124		) {
	125	+	if startErr, status := rh.getStartErr(); startErr != nil {
	126	+	if status == 0 {
	127	+	status = httpStatusBadGateway
	128	+	}
	129	+	response.SetStatus(int32(status))
	130	+	if status == httpStatusForbidden {
	131	+	response.SetStatusText("Forbidden")
	132	+	} else {
	133	+	response.SetStatusText("Bad Gateway")
	134	+	}
	135	+	response.SetMimeType("text/plain")
	136	+	if responseLength != nil {
	137	+	*responseLength = 0
	138	+	}
	139	+	return
	140	+	}
91	141		response.SetStatus(httpStatusOK)
92	142		response.SetStatusText("OK")
93	143		response.SetMimeType("video/webm")

@@ -108,12 +158,15 @@ func (rh *transcodingResourceHandler) Read(
108	158		dataOut unsafe.Pointer, bytesToRead int32,
109	159		bytesRead *int32, _ purecef.ResourceReadCallback,
110	160		) int32 {
111		-	if rh.session == nil {
	161	+	rh.mu.Lock()
	162	+	session := rh.session
	163	+	rh.mu.Unlock()
	164	+	if session == nil {
112	165		return 0
113	166		}
114	167
115	168		dst := unsafe.Slice((*byte)(dataOut), int(bytesToRead))
116		-	n, err := rh.session.Read(dst)
	169	+	n, err := session.Read(dst)
117	170		if n > 0 {
118	171		rh.totalBytes += int64(n)
119	172		if rh.totalBytes == int64(n) {

@@ -153,8 +206,11 @@ func (rh *transcodingResourceHandler) Cancel() {
153	206		Str("source_url", sourceURL).
154	207		Int64("total_bytes", rh.totalBytes).
155	208		Msg("cef: transcoding resource stream canceled")
156		-	if rh.session != nil {
157		-	if err := rh.session.Close(); err != nil {
	209	+	rh.mu.Lock()
	210	+	session := rh.session
	211	+	rh.mu.Unlock()
	212	+	if session != nil {
	213	+	if err := session.Close(); err != nil {
158	214		rh.logger().Warn().
159	215		Str("source_url", sourceURL).
160	216		Err(err).

 const (
 	maxTranscodingURLLength = 240
 	httpStatusOK            = 200
+	httpStatusForbidden     = 403
+	httpStatusBadGateway    = 502
 )
 // transcodingResourceHandler is checked indirectly: purecef.NewResourceHandler
 // ---------------------------------------------------------------------------
 type transcodingResourceHandler struct {
-	transcoder port.MediaTranscoder
+	transcoder     port.MediaTranscoder
-	sourceURL  string
+	sourceURL      string
-	headers    map[string]string
+	headers        map[string]string
-	session    port.TranscodeSession
+	session        port.TranscodeSession
-	ctx        context.Context
+	ctx            context.Context
-	cancel     context.CancelFunc
+	cancel         context.CancelFunc
-	logf       func() zerolog.Logger
+	logf           func() zerolog.Logger
-	totalBytes int64
+	validateSource func(context.Context) error
+	mu             sync.Mutex
+	startErr       error
+	startErrStatus int
+	totalBytes     int64
 }
 // Open starts the transcode session asynchronously. CEF will call
 		Msg("cef: starting transcoding resource stream")
 	go func() {
+		if rh.validateSource != nil {
+			if err := rh.validateSource(rh.ctx); err != nil {
+				log.Warn().
+					Err(err).
+					Str("source_url", sourceURL).
+					Msg("cef: rejected transcoding source")
+				rh.setStartErr(err, httpStatusForbidden)
+				callback.Cont()
+				return
+			}
+		}
 		session, err := rh.transcoder.Start(rh.ctx, rh.sourceURL, rh.headers)
 		if err != nil {
 			log.Error().
 				Str("source_url", sourceURL).
 				Msg("cef: failed to start transcoding resource stream")
 			// Let CEF know we failed — Cancel will be called.
+			rh.setStartErr(err, httpStatusBadGateway)
 			rh.cancel()
 			callback.Cont()
 			return
 		}
+		rh.mu.Lock()
 		rh.session = session
+		rh.mu.Unlock()
 		log.Info().
 			Str("source_url", sourceURL).
 			Str("content_type", session.ContentType()).
 	return 1
 }
+func (rh *transcodingResourceHandler) setStartErr(err error, status int) {
+	rh.mu.Lock()
+	defer rh.mu.Unlock()
+	rh.startErr = err
+	rh.startErrStatus = status
+}
+func (rh *transcodingResourceHandler) getStartErr() (error, int) {
+	rh.mu.Lock()
+	defer rh.mu.Unlock()
+	return rh.startErr, rh.startErrStatus
+}
 // GetResponseHeaders sets the streaming response metadata.
 func (rh *transcodingResourceHandler) GetResponseHeaders(
 	response purecef.Response, responseLength *int64, _ uintptr,
 ) {
+	if startErr, status := rh.getStartErr(); startErr != nil {
+		if status == 0 {
+			status = httpStatusBadGateway
+		}
+		response.SetStatus(int32(status))
+		if status == httpStatusForbidden {
+			response.SetStatusText("Forbidden")
+		} else {
+			response.SetStatusText("Bad Gateway")
+		}
+		response.SetMimeType("text/plain")
+		if responseLength != nil {
+			*responseLength = 0
+		}
+		return
+	}
 	response.SetStatus(httpStatusOK)
 	response.SetStatusText("OK")
 	response.SetMimeType("video/webm")
 	dataOut unsafe.Pointer, bytesToRead int32,
 	bytesRead *int32, _ purecef.ResourceReadCallback,
 ) int32 {
-	if rh.session == nil {
+	rh.mu.Lock()
+	session := rh.session
+	rh.mu.Unlock()
+	if session == nil {
 		return 0
 	}
 	dst := unsafe.Slice((*byte)(dataOut), int(bytesToRead))
-	n, err := rh.session.Read(dst)
+	n, err := session.Read(dst)
 	if n > 0 {
 		rh.totalBytes += int64(n)
 		if rh.totalBytes == int64(n) {
 		Str("source_url", sourceURL).
 		Int64("total_bytes", rh.totalBytes).
 		Msg("cef: transcoding resource stream canceled")
-	if rh.session != nil {
+	rh.mu.Lock()
-		if err := rh.session.Close(); err != nil {
+	session := rh.session
+	rh.mu.Unlock()
+	if session != nil {
+		if err := session.Close(); err != nil {
 			rh.logger().Warn().
 				Str("source_url", sourceURL).
 				Err(err).

M internal/infrastructure/config/defaults_test.go +4 -0


@@ -41,5 +41,9 @@ func requireActionBinding(t *testing.T, actions map[string]ActionBinding, action
41	41		t.Helper()
42	42		binding, ok := actions[action]
43	43		require.True(t, ok, "missing action binding %q", action)
	44	+	if len(keys) == 0 {
	45	+	assert.Empty(t, binding.Keys)
	46	+	return
	47	+	}
44	48		assert.Equal(t, keys, binding.Keys)
45	49		}


@@ -41,5 +41,9 @@ func requireActionBinding(t *testing.T, actions map[string]ActionBinding, action
41	t.Helper()	41		t.Helper()
42	binding, ok := actions[action]	42		binding, ok := actions[action]
43	require.True(t, ok, "missing action binding %q", action)	43		require.True(t, ok, "missing action binding %q", action)
		44	+	if len(keys) == 0 {
		45	+	assert.Empty(t, binding.Keys)
		46	+	return
		47	+	}
44	assert.Equal(t, keys, binding.Keys)	48		assert.Equal(t, keys, binding.Keys)
45	}	49		}

M internal/infrastructure/config/migrate.go +8 -0


@@ -777,6 +777,10 @@ func (m *Migrator) detectMissingWorkspaceShortcutActions(userKeysWithValues map[
777	777		if _, exists := userActions[actionName]; exists {
778	778		continue
779	779		}
	780	+	legacyActionName := strings.ReplaceAll(actionName, "-", "_")
	781	+	if _, exists := userActions[legacyActionName]; exists {
	782	+	continue
	783	+	}
780	784		missing = append(missing, workspaceShortcutsActionsKey+"."+actionName)
781	785		}
782	786

@@ -801,6 +805,10 @@ func (m *Migrator) mergeMissingWorkspaceShortcutActions(rawConfig map[string]any
801	805		if _, exists := userActions[actionName]; exists {
802	806		continue
803	807		}
	808	+	legacyActionName := strings.ReplaceAll(actionName, "-", "_")
	809	+	if _, exists := userActions[legacyActionName]; exists {
	810	+	continue
	811	+	}
804	812		userActions[actionName] = defaultAction
805	813		}
806	814


@@ -777,6 +777,10 @@ func (m *Migrator) detectMissingWorkspaceShortcutActions(userKeysWithValues map[
777	if _, exists := userActions[actionName]; exists {	777		if _, exists := userActions[actionName]; exists {
778	continue	778		continue
779	}	779		}
		780	+	legacyActionName := strings.ReplaceAll(actionName, "-", "_")
		781	+	if _, exists := userActions[legacyActionName]; exists {
		782	+	continue
		783	+	}
780	missing = append(missing, workspaceShortcutsActionsKey+"."+actionName)	784		missing = append(missing, workspaceShortcutsActionsKey+"."+actionName)
781	}	785		}
782		786

@@ -801,6 +805,10 @@ func (m *Migrator) mergeMissingWorkspaceShortcutActions(rawConfig map[string]any
801	if _, exists := userActions[actionName]; exists {	805		if _, exists := userActions[actionName]; exists {
802	continue	806		continue
803	}	807		}
		808	+	legacyActionName := strings.ReplaceAll(actionName, "-", "_")
		809	+	if _, exists := userActions[legacyActionName]; exists {
		810	+	continue
		811	+	}
804	userActions[actionName] = defaultAction	812		userActions[actionName] = defaultAction
805	}	813		}
806		814

M internal/infrastructure/config/migrate_test.go +7 -0


@@ -759,6 +759,13 @@ func TestMigrator_MergeMissingWorkspaceShortcutActions(t *testing.T) {
759	759		closePane, ok := closePaneAny.(map[string]any)
760	760		require.True(t, ok)
761	761		assert.Equal(t, "Custom close pane", closePane["desc"])
	762	+	assert.NotContains(t, actions, "close-pane")
	763	+	assert.NotContains(t, actions, "next-tab")
	764	+	assert.NotContains(t, actions, "previous-tab")
	765	+	assert.NotContains(t, actions, "consume-or-expel-left")
	766	+	assert.NotContains(t, actions, "consume-or-expel-right")
	767	+	assert.NotContains(t, actions, "consume-or-expel-up")
	768	+	assert.NotContains(t, actions, "consume-or-expel-down")
762	769		}
763	770
764	771		func TestMigrator_DefaultValueForKey_WorkspaceShortcutAction(t *testing.T) {


@@ -759,6 +759,13 @@ func TestMigrator_MergeMissingWorkspaceShortcutActions(t *testing.T) {
759	closePane, ok := closePaneAny.(map[string]any)	759		closePane, ok := closePaneAny.(map[string]any)
760	require.True(t, ok)	760		require.True(t, ok)
761	assert.Equal(t, "Custom close pane", closePane["desc"])	761		assert.Equal(t, "Custom close pane", closePane["desc"])
		762	+	assert.NotContains(t, actions, "close-pane")
		763	+	assert.NotContains(t, actions, "next-tab")
		764	+	assert.NotContains(t, actions, "previous-tab")
		765	+	assert.NotContains(t, actions, "consume-or-expel-left")
		766	+	assert.NotContains(t, actions, "consume-or-expel-right")
		767	+	assert.NotContains(t, actions, "consume-or-expel-up")
		768	+	assert.NotContains(t, actions, "consume-or-expel-down")
762	}	769		}
763		770
764	func TestMigrator_DefaultValueForKey_WorkspaceShortcutAction(t *testing.T) {	771		func TestMigrator_DefaultValueForKey_WorkspaceShortcutAction(t *testing.T) {

M internal/infrastructure/config/systemview_reader.go +5 -4


@@ -3,6 +3,7 @@ package config
3	3		import (
4	4		"context"
5	5
	6	+	"github.com/bnema/dumber/internal/application/dto"
6	7		"github.com/bnema/dumber/internal/application/port"
7	8		)
8	9

@@ -17,17 +18,17 @@ func NewSystemviewConfigReader(hwSurveyor port.HardwareSurveyor) port.Systemview
17	18		return &systemviewConfigReader{hwSurveyor: hwSurveyor}
18	19		}
19	20
20		-	func (r *systemviewConfigReader) Current(ctx context.Context) (port.SystemviewConfigPayload, error) {
	21	+	func (r *systemviewConfigReader) Current(ctx context.Context) (dto.SystemviewConfigPayload, error) {
21	22		return r.build(ctx, Get())
22	23		}
23	24
24		-	func (r *systemviewConfigReader) Default(ctx context.Context) (port.SystemviewConfigPayload, error) {
	25	+	func (r *systemviewConfigReader) Default(ctx context.Context) (dto.SystemviewConfigPayload, error) {
25	26		return r.build(ctx, DefaultConfig())
26	27		}
27	28
28		-	func (r systemviewConfigReader) build(ctx context.Context, cfg Config) (port.SystemviewConfigPayload, error) {
	29	+	func (r systemviewConfigReader) build(ctx context.Context, cfg Config) (dto.SystemviewConfigPayload, error) {
29	30		if cfg == nil {
30		-	return port.SystemviewConfigPayload{}, nil
	31	+	return dto.SystemviewConfigPayload{}, nil
31	32		}
32	33
33	34		var hw *port.HardwareInfo

 import (
 	"context"
+	"github.com/bnema/dumber/internal/application/dto"
 	"github.com/bnema/dumber/internal/application/port"
 )
 	return &systemviewConfigReader{hwSurveyor: hwSurveyor}
 }
-func (r *systemviewConfigReader) Current(ctx context.Context) (port.SystemviewConfigPayload, error) {
+func (r *systemviewConfigReader) Current(ctx context.Context) (dto.SystemviewConfigPayload, error) {
 	return r.build(ctx, Get())
 }
-func (r *systemviewConfigReader) Default(ctx context.Context) (port.SystemviewConfigPayload, error) {
+func (r *systemviewConfigReader) Default(ctx context.Context) (dto.SystemviewConfigPayload, error) {
 	return r.build(ctx, DefaultConfig())
 }
-func (r *systemviewConfigReader) build(ctx context.Context, cfg *Config) (port.SystemviewConfigPayload, error) {
+func (r *systemviewConfigReader) build(ctx context.Context, cfg *Config) (dto.SystemviewConfigPayload, error) {
 	if cfg == nil {
-		return port.SystemviewConfigPayload{}, nil
+		return dto.SystemviewConfigPayload{}, nil
 	}
 	var hw *port.HardwareInfo

M internal/infrastructure/config/webui_gateway.go +2 -2


@@ -4,7 +4,7 @@ import (
4	4		"context"
5	5		"fmt"
6	6
7		-	"github.com/bnema/dumber/internal/application/port"
	7	+	"github.com/bnema/dumber/internal/application/dto"
8	8		)
9	9
10	10		type WebUIConfigGateway struct {

@@ -33,7 +33,7 @@ func clampInt(v, lo, hi int) int {
33	33		return v
34	34		}
35	35
36		-	func (g *WebUIConfigGateway) SaveWebUIConfig(ctx context.Context, cfg port.WebUIConfig) error {
	36	+	func (g *WebUIConfigGateway) SaveWebUIConfig(ctx context.Context, cfg dto.WebUIConfig) error {
37	37		_ = ctx
38	38		if g == nil \|\| g.mgr == nil {
39	39		return fmt.Errorf("config manager not initialized")


@@ -4,7 +4,7 @@ import (
4		"context"	4		"context"
5		"fmt"	5		"fmt"
6			6
7	-	"github.com/bnema/dumber/internal/application/port"	7	+	"github.com/bnema/dumber/internal/application/dto"
8		)	8		)
9			9
10		type WebUIConfigGateway struct {	10		type WebUIConfigGateway struct {

@@ -33,7 +33,7 @@ func clampInt(v, lo, hi int) int {
33		return v	33		return v
34		}	34		}
35			35
36	-	func (g *WebUIConfigGateway) SaveWebUIConfig(ctx context.Context, cfg port.WebUIConfig) error {	36	+	func (g *WebUIConfigGateway) SaveWebUIConfig(ctx context.Context, cfg dto.WebUIConfig) error {
37		_ = ctx	37		_ = ctx
38		if g == nil \|\| g.mgr == nil {	38		if g == nil \|\| g.mgr == nil {
39		return fmt.Errorf("config manager not initialized")	39		return fmt.Errorf("config manager not initialized")

M internal/infrastructure/config/webui_payload.go +21 -18

@@ -1,12 +1,15 @@
1	1		package config
2	2
3		-	import "github.com/bnema/dumber/internal/application/port"
	3	+	import (
	4	+	"github.com/bnema/dumber/internal/application/dto"
	5	+	"github.com/bnema/dumber/internal/application/port"
	6	+	)
4	7
5	8		// BuildSystemviewConfigPayload projects the full config into the stable DTO used by
6	9		// the settings page across engines.
7		-	func BuildSystemviewConfigPayload(cfg Config, hw port.HardwareInfo) port.SystemviewConfigPayload {
8		-	payload := port.SystemviewConfigPayload{
9		-	SearchShortcuts: map[string]port.SearchShortcut{},
	10	+	func BuildSystemviewConfigPayload(cfg Config, hw port.HardwareInfo) dto.SystemviewConfigPayload {
	11	+	payload := dto.SystemviewConfigPayload{
	12	+	SearchShortcuts: map[string]dto.SearchShortcut{},
10	13		}
11	14		if cfg == nil {
12	15		return payload

@@ -20,16 +23,16 @@ func BuildSystemviewConfigPayload(cfg Config, hw port.HardwareInfo) port.Syste
20	23		payload.DefaultSearchEngine = cfg.DefaultSearchEngine
21	24		payload.SearchShortcuts = buildSystemviewSearchShortcutsPayload(cfg.SearchShortcuts)
22	25		payload.EngineType = cfg.Engine.ResolveEngineType()
23		-	payload.Performance = port.SystemviewPerformancePayload{
	26	+	payload.Performance = dto.SystemviewPerformancePayload{
24	27		Profile: string(cfg.Engine.Profile),
25		-	Custom: port.SystemviewCustomPerformancePayload{
	28	+	Custom: dto.SystemviewCustomPerformancePayload{
26	29		SkiaCPUThreads: cfg.Engine.WebKit.SkiaCPUPaintingThreads,
27	30		SkiaGPUThreads: cfg.Engine.WebKit.SkiaGPUPaintingThreads,
28	31		WebProcessMemoryMB: cfg.Engine.WebKit.WebProcessMemoryLimitMB,
29	32		NetworkProcessMemoryMB: cfg.Engine.WebKit.NetworkProcessMemoryLimitMB,
30	33		WebViewPoolPrewarm: cfg.Engine.PoolPrewarmCount,
31	34		},
32		-	Resolved: port.SystemviewResolvedPerformancePayload{
	35	+	Resolved: dto.SystemviewResolvedPerformancePayload{
33	36		SkiaCPUThreads: resolved.SkiaCPUPaintingThreads,
34	37		SkiaGPUThreads: resolved.SkiaGPUPaintingThreads,
35	38		WebProcessMemoryMB: resolved.WebProcessMemoryLimitMB,

@@ -44,9 +47,9 @@ func BuildSystemviewConfigPayload(cfg Config, hw port.HardwareInfo) port.Syste
44	47		return payload
45	48		}
46	49
47		-	func buildSystemviewAppearancePayload(appearance AppearanceConfig) port.WebUIAppearanceConfig {
	50	+	func buildSystemviewAppearancePayload(appearance AppearanceConfig) dto.WebUIAppearanceConfig {
48	51		defaults := DefaultConfig().Appearance
49		-	return port.WebUIAppearanceConfig{
	52	+	return dto.WebUIAppearanceConfig{
50	53		SansFont: appearance.SansFont,
51	54		SerifFont: appearance.SerifFont,
52	55		MonospaceFont: appearance.MonospaceFont,

@@ -57,8 +60,8 @@ func buildSystemviewAppearancePayload(appearance AppearanceConfig) port.WebUIApp
57	60		}
58	61		}
59	62
60		-	func buildSystemviewPalettePayload(palette, fallback ColorPalette) port.ColorPalette {
61		-	return port.ColorPalette{
	63	+	func buildSystemviewPalettePayload(palette, fallback ColorPalette) dto.ColorPalette {
	64	+	return dto.ColorPalette{
62	65		Background: nonEmptyColor(palette.Background, fallback.Background),
63	66		Surface: nonEmptyColor(palette.Surface, fallback.Surface),
64	67		SurfaceVariant: nonEmptyColor(palette.SurfaceVariant, fallback.SurfaceVariant),

@@ -76,23 +79,23 @@ func nonEmptyColor(value, fallback string) string {
76	79		return fallback
77	80		}
78	81
79		-	func buildSystemviewSearchShortcutsPayload(shortcuts map[string]SearchShortcut) map[string]port.SearchShortcut {
	82	+	func buildSystemviewSearchShortcutsPayload(shortcuts map[string]SearchShortcut) map[string]dto.SearchShortcut {
80	83		if len(shortcuts) == 0 {
81		-	return map[string]port.SearchShortcut{}
	84	+	return map[string]dto.SearchShortcut{}
82	85		}
83	86
84		-	result := make(map[string]port.SearchShortcut, len(shortcuts))
	87	+	result := make(map[string]dto.SearchShortcut, len(shortcuts))
85	88		for key, shortcut := range shortcuts {
86		-	result[key] = port.SearchShortcut{URL: shortcut.URL, Description: shortcut.Description}
	89	+	result[key] = dto.SearchShortcut{URL: shortcut.URL, Description: shortcut.Description}
87	90		}
88	91		return result
89	92		}
90	93
91		-	func buildSystemviewHardwarePayload(hw *port.HardwareInfo) port.SystemviewHardwarePayload {
	94	+	func buildSystemviewHardwarePayload(hw *port.HardwareInfo) dto.SystemviewHardwarePayload {
92	95		if hw == nil {
93		-	return port.SystemviewHardwarePayload{}
	96	+	return dto.SystemviewHardwarePayload{}
94	97		}
95		-	return port.SystemviewHardwarePayload{
	98	+	return dto.SystemviewHardwarePayload{
96	99		CPUCores: hw.CPUCores,
97	100		CPUThreads: hw.CPUThreads,
98	101		TotalRAMMB: hw.TotalRAMMB(),

 package config
-import "github.com/bnema/dumber/internal/application/port"
+import (
+	"github.com/bnema/dumber/internal/application/dto"
+	"github.com/bnema/dumber/internal/application/port"
+)
 // BuildSystemviewConfigPayload projects the full config into the stable DTO used by
 // the settings page across engines.
-func BuildSystemviewConfigPayload(cfg *Config, hw *port.HardwareInfo) port.SystemviewConfigPayload {
+func BuildSystemviewConfigPayload(cfg *Config, hw *port.HardwareInfo) dto.SystemviewConfigPayload {
-	payload := port.SystemviewConfigPayload{
+	payload := dto.SystemviewConfigPayload{
-		SearchShortcuts: map[string]port.SearchShortcut{},
+		SearchShortcuts: map[string]dto.SearchShortcut{},
 	}
 	if cfg == nil {
 		return payload
 	payload.DefaultSearchEngine = cfg.DefaultSearchEngine
 	payload.SearchShortcuts = buildSystemviewSearchShortcutsPayload(cfg.SearchShortcuts)
 	payload.EngineType = cfg.Engine.ResolveEngineType()
-	payload.Performance = port.SystemviewPerformancePayload{
+	payload.Performance = dto.SystemviewPerformancePayload{
 		Profile: string(cfg.Engine.Profile),
-		Custom: port.SystemviewCustomPerformancePayload{
+		Custom: dto.SystemviewCustomPerformancePayload{
 			SkiaCPUThreads:         cfg.Engine.WebKit.SkiaCPUPaintingThreads,
 			SkiaGPUThreads:         cfg.Engine.WebKit.SkiaGPUPaintingThreads,
 			WebProcessMemoryMB:     cfg.Engine.WebKit.WebProcessMemoryLimitMB,
 			NetworkProcessMemoryMB: cfg.Engine.WebKit.NetworkProcessMemoryLimitMB,
 			WebViewPoolPrewarm:     cfg.Engine.PoolPrewarmCount,
 		},
-		Resolved: port.SystemviewResolvedPerformancePayload{
+		Resolved: dto.SystemviewResolvedPerformancePayload{
 			SkiaCPUThreads:         resolved.SkiaCPUPaintingThreads,
 			SkiaGPUThreads:         resolved.SkiaGPUPaintingThreads,
 			WebProcessMemoryMB:     resolved.WebProcessMemoryLimitMB,
 	return payload
 }
-func buildSystemviewAppearancePayload(appearance AppearanceConfig) port.WebUIAppearanceConfig {
+func buildSystemviewAppearancePayload(appearance AppearanceConfig) dto.WebUIAppearanceConfig {
 	defaults := DefaultConfig().Appearance
-	return port.WebUIAppearanceConfig{
+	return dto.WebUIAppearanceConfig{
 		SansFont:        appearance.SansFont,
 		SerifFont:       appearance.SerifFont,
 		MonospaceFont:   appearance.MonospaceFont,
 	}
 }
-func buildSystemviewPalettePayload(palette, fallback ColorPalette) port.ColorPalette {
+func buildSystemviewPalettePayload(palette, fallback ColorPalette) dto.ColorPalette {
-	return port.ColorPalette{
+	return dto.ColorPalette{
 		Background:     nonEmptyColor(palette.Background, fallback.Background),
 		Surface:        nonEmptyColor(palette.Surface, fallback.Surface),
 		SurfaceVariant: nonEmptyColor(palette.SurfaceVariant, fallback.SurfaceVariant),
 	return fallback
 }
-func buildSystemviewSearchShortcutsPayload(shortcuts map[string]SearchShortcut) map[string]port.SearchShortcut {
+func buildSystemviewSearchShortcutsPayload(shortcuts map[string]SearchShortcut) map[string]dto.SearchShortcut {
 	if len(shortcuts) == 0 {
-		return map[string]port.SearchShortcut{}
+		return map[string]dto.SearchShortcut{}
 	}
-	result := make(map[string]port.SearchShortcut, len(shortcuts))
+	result := make(map[string]dto.SearchShortcut, len(shortcuts))
 	for key, shortcut := range shortcuts {
-		result[key] = port.SearchShortcut{URL: shortcut.URL, Description: shortcut.Description}
+		result[key] = dto.SearchShortcut{URL: shortcut.URL, Description: shortcut.Description}
 	}
 	return result
 }
-func buildSystemviewHardwarePayload(hw *port.HardwareInfo) port.SystemviewHardwarePayload {
+func buildSystemviewHardwarePayload(hw *port.HardwareInfo) dto.SystemviewHardwarePayload {
 	if hw == nil {
-		return port.SystemviewHardwarePayload{}
+		return dto.SystemviewHardwarePayload{}
 	}
-	return port.SystemviewHardwarePayload{
+	return dto.SystemviewHardwarePayload{
 		CPUCores:   hw.CPUCores,
 		CPUThreads: hw.CPUThreads,
 		TotalRAMMB: hw.TotalRAMMB(),

M internal/infrastructure/handlers/config.go +5 -4


@@ -5,18 +5,19 @@ import (
5	5		"encoding/json"
6	6		"fmt"
7	7
	8	+	"github.com/bnema/dumber/internal/application/dto"
8	9		"github.com/bnema/dumber/internal/application/port"
9	10		"github.com/bnema/dumber/internal/logging"
10	11		)
11	12
12	13		// ConfigHandler handles configuration-related messages.
13	14		type ConfigHandler struct {
14		-	saveConfig func(context.Context, port.WebUIConfig) error
	15	+	saveConfig func(context.Context, dto.WebUIConfig) error
15	16		}
16	17
17	18		// NewConfigHandler creates a new ConfigHandler.
18	19		// saveConfig is called to persist config changes (typically usecase.SaveWebUIConfigUseCase.Execute).
19		-	func NewConfigHandler(saveConfig func(context.Context, port.WebUIConfig) error) *ConfigHandler {
	20	+	func NewConfigHandler(saveConfig func(context.Context, dto.WebUIConfig) error) *ConfigHandler {
20	21		if saveConfig == nil {
21	22		panic("NewConfigHandler: saveConfig must not be nil")
22	23		}

@@ -33,7 +34,7 @@ func (h *ConfigHandler) Handle(ctx context.Context, viewID port.WebViewID, paylo
33	34		}
34	35		log := logging.FromContext(ctx).With().Str("handler", "config").Logger()
35	36
36		-	var payloadCfg port.WebUIConfig
	37	+	var payloadCfg dto.WebUIConfig
37	38		if err := json.Unmarshal(payload, &payloadCfg); err != nil {
38	39		log.Error().Err(err).Msg("failed to unmarshal config payload")
39	40		return nil, fmt.Errorf("invalid config format: %w", err)

@@ -56,7 +57,7 @@ func (h *ConfigHandler) Handle(ctx context.Context, viewID port.WebViewID, paylo
56	57		// RegisterConfigHandlers registers configuration handlers with the router.
57	58		func RegisterConfigHandlers(
58	59		ctx context.Context, router port.WebUIHandlerRouter,
59		-	saveConfig func(context.Context, port.WebUIConfig) error,
	60	+	saveConfig func(context.Context, dto.WebUIConfig) error,
60	61		) error {
61	62		handler := NewConfigHandler(saveConfig)
62	63

 	"encoding/json"
 	"fmt"
+	"github.com/bnema/dumber/internal/application/dto"
 	"github.com/bnema/dumber/internal/application/port"
 	"github.com/bnema/dumber/internal/logging"
 )
 // ConfigHandler handles configuration-related messages.
 type ConfigHandler struct {
-	saveConfig func(context.Context, port.WebUIConfig) error
+	saveConfig func(context.Context, dto.WebUIConfig) error
 }
 // NewConfigHandler creates a new ConfigHandler.
 // saveConfig is called to persist config changes (typically usecase.SaveWebUIConfigUseCase.Execute).
-func NewConfigHandler(saveConfig func(context.Context, port.WebUIConfig) error) *ConfigHandler {
+func NewConfigHandler(saveConfig func(context.Context, dto.WebUIConfig) error) *ConfigHandler {
 	if saveConfig == nil {
 		panic("NewConfigHandler: saveConfig must not be nil")
 	}
 	}
 	log := logging.FromContext(ctx).With().Str("handler", "config").Logger()
-	var payloadCfg port.WebUIConfig
+	var payloadCfg dto.WebUIConfig
 	if err := json.Unmarshal(payload, &payloadCfg); err != nil {
 		log.Error().Err(err).Msg("failed to unmarshal config payload")
 		return nil, fmt.Errorf("invalid config format: %w", err)
 // RegisterConfigHandlers registers configuration handlers with the router.
 func RegisterConfigHandlers(
 	ctx context.Context, router port.WebUIHandlerRouter,
-	saveConfig func(context.Context, port.WebUIConfig) error,
+	saveConfig func(context.Context, dto.WebUIConfig) error,
 ) error {
 	handler := NewConfigHandler(saveConfig)

M internal/infrastructure/handlers/homepage/favorites.go +36 -14


@@ -11,22 +11,26 @@ import (
11	11		"github.com/bnema/dumber/internal/logging"
12	12		)
13	13
14		-	func folderIDFromInt64(id int64) entity.FolderID {
	14	+	func folderIDFromInt64(id int64) (entity.FolderID, error) {
15	15		if id == nil {
16		-	return nil
	16	+	return nil, nil
	17	+	}
	18	+	if *id <= 0 {
	19	+	return nil, fmt.Errorf("folder id must be positive")
17	20		}
18	21		folderID := entity.FolderID(*id)
19		-	return &folderID
	22	+	return &folderID, nil
20	23		}
21	24
22		-	func tagIDsFromInt64s(ids []int64) []entity.TagID {
	25	+	func tagIDsFromInt64s(ids []int64) ([]entity.TagID, error) {
23	26		out := make([]entity.TagID, 0, len(ids))
24	27		for _, id := range ids {
25		-	if id > 0 {
26		-	out = append(out, entity.TagID(id))
	28	+	if id <= 0 {
	29	+	return nil, fmt.Errorf("tag id must be positive")
27	30		}
	31	+	out = append(out, entity.TagID(id))
28	32		}
29		-	return out
	33	+	return out, nil
30	34		}
31	35
32	36		// FavoritesHandlers handles favorite-related messages from the homepage.

@@ -80,19 +84,27 @@ func (h *FavoritesHandlers) HandleCreate() port.WebUIMessageHandler {
80	84
81	85		log.Debug().
82	86		Str("request_id", req.RequestID).
83		-	Str("url", req.URL).
84	87		Msg("handling favorite_create")
85	88
86		-	if strings.TrimSpace(req.URL) == "" {
	89	+	trimmedURL := strings.TrimSpace(req.URL)
	90	+	if trimmedURL == "" {
87	91		return NewErrorResponse(req.RequestID, fmt.Errorf("URL is required")), nil
88	92		}
	93	+	folderID, err := folderIDFromInt64(req.FolderID)
	94	+	if err != nil {
	95	+	return NewErrorResponse(req.RequestID, err), nil
	96	+	}
	97	+	tags, err := tagIDsFromInt64s(req.Tags)
	98	+	if err != nil {
	99	+	return NewErrorResponse(req.RequestID, err), nil
	100	+	}
89	101
90	102		input := port.FavoriteCreateInput{
91		-	URL: req.URL,
	103	+	URL: trimmedURL,
92	104		Title: req.Title,
93	105		FaviconURL: req.FaviconURL,
94		-	FolderID: folderIDFromInt64(req.FolderID),
95		-	Tags: tagIDsFromInt64s(req.Tags),
	106	+	FolderID: folderID,
	107	+	Tags: tags,
96	108		}
97	109		favorite, err := h.favoritesUC.AddFavorite(ctx, input)
98	110		if err != nil {

@@ -131,11 +143,16 @@ func (h *FavoritesHandlers) HandleUpdate() port.WebUIMessageHandler {
131	143		return NewErrorResponse(req.RequestID, fmt.Errorf("favorite id must be positive")), nil
132	144		}
133	145
	146	+	folderID, err := folderIDFromInt64(req.FolderID)
	147	+	if err != nil {
	148	+	return NewErrorResponse(req.RequestID, err), nil
	149	+	}
	150	+
134	151		favorite, err := h.favoritesUC.UpdateFavorite(ctx, port.FavoriteUpdateInput{
135	152		ID: entity.FavoriteID(req.ID),
136	153		Title: req.Title,
137	154		FaviconURL: req.FaviconURL,
138		-	FolderID: folderIDFromInt64(req.FolderID),
	155	+	FolderID: folderID,
139	156		ShortcutKey: req.ShortcutKey,
140	157		})
141	158		if err != nil {

@@ -260,7 +277,12 @@ func (h *FavoritesHandlers) HandleSetFolder() port.WebUIMessageHandler {
260	277		Int64("favorite_id", req.FavoriteID).
261	278		Msg("handling favorite_set_folder")
262	279
263		-	if err := h.favoritesUC.Move(ctx, entity.FavoriteID(req.FavoriteID), folderIDFromInt64(req.FolderID)); err != nil {
	280	+	folderID, err := folderIDFromInt64(req.FolderID)
	281	+	if err != nil {
	282	+	return NewErrorResponse(req.RequestID, err), nil
	283	+	}
	284	+
	285	+	if err := h.favoritesUC.Move(ctx, entity.FavoriteID(req.FavoriteID), folderID); err != nil {
264	286		return NewErrorResponse(req.RequestID, err), nil
265	287		}
266	288

 	"github.com/bnema/dumber/internal/logging"
 )
-func folderIDFromInt64(id *int64) *entity.FolderID {
+func folderIDFromInt64(id *int64) (*entity.FolderID, error) {
 	if id == nil {
-		return nil
+		return nil, nil
+	}
+	if *id <= 0 {
+		return nil, fmt.Errorf("folder id must be positive")
 	}
 	folderID := entity.FolderID(*id)
-	return &folderID
+	return &folderID, nil
 }
-func tagIDsFromInt64s(ids []int64) []entity.TagID {
+func tagIDsFromInt64s(ids []int64) ([]entity.TagID, error) {
 	out := make([]entity.TagID, 0, len(ids))
 	for _, id := range ids {
-		if id > 0 {
+		if id <= 0 {
-			out = append(out, entity.TagID(id))
+			return nil, fmt.Errorf("tag id must be positive")
 		}
+		out = append(out, entity.TagID(id))
 	}
-	return out
+	return out, nil
 }
 // FavoritesHandlers handles favorite-related messages from the homepage.
 		log.Debug().
 			Str("request_id", req.RequestID).
-			Str("url", req.URL).
 			Msg("handling favorite_create")
-		if strings.TrimSpace(req.URL) == "" {
+		trimmedURL := strings.TrimSpace(req.URL)
+		if trimmedURL == "" {
 			return NewErrorResponse(req.RequestID, fmt.Errorf("URL is required")), nil
 		}
+		folderID, err := folderIDFromInt64(req.FolderID)
+		if err != nil {
+			return NewErrorResponse(req.RequestID, err), nil
+		}
+		tags, err := tagIDsFromInt64s(req.Tags)
+		if err != nil {
+			return NewErrorResponse(req.RequestID, err), nil
+		}
 		input := port.FavoriteCreateInput{
-			URL:        req.URL,
+			URL:        trimmedURL,
 			Title:      req.Title,
 			FaviconURL: req.FaviconURL,
-			FolderID:   folderIDFromInt64(req.FolderID),
+			FolderID:   folderID,
-			Tags:       tagIDsFromInt64s(req.Tags),
+			Tags:       tags,
 		}
 		favorite, err := h.favoritesUC.AddFavorite(ctx, input)
 		if err != nil {
 			return NewErrorResponse(req.RequestID, fmt.Errorf("favorite id must be positive")), nil
 		}
+		folderID, err := folderIDFromInt64(req.FolderID)
+		if err != nil {
+			return NewErrorResponse(req.RequestID, err), nil
+		}
 		favorite, err := h.favoritesUC.UpdateFavorite(ctx, port.FavoriteUpdateInput{
 			ID:          entity.FavoriteID(req.ID),
 			Title:       req.Title,
 			FaviconURL:  req.FaviconURL,
-			FolderID:    folderIDFromInt64(req.FolderID),
+			FolderID:    folderID,
 			ShortcutKey: req.ShortcutKey,
 		})
 		if err != nil {
 			Int64("favorite_id", req.FavoriteID).
 			Msg("handling favorite_set_folder")
-		if err := h.favoritesUC.Move(ctx, entity.FavoriteID(req.FavoriteID), folderIDFromInt64(req.FolderID)); err != nil {
+		folderID, err := folderIDFromInt64(req.FolderID)
+		if err != nil {
+			return NewErrorResponse(req.RequestID, err), nil
+		}
+		if err := h.favoritesUC.Move(ctx, entity.FavoriteID(req.FavoriteID), folderID); err != nil {
 			return NewErrorResponse(req.RequestID, err), nil
 		}

M internal/infrastructure/handlers/homepage/folders.go +13 -10


@@ -62,11 +62,12 @@ func (h *FolderHandlers) HandleCreate() port.WebUIMessageHandler {
62	62		Str("name", req.Name).
63	63		Msg("handling folder_create")
64	64
65		-	icon := ""
66		-	if req.Icon != nil {
67		-	icon = *req.Icon
	65	+	parentID, err := folderIDFromInt64(req.ParentID)
	66	+	if err != nil {
	67	+	return NewErrorResponse(req.RequestID, err), nil
68	68		}
69		-	folder, err := h.favoritesUC.CreateFolder(ctx, req.Name, icon, folderIDFromInt64(req.ParentID))
	69	+
	70	+	folder, err := h.favoritesUC.CreateFolder(ctx, req.Name, optionalStringValue(req.Icon), parentID)
70	71		if err != nil {
71	72		return NewErrorResponse(req.RequestID, err), nil
72	73		}

@@ -114,6 +115,13 @@ type updateFolderRequest struct {
114	115
115	116		// HandleUpdate handles folder_update messages.
116	117		// It delegates to the port.HomepageFavorites interface's UpdateFolder method.
	118	+	func optionalStringValue(value *string) string {
	119	+	if value == nil {
	120	+	return ""
	121	+	}
	122	+	return *value
	123	+	}
	124	+
117	125		func (h *FolderHandlers) HandleUpdate() port.WebUIMessageHandler {
118	126		return port.WebUIMessageHandlerFunc(func(ctx context.Context, _ port.WebViewID, payload json.RawMessage) (any, error) {
119	127		log := logging.FromContext(ctx)

@@ -129,12 +137,7 @@ func (h *FolderHandlers) HandleUpdate() port.WebUIMessageHandler {
129	137		Str("name", req.Name).
130	138		Msg("handling folder_update")
131	139
132		-	icon := ""
133		-	if req.Icon != nil {
134		-	icon = *req.Icon
135		-	}
136		-
137		-	if err := h.favoritesUC.UpdateFolder(ctx, entity.FolderID(req.ID), req.Name, icon); err != nil {
	140	+	if err := h.favoritesUC.UpdateFolder(ctx, entity.FolderID(req.ID), req.Name, optionalStringValue(req.Icon)); err != nil {
138	141		return NewErrorResponse(req.RequestID, err), nil
139	142		}
140	143


@@ -62,11 +62,12 @@ func (h *FolderHandlers) HandleCreate() port.WebUIMessageHandler {
62		Str("name", req.Name).	62		Str("name", req.Name).
63		Msg("handling folder_create")	63		Msg("handling folder_create")
64			64
65	-	icon := ""	65	+	parentID, err := folderIDFromInt64(req.ParentID)
66	-	if req.Icon != nil {	66	+	if err != nil {
67	-	icon = *req.Icon	67	+	return NewErrorResponse(req.RequestID, err), nil
68		}	68		}
69	-	folder, err := h.favoritesUC.CreateFolder(ctx, req.Name, icon, folderIDFromInt64(req.ParentID))	69	+
			70	+	folder, err := h.favoritesUC.CreateFolder(ctx, req.Name, optionalStringValue(req.Icon), parentID)
70		if err != nil {	71		if err != nil {
71		return NewErrorResponse(req.RequestID, err), nil	72		return NewErrorResponse(req.RequestID, err), nil
72		}	73		}

@@ -114,6 +115,13 @@ type updateFolderRequest struct {
114			115
115		// HandleUpdate handles folder_update messages.	116		// HandleUpdate handles folder_update messages.
116		// It delegates to the port.HomepageFavorites interface's UpdateFolder method.	117		// It delegates to the port.HomepageFavorites interface's UpdateFolder method.
			118	+	func optionalStringValue(value *string) string {
			119	+	if value == nil {
			120	+	return ""
			121	+	}
			122	+	return *value
			123	+	}
			124	+
117		func (h *FolderHandlers) HandleUpdate() port.WebUIMessageHandler {	125		func (h *FolderHandlers) HandleUpdate() port.WebUIMessageHandler {
118		return port.WebUIMessageHandlerFunc(func(ctx context.Context, _ port.WebViewID, payload json.RawMessage) (any, error) {	126		return port.WebUIMessageHandlerFunc(func(ctx context.Context, _ port.WebViewID, payload json.RawMessage) (any, error) {
119		log := logging.FromContext(ctx)	127		log := logging.FromContext(ctx)

@@ -129,12 +137,7 @@ func (h *FolderHandlers) HandleUpdate() port.WebUIMessageHandler {
129		Str("name", req.Name).	137		Str("name", req.Name).
130		Msg("handling folder_update")	138		Msg("handling folder_update")
131			139
132	-	icon := ""	140	+	if err := h.favoritesUC.UpdateFolder(ctx, entity.FolderID(req.ID), req.Name, optionalStringValue(req.Icon)); err != nil {
133	-	if req.Icon != nil {
134	-	icon = *req.Icon
135	-	}
136	-
137	-	if err := h.favoritesUC.UpdateFolder(ctx, entity.FolderID(req.ID), req.Name, icon); err != nil {
138		return NewErrorResponse(req.RequestID, err), nil	141		return NewErrorResponse(req.RequestID, err), nil
139		}	142		}
140			143

M internal/infrastructure/handlers/homepage/history.go +0 -12


@@ -182,9 +182,6 @@ func (h *HistoryHandlers) HandleDeleteRange() port.WebUIMessageHandler {
182	182		Str("range", req.Range).
183	183		Msg("handling history_delete_range")
184	184
185		-	if !isAllowedHistoryDeleteRange(req.Range) {
186		-	return NewErrorResponse(req.RequestID, fmt.Errorf("invalid range: %s", req.Range)), nil
187		-	}
188	185		if err := h.historyUC.ClearRange(ctx, req.Range); err != nil {
189	186		return NewErrorResponse(req.RequestID, err), nil
190	187		}

@@ -193,15 +190,6 @@ func (h *HistoryHandlers) HandleDeleteRange() port.WebUIMessageHandler {
193	190		})
194	191		}
195	192
196		-	func isAllowedHistoryDeleteRange(rangeID string) bool {
197		-	switch rangeID {
198		-	case "hour", "day", "week", "month", "all":
199		-	return true
200		-	default:
201		-	return false
202		-	}
203		-	}
204		-
205	193		// HandleClearAll handles history_clear_all messages.
206	194		func (h *HistoryHandlers) HandleClearAll() port.WebUIMessageHandler {
207	195		return port.WebUIMessageHandlerFunc(func(ctx context.Context, _ port.WebViewID, payload json.RawMessage) (any, error) {


@@ -182,9 +182,6 @@ func (h *HistoryHandlers) HandleDeleteRange() port.WebUIMessageHandler {
182		Str("range", req.Range).	182	Str("range", req.Range).
183		Msg("handling history_delete_range")	183	Msg("handling history_delete_range")
184			184
185	-	if !isAllowedHistoryDeleteRange(req.Range) {
186	-	return NewErrorResponse(req.RequestID, fmt.Errorf("invalid range: %s", req.Range)), nil
187	-	}
188		if err := h.historyUC.ClearRange(ctx, req.Range); err != nil {	185	if err := h.historyUC.ClearRange(ctx, req.Range); err != nil {
189		return NewErrorResponse(req.RequestID, err), nil	186	return NewErrorResponse(req.RequestID, err), nil
190		}	187	}

@@ -193,15 +190,6 @@ func (h *HistoryHandlers) HandleDeleteRange() port.WebUIMessageHandler {
193		})	190	})
194		}	191	}
195			192
196	-	func isAllowedHistoryDeleteRange(rangeID string) bool {
197	-	switch rangeID {
198	-	case "hour", "day", "week", "month", "all":
199	-	return true
200	-	default:
201	-	return false
202	-	}
203	-	}
204	-
205		// HandleClearAll handles history_clear_all messages.	193	// HandleClearAll handles history_clear_all messages.
206		func (h *HistoryHandlers) HandleClearAll() port.WebUIMessageHandler {	194	func (h *HistoryHandlers) HandleClearAll() port.WebUIMessageHandler {
207		return port.WebUIMessageHandlerFunc(func(ctx context.Context, _ port.WebViewID, payload json.RawMessage) (any, error) {	195	return port.WebUIMessageHandlerFunc(func(ctx context.Context, _ port.WebViewID, payload json.RawMessage) (any, error) {

M internal/infrastructure/persistence/sqlite/history_repo.go +3 -3


@@ -494,9 +494,10 @@ func (r historyRepo) GetRecent(ctx context.Context, limit, offset int) ([]enti
494	494		}
495	495
496	496		func (r historyRepo) GetRecentByDomain(ctx context.Context, domain string, limit, offset int) ([]entity.HistoryEntry, error) {
	497	+	rawDomain := domain
497	498		domain = domainurl.CanonicalDomain(domain)
498	499		if domain == "" {
499		-	return []*entity.HistoryEntry{}, nil
	500	+	return nil, fmt.Errorf("history domain is required: %q", rawDomain)
500	501		}
501	502		rows, err := r.queries.GetRecentHistoryByDomain(ctx, sqlc.GetRecentHistoryByDomainParams{
502	503		Domain: sql.NullString{String: domain, Valid: true},

@@ -597,8 +598,7 @@ func (r *historyRepo) DeleteByDomain(ctx context.Context, domain string) error {
597	598		rawDomain := domain
598	599		domain = domainurl.CanonicalDomain(domain)
599	600		if domain == "" {
600		-	logging.FromContext(ctx).Debug().Str("domain", rawDomain).Msg("skipping delete by domain: empty canonical domain")
601		-	return nil
	601	+	return fmt.Errorf("history domain is required: %q", rawDomain)
602	602		}
603	603		return r.queries.DeleteHistoryByDomain(ctx, sql.NullString{String: domain, Valid: true})
604	604		}

 }
 func (r *historyRepo) GetRecentByDomain(ctx context.Context, domain string, limit, offset int) ([]*entity.HistoryEntry, error) {
+	rawDomain := domain
 	domain = domainurl.CanonicalDomain(domain)
 	if domain == "" {
-		return []*entity.HistoryEntry{}, nil
+		return nil, fmt.Errorf("history domain is required: %q", rawDomain)
 	}
 	rows, err := r.queries.GetRecentHistoryByDomain(ctx, sqlc.GetRecentHistoryByDomainParams{
 		Domain: sql.NullString{String: domain, Valid: true},
 	rawDomain := domain
 	domain = domainurl.CanonicalDomain(domain)
 	if domain == "" {
-		logging.FromContext(ctx).Debug().Str("domain", rawDomain).Msg("skipping delete by domain: empty canonical domain")
+		return fmt.Errorf("history domain is required: %q", rawDomain)
-		return nil
 	}
 	return r.queries.DeleteHistoryByDomain(ctx, sql.NullString{String: domain, Valid: true})
 }

M internal/infrastructure/persistence/sqlite/history_repo_test.go +16 -0


@@ -833,6 +833,22 @@ func TestHistoryRepository_Search_ReturnsEmptyForNonPositiveLimit(t *testing.T)
833	833		assert.Empty(t, results)
834	834		}
835	835
	836	+	func TestHistoryRepository_RejectsEmptyCanonicalDomain(t *testing.T) {
	837	+	ctx := historyTestCtx()
	838	+	dbPath := filepath.Join(t.TempDir(), "dumber.db")
	839	+
	840	+	db, err := sqlite.NewConnection(ctx, dbPath)
	841	+	require.NoError(t, err)
	842	+	t.Cleanup(func() { _ = db.Close() })
	843	+
	844	+	repo := sqlite.NewHistoryRepository(db)
	845	+
	846	+	entries, err := repo.GetRecentByDomain(ctx, " ", 10, 0)
	847	+	require.Error(t, err)
	848	+	assert.Nil(t, entries)
	849	+	assert.Error(t, repo.DeleteByDomain(ctx, "/path"))
	850	+	}
	851	+
836	852		func TestHistoryRepository_DomainColumnPowersFilteringStatsAndDelete(t *testing.T) {
837	853		ctx := historyTestCtx()
838	854		dbPath := filepath.Join(t.TempDir(), "dumber.db")


@@ -833,6 +833,22 @@ func TestHistoryRepository_Search_ReturnsEmptyForNonPositiveLimit(t *testing.T)
833	assert.Empty(t, results)	833		assert.Empty(t, results)
834	}	834		}
835		835
		836	+	func TestHistoryRepository_RejectsEmptyCanonicalDomain(t *testing.T) {
		837	+	ctx := historyTestCtx()
		838	+	dbPath := filepath.Join(t.TempDir(), "dumber.db")
		839	+
		840	+	db, err := sqlite.NewConnection(ctx, dbPath)
		841	+	require.NoError(t, err)
		842	+	t.Cleanup(func() { _ = db.Close() })
		843	+
		844	+	repo := sqlite.NewHistoryRepository(db)
		845	+
		846	+	entries, err := repo.GetRecentByDomain(ctx, " ", 10, 0)
		847	+	require.Error(t, err)
		848	+	assert.Nil(t, entries)
		849	+	assert.Error(t, repo.DeleteByDomain(ctx, "/path"))
		850	+	}
		851	+
836	func TestHistoryRepository_DomainColumnPowersFilteringStatsAndDelete(t *testing.T) {	852		func TestHistoryRepository_DomainColumnPowersFilteringStatsAndDelete(t *testing.T) {
837	ctx := historyTestCtx()	853		ctx := historyTestCtx()
838	dbPath := filepath.Join(t.TempDir(), "dumber.db")	854		dbPath := filepath.Join(t.TempDir(), "dumber.db")

M internal/infrastructure/persistence/sqlite/migrations/008_history_domain.sql +57 -1


@@ -31,4 +31,60 @@ CREATE INDEX IF NOT EXISTS idx_history_domain_last_visited ON history(domain, la
31	31
32	32		-- +goose Down
33	33		DROP INDEX IF EXISTS idx_history_domain_last_visited;
34		-	ALTER TABLE history DROP COLUMN domain;
	34	+
	35	+	-- Rebuild instead of ALTER TABLE DROP COLUMN so rollback works on SQLite
	36	+	-- versions before 3.35. Preserve the base history schema and indexes/triggers.
	37	+	DROP TRIGGER IF EXISTS history_fts_update;
	38	+	DROP TRIGGER IF EXISTS history_fts_delete;
	39	+	DROP TRIGGER IF EXISTS history_fts_insert;
	40	+	DROP TABLE IF EXISTS history_fts;
	41	+
	42	+	CREATE TABLE history_008_down (
	43	+	id INTEGER PRIMARY KEY AUTOINCREMENT,
	44	+	url TEXT NOT NULL UNIQUE,
	45	+	title TEXT,
	46	+	favicon_url TEXT,
	47	+	visit_count INTEGER DEFAULT 1,
	48	+	last_visited DATETIME DEFAULT CURRENT_TIMESTAMP,
	49	+	created_at DATETIME DEFAULT CURRENT_TIMESTAMP
	50	+	);
	51	+
	52	+	INSERT INTO history_008_down (id, url, title, favicon_url, visit_count, last_visited, created_at)
	53	+	SELECT id, url, title, favicon_url, visit_count, last_visited, created_at
	54	+	FROM history;
	55	+
	56	+	DROP TABLE history;
	57	+	ALTER TABLE history_008_down RENAME TO history;
	58	+
	59	+	CREATE INDEX IF NOT EXISTS idx_history_url ON history(url);
	60	+	CREATE INDEX IF NOT EXISTS idx_history_last_visited ON history(last_visited);
	61	+	CREATE INDEX IF NOT EXISTS idx_history_visit_count_last_visited ON history(visit_count DESC, last_visited DESC);
	62	+
	63	+	CREATE VIRTUAL TABLE IF NOT EXISTS history_fts USING fts5(
	64	+	url,
	65	+	title,
	66	+	content='history',
	67	+	content_rowid='id'
	68	+	);
	69	+
	70	+	-- +goose StatementBegin
	71	+	CREATE TRIGGER IF NOT EXISTS history_fts_insert AFTER INSERT ON history BEGIN
	72	+	INSERT INTO history_fts(rowid, url, title) VALUES (NEW.id, NEW.url, NEW.title);
	73	+	END;
	74	+	-- +goose StatementEnd
	75	+
	76	+	-- +goose StatementBegin
	77	+	CREATE TRIGGER IF NOT EXISTS history_fts_delete AFTER DELETE ON history BEGIN
	78	+	INSERT INTO history_fts(history_fts, rowid, url, title) VALUES('delete', OLD.id, OLD.url, OLD.title);
	79	+	END;
	80	+	-- +goose StatementEnd
	81	+
	82	+	-- +goose StatementBegin
	83	+	CREATE TRIGGER IF NOT EXISTS history_fts_update AFTER UPDATE ON history BEGIN
	84	+	INSERT INTO history_fts(history_fts, rowid, url, title) VALUES('delete', OLD.id, OLD.url, OLD.title);
	85	+	INSERT INTO history_fts(rowid, url, title) VALUES (NEW.id, NEW.url, NEW.title);
	86	+	END;
	87	+	-- +goose StatementEnd
	88	+
	89	+	INSERT INTO history_fts(rowid, url, title)
	90	+	SELECT id, url, title FROM history;


@@ -31,4 +31,60 @@ CREATE INDEX IF NOT EXISTS idx_history_domain_last_visited ON history(domain, la
31			31
32		-- +goose Down	32		-- +goose Down
33		DROP INDEX IF EXISTS idx_history_domain_last_visited;	33		DROP INDEX IF EXISTS idx_history_domain_last_visited;
34	-	ALTER TABLE history DROP COLUMN domain;	34	+
			35	+	-- Rebuild instead of ALTER TABLE DROP COLUMN so rollback works on SQLite
			36	+	-- versions before 3.35. Preserve the base history schema and indexes/triggers.
			37	+	DROP TRIGGER IF EXISTS history_fts_update;
			38	+	DROP TRIGGER IF EXISTS history_fts_delete;
			39	+	DROP TRIGGER IF EXISTS history_fts_insert;
			40	+	DROP TABLE IF EXISTS history_fts;
			41	+
			42	+	CREATE TABLE history_008_down (
			43	+	id INTEGER PRIMARY KEY AUTOINCREMENT,
			44	+	url TEXT NOT NULL UNIQUE,
			45	+	title TEXT,
			46	+	favicon_url TEXT,
			47	+	visit_count INTEGER DEFAULT 1,
			48	+	last_visited DATETIME DEFAULT CURRENT_TIMESTAMP,
			49	+	created_at DATETIME DEFAULT CURRENT_TIMESTAMP
			50	+	);
			51	+
			52	+	INSERT INTO history_008_down (id, url, title, favicon_url, visit_count, last_visited, created_at)
			53	+	SELECT id, url, title, favicon_url, visit_count, last_visited, created_at
			54	+	FROM history;
			55	+
			56	+	DROP TABLE history;
			57	+	ALTER TABLE history_008_down RENAME TO history;
			58	+
			59	+	CREATE INDEX IF NOT EXISTS idx_history_url ON history(url);
			60	+	CREATE INDEX IF NOT EXISTS idx_history_last_visited ON history(last_visited);
			61	+	CREATE INDEX IF NOT EXISTS idx_history_visit_count_last_visited ON history(visit_count DESC, last_visited DESC);
			62	+
			63	+	CREATE VIRTUAL TABLE IF NOT EXISTS history_fts USING fts5(
			64	+	url,
			65	+	title,
			66	+	content='history',
			67	+	content_rowid='id'
			68	+	);
			69	+
			70	+	-- +goose StatementBegin
			71	+	CREATE TRIGGER IF NOT EXISTS history_fts_insert AFTER INSERT ON history BEGIN
			72	+	INSERT INTO history_fts(rowid, url, title) VALUES (NEW.id, NEW.url, NEW.title);
			73	+	END;
			74	+	-- +goose StatementEnd
			75	+
			76	+	-- +goose StatementBegin
			77	+	CREATE TRIGGER IF NOT EXISTS history_fts_delete AFTER DELETE ON history BEGIN
			78	+	INSERT INTO history_fts(history_fts, rowid, url, title) VALUES('delete', OLD.id, OLD.url, OLD.title);
			79	+	END;
			80	+	-- +goose StatementEnd
			81	+
			82	+	-- +goose StatementBegin
			83	+	CREATE TRIGGER IF NOT EXISTS history_fts_update AFTER UPDATE ON history BEGIN
			84	+	INSERT INTO history_fts(history_fts, rowid, url, title) VALUES('delete', OLD.id, OLD.url, OLD.title);
			85	+	INSERT INTO history_fts(rowid, url, title) VALUES (NEW.id, NEW.url, NEW.title);
			86	+	END;
			87	+	-- +goose StatementEnd
			88	+
			89	+	INSERT INTO history_fts(rowid, url, title)
			90	+	SELECT id, url, title FROM history;

M internal/infrastructure/persistence/sqlite/queries/history.sql +31 -6


@@ -19,7 +19,7 @@ DO UPDATE SET
19	19		last_visited = CURRENT_TIMESTAMP,
20	20		title = COALESCE(EXCLUDED.title, history.title),
21	21		favicon_url = COALESCE(EXCLUDED.favicon_url, history.favicon_url),
22		-	domain = EXCLUDED.domain;
	22	+	domain = COALESCE(EXCLUDED.domain, history.domain);
23	23
24	24		-- name: IncrementVisitCount :exec
25	25		UPDATE history

@@ -50,22 +50,47 @@ DELETE FROM history WHERE last_visited >= ?;
50	50		DELETE FROM history;
51	51
52	52		-- name: GetHistoryStats :one
53		-	SELECT COUNT(*) as total_entries, COALESCE(SUM(visit_count), 0) as total_visits, COUNT(DISTINCT date(last_visited)) as unique_days FROM history;
	53	+	SELECT
	54	+	COUNT(*) as total_entries,
	55	+	COALESCE(SUM(visit_count), 0) as total_visits,
	56	+	COUNT(DISTINCT date(last_visited)) as unique_days
	57	+	FROM history;
54	58
55	59		-- name: GetDomainStats :many
56		-	SELECT COALESCE(domain, '') as domain, COUNT(*) as page_count, SUM(visit_count) as total_visits, MAX(last_visited) as last_visit FROM history WHERE domain IS NOT NULL AND domain != '' GROUP BY domain ORDER BY total_visits DESC LIMIT ?;
	60	+	SELECT
	61	+	COALESCE(domain, '') as domain,
	62	+	COUNT(*) as page_count,
	63	+	SUM(visit_count) as total_visits,
	64	+	MAX(last_visited) as last_visit
	65	+	FROM history
	66	+	WHERE domain IS NOT NULL AND domain != ''
	67	+	GROUP BY domain
	68	+	ORDER BY total_visits DESC
	69	+	LIMIT ?;
57	70
58	71		-- name: GetHourlyDistribution :many
59		-	SELECT CAST(strftime('%H', last_visited) AS INTEGER) as hour, COUNT(*) as visit_count FROM history GROUP BY hour ORDER BY hour;
	72	+	SELECT
	73	+	CAST(strftime('%H', last_visited) AS INTEGER) as hour,
	74	+	COUNT(*) as visit_count
	75	+	FROM history
	76	+	GROUP BY hour
	77	+	ORDER BY hour;
60	78
61	79		-- name: GetDailyVisitCount :many
62		-	SELECT date(last_visited) as day, COUNT(*) as entries, SUM(visit_count) as visits FROM history WHERE last_visited >= date('now', ?) GROUP BY day ORDER BY day ASC;
	80	+	SELECT
	81	+	date(last_visited) as day,
	82	+	COUNT(*) as entries,
	83	+	SUM(visit_count) as visits
	84	+	FROM history
	85	+	WHERE last_visited >= date('now', ?)
	86	+	GROUP BY day
	87	+	ORDER BY day ASC;
63	88
64	89		-- name: DeleteHistoryByDomain :exec
65	90		DELETE FROM history WHERE domain = @domain;
66	91
67	92		-- name: SearchHistoryFTSUrl :many
68		-	SELECT h.id, h.url, h.title, h.favicon_url, h.visit_count, h.last_visited, h.created_at
	93	+	SELECT h.id, h.url, h.title, h.favicon_url, h.visit_count, h.last_visited, h.created_at, h.domain
69	94		FROM history_fts fts
70	95		JOIN history h ON fts.rowid = h.id
71	96		WHERE fts.url MATCH @query

     last_visited = CURRENT_TIMESTAMP,
     title = COALESCE(EXCLUDED.title, history.title),
     favicon_url = COALESCE(EXCLUDED.favicon_url, history.favicon_url),
-    domain = EXCLUDED.domain;
+    domain = COALESCE(EXCLUDED.domain, history.domain);
 -- name: IncrementVisitCount :exec
 UPDATE history
 DELETE FROM history;
 -- name: GetHistoryStats :one
-SELECT COUNT(*) as total_entries, COALESCE(SUM(visit_count), 0) as total_visits, COUNT(DISTINCT date(last_visited)) as unique_days FROM history;
+SELECT
+    COUNT(*) as total_entries,
+    COALESCE(SUM(visit_count), 0) as total_visits,
+    COUNT(DISTINCT date(last_visited)) as unique_days
+FROM history;
 -- name: GetDomainStats :many
-SELECT COALESCE(domain, '') as domain, COUNT(*) as page_count, SUM(visit_count) as total_visits, MAX(last_visited) as last_visit FROM history WHERE domain IS NOT NULL AND domain != '' GROUP BY domain ORDER BY total_visits DESC LIMIT ?;
+SELECT
+    COALESCE(domain, '') as domain,
+    COUNT(*) as page_count,
+    SUM(visit_count) as total_visits,
+    MAX(last_visited) as last_visit
+FROM history
+WHERE domain IS NOT NULL AND domain != ''
+GROUP BY domain
+ORDER BY total_visits DESC
+LIMIT ?;
 -- name: GetHourlyDistribution :many
-SELECT CAST(strftime('%H', last_visited) AS INTEGER) as hour, COUNT(*) as visit_count FROM history GROUP BY hour ORDER BY hour;
+SELECT
+    CAST(strftime('%H', last_visited) AS INTEGER) as hour,
+    COUNT(*) as visit_count
+FROM history
+GROUP BY hour
+ORDER BY hour;
 -- name: GetDailyVisitCount :many
-SELECT date(last_visited) as day, COUNT(*) as entries, SUM(visit_count) as visits FROM history WHERE last_visited >= date('now', ?) GROUP BY day ORDER BY day ASC;
+SELECT
+    date(last_visited) as day,
+    COUNT(*) as entries,
+    SUM(visit_count) as visits
+FROM history
+WHERE last_visited >= date('now', ?)
+GROUP BY day
+ORDER BY day ASC;
 -- name: DeleteHistoryByDomain :exec
 DELETE FROM history WHERE domain = @domain;
 -- name: SearchHistoryFTSUrl :many
-SELECT h.id, h.url, h.title, h.favicon_url, h.visit_count, h.last_visited, h.created_at
+SELECT h.id, h.url, h.title, h.favicon_url, h.visit_count, h.last_visited, h.created_at, h.domain
 FROM history_fts fts
 JOIN history h ON fts.rowid = h.id
 WHERE fts.url MATCH @query

M internal/infrastructure/persistence/sqlite/sqlc/history.sql.go +35 -19


@@ -145,7 +145,14 @@ func (q *Queries) GetAllRecentHistory(ctx context.Context) ([]History, error) {
145	145		}
146	146
147	147		const GetDailyVisitCount = `-- name: GetDailyVisitCount :many
148		-	SELECT date(last_visited) as day, COUNT(*) as entries, SUM(visit_count) as visits FROM history WHERE last_visited >= date('now', ?) GROUP BY day ORDER BY day ASC
	148	+	SELECT
	149	+	date(last_visited) as day,
	150	+	COUNT(*) as entries,
	151	+	SUM(visit_count) as visits
	152	+	FROM history
	153	+	WHERE last_visited >= date('now', ?)
	154	+	GROUP BY day
	155	+	ORDER BY day ASC
149	156		`
150	157
151	158		type GetDailyVisitCountRow struct {

@@ -178,7 +185,16 @@ func (q *Queries) GetDailyVisitCount(ctx context.Context, date interface{}) ([]G
178	185		}
179	186
180	187		const GetDomainStats = `-- name: GetDomainStats :many
181		-	SELECT COALESCE(domain, '') as domain, COUNT(*) as page_count, SUM(visit_count) as total_visits, MAX(last_visited) as last_visit FROM history WHERE domain IS NOT NULL AND domain != '' GROUP BY domain ORDER BY total_visits DESC LIMIT ?
	188	+	SELECT
	189	+	COALESCE(domain, '') as domain,
	190	+	COUNT(*) as page_count,
	191	+	SUM(visit_count) as total_visits,
	192	+	MAX(last_visited) as last_visit
	193	+	FROM history
	194	+	WHERE domain IS NOT NULL AND domain != ''
	195	+	GROUP BY domain
	196	+	ORDER BY total_visits DESC
	197	+	LIMIT ?
182	198		`
183	199
184	200		type GetDomainStatsRow struct {

@@ -237,7 +253,11 @@ func (q *Queries) GetHistoryByURL(ctx context.Context, url string) (History, err
237	253		}
238	254
239	255		const GetHistoryStats = `-- name: GetHistoryStats :one
240		-	SELECT COUNT(*) as total_entries, COALESCE(SUM(visit_count), 0) as total_visits, COUNT(DISTINCT date(last_visited)) as unique_days FROM history
	256	+	SELECT
	257	+	COUNT(*) as total_entries,
	258	+	COALESCE(SUM(visit_count), 0) as total_visits,
	259	+	COUNT(DISTINCT date(last_visited)) as unique_days
	260	+	FROM history
241	261		`
242	262
243	263		type GetHistoryStatsRow struct {

@@ -254,7 +274,12 @@ func (q *Queries) GetHistoryStats(ctx context.Context) (GetHistoryStatsRow, erro
254	274		}
255	275
256	276		const GetHourlyDistribution = `-- name: GetHourlyDistribution :many
257		-	SELECT CAST(strftime('%H', last_visited) AS INTEGER) as hour, COUNT(*) as visit_count FROM history GROUP BY hour ORDER BY hour
	277	+	SELECT
	278	+	CAST(strftime('%H', last_visited) AS INTEGER) as hour,
	279	+	COUNT(*) as visit_count
	280	+	FROM history
	281	+	GROUP BY hour
	282	+	ORDER BY hour
258	283		`
259	284
260	285		type GetHourlyDistributionRow struct {

@@ -566,7 +591,7 @@ func (q *Queries) SearchHistoryFTSTitle(ctx context.Context, arg SearchHistoryFT
566	591		}
567	592
568	593		const SearchHistoryFTSUrl = `-- name: SearchHistoryFTSUrl :many
569		-	SELECT h.id, h.url, h.title, h.favicon_url, h.visit_count, h.last_visited, h.created_at
	594	+	SELECT h.id, h.url, h.title, h.favicon_url, h.visit_count, h.last_visited, h.created_at, h.domain
570	595		FROM history_fts fts
571	596		JOIN history h ON fts.rowid = h.id
572	597		WHERE fts.url MATCH ?1

@@ -579,25 +604,15 @@ type SearchHistoryFTSUrlParams struct {
579	604		Limit int64 `json:"limit"`
580	605		}
581	606
582		-	type SearchHistoryFTSUrlRow struct {
583		-	ID int64 `json:"id"`
584		-	Url string `json:"url"`
585		-	Title sql.NullString `json:"title"`
586		-	FaviconUrl sql.NullString `json:"favicon_url"`
587		-	VisitCount sql.NullInt64 `json:"visit_count"`
588		-	LastVisited sql.NullTime `json:"last_visited"`
589		-	CreatedAt sql.NullTime `json:"created_at"`
590		-	}
591		-
592		-	func (q *Queries) SearchHistoryFTSUrl(ctx context.Context, arg SearchHistoryFTSUrlParams) ([]SearchHistoryFTSUrlRow, error) {
	607	+	func (q *Queries) SearchHistoryFTSUrl(ctx context.Context, arg SearchHistoryFTSUrlParams) ([]History, error) {
593	608		rows, err := q.db.QueryContext(ctx, SearchHistoryFTSUrl, arg.Query, arg.Limit)
594	609		if err != nil {
595	610		return nil, err
596	611		}
597	612		defer rows.Close()
598		-	items := []SearchHistoryFTSUrlRow{}
	613	+	items := []History{}
599	614		for rows.Next() {
600		-	var i SearchHistoryFTSUrlRow
	615	+	var i History
601	616		if err := rows.Scan(
602	617		&i.ID,
603	618		&i.Url,

@@ -606,6 +621,7 @@ func (q *Queries) SearchHistoryFTSUrl(ctx context.Context, arg SearchHistoryFTSU
606	621		&i.VisitCount,
607	622		&i.LastVisited,
608	623		&i.CreatedAt,
	624	+	&i.Domain,
609	625		); err != nil {
610	626		return nil, err
611	627		}

@@ -694,7 +710,7 @@ DO UPDATE SET
694	710		last_visited = CURRENT_TIMESTAMP,
695	711		title = COALESCE(EXCLUDED.title, history.title),
696	712		favicon_url = COALESCE(EXCLUDED.favicon_url, history.favicon_url),
697		-	domain = EXCLUDED.domain
	713	+	domain = COALESCE(EXCLUDED.domain, history.domain)
698	714		`
699	715
700	716		type UpsertHistoryParams struct {

 }
 const GetDailyVisitCount = `-- name: GetDailyVisitCount :many
-SELECT date(last_visited) as day, COUNT(*) as entries, SUM(visit_count) as visits FROM history WHERE last_visited >= date('now', ?) GROUP BY day ORDER BY day ASC
+SELECT
+    date(last_visited) as day,
+    COUNT(*) as entries,
+    SUM(visit_count) as visits
+FROM history
+WHERE last_visited >= date('now', ?)
+GROUP BY day
+ORDER BY day ASC
 `
 type GetDailyVisitCountRow struct {
 }
 const GetDomainStats = `-- name: GetDomainStats :many
-SELECT COALESCE(domain, '') as domain, COUNT(*) as page_count, SUM(visit_count) as total_visits, MAX(last_visited) as last_visit FROM history WHERE domain IS NOT NULL AND domain != '' GROUP BY domain ORDER BY total_visits DESC LIMIT ?
+SELECT
+    COALESCE(domain, '') as domain,
+    COUNT(*) as page_count,
+    SUM(visit_count) as total_visits,
+    MAX(last_visited) as last_visit
+FROM history
+WHERE domain IS NOT NULL AND domain != ''
+GROUP BY domain
+ORDER BY total_visits DESC
+LIMIT ?
 `
 type GetDomainStatsRow struct {
 }
 const GetHistoryStats = `-- name: GetHistoryStats :one
-SELECT COUNT(*) as total_entries, COALESCE(SUM(visit_count), 0) as total_visits, COUNT(DISTINCT date(last_visited)) as unique_days FROM history
+SELECT
+    COUNT(*) as total_entries,
+    COALESCE(SUM(visit_count), 0) as total_visits,
+    COUNT(DISTINCT date(last_visited)) as unique_days
+FROM history
 `
 type GetHistoryStatsRow struct {
 }
 const GetHourlyDistribution = `-- name: GetHourlyDistribution :many
-SELECT CAST(strftime('%H', last_visited) AS INTEGER) as hour, COUNT(*) as visit_count FROM history GROUP BY hour ORDER BY hour
+SELECT
+    CAST(strftime('%H', last_visited) AS INTEGER) as hour,
+    COUNT(*) as visit_count
+FROM history
+GROUP BY hour
+ORDER BY hour
 `
 type GetHourlyDistributionRow struct {
 }
 const SearchHistoryFTSUrl = `-- name: SearchHistoryFTSUrl :many
-SELECT h.id, h.url, h.title, h.favicon_url, h.visit_count, h.last_visited, h.created_at
+SELECT h.id, h.url, h.title, h.favicon_url, h.visit_count, h.last_visited, h.created_at, h.domain
 FROM history_fts fts
 JOIN history h ON fts.rowid = h.id
 WHERE fts.url MATCH ?1
 	Limit int64  `json:"limit"`
 }
-type SearchHistoryFTSUrlRow struct {
+func (q *Queries) SearchHistoryFTSUrl(ctx context.Context, arg SearchHistoryFTSUrlParams) ([]History, error) {
-	ID          int64          `json:"id"`
-	Url         string         `json:"url"`
-	Title       sql.NullString `json:"title"`
-	FaviconUrl  sql.NullString `json:"favicon_url"`
-	VisitCount  sql.NullInt64  `json:"visit_count"`
-	LastVisited sql.NullTime   `json:"last_visited"`
-	CreatedAt   sql.NullTime   `json:"created_at"`
-}
-func (q *Queries) SearchHistoryFTSUrl(ctx context.Context, arg SearchHistoryFTSUrlParams) ([]SearchHistoryFTSUrlRow, error) {
 	rows, err := q.db.QueryContext(ctx, SearchHistoryFTSUrl, arg.Query, arg.Limit)
 	if err != nil {
 		return nil, err
 	}
 	defer rows.Close()
-	items := []SearchHistoryFTSUrlRow{}
+	items := []History{}
 	for rows.Next() {
-		var i SearchHistoryFTSUrlRow
+		var i History
 		if err := rows.Scan(
 			&i.ID,
 			&i.Url,
 			&i.VisitCount,
 			&i.LastVisited,
 			&i.CreatedAt,
+			&i.Domain,
 		); err != nil {
 			return nil, err
 		}
     last_visited = CURRENT_TIMESTAMP,
     title = COALESCE(EXCLUDED.title, history.title),
     favicon_url = COALESCE(EXCLUDED.favicon_url, history.favicon_url),
-    domain = EXCLUDED.domain
+    domain = COALESCE(EXCLUDED.domain, history.domain)
 `
 type UpsertHistoryParams struct {

M internal/infrastructure/persistence/sqlite/sqlc/querier.go +1 -1


@@ -79,7 +79,7 @@ type Querier interface {
79	79		RemoveTagFromFavorite(ctx context.Context, arg RemoveTagFromFavoriteParams) error
80	80		SearchHistory(ctx context.Context, arg SearchHistoryParams) ([]History, error)
81	81		SearchHistoryFTSTitle(ctx context.Context, arg SearchHistoryFTSTitleParams) ([]History, error)
82		-	SearchHistoryFTSUrl(ctx context.Context, arg SearchHistoryFTSUrlParams) ([]SearchHistoryFTSUrlRow, error)
	82	+	SearchHistoryFTSUrl(ctx context.Context, arg SearchHistoryFTSUrlParams) ([]History, error)
83	83		SearchHistoryFTSUrlWithDomainBoost(ctx context.Context, arg SearchHistoryFTSUrlWithDomainBoostParams) ([]SearchHistoryFTSUrlWithDomainBoostRow, error)
84	84		SetFavoriteFolder(ctx context.Context, arg SetFavoriteFolderParams) error
85	85		SetFavoriteShortcut(ctx context.Context, arg SetFavoriteShortcutParams) error


@@ -79,7 +79,7 @@ type Querier interface {
79		RemoveTagFromFavorite(ctx context.Context, arg RemoveTagFromFavoriteParams) error	79		RemoveTagFromFavorite(ctx context.Context, arg RemoveTagFromFavoriteParams) error
80		SearchHistory(ctx context.Context, arg SearchHistoryParams) ([]History, error)	80		SearchHistory(ctx context.Context, arg SearchHistoryParams) ([]History, error)
81		SearchHistoryFTSTitle(ctx context.Context, arg SearchHistoryFTSTitleParams) ([]History, error)	81		SearchHistoryFTSTitle(ctx context.Context, arg SearchHistoryFTSTitleParams) ([]History, error)
82	-	SearchHistoryFTSUrl(ctx context.Context, arg SearchHistoryFTSUrlParams) ([]SearchHistoryFTSUrlRow, error)	82	+	SearchHistoryFTSUrl(ctx context.Context, arg SearchHistoryFTSUrlParams) ([]History, error)
83		SearchHistoryFTSUrlWithDomainBoost(ctx context.Context, arg SearchHistoryFTSUrlWithDomainBoostParams) ([]SearchHistoryFTSUrlWithDomainBoostRow, error)	83		SearchHistoryFTSUrlWithDomainBoost(ctx context.Context, arg SearchHistoryFTSUrlWithDomainBoostParams) ([]SearchHistoryFTSUrlWithDomainBoostRow, error)
84		SetFavoriteFolder(ctx context.Context, arg SetFavoriteFolderParams) error	84		SetFavoriteFolder(ctx context.Context, arg SetFavoriteFolderParams) error
85		SetFavoriteShortcut(ctx context.Context, arg SetFavoriteShortcutParams) error	85		SetFavoriteShortcut(ctx context.Context, arg SetFavoriteShortcutParams) error

M internal/infrastructure/systemviewsbridge/client.go +7 -8


@@ -9,6 +9,7 @@ import (
9	9		"sync/atomic"
10	10		"time"
11	11
	12	+	"github.com/bnema/dumber/internal/application/dto"
12	13		"github.com/bnema/dumber/internal/application/port"
13	14		"github.com/bnema/dumber/internal/domain/entity"
14	15		)

@@ -143,21 +144,21 @@ func (c *Client) DeleteRange(ctx context.Context, rangeID string) error {
143	144
144	145		// Current intentionally targets the direct HTTP config endpoint rather than a
145	146		// snake_case bridge message so CEF/WebKit fetch shims can reuse /api/config.
146		-	func (c *Client) Current(ctx context.Context) (port.SystemviewConfigPayload, error) {
147		-	return request[port.SystemviewConfigPayload](c, ctx, "/api/config", struct {
	147	+	func (c *Client) Current(ctx context.Context) (dto.SystemviewConfigPayload, error) {
	148	+	return request[dto.SystemviewConfigPayload](c, ctx, "/api/config", struct {
148	149		RequestID string `json:"requestId"`
149	150		}{RequestID: nextRequestID()})
150	151		}
151	152
152	153		// Default intentionally targets the direct HTTP config endpoint rather than a
153	154		// snake_case bridge message so CEF/WebKit fetch shims can reuse /api/config/default.
154		-	func (c *Client) Default(ctx context.Context) (port.SystemviewConfigPayload, error) {
155		-	return request[port.SystemviewConfigPayload](c, ctx, "/api/config/default", struct {
	155	+	func (c *Client) Default(ctx context.Context) (dto.SystemviewConfigPayload, error) {
	156	+	return request[dto.SystemviewConfigPayload](c, ctx, "/api/config/default", struct {
156	157		RequestID string `json:"requestId"`
157	158		}{RequestID: nextRequestID()})
158	159		}
159	160
160		-	func (c *Client) Save(ctx context.Context, cfg port.WebUIConfig) error {
	161	+	func (c *Client) Save(ctx context.Context, cfg dto.WebUIConfig) error {
161	162		_, err := request[struct{}](c, ctx, "save_config", cfg)
162	163		return err
163	164		}

@@ -482,10 +483,8 @@ func request[T any](c *Client, ctx context.Context, msgType string, payload any)
482	483		return decodeBridgeResponse[T](raw)
483	484		}
484	485
	486	+	// withBridgeRequestTimeout applies the bridge request timeout; ctx must be non-nil.
485	487		func (c *Client) withBridgeRequestTimeout(ctx context.Context) (context.Context, context.CancelFunc) {
486		-	if ctx == nil {
487		-	ctx = context.Background()
488		-	}
489	488		timeout := defaultBridgeRequestTimeout
490	489		if c != nil {
491	490		timeout = c.requestTimeout

 	"sync/atomic"
 	"time"
+	"github.com/bnema/dumber/internal/application/dto"
 	"github.com/bnema/dumber/internal/application/port"
 	"github.com/bnema/dumber/internal/domain/entity"
 )
 // Current intentionally targets the direct HTTP config endpoint rather than a
 // snake_case bridge message so CEF/WebKit fetch shims can reuse /api/config.
-func (c *Client) Current(ctx context.Context) (port.SystemviewConfigPayload, error) {
+func (c *Client) Current(ctx context.Context) (dto.SystemviewConfigPayload, error) {
-	return request[port.SystemviewConfigPayload](c, ctx, "/api/config", struct {
+	return request[dto.SystemviewConfigPayload](c, ctx, "/api/config", struct {
 		RequestID string `json:"requestId"`
 	}{RequestID: nextRequestID()})
 }
 // Default intentionally targets the direct HTTP config endpoint rather than a
 // snake_case bridge message so CEF/WebKit fetch shims can reuse /api/config/default.
-func (c *Client) Default(ctx context.Context) (port.SystemviewConfigPayload, error) {
+func (c *Client) Default(ctx context.Context) (dto.SystemviewConfigPayload, error) {
-	return request[port.SystemviewConfigPayload](c, ctx, "/api/config/default", struct {
+	return request[dto.SystemviewConfigPayload](c, ctx, "/api/config/default", struct {
 		RequestID string `json:"requestId"`
 	}{RequestID: nextRequestID()})
 }
-func (c *Client) Save(ctx context.Context, cfg port.WebUIConfig) error {
+func (c *Client) Save(ctx context.Context, cfg dto.WebUIConfig) error {
 	_, err := request[struct{}](c, ctx, "save_config", cfg)
 	return err
 }
 	return decodeBridgeResponse[T](raw)
 }
+// withBridgeRequestTimeout applies the bridge request timeout; ctx must be non-nil.
 func (c *Client) withBridgeRequestTimeout(ctx context.Context) (context.Context, context.CancelFunc) {
-	if ctx == nil {
-		ctx = context.Background()
-	}
 	timeout := defaultBridgeRequestTimeout
 	if c != nil {
 		timeout = c.requestTimeout

M internal/infrastructure/systemviewsbridge/client_test.go +3 -2


@@ -7,6 +7,7 @@ import (
7	7		"testing"
8	8		"time"
9	9
	10	+	"github.com/bnema/dumber/internal/application/dto"
10	11		"github.com/bnema/dumber/internal/application/port"
11	12		)
12	13

@@ -289,10 +290,10 @@ func TestClientConfigActionsUseExpectedMessageTypes(t *testing.T) {
289	290		{
290	291		name: "save config",
291	292		call: func(client *Client) error {
292		-	return client.Save(context.Background(), port.WebUIConfig{DefaultSearchEngine: "DuckDuckGo"})
	293	+	return client.Save(context.Background(), dto.WebUIConfig{DefaultSearchEngine: "DuckDuckGo"})
293	294		},
294	295		want: "save_config",
295		-	payload: port.WebUIConfig{DefaultSearchEngine: "DuckDuckGo"},
	296	+	payload: dto.WebUIConfig{DefaultSearchEngine: "DuckDuckGo"},
296	297		},
297	298		{
298	299		name: "get keybindings",

 	"testing"
 	"time"
+	"github.com/bnema/dumber/internal/application/dto"
 	"github.com/bnema/dumber/internal/application/port"
 )
 		{
 			name: "save config",
 			call: func(client *Client) error {
-				return client.Save(context.Background(), port.WebUIConfig{DefaultSearchEngine: "DuckDuckGo"})
+				return client.Save(context.Background(), dto.WebUIConfig{DefaultSearchEngine: "DuckDuckGo"})
 			},
 			want:    "save_config",
-			payload: port.WebUIConfig{DefaultSearchEngine: "DuckDuckGo"},
+			payload: dto.WebUIConfig{DefaultSearchEngine: "DuckDuckGo"},
 		},
 		{
 			name: "get keybindings",

M internal/infrastructure/webkit/scheme_handler.go +15 -7


@@ -355,20 +355,27 @@ func safeSystemviewsAssetPath(assetDir, relPath string) (fullPath, cleanRelPath
355	355		}
356	356
357	357		func readAssetWithEncoding(assets embed.FS, fullPath, relPath string) ([]byte, map[string]string, error) {
	358	+	var compressedErr error
358	359		if strings.HasSuffix(relPath, ".wasm") {
359	360		if compressed, err := fs.ReadFile(assets, fullPath+".br"); err == nil {
360	361		data, err := io.ReadAll(io.LimitReader(brotli.NewReader(bytes.NewReader(compressed)), maxSystemviewsWASMBytes+1))
361	362		if err != nil {
362		-	return nil, nil, err
	363	+	compressedErr = err
	364	+	} else if len(data) > maxSystemviewsWASMBytes {
	365	+	compressedErr = fmt.Errorf("decompressed asset %s exceeds %d bytes", fullPath, maxSystemviewsWASMBytes)
	366	+	} else {
	367	+	return data, nil, nil
363	368		}
364		-	if len(data) > maxSystemviewsWASMBytes {
365		-	return nil, nil, fmt.Errorf("decompressed asset %s exceeds %d bytes", fullPath, maxSystemviewsWASMBytes)
366		-	}
367		-	return data, nil, nil
368	369		}
369	370		}
370	371		data, err := fs.ReadFile(assets, fullPath)
371		-	return data, nil, err
	372	+	if err == nil {
	373	+	return data, nil, nil
	374	+	}
	375	+	if compressedErr != nil {
	376	+	return nil, nil, compressedErr
	377	+	}
	378	+	return nil, nil, err
372	379		}
373	380
374	381		func resolveAssetPath(u *url.URL) (assetDir, relPath string, ok bool) {

@@ -384,6 +391,7 @@ func resolveAssetPath(u *url.URL) (assetDir, relPath string, ok bool) {
384	391		FavoritesPath: {assetDir: systemviewsAssetDir, file: IndexHTML},
385	392		ConfigPath: {assetDir: systemviewsAssetDir, file: IndexHTML},
386	393		ErrorPath: {assetDir: systemviewsAssetDir, file: IndexHTML},
	394	+	CrashPath: {assetDir: systemviewsAssetDir, file: IndexHTML},
387	395		}
388	396
389	397		if root, ok := rootByHost[u.Host]; ok {

@@ -395,7 +403,7 @@ func resolveAssetPath(u *url.URL) (assetDir, relPath string, ok bool) {
395	403		}
396	404
397	405		switch u.Opaque {
398		-	case HistoryPath, FavoritesPath, ConfigPath, ErrorPath:
	406	+	case HistoryPath, FavoritesPath, ConfigPath, ErrorPath, CrashPath:
399	407		return systemviewsAssetDir, IndexHTML, true
400	408		default:
401	409		return "", "", false

 }
 func readAssetWithEncoding(assets embed.FS, fullPath, relPath string) ([]byte, map[string]string, error) {
+	var compressedErr error
 	if strings.HasSuffix(relPath, ".wasm") {
 		if compressed, err := fs.ReadFile(assets, fullPath+".br"); err == nil {
 			data, err := io.ReadAll(io.LimitReader(brotli.NewReader(bytes.NewReader(compressed)), maxSystemviewsWASMBytes+1))
 			if err != nil {
-				return nil, nil, err
+				compressedErr = err
+			} else if len(data) > maxSystemviewsWASMBytes {
+				compressedErr = fmt.Errorf("decompressed asset %s exceeds %d bytes", fullPath, maxSystemviewsWASMBytes)
+			} else {
+				return data, nil, nil
 			}
-			if len(data) > maxSystemviewsWASMBytes {
-				return nil, nil, fmt.Errorf("decompressed asset %s exceeds %d bytes", fullPath, maxSystemviewsWASMBytes)
-			}
-			return data, nil, nil
 		}
 	}
 	data, err := fs.ReadFile(assets, fullPath)
-	return data, nil, err
+	if err == nil {
+		return data, nil, nil
+	}
+	if compressedErr != nil {
+		return nil, nil, compressedErr
+	}
+	return nil, nil, err
 }
 func resolveAssetPath(u *url.URL) (assetDir, relPath string, ok bool) {
 		FavoritesPath: {assetDir: systemviewsAssetDir, file: IndexHTML},
 		ConfigPath:    {assetDir: systemviewsAssetDir, file: IndexHTML},
 		ErrorPath:     {assetDir: systemviewsAssetDir, file: IndexHTML},
+		CrashPath:     {assetDir: systemviewsAssetDir, file: IndexHTML},
 	}
 	if root, ok := rootByHost[u.Host]; ok {
 	}
 	switch u.Opaque {
-	case HistoryPath, FavoritesPath, ConfigPath, ErrorPath:
+	case HistoryPath, FavoritesPath, ConfigPath, ErrorPath, CrashPath:
 		return systemviewsAssetDir, IndexHTML, true
 	default:
 		return "", "", false

M internal/ui/app_clipboard_test.go +3 -2


@@ -4,6 +4,7 @@ import (
4	4		"context"
5	5		"testing"
6	6
	7	+	"github.com/bnema/dumber/internal/application/dto"
7	8		"github.com/bnema/dumber/internal/application/port"
8	9		portmocks "github.com/bnema/dumber/internal/application/port/mocks"
9	10		"github.com/bnema/dumber/internal/domain/entity"

@@ -28,7 +29,7 @@ func TestNew_DoesNotWireClipboardOrchestratorWhenClipboardMissing(t *testing.T)
28	29		Config: &config.Config{},
29	30		Engine: engine,
30	31		HandlerDeps: port.HandlerDeps{
31		-	SaveConfig: func(context.Context, port.WebUIConfig) error { return nil },
	32	+	SaveConfig: func(context.Context, dto.WebUIConfig) error { return nil },
32	33		SaveOmniboxInitialBehavior: func(context.Context, entity.OmniboxInitialBehavior) error { return nil },
33	34		},
34	35		Clipboard: nil,

@@ -57,7 +58,7 @@ func TestNew_WiresClipboardOrchestratorWhenClipboardPresent(t *testing.T) {
57	58		Config: &config.Config{},
58	59		Engine: engine,
59	60		HandlerDeps: port.HandlerDeps{
60		-	SaveConfig: func(context.Context, port.WebUIConfig) error { return nil },
	61	+	SaveConfig: func(context.Context, dto.WebUIConfig) error { return nil },
61	62		SaveOmniboxInitialBehavior: func(context.Context, entity.OmniboxInitialBehavior) error { return nil },
62	63		},
63	64		Clipboard: clipboard,

 	"context"
 	"testing"
+	"github.com/bnema/dumber/internal/application/dto"
 	"github.com/bnema/dumber/internal/application/port"
 	portmocks "github.com/bnema/dumber/internal/application/port/mocks"
 	"github.com/bnema/dumber/internal/domain/entity"
 		Config: &config.Config{},
 		Engine: engine,
 		HandlerDeps: port.HandlerDeps{
-			SaveConfig:                 func(context.Context, port.WebUIConfig) error { return nil },
+			SaveConfig:                 func(context.Context, dto.WebUIConfig) error { return nil },
 			SaveOmniboxInitialBehavior: func(context.Context, entity.OmniboxInitialBehavior) error { return nil },
 		},
 		Clipboard: nil,
 		Config: &config.Config{},
 		Engine: engine,
 		HandlerDeps: port.HandlerDeps{
-			SaveConfig:                 func(context.Context, port.WebUIConfig) error { return nil },
+			SaveConfig:                 func(context.Context, dto.WebUIConfig) error { return nil },
 			SaveOmniboxInitialBehavior: func(context.Context, entity.OmniboxInitialBehavior) error { return nil },
 		},
 		Clipboard: clipboard,

M internal/ui/coordinator/workspace.go +21 -2


@@ -4,6 +4,8 @@ import (
4	4		"context"
5	5		"errors"
6	6		"fmt"
	7	+	"net/url"
	8	+	"strings"
7	9
8	10		"github.com/bnema/dumber/internal/application/usecase"
9	11		"github.com/bnema/dumber/internal/domain/entity"

@@ -261,21 +263,38 @@ func (c *WorkspaceCoordinator) ToggleSystemViewRight(ctx context.Context, target
261	263		}
262	264
263	265		func paneMatchesURL(node *entity.PaneNode, targetURL string) bool {
264		-	return node != nil && node.Pane != nil && domainurl.Normalize(node.Pane.URI) == targetURL
	266	+	return node != nil && node.Pane != nil && comparablePaneURL(node.Pane.URI) == comparablePaneURL(targetURL)
265	267		}
266	268
267	269		func findPaneByURL(ws entity.Workspace, targetURL string) entity.Pane {
268	270		if ws == nil {
269	271		return nil
270	272		}
	273	+	targetURL = comparablePaneURL(targetURL)
271	274		for _, pane := range ws.AllPanes() {
272		-	if pane != nil && domainurl.Normalize(pane.URI) == targetURL {
	275	+	if pane != nil && comparablePaneURL(pane.URI) == targetURL {
273	276		return pane
274	277		}
275	278		}
276	279		return nil
277	280		}
278	281
	282	+	func comparablePaneURL(raw string) string {
	283	+	normalized := domainurl.Normalize(raw)
	284	+	parsed, err := url.Parse(normalized)
	285	+	if err != nil \|\| !strings.EqualFold(parsed.Scheme, "dumb") {
	286	+	return normalized
	287	+	}
	288	+	page := parsed.Host
	289	+	if page == "" {
	290	+	page = parsed.Opaque
	291	+	}
	292	+	if page == "" \|\| parsed.Path != "" \|\| parsed.RawQuery != "" \|\| parsed.Fragment != "" {
	293	+	return normalized
	294	+	}
	295	+	return "dumb:" + page
	296	+	}
	297	+
279	298		func (c *WorkspaceCoordinator) focusExistingPane(
280	299		ctx context.Context,
281	300		ws *entity.Workspace,

 	"context"
 	"errors"
 	"fmt"
+	"net/url"
+	"strings"
 	"github.com/bnema/dumber/internal/application/usecase"
 	"github.com/bnema/dumber/internal/domain/entity"
 }
 func paneMatchesURL(node *entity.PaneNode, targetURL string) bool {
-	return node != nil && node.Pane != nil && domainurl.Normalize(node.Pane.URI) == targetURL
+	return node != nil && node.Pane != nil && comparablePaneURL(node.Pane.URI) == comparablePaneURL(targetURL)
 }
 func findPaneByURL(ws *entity.Workspace, targetURL string) *entity.Pane {
 	if ws == nil {
 		return nil
 	}
+	targetURL = comparablePaneURL(targetURL)
 	for _, pane := range ws.AllPanes() {
-		if pane != nil && domainurl.Normalize(pane.URI) == targetURL {
+		if pane != nil && comparablePaneURL(pane.URI) == targetURL {
 			return pane
 		}
 	}
 	return nil
 }
+func comparablePaneURL(raw string) string {
+	normalized := domainurl.Normalize(raw)
+	parsed, err := url.Parse(normalized)
+	if err != nil || !strings.EqualFold(parsed.Scheme, "dumb") {
+		return normalized
+	}
+	page := parsed.Host
+	if page == "" {
+		page = parsed.Opaque
+	}
+	if page == "" || parsed.Path != "" || parsed.RawQuery != "" || parsed.Fragment != "" {
+		return normalized
+	}
+	return "dumb:" + page
+}
 func (c *WorkspaceCoordinator) focusExistingPane(
 	ctx context.Context,
 	ws *entity.Workspace,

M internal/ui/systemviews/app.go +2 -1


@@ -7,6 +7,7 @@ import (
7	7		"strings"
8	8		"sync"
9	9
	10	+	"github.com/bnema/dumber/internal/application/dto"
10	11		"github.com/bnema/dumber/internal/application/port"
11	12		"github.com/bnema/dumber/internal/domain/entity"
12	13		)

@@ -42,7 +43,7 @@ type App struct {
42	43		favoriteTagFilter *entity.TagID
43	44		favoritesNotice string
44	45		favoritesError string
45		-	config *port.SystemviewConfigPayload
	46	+	config *dto.SystemviewConfigPayload
46	47		keybindings port.KeybindingsConfig
47	48		configNotice string
48	49		configError string

 	"strings"
 	"sync"
+	"github.com/bnema/dumber/internal/application/dto"
 	"github.com/bnema/dumber/internal/application/port"
 	"github.com/bnema/dumber/internal/domain/entity"
 )
 	favoriteTagFilter    *entity.TagID
 	favoritesNotice      string
 	favoritesError       string
-	config               *port.SystemviewConfigPayload
+	config               *dto.SystemviewConfigPayload
 	keybindings          port.KeybindingsConfig
 	configNotice         string
 	configError          string

M internal/ui/systemviews/app_test.go +30 -29


@@ -5,6 +5,7 @@ import (
5	5		"errors"
6	6		"testing"
7	7
	8	+	"github.com/bnema/dumber/internal/application/dto"
8	9		"github.com/bnema/dumber/internal/application/port"
9	10		"github.com/bnema/dumber/internal/domain/entity"
10	11		"github.com/stretchr/testify/assert"

@@ -245,10 +246,10 @@ func TestAppLoadInitialHistoryRouteAppliesThemeTokens(t *testing.T) {
245	246		URL: "https://example.com",
246	247		Title: "Example",
247	248		}}}
248		-	config := &fakeConfigService{current: port.SystemviewConfigPayload{
249		-	Appearance: port.WebUIAppearanceConfig{
	249	+	config := &fakeConfigService{current: dto.SystemviewConfigPayload{
	250	+	Appearance: dto.WebUIAppearanceConfig{
250	251		ColorScheme: "prefer-light",
251		-	LightPalette: port.ColorPalette{
	252	+	LightPalette: dto.ColorPalette{
252	253		Background: "#ffffff",
253	254		Surface: "#fafafa",
254	255		SurfaceVariant: "#eeeeee",

@@ -257,7 +258,7 @@ func TestAppLoadInitialHistoryRouteAppliesThemeTokens(t *testing.T) {
257	258		Accent: "#0055ff",
258	259		Border: "#dddddd",
259	260		},
260		-	DarkPalette: port.ColorPalette{
	261	+	DarkPalette: dto.ColorPalette{
261	262		Background: "#111111",
262	263		Surface: "#1a1a1a",
263	264		SurfaceVariant: "#2a2a2a",

@@ -425,15 +426,15 @@ func TestAppHandleFavoriteActionsRefreshesDOM(t *testing.T) {
425	426		func TestAppLoadInitialConfigRouteRendersData(t *testing.T) {
426	427		t.Parallel()
427	428
428		-	config := port.SystemviewConfigPayload{
	429	+	config := dto.SystemviewConfigPayload{
429	430		EngineType: "webkit",
430		-	Appearance: port.WebUIAppearanceConfig{
	431	+	Appearance: dto.WebUIAppearanceConfig{
431	432		ColorScheme: "prefer-dark",
432	433		SansFont: "Inter",
433	434		SerifFont: "Georgia",
434	435		MonospaceFont: "JetBrains Mono",
435	436		DefaultFontSize: 16,
436		-	LightPalette: port.ColorPalette{
	437	+	LightPalette: dto.ColorPalette{
437	438		Background: "#ffffff",
438	439		Surface: "#fafafa",
439	440		SurfaceVariant: "#eeeeee",

@@ -442,7 +443,7 @@ func TestAppLoadInitialConfigRouteRendersData(t *testing.T) {
442	443		Accent: "#0055ff",
443	444		Border: "#dddddd",
444	445		},
445		-	DarkPalette: port.ColorPalette{
	446	+	DarkPalette: dto.ColorPalette{
446	447		Background: "#111111",
447	448		Surface: "#1a1a1a",
448	449		SurfaceVariant: "#2a2a2a",

@@ -452,16 +453,16 @@ func TestAppLoadInitialConfigRouteRendersData(t *testing.T) {
452	453		Border: "#333333",
453	454		},
454	455		},
455		-	Performance: port.SystemviewPerformancePayload{
	456	+	Performance: dto.SystemviewPerformancePayload{
456	457		Profile: "balanced",
457		-	Custom: port.SystemviewCustomPerformancePayload{
	458	+	Custom: dto.SystemviewCustomPerformancePayload{
458	459		SkiaCPUThreads: 4,
459	460		SkiaGPUThreads: 2,
460	461		WebProcessMemoryMB: 512,
461	462		NetworkProcessMemoryMB: 128,
462	463		WebViewPoolPrewarm: 1,
463	464		},
464		-	Hardware: port.SystemviewHardwarePayload{
	465	+	Hardware: dto.SystemviewHardwarePayload{
465	466		CPUCores: 8,
466	467		CPUThreads: 16,
467	468		TotalRAMMB: 32768,

@@ -471,7 +472,7 @@ func TestAppLoadInitialConfigRouteRendersData(t *testing.T) {
471	472		},
472	473		},
473	474		DefaultSearchEngine: "https://duckduckgo.com/?q=%s",
474		-	SearchShortcuts: map[string]port.SearchShortcut{
	475	+	SearchShortcuts: map[string]dto.SearchShortcut{
475	476		"ddg": {
476	477		URL: "https://duckduckgo.com/?q=%s",
477	478		Description: "DuckDuckGo",

@@ -685,32 +686,32 @@ func TestAppRejectsSearchURLsWithoutPlaceholder(t *testing.T) {
685	686		assert.False(t, service.calledSave)
686	687		}
687	688
688		-	func testConfigPayload() port.SystemviewConfigPayload {
689		-	return port.SystemviewConfigPayload{
	689	+	func testConfigPayload() dto.SystemviewConfigPayload {
	690	+	return dto.SystemviewConfigPayload{
690	691		EngineType: "webkit",
691		-	Appearance: port.WebUIAppearanceConfig{
	692	+	Appearance: dto.WebUIAppearanceConfig{
692	693		ColorScheme: "prefer-dark",
693	694		SansFont: "Inter",
694	695		SerifFont: "Georgia",
695	696		MonospaceFont: "JetBrains Mono",
696	697		DefaultFontSize: 16,
697		-	LightPalette: port.ColorPalette{Background: "#ffffff", Surface: "#fafafa", SurfaceVariant: "#eeeeee", Text: "#111111", Muted: "#666666", Accent: "#0055ff", Border: "#dddddd"},
698		-	DarkPalette: port.ColorPalette{Background: "#111111", Surface: "#1a1a1a", SurfaceVariant: "#2a2a2a", Text: "#f5f5f5", Muted: "#a0a0a0", Accent: "#66aaff", Border: "#333333"},
	698	+	LightPalette: dto.ColorPalette{Background: "#ffffff", Surface: "#fafafa", SurfaceVariant: "#eeeeee", Text: "#111111", Muted: "#666666", Accent: "#0055ff", Border: "#dddddd"},
	699	+	DarkPalette: dto.ColorPalette{Background: "#111111", Surface: "#1a1a1a", SurfaceVariant: "#2a2a2a", Text: "#f5f5f5", Muted: "#a0a0a0", Accent: "#66aaff", Border: "#333333"},
699	700		},
700	701		DefaultUIScale: 1,
701	702		DefaultSearchEngine: "https://duckduckgo.com/?q=%s",
702		-	SearchShortcuts: map[string]port.SearchShortcut{
	703	+	SearchShortcuts: map[string]dto.SearchShortcut{
703	704		"ddg": {URL: "https://duckduckgo.com/?q=%s", Description: "DuckDuckGo"},
704	705		},
705		-	Performance: port.SystemviewPerformancePayload{
	706	+	Performance: dto.SystemviewPerformancePayload{
706	707		Profile: "default",
707		-	Custom: port.SystemviewCustomPerformancePayload{SkiaCPUThreads: 2, SkiaGPUThreads: 1, WebProcessMemoryMB: 1024, NetworkProcessMemoryMB: 256, WebViewPoolPrewarm: 2},
708		-	Hardware: port.SystemviewHardwarePayload{CPUCores: 4, CPUThreads: 8, TotalRAMMB: 16384, GPUVendor: "AMD", GPUName: "Radeon", VRAMMB: 4096},
	708	+	Custom: dto.SystemviewCustomPerformancePayload{SkiaCPUThreads: 2, SkiaGPUThreads: 1, WebProcessMemoryMB: 1024, NetworkProcessMemoryMB: 256, WebViewPoolPrewarm: 2},
	709	+	Hardware: dto.SystemviewHardwarePayload{CPUCores: 4, CPUThreads: 8, TotalRAMMB: 16384, GPUVendor: "AMD", GPUName: "Radeon", VRAMMB: 4096},
709	710		},
710	711		}
711	712		}
712	713
713		-	func testDefaultConfigPayload() port.SystemviewConfigPayload {
	714	+	func testDefaultConfigPayload() dto.SystemviewConfigPayload {
714	715		cfg := testConfigPayload()
715	716		cfg.Appearance.DefaultFontSize = 14
716	717		cfg.DefaultUIScale = 1

@@ -934,26 +935,26 @@ type fakeConfigService struct {
934	935		calledReset bool
935	936		calledResetAll bool
936	937
937		-	current port.SystemviewConfigPayload
938		-	defaultCfg port.SystemviewConfigPayload
	938	+	current dto.SystemviewConfigPayload
	939	+	defaultCfg dto.SystemviewConfigPayload
939	940		keybindings port.KeybindingsConfig
940		-	savedConfig port.WebUIConfig
	941	+	savedConfig dto.WebUIConfig
941	942		setReq port.SetKeybindingRequest
942	943		setResp port.SetKeybindingResponse
943	944		resetReq port.ResetKeybindingRequest
944	945		}
945	946
946		-	func (s *fakeConfigService) Current(context.Context) (port.SystemviewConfigPayload, error) {
	947	+	func (s *fakeConfigService) Current(context.Context) (dto.SystemviewConfigPayload, error) {
947	948		s.calledCurrent = true
948	949		return s.current, nil
949	950		}
950	951
951		-	func (s *fakeConfigService) Default(context.Context) (port.SystemviewConfigPayload, error) {
	952	+	func (s *fakeConfigService) Default(context.Context) (dto.SystemviewConfigPayload, error) {
952	953		s.calledDefault = true
953	954		return s.defaultCfg, nil
954	955		}
955	956
956		-	func (s *fakeConfigService) Save(_ context.Context, cfg port.WebUIConfig) error {
	957	+	func (s *fakeConfigService) Save(_ context.Context, cfg dto.WebUIConfig) error {
957	958		s.calledSave = true
958	959		s.savedConfig = cfg
959	960		s.current.Appearance = cfg.Appearance

@@ -961,7 +962,7 @@ func (s *fakeConfigService) Save(_ context.Context, cfg port.WebUIConfig) error
961	962		s.current.DefaultSearchEngine = cfg.DefaultSearchEngine
962	963		s.current.SearchShortcuts = cfg.SearchShortcuts
963	964		s.current.Performance.Profile = cfg.Performance.Profile
964		-	s.current.Performance.Custom = port.SystemviewCustomPerformancePayload{
	965	+	s.current.Performance.Custom = dto.SystemviewCustomPerformancePayload{
965	966		SkiaCPUThreads: cfg.Performance.Custom.SkiaCPUThreads,
966	967		SkiaGPUThreads: cfg.Performance.Custom.SkiaGPUThreads,
967	968		WebProcessMemoryMB: cfg.Performance.Custom.WebProcessMemoryMB,

 	"errors"
 	"testing"
+	"github.com/bnema/dumber/internal/application/dto"
 	"github.com/bnema/dumber/internal/application/port"
 	"github.com/bnema/dumber/internal/domain/entity"
 	"github.com/stretchr/testify/assert"
 		URL:   "https://example.com",
 		Title: "Example",
 	}}}
-	config := &fakeConfigService{current: port.SystemviewConfigPayload{
+	config := &fakeConfigService{current: dto.SystemviewConfigPayload{
-		Appearance: port.WebUIAppearanceConfig{
+		Appearance: dto.WebUIAppearanceConfig{
 			ColorScheme: "prefer-light",
-			LightPalette: port.ColorPalette{
+			LightPalette: dto.ColorPalette{
 				Background:     "#ffffff",
 				Surface:        "#fafafa",
 				SurfaceVariant: "#eeeeee",
 				Accent:         "#0055ff",
 				Border:         "#dddddd",
 			},
-			DarkPalette: port.ColorPalette{
+			DarkPalette: dto.ColorPalette{
 				Background:     "#111111",
 				Surface:        "#1a1a1a",
 				SurfaceVariant: "#2a2a2a",
 func TestAppLoadInitialConfigRouteRendersData(t *testing.T) {
 	t.Parallel()
-	config := port.SystemviewConfigPayload{
+	config := dto.SystemviewConfigPayload{
 		EngineType: "webkit",
-		Appearance: port.WebUIAppearanceConfig{
+		Appearance: dto.WebUIAppearanceConfig{
 			ColorScheme:     "prefer-dark",
 			SansFont:        "Inter",
 			SerifFont:       "Georgia",
 			MonospaceFont:   "JetBrains Mono",
 			DefaultFontSize: 16,
-			LightPalette: port.ColorPalette{
+			LightPalette: dto.ColorPalette{
 				Background:     "#ffffff",
 				Surface:        "#fafafa",
 				SurfaceVariant: "#eeeeee",
 				Accent:         "#0055ff",
 				Border:         "#dddddd",
 			},
-			DarkPalette: port.ColorPalette{
+			DarkPalette: dto.ColorPalette{
 				Background:     "#111111",
 				Surface:        "#1a1a1a",
 				SurfaceVariant: "#2a2a2a",
 				Border:         "#333333",
 			},
 		},
-		Performance: port.SystemviewPerformancePayload{
+		Performance: dto.SystemviewPerformancePayload{
 			Profile: "balanced",
-			Custom: port.SystemviewCustomPerformancePayload{
+			Custom: dto.SystemviewCustomPerformancePayload{
 				SkiaCPUThreads:         4,
 				SkiaGPUThreads:         2,
 				WebProcessMemoryMB:     512,
 				NetworkProcessMemoryMB: 128,
 				WebViewPoolPrewarm:     1,
 			},
-			Hardware: port.SystemviewHardwarePayload{
+			Hardware: dto.SystemviewHardwarePayload{
 				CPUCores:   8,
 				CPUThreads: 16,
 				TotalRAMMB: 32768,
 			},
 		},
 		DefaultSearchEngine: "https://duckduckgo.com/?q=%s",
-		SearchShortcuts: map[string]port.SearchShortcut{
+		SearchShortcuts: map[string]dto.SearchShortcut{
 			"ddg": {
 				URL:         "https://duckduckgo.com/?q=%s",
 				Description: "DuckDuckGo",
 	assert.False(t, service.calledSave)
 }
-func testConfigPayload() port.SystemviewConfigPayload {
+func testConfigPayload() dto.SystemviewConfigPayload {
-	return port.SystemviewConfigPayload{
+	return dto.SystemviewConfigPayload{
 		EngineType: "webkit",
-		Appearance: port.WebUIAppearanceConfig{
+		Appearance: dto.WebUIAppearanceConfig{
 			ColorScheme:     "prefer-dark",
 			SansFont:        "Inter",
 			SerifFont:       "Georgia",
 			MonospaceFont:   "JetBrains Mono",
 			DefaultFontSize: 16,
-			LightPalette:    port.ColorPalette{Background: "#ffffff", Surface: "#fafafa", SurfaceVariant: "#eeeeee", Text: "#111111", Muted: "#666666", Accent: "#0055ff", Border: "#dddddd"},
+			LightPalette:    dto.ColorPalette{Background: "#ffffff", Surface: "#fafafa", SurfaceVariant: "#eeeeee", Text: "#111111", Muted: "#666666", Accent: "#0055ff", Border: "#dddddd"},
-			DarkPalette:     port.ColorPalette{Background: "#111111", Surface: "#1a1a1a", SurfaceVariant: "#2a2a2a", Text: "#f5f5f5", Muted: "#a0a0a0", Accent: "#66aaff", Border: "#333333"},
+			DarkPalette:     dto.ColorPalette{Background: "#111111", Surface: "#1a1a1a", SurfaceVariant: "#2a2a2a", Text: "#f5f5f5", Muted: "#a0a0a0", Accent: "#66aaff", Border: "#333333"},
 		},
 		DefaultUIScale:      1,
 		DefaultSearchEngine: "https://duckduckgo.com/?q=%s",
-		SearchShortcuts: map[string]port.SearchShortcut{
+		SearchShortcuts: map[string]dto.SearchShortcut{
 			"ddg": {URL: "https://duckduckgo.com/?q=%s", Description: "DuckDuckGo"},
 		},
-		Performance: port.SystemviewPerformancePayload{
+		Performance: dto.SystemviewPerformancePayload{
 			Profile:  "default",
-			Custom:   port.SystemviewCustomPerformancePayload{SkiaCPUThreads: 2, SkiaGPUThreads: 1, WebProcessMemoryMB: 1024, NetworkProcessMemoryMB: 256, WebViewPoolPrewarm: 2},
+			Custom:   dto.SystemviewCustomPerformancePayload{SkiaCPUThreads: 2, SkiaGPUThreads: 1, WebProcessMemoryMB: 1024, NetworkProcessMemoryMB: 256, WebViewPoolPrewarm: 2},
-			Hardware: port.SystemviewHardwarePayload{CPUCores: 4, CPUThreads: 8, TotalRAMMB: 16384, GPUVendor: "AMD", GPUName: "Radeon", VRAMMB: 4096},
+			Hardware: dto.SystemviewHardwarePayload{CPUCores: 4, CPUThreads: 8, TotalRAMMB: 16384, GPUVendor: "AMD", GPUName: "Radeon", VRAMMB: 4096},
 		},
 	}
 }
-func testDefaultConfigPayload() port.SystemviewConfigPayload {
+func testDefaultConfigPayload() dto.SystemviewConfigPayload {
 	cfg := testConfigPayload()
 	cfg.Appearance.DefaultFontSize = 14
 	cfg.DefaultUIScale = 1
 	calledReset       bool
 	calledResetAll    bool
-	current     port.SystemviewConfigPayload
+	current     dto.SystemviewConfigPayload
-	defaultCfg  port.SystemviewConfigPayload
+	defaultCfg  dto.SystemviewConfigPayload
 	keybindings port.KeybindingsConfig
-	savedConfig port.WebUIConfig
+	savedConfig dto.WebUIConfig
 	setReq      port.SetKeybindingRequest
 	setResp     port.SetKeybindingResponse
 	resetReq    port.ResetKeybindingRequest
 }
-func (s *fakeConfigService) Current(context.Context) (port.SystemviewConfigPayload, error) {
+func (s *fakeConfigService) Current(context.Context) (dto.SystemviewConfigPayload, error) {
 	s.calledCurrent = true
 	return s.current, nil
 }
-func (s *fakeConfigService) Default(context.Context) (port.SystemviewConfigPayload, error) {
+func (s *fakeConfigService) Default(context.Context) (dto.SystemviewConfigPayload, error) {
 	s.calledDefault = true
 	return s.defaultCfg, nil
 }
-func (s *fakeConfigService) Save(_ context.Context, cfg port.WebUIConfig) error {
+func (s *fakeConfigService) Save(_ context.Context, cfg dto.WebUIConfig) error {
 	s.calledSave = true
 	s.savedConfig = cfg
 	s.current.Appearance = cfg.Appearance
 	s.current.DefaultSearchEngine = cfg.DefaultSearchEngine
 	s.current.SearchShortcuts = cfg.SearchShortcuts
 	s.current.Performance.Profile = cfg.Performance.Profile
-	s.current.Performance.Custom = port.SystemviewCustomPerformancePayload{
+	s.current.Performance.Custom = dto.SystemviewCustomPerformancePayload{
 		SkiaCPUThreads:         cfg.Performance.Custom.SkiaCPUThreads,
 		SkiaGPUThreads:         cfg.Performance.Custom.SkiaGPUThreads,
 		WebProcessMemoryMB:     cfg.Performance.Custom.WebProcessMemoryMB,

M internal/ui/systemviews/config.templ +15 -12

@@ -1,6 +1,9 @@
1	1		package systemviews
2	2
3		-	import "github.com/bnema/dumber/internal/application/port"
	3	+	import (
	4	+	"github.com/bnema/dumber/internal/application/dto"
	5	+	"github.com/bnema/dumber/internal/application/port"
	6	+	)
4	7
5	8		templ ConfigView(data configRenderData) {
6	9		@Alert("success", data.Notice)

@@ -23,7 +26,7 @@ templ ConfigView(data configRenderData) {
23	26		}
24	27		}
25	28
26		-	templ AppearanceForm(config port.SystemviewConfigPayload) {
	29	+	templ AppearanceForm(config dto.SystemviewConfigPayload) {
27	30		<form class="sv-card-form sv-config-form" data-sv-action="config.appearance.save">
28	31		<label><span>Sans font</span><input name="sans_font" type="text" value={ config.Appearance.SansFont } required/></label>
29	32		<label><span>Serif font</span><input name="serif_font" type="text" value={ config.Appearance.SerifFont } required/></label>

@@ -44,20 +47,20 @@ templ AppearanceForm(config port.SystemviewConfigPayload) {
44	47		</form>
45	48		}
46	49
47		-	templ PaletteFields(title string, prefix string, palette port.ColorPalette) {
	50	+	templ PaletteFields(title string, prefix string, palette dto.ColorPalette) {
48	51		<fieldset class="sv-fieldset">
49	52		<legend>{ title }</legend>
50		-	<label><span>Background</span><input name={ prefix + "_background" } type="color" value={ palette.Background } required/></label>
51		-	<label><span>Surface</span><input name={ prefix + "_surface" } type="color" value={ palette.Surface } required/></label>
52		-	<label><span>Surface variant</span><input name={ prefix + "_surface_variant" } type="color" value={ palette.SurfaceVariant } required/></label>
53		-	<label><span>Text</span><input name={ prefix + "_text" } type="color" value={ palette.Text } required/></label>
54		-	<label><span>Muted</span><input name={ prefix + "_muted" } type="color" value={ palette.Muted } required/></label>
55		-	<label><span>Accent</span><input name={ prefix + "_accent" } type="color" value={ palette.Accent } required/></label>
56		-	<label><span>Border</span><input name={ prefix + "_border" } type="color" value={ palette.Border } required/></label>
	53	+	<label><span>Background</span><input name={ prefix + "_background" } type="text" value={ palette.Background } required/></label>
	54	+	<label><span>Surface</span><input name={ prefix + "_surface" } type="text" value={ palette.Surface } required/></label>
	55	+	<label><span>Surface variant</span><input name={ prefix + "_surface_variant" } type="text" value={ palette.SurfaceVariant } required/></label>
	56	+	<label><span>Text</span><input name={ prefix + "_text" } type="text" value={ palette.Text } required/></label>
	57	+	<label><span>Muted</span><input name={ prefix + "_muted" } type="text" value={ palette.Muted } required/></label>
	58	+	<label><span>Accent</span><input name={ prefix + "_accent" } type="text" value={ palette.Accent } required/></label>
	59	+	<label><span>Border</span><input name={ prefix + "_border" } type="text" value={ palette.Border } required/></label>
57	60		</fieldset>
58	61		}
59	62
60		-	templ SearchSettings(config port.SystemviewConfigPayload) {
	63	+	templ SearchSettings(config dto.SystemviewConfigPayload) {
61	64		<form class="sv-card-form" data-sv-action="config.search.save">
62	65		<label><span>Default search engine</span><input name="default_search_engine" type="text" value={ config.DefaultSearchEngine } placeholder="https://duckduckgo.com/?q=%s" required/></label>
63	66		<button class="sv-button" type="submit">Save search default</button>

@@ -97,7 +100,7 @@ templ SearchShortcutItem(shortcut searchShortcutRow) {
97	100		</li>
98	101		}
99	102
100		-	templ PerformanceSettings(config port.SystemviewConfigPayload) {
	103	+	templ PerformanceSettings(config dto.SystemviewConfigPayload) {
101	104		{{ customProfile := performanceProfileSelected(config.Performance.Profile, "custom") }}
102	105		<form class="sv-card-form sv-config-form" data-sv-action="config.performance.save">
103	106		<label><span>Profile</span><select name="profile">

 package systemviews
-import "github.com/bnema/dumber/internal/application/port"
+import (
+	"github.com/bnema/dumber/internal/application/dto"
+	"github.com/bnema/dumber/internal/application/port"
+)
 templ ConfigView(data configRenderData) {
 	@Alert("success", data.Notice)
 	}
 }
-templ AppearanceForm(config port.SystemviewConfigPayload) {
+templ AppearanceForm(config dto.SystemviewConfigPayload) {
 	<form class="sv-card-form sv-config-form" data-sv-action="config.appearance.save">
 		<label><span>Sans font</span><input name="sans_font" type="text" value={ config.Appearance.SansFont } required/></label>
 		<label><span>Serif font</span><input name="serif_font" type="text" value={ config.Appearance.SerifFont } required/></label>
 	</form>
 }
-templ PaletteFields(title string, prefix string, palette port.ColorPalette) {
+templ PaletteFields(title string, prefix string, palette dto.ColorPalette) {
 	<fieldset class="sv-fieldset">
 		<legend>{ title }</legend>
-		<label><span>Background</span><input name={ prefix + "_background" } type="color" value={ palette.Background } required/></label>
+		<label><span>Background</span><input name={ prefix + "_background" } type="text" value={ palette.Background } required/></label>
-		<label><span>Surface</span><input name={ prefix + "_surface" } type="color" value={ palette.Surface } required/></label>
+		<label><span>Surface</span><input name={ prefix + "_surface" } type="text" value={ palette.Surface } required/></label>
-		<label><span>Surface variant</span><input name={ prefix + "_surface_variant" } type="color" value={ palette.SurfaceVariant } required/></label>
+		<label><span>Surface variant</span><input name={ prefix + "_surface_variant" } type="text" value={ palette.SurfaceVariant } required/></label>
-		<label><span>Text</span><input name={ prefix + "_text" } type="color" value={ palette.Text } required/></label>
+		<label><span>Text</span><input name={ prefix + "_text" } type="text" value={ palette.Text } required/></label>
-		<label><span>Muted</span><input name={ prefix + "_muted" } type="color" value={ palette.Muted } required/></label>
+		<label><span>Muted</span><input name={ prefix + "_muted" } type="text" value={ palette.Muted } required/></label>
-		<label><span>Accent</span><input name={ prefix + "_accent" } type="color" value={ palette.Accent } required/></label>
+		<label><span>Accent</span><input name={ prefix + "_accent" } type="text" value={ palette.Accent } required/></label>
-		<label><span>Border</span><input name={ prefix + "_border" } type="color" value={ palette.Border } required/></label>
+		<label><span>Border</span><input name={ prefix + "_border" } type="text" value={ palette.Border } required/></label>
 	</fieldset>
 }
-templ SearchSettings(config port.SystemviewConfigPayload) {
+templ SearchSettings(config dto.SystemviewConfigPayload) {
 	<form class="sv-card-form" data-sv-action="config.search.save">
 		<label><span>Default search engine</span><input name="default_search_engine" type="text" value={ config.DefaultSearchEngine } placeholder="https://duckduckgo.com/?q=%s" required/></label>
 		<button class="sv-button" type="submit">Save search default</button>
 	</li>
 }
-templ PerformanceSettings(config port.SystemviewConfigPayload) {
+templ PerformanceSettings(config dto.SystemviewConfigPayload) {
 	{{ customProfile := performanceProfileSelected(config.Performance.Profile, "custom") }}
 	<form class="sv-card-form sv-config-form" data-sv-action="config.performance.save">
 		<label><span>Profile</span><select name="profile">

M internal/ui/systemviews/config_actions.go +34 -21


@@ -9,6 +9,7 @@ import (
9	9		"strings"
10	10		"sync/atomic"
11	11
	12	+	"github.com/bnema/dumber/internal/application/dto"
12	13		"github.com/bnema/dumber/internal/application/port"
13	14		)
14	15

@@ -236,6 +237,9 @@ func (a *App) savePerformanceConfig(ctx context.Context, data map[string]string)
236	237		return err
237	238		}
238	239		profile := strings.TrimSpace(data["profile"])
	240	+	if !isAllowedPerformanceProfile(profile) {
	241	+	return fmt.Errorf("unknown performance profile: %q", profile)
	242	+	}
239	243		cfg.Performance.Profile = profile
240	244		if profile != "custom" {
241	245		if err := a.saveEditableConfig(ctx, cfg); err != nil {

@@ -281,7 +285,7 @@ func (a *App) savePerformanceConfig(ctx context.Context, data map[string]string)
281	285		return err
282	286		}
283	287
284		-	cfg.Performance.Custom = port.WebUICustomPerformanceConfig{
	288	+	cfg.Performance.Custom = dto.WebUICustomPerformanceConfig{
285	289		SkiaCPUThreads: skiaCPU,
286	290		SkiaGPUThreads: skiaGPU,
287	291		WebProcessMemoryMB: webMemory,

@@ -342,10 +346,10 @@ func (a *App) resetConfigKeybinding(ctx context.Context, data map[string]string)
342	346		return nil
343	347		}
344	348
345		-	func (a *App) editableConfig(ctx context.Context) (port.WebUIConfig, error) {
	349	+	func (a *App) editableConfig(ctx context.Context) (dto.WebUIConfig, error) {
346	350		cfg, err := a.deps.Config.Current(ctx)
347	351		if err != nil {
348		-	return port.WebUIConfig{}, err
	352	+	return dto.WebUIConfig{}, err
349	353		}
350	354		a.config = &cfg
351	355		return webUIConfigFromPayload(cfg), nil

@@ -371,7 +375,7 @@ func (a *App) requireKeybindingTarget(ctx context.Context, mode, action string)
371	375		return fmt.Errorf("keybinding %s/%s not found", mode, action)
372	376		}
373	377
374		-	func (a *App) saveEditableConfig(ctx context.Context, cfg port.WebUIConfig) error {
	378	+	func (a *App) saveEditableConfig(ctx context.Context, cfg dto.WebUIConfig) error {
375	379		if err := a.deps.Config.Save(ctx, cfg); err != nil {
376	380		return err
377	381		}

@@ -379,15 +383,15 @@ func (a *App) saveEditableConfig(ctx context.Context, cfg port.WebUIConfig) erro
379	383		return nil
380	384		}
381	385
382		-	func webUIConfigFromPayload(payload port.SystemviewConfigPayload) port.WebUIConfig {
383		-	return port.WebUIConfig{
	386	+	func webUIConfigFromPayload(payload dto.SystemviewConfigPayload) dto.WebUIConfig {
	387	+	return dto.WebUIConfig{
384	388		Appearance: payload.Appearance,
385	389		DefaultUIScale: payload.DefaultUIScale,
386	390		DefaultSearchEngine: payload.DefaultSearchEngine,
387	391		SearchShortcuts: cloneSearchShortcuts(payload.SearchShortcuts),
388		-	Performance: port.WebUIPerformanceConfig{
	392	+	Performance: dto.WebUIPerformanceConfig{
389	393		Profile: payload.Performance.Profile,
390		-	Custom: port.WebUICustomPerformanceConfig{
	394	+	Custom: dto.WebUICustomPerformanceConfig{
391	395		SkiaCPUThreads: payload.Performance.Custom.SkiaCPUThreads,
392	396		SkiaGPUThreads: payload.Performance.Custom.SkiaGPUThreads,
393	397		WebProcessMemoryMB: payload.Performance.Custom.WebProcessMemoryMB,

@@ -398,15 +402,15 @@ func webUIConfigFromPayload(payload port.SystemviewConfigPayload) port.WebUIConf
398	402		}
399	403		}
400	404
401		-	func cloneSearchShortcuts(shortcuts map[string]port.SearchShortcut) map[string]port.SearchShortcut {
402		-	clone := make(map[string]port.SearchShortcut, len(shortcuts))
	405	+	func cloneSearchShortcuts(shortcuts map[string]dto.SearchShortcut) map[string]dto.SearchShortcut {
	406	+	clone := make(map[string]dto.SearchShortcut, len(shortcuts))
403	407		for key, shortcut := range shortcuts {
404	408		clone[key] = shortcut
405	409		}
406	410		return clone
407	411		}
408	412
409		-	func paletteFromForm(data map[string]string, prefix string) (port.ColorPalette, error) {
	413	+	func paletteFromForm(data map[string]string, prefix string) (dto.ColorPalette, error) {
410	414		color := func(field string) (string, error) {
411	415		value := strings.TrimSpace(data[prefix+"_"+field])
412	416		if value == "" \|\| isValidHexColor(value) {

@@ -417,34 +421,34 @@ func paletteFromForm(data map[string]string, prefix string) (port.ColorPalette,
417	421
418	422		background, err := color("background")
419	423		if err != nil {
420		-	return port.ColorPalette{}, err
	424	+	return dto.ColorPalette{}, err
421	425		}
422	426		surface, err := color("surface")
423	427		if err != nil {
424		-	return port.ColorPalette{}, err
	428	+	return dto.ColorPalette{}, err
425	429		}
426	430		surfaceVariant, err := color("surface_variant")
427	431		if err != nil {
428		-	return port.ColorPalette{}, err
	432	+	return dto.ColorPalette{}, err
429	433		}
430	434		text, err := color("text")
431	435		if err != nil {
432		-	return port.ColorPalette{}, err
	436	+	return dto.ColorPalette{}, err
433	437		}
434	438		muted, err := color("muted")
435	439		if err != nil {
436		-	return port.ColorPalette{}, err
	440	+	return dto.ColorPalette{}, err
437	441		}
438	442		accent, err := color("accent")
439	443		if err != nil {
440		-	return port.ColorPalette{}, err
	444	+	return dto.ColorPalette{}, err
441	445		}
442	446		border, err := color("border")
443	447		if err != nil {
444		-	return port.ColorPalette{}, err
	448	+	return dto.ColorPalette{}, err
445	449		}
446	450
447		-	return port.ColorPalette{
	451	+	return dto.ColorPalette{
448	452		Background: background,
449	453		Surface: surface,
450	454		SurfaceVariant: surfaceVariant,

@@ -459,8 +463,8 @@ func isValidHexColor(value string) bool {
459	463		return isHexColor(strings.TrimSpace(value))
460	464		}
461	465
462		-	func searchShortcutFromForm(data map[string]string, keyField string) (string, port.SearchShortcut) {
463		-	return strings.TrimSpace(data[keyField]), port.SearchShortcut{
	466	+	func searchShortcutFromForm(data map[string]string, keyField string) (string, dto.SearchShortcut) {
	467	+	return strings.TrimSpace(data[keyField]), dto.SearchShortcut{
464	468		URL: strings.TrimSpace(data["url"]),
465	469		Description: strings.TrimSpace(data["description"]),
466	470		}

@@ -497,6 +501,15 @@ func parseConfigFloat(raw, label string) (float64, error) {
497	501		return value, nil
498	502		}
499	503
	504	+	func isAllowedPerformanceProfile(profile string) bool {
	505	+	switch profile {
	506	+	case "default", "lite", "max", "custom":
	507	+	return true
	508	+	default:
	509	+	return false
	510	+	}
	511	+	}
	512	+
500	513		func validatePerformanceInt(value int, label string, minValue, maxValue int) error {
501	514		if value < minValue \|\| value > maxValue {
502	515		return fmt.Errorf("%s must be between %d and %d", label, minValue, maxValue)

 	"strings"
 	"sync/atomic"
+	"github.com/bnema/dumber/internal/application/dto"
 	"github.com/bnema/dumber/internal/application/port"
 )
 		return err
 	}
 	profile := strings.TrimSpace(data["profile"])
+	if !isAllowedPerformanceProfile(profile) {
+		return fmt.Errorf("unknown performance profile: %q", profile)
+	}
 	cfg.Performance.Profile = profile
 	if profile != "custom" {
 		if err := a.saveEditableConfig(ctx, cfg); err != nil {
 		return err
 	}
-	cfg.Performance.Custom = port.WebUICustomPerformanceConfig{
+	cfg.Performance.Custom = dto.WebUICustomPerformanceConfig{
 		SkiaCPUThreads:         skiaCPU,
 		SkiaGPUThreads:         skiaGPU,
 		WebProcessMemoryMB:     webMemory,
 	return nil
 }
-func (a *App) editableConfig(ctx context.Context) (port.WebUIConfig, error) {
+func (a *App) editableConfig(ctx context.Context) (dto.WebUIConfig, error) {
 	cfg, err := a.deps.Config.Current(ctx)
 	if err != nil {
-		return port.WebUIConfig{}, err
+		return dto.WebUIConfig{}, err
 	}
 	a.config = &cfg
 	return webUIConfigFromPayload(cfg), nil
 	return fmt.Errorf("keybinding %s/%s not found", mode, action)
 }
-func (a *App) saveEditableConfig(ctx context.Context, cfg port.WebUIConfig) error {
+func (a *App) saveEditableConfig(ctx context.Context, cfg dto.WebUIConfig) error {
 	if err := a.deps.Config.Save(ctx, cfg); err != nil {
 		return err
 	}
 	return nil
 }
-func webUIConfigFromPayload(payload port.SystemviewConfigPayload) port.WebUIConfig {
+func webUIConfigFromPayload(payload dto.SystemviewConfigPayload) dto.WebUIConfig {
-	return port.WebUIConfig{
+	return dto.WebUIConfig{
 		Appearance:          payload.Appearance,
 		DefaultUIScale:      payload.DefaultUIScale,
 		DefaultSearchEngine: payload.DefaultSearchEngine,
 		SearchShortcuts:     cloneSearchShortcuts(payload.SearchShortcuts),
-		Performance: port.WebUIPerformanceConfig{
+		Performance: dto.WebUIPerformanceConfig{
 			Profile: payload.Performance.Profile,
-			Custom: port.WebUICustomPerformanceConfig{
+			Custom: dto.WebUICustomPerformanceConfig{
 				SkiaCPUThreads:         payload.Performance.Custom.SkiaCPUThreads,
 				SkiaGPUThreads:         payload.Performance.Custom.SkiaGPUThreads,
 				WebProcessMemoryMB:     payload.Performance.Custom.WebProcessMemoryMB,
 	}
 }
-func cloneSearchShortcuts(shortcuts map[string]port.SearchShortcut) map[string]port.SearchShortcut {
+func cloneSearchShortcuts(shortcuts map[string]dto.SearchShortcut) map[string]dto.SearchShortcut {
-	clone := make(map[string]port.SearchShortcut, len(shortcuts))
+	clone := make(map[string]dto.SearchShortcut, len(shortcuts))
 	for key, shortcut := range shortcuts {
 		clone[key] = shortcut
 	}
 	return clone
 }
-func paletteFromForm(data map[string]string, prefix string) (port.ColorPalette, error) {
+func paletteFromForm(data map[string]string, prefix string) (dto.ColorPalette, error) {
 	color := func(field string) (string, error) {
 		value := strings.TrimSpace(data[prefix+"_"+field])
 		if value == "" || isValidHexColor(value) {
 	background, err := color("background")
 	if err != nil {
-		return port.ColorPalette{}, err
+		return dto.ColorPalette{}, err
 	}
 	surface, err := color("surface")
 	if err != nil {
-		return port.ColorPalette{}, err
+		return dto.ColorPalette{}, err
 	}
 	surfaceVariant, err := color("surface_variant")
 	if err != nil {
-		return port.ColorPalette{}, err
+		return dto.ColorPalette{}, err
 	}
 	text, err := color("text")
 	if err != nil {
-		return port.ColorPalette{}, err
+		return dto.ColorPalette{}, err
 	}
 	muted, err := color("muted")
 	if err != nil {
-		return port.ColorPalette{}, err
+		return dto.ColorPalette{}, err
 	}
 	accent, err := color("accent")
 	if err != nil {
-		return port.ColorPalette{}, err
+		return dto.ColorPalette{}, err
 	}
 	border, err := color("border")
 	if err != nil {
-		return port.ColorPalette{}, err
+		return dto.ColorPalette{}, err
 	}
-	return port.ColorPalette{
+	return dto.ColorPalette{
 		Background:     background,
 		Surface:        surface,
 		SurfaceVariant: surfaceVariant,
 	return isHexColor(strings.TrimSpace(value))
 }
-func searchShortcutFromForm(data map[string]string, keyField string) (string, port.SearchShortcut) {
+func searchShortcutFromForm(data map[string]string, keyField string) (string, dto.SearchShortcut) {
-	return strings.TrimSpace(data[keyField]), port.SearchShortcut{
+	return strings.TrimSpace(data[keyField]), dto.SearchShortcut{
 		URL:         strings.TrimSpace(data["url"]),
 		Description: strings.TrimSpace(data["description"]),
 	}
 	return value, nil
 }
+func isAllowedPerformanceProfile(profile string) bool {
+	switch profile {
+	case "default", "lite", "max", "custom":
+		return true
+	default:
+		return false
+	}
+}
 func validatePerformanceInt(value int, label string, minValue, maxValue int) error {
 	if value < minValue || value > maxValue {
 		return fmt.Errorf("%s must be between %d and %d", label, minValue, maxValue)

M internal/ui/systemviews/config_templ.go +60 -57 generated file: collapsed

load diff

M internal/ui/systemviews/config_view.go +3 -2


@@ -6,11 +6,12 @@ import (
6	6		"sort"
7	7		"strings"
8	8
	9	+	"github.com/bnema/dumber/internal/application/dto"
9	10		"github.com/bnema/dumber/internal/application/port"
10	11		)
11	12
12	13		type configRenderData struct {
13		-	Config port.SystemviewConfigPayload
	14	+	Config dto.SystemviewConfigPayload
14	15		Keybindings port.KeybindingsConfig
15	16		Notice string
16	17		Error string

@@ -100,7 +101,7 @@ type searchShortcutRow struct {
100	101		Description string
101	102		}
102	103
103		-	func searchShortcutRows(shortcuts map[string]port.SearchShortcut) []searchShortcutRow {
	104	+	func searchShortcutRows(shortcuts map[string]dto.SearchShortcut) []searchShortcutRow {
104	105		if len(shortcuts) == 0 {
105	106		return nil
106	107		}

 	"sort"
 	"strings"
+	"github.com/bnema/dumber/internal/application/dto"
 	"github.com/bnema/dumber/internal/application/port"
 )
 type configRenderData struct {
-	Config      port.SystemviewConfigPayload
+	Config      dto.SystemviewConfigPayload
 	Keybindings port.KeybindingsConfig
 	Notice      string
 	Error       string
 	Description string
 }
-func searchShortcutRows(shortcuts map[string]port.SearchShortcut) []searchShortcutRow {
+func searchShortcutRows(shortcuts map[string]dto.SearchShortcut) []searchShortcutRow {
 	if len(shortcuts) == 0 {
 		return nil
 	}

M internal/ui/systemviews/dom_js.go +5 -6


@@ -402,7 +402,10 @@ func isEditableTarget(target js.Value) bool {
402	402		return false
403	403		}
404	404		tag := strings.ToLower(target.Get("tagName").String())
405		-	return tag == "input" \|\| tag == "textarea" \|\| tag == "select" \|\| target.Get("isContentEditable").Bool()
	405	+	role := strings.ToLower(target.Get("role").String())
	406	+	return tag == "input" \|\| tag == "textarea" \|\| tag == "select" \|\| tag == "button" \|\|
	407	+	(tag == "a" && target.Get("href").String() != "") \|\| role == "button" \|\| role == "link" \|\|
	408	+	target.Get("isContentEditable").Bool()
406	409		}
407	410
408	411		func (d *browserDOM) focusHistoryRow(delta int) {

@@ -456,11 +459,7 @@ func (d *browserDOM) activeRow(selector, datasetKey string) js.Value {
456	459		}
457	460		idx := d.activeIndex(datasetKey)
458	461		if idx < 0 \|\| idx >= length {
459		-	idx = 0
460		-	row := rows.Index(idx)
461		-	d.target.Get("dataset").Set(datasetKey, "0")
462		-	row.Get("classList").Call("add", "sv-focused")
463		-	return row
	462	+	return js.Value{}
464	463		}
465	464		return rows.Index(idx)
466	465		}

 		return false
 	}
 	tag := strings.ToLower(target.Get("tagName").String())
-	return tag == "input" || tag == "textarea" || tag == "select" || target.Get("isContentEditable").Bool()
+	role := strings.ToLower(target.Get("role").String())
+	return tag == "input" || tag == "textarea" || tag == "select" || tag == "button" ||
+		(tag == "a" && target.Get("href").String() != "") || role == "button" || role == "link" ||
+		target.Get("isContentEditable").Bool()
 }
 func (d *browserDOM) focusHistoryRow(delta int) {
 	}
 	idx := d.activeIndex(datasetKey)
 	if idx < 0 || idx >= length {
-		idx = 0
+		return js.Value{}
-		row := rows.Index(idx)
-		d.target.Get("dataset").Set(datasetKey, "0")
-		row.Get("classList").Call("add", "sv-focused")
-		return row
 	}
 	return rows.Index(idx)
 }

M internal/ui/systemviews/history_view_test.go +6 -3


@@ -13,10 +13,13 @@ func TestHistoryDateKeyAndLabelUsesProvidedNow(t *testing.T) {
13	13		loc := time.FixedZone("test", 26060)
14	14		now := time.Date(2026, 4, 24, 12, 0, 0, 0, loc)
15	15
16		-	_, todayLabel := historyDateKeyAndLabel(time.Date(2026, 4, 24, 8, 30, 0, 0, loc), now)
17		-	_, yesterdayLabel := historyDateKeyAndLabel(time.Date(2026, 4, 23, 22, 30, 0, 0, loc), now)
18		-	_, olderLabel := historyDateKeyAndLabel(time.Date(2026, 4, 20, 9, 0, 0, 0, loc), now)
	16	+	todayKey, todayLabel := historyDateKeyAndLabel(time.Date(2026, 4, 24, 8, 30, 0, 0, loc), now)
	17	+	yesterdayKey, yesterdayLabel := historyDateKeyAndLabel(time.Date(2026, 4, 23, 22, 30, 0, 0, loc), now)
	18	+	olderKey, olderLabel := historyDateKeyAndLabel(time.Date(2026, 4, 20, 9, 0, 0, 0, loc), now)
19	19
	20	+	assert.Equal(t, "2026-04-24", todayKey)
	21	+	assert.Equal(t, "2026-04-23", yesterdayKey)
	22	+	assert.Equal(t, "2026-04-20", olderKey)
20	23		assert.Equal(t, "Today", todayLabel)
21	24		assert.Equal(t, "Yesterday", yesterdayLabel)
22	25		assert.Equal(t, "Mon Apr 20", olderLabel)

 	loc := time.FixedZone("test", 2*60*60)
 	now := time.Date(2026, 4, 24, 12, 0, 0, 0, loc)
-	_, todayLabel := historyDateKeyAndLabel(time.Date(2026, 4, 24, 8, 30, 0, 0, loc), now)
+	todayKey, todayLabel := historyDateKeyAndLabel(time.Date(2026, 4, 24, 8, 30, 0, 0, loc), now)
-	_, yesterdayLabel := historyDateKeyAndLabel(time.Date(2026, 4, 23, 22, 30, 0, 0, loc), now)
+	yesterdayKey, yesterdayLabel := historyDateKeyAndLabel(time.Date(2026, 4, 23, 22, 30, 0, 0, loc), now)
-	_, olderLabel := historyDateKeyAndLabel(time.Date(2026, 4, 20, 9, 0, 0, 0, loc), now)
+	olderKey, olderLabel := historyDateKeyAndLabel(time.Date(2026, 4, 20, 9, 0, 0, 0, loc), now)
+	assert.Equal(t, "2026-04-24", todayKey)
+	assert.Equal(t, "2026-04-23", yesterdayKey)
+	assert.Equal(t, "2026-04-20", olderKey)
 	assert.Equal(t, "Today", todayLabel)
 	assert.Equal(t, "Yesterday", yesterdayLabel)
 	assert.Equal(t, "Mon Apr 20", olderLabel)

M internal/ui/systemviews/href.go +1 -0


@@ -29,6 +29,7 @@ func sanitizeHref(raw string) string {
29	29		return "#"
30	30		}
31	31		parsed.Scheme = strings.ToLower(parsed.Scheme)
	32	+	parsed.User = nil
32	33		return parsed.String()
33	34		case "dumb":
34	35		if parsed.Host == "" && parsed.Opaque == "" {


@@ -29,6 +29,7 @@ func sanitizeHref(raw string) string {
29	return "#"	29		return "#"
30	}	30		}
31	parsed.Scheme = strings.ToLower(parsed.Scheme)	31		parsed.Scheme = strings.ToLower(parsed.Scheme)
		32	+	parsed.User = nil
32	return parsed.String()	33		return parsed.String()
33	case "dumb":	34		case "dumb":
34	if parsed.Host == "" && parsed.Opaque == "" {	35		if parsed.Host == "" && parsed.Opaque == "" {

M internal/ui/systemviews/href_test.go +1 -0


@@ -42,6 +42,7 @@ func TestSanitizeHrefRejectsNetworkPathAndMalformedHTTP(t *testing.T) {
42	42		assert.Equal(t, "#", sanitizeHref("https:///evil.com"))
43	43		assert.Equal(t, "#", sanitizeHref("http:evil.com"))
44	44		assert.Equal(t, "https://example.com", sanitizeHref("https://example.com"))
	45	+	assert.Equal(t, "https://example.com/path", sanitizeHref("https://user:pass@example.com/path"))
45	46		}
46	47
47	48		func TestSanitizeHrefAllowsInternalDumbRoutes(t *testing.T) {


@@ -42,6 +42,7 @@ func TestSanitizeHrefRejectsNetworkPathAndMalformedHTTP(t *testing.T) {
42	assert.Equal(t, "#", sanitizeHref("https:///evil.com"))	42		assert.Equal(t, "#", sanitizeHref("https:///evil.com"))
43	assert.Equal(t, "#", sanitizeHref("http:evil.com"))	43		assert.Equal(t, "#", sanitizeHref("http:evil.com"))
44	assert.Equal(t, "https://example.com", sanitizeHref("https://example.com"))	44		assert.Equal(t, "https://example.com", sanitizeHref("https://example.com"))
		45	+	assert.Equal(t, "https://example.com/path", sanitizeHref("https://user:pass@example.com/path"))
45	}	46		}
46		47
47	func TestSanitizeHrefAllowsInternalDumbRoutes(t *testing.T) {	48		func TestSanitizeHrefAllowsInternalDumbRoutes(t *testing.T) {

M internal/ui/systemviews/theme.go +7 -7


@@ -5,7 +5,7 @@ import (
5	5		"strings"
6	6		"unicode"
7	7
8		-	"github.com/bnema/dumber/internal/application/port"
	8	+	"github.com/bnema/dumber/internal/application/dto"
9	9		)
10	10
11	11		type shellTheme struct {

@@ -31,12 +31,12 @@ func currentPrefersDark() bool {
31	31		return currentPrefersDarkImpl()
32	32		}
33	33
34		-	func resolveShellTheme(appearance port.WebUIAppearanceConfig) shellTheme {
	34	+	func resolveShellTheme(appearance dto.WebUIAppearanceConfig) shellTheme {
35	35		if isZeroAppearance(appearance) {
36	36		return shellTheme{}
37	37		}
38	38
39		-	var palette port.ColorPalette
	39	+	var palette dto.ColorPalette
40	40		var rootClass string
41	41
42	42		switch strings.ToLower(strings.TrimSpace(appearance.ColorScheme)) {

@@ -62,7 +62,7 @@ func resolveShellTheme(appearance port.WebUIAppearanceConfig) shellTheme {
62	62		}
63	63		}
64	64
65		-	func buildInlineVars(appearance port.WebUIAppearanceConfig, palette port.ColorPalette) string {
	65	+	func buildInlineVars(appearance dto.WebUIAppearanceConfig, palette dto.ColorPalette) string {
66	66		parts := make([]string, 0, 11)
67	67		appendInlineVar := func(name, value string, sanitize func(string) (string, bool)) {
68	68		value, ok := sanitize(value)

@@ -178,12 +178,12 @@ func isNamedColor(value string) bool {
178	178		return ok
179	179		}
180	180
181		-	func isZeroAppearance(appearance port.WebUIAppearanceConfig) bool {
	181	+	func isZeroAppearance(appearance dto.WebUIAppearanceConfig) bool {
182	182		return appearance.ColorScheme == "" &&
183	183		appearance.SansFont == "" &&
184	184		appearance.SerifFont == "" &&
185	185		appearance.MonospaceFont == "" &&
186	186		appearance.DefaultFontSize == 0 &&
187		-	appearance.LightPalette == (port.ColorPalette{}) &&
188		-	appearance.DarkPalette == (port.ColorPalette{})
	187	+	appearance.LightPalette == (dto.ColorPalette{}) &&
	188	+	appearance.DarkPalette == (dto.ColorPalette{})
189	189		}


@@ -5,7 +5,7 @@ import (
5		"strings"	5		"strings"
6		"unicode"	6		"unicode"
7			7
8	-	"github.com/bnema/dumber/internal/application/port"	8	+	"github.com/bnema/dumber/internal/application/dto"
9		)	9		)
10			10
11		type shellTheme struct {	11		type shellTheme struct {

@@ -31,12 +31,12 @@ func currentPrefersDark() bool {
31		return currentPrefersDarkImpl()	31		return currentPrefersDarkImpl()
32		}	32		}
33			33
34	-	func resolveShellTheme(appearance port.WebUIAppearanceConfig) shellTheme {	34	+	func resolveShellTheme(appearance dto.WebUIAppearanceConfig) shellTheme {
35		if isZeroAppearance(appearance) {	35		if isZeroAppearance(appearance) {
36		return shellTheme{}	36		return shellTheme{}
37		}	37		}
38			38
39	-	var palette port.ColorPalette	39	+	var palette dto.ColorPalette
40		var rootClass string	40		var rootClass string
41			41
42		switch strings.ToLower(strings.TrimSpace(appearance.ColorScheme)) {	42		switch strings.ToLower(strings.TrimSpace(appearance.ColorScheme)) {

@@ -62,7 +62,7 @@ func resolveShellTheme(appearance port.WebUIAppearanceConfig) shellTheme {
62		}	62		}
63		}	63		}
64			64
65	-	func buildInlineVars(appearance port.WebUIAppearanceConfig, palette port.ColorPalette) string {	65	+	func buildInlineVars(appearance dto.WebUIAppearanceConfig, palette dto.ColorPalette) string {
66		parts := make([]string, 0, 11)	66		parts := make([]string, 0, 11)
67		appendInlineVar := func(name, value string, sanitize func(string) (string, bool)) {	67		appendInlineVar := func(name, value string, sanitize func(string) (string, bool)) {
68		value, ok := sanitize(value)	68		value, ok := sanitize(value)

@@ -178,12 +178,12 @@ func isNamedColor(value string) bool {
178		return ok	178		return ok
179		}	179		}
180			180
181	-	func isZeroAppearance(appearance port.WebUIAppearanceConfig) bool {	181	+	func isZeroAppearance(appearance dto.WebUIAppearanceConfig) bool {
182		return appearance.ColorScheme == "" &&	182		return appearance.ColorScheme == "" &&
183		appearance.SansFont == "" &&	183		appearance.SansFont == "" &&
184		appearance.SerifFont == "" &&	184		appearance.SerifFont == "" &&
185		appearance.MonospaceFont == "" &&	185		appearance.MonospaceFont == "" &&
186		appearance.DefaultFontSize == 0 &&	186		appearance.DefaultFontSize == 0 &&
187	-	appearance.LightPalette == (port.ColorPalette{}) &&	187	+	appearance.LightPalette == (dto.ColorPalette{}) &&
188	-	appearance.DarkPalette == (port.ColorPalette{})	188	+	appearance.DarkPalette == (dto.ColorPalette{})
189		}	189		}

M internal/ui/systemviews/theme_test.go +7 -7


@@ -3,25 +3,25 @@ package systemviews
3	3		import (
4	4		"testing"
5	5
6		-	"github.com/bnema/dumber/internal/application/port"
	6	+	"github.com/bnema/dumber/internal/application/dto"
7	7		"github.com/stretchr/testify/assert"
8	8		)
9	9
10	10		func TestBuildInlineVarsRejectsUnsafeCSSValues(t *testing.T) {
11	11		t.Parallel()
12	12
13		-	vars := buildInlineVars(port.WebUIAppearanceConfig{
	13	+	vars := buildInlineVars(dto.WebUIAppearanceConfig{
14	14		SansFont: "Inter; color:red",
15	15		SerifFont: "Georgia",
16	16		MonospaceFont: "JetBrains Mono",
17		-	LightPalette: port.ColorPalette{
	17	+	LightPalette: dto.ColorPalette{
18	18		Background: "#ffffff; color:red",
19	19		Surface: "rgb(1 2 3 / 50%)",
20	20		Text: "transparent",
21	21		Accent: "definitelynotacolor",
22	22		Border: "#ABCDEF80",
23	23		},
24		-	}, port.ColorPalette{
	24	+	}, dto.ColorPalette{
25	25		Background: "#ffffff; color:red",
26	26		Surface: "rgb(1 2 3 / 50%)",
27	27		Text: "transparent",

@@ -73,13 +73,13 @@ func TestResolveShellTheme(t *testing.T) {
73	73		currentPrefersDarkImpl = orig
74	74		})
75	75
76		-	appearance := port.WebUIAppearanceConfig{
	76	+	appearance := dto.WebUIAppearanceConfig{
77	77		SansFont: "Inter",
78	78		SerifFont: "Georgia",
79	79		MonospaceFont: "JetBrains Mono",
80	80		DefaultFontSize: 16,
81	81		ColorScheme: "default",
82		-	LightPalette: port.ColorPalette{
	82	+	LightPalette: dto.ColorPalette{
83	83		Background: "#ffffff",
84	84		Surface: "#f8f8f8",
85	85		SurfaceVariant: "#eeeeee",

@@ -88,7 +88,7 @@ func TestResolveShellTheme(t *testing.T) {
88	88		Accent: "#0055ff",
89	89		Border: "#dddddd",
90	90		},
91		-	DarkPalette: port.ColorPalette{
	91	+	DarkPalette: dto.ColorPalette{
92	92		Background: "#111111",
93	93		Surface: "#1a1a1a",
94	94		SurfaceVariant: "#2a2a2a",


@@ -3,25 +3,25 @@ package systemviews
3		import (	3		import (
4		"testing"	4		"testing"
5			5
6	-	"github.com/bnema/dumber/internal/application/port"	6	+	"github.com/bnema/dumber/internal/application/dto"
7		"github.com/stretchr/testify/assert"	7		"github.com/stretchr/testify/assert"
8		)	8		)
9			9
10		func TestBuildInlineVarsRejectsUnsafeCSSValues(t *testing.T) {	10		func TestBuildInlineVarsRejectsUnsafeCSSValues(t *testing.T) {
11		t.Parallel()	11		t.Parallel()
12			12
13	-	vars := buildInlineVars(port.WebUIAppearanceConfig{	13	+	vars := buildInlineVars(dto.WebUIAppearanceConfig{
14		SansFont: "Inter; color:red",	14		SansFont: "Inter; color:red",
15		SerifFont: "Georgia",	15		SerifFont: "Georgia",
16		MonospaceFont: "JetBrains Mono",	16		MonospaceFont: "JetBrains Mono",
17	-	LightPalette: port.ColorPalette{	17	+	LightPalette: dto.ColorPalette{
18		Background: "#ffffff; color:red",	18		Background: "#ffffff; color:red",
19		Surface: "rgb(1 2 3 / 50%)",	19		Surface: "rgb(1 2 3 / 50%)",
20		Text: "transparent",	20		Text: "transparent",
21		Accent: "definitelynotacolor",	21		Accent: "definitelynotacolor",
22		Border: "#ABCDEF80",	22		Border: "#ABCDEF80",
23		},	23		},
24	-	}, port.ColorPalette{	24	+	}, dto.ColorPalette{
25		Background: "#ffffff; color:red",	25		Background: "#ffffff; color:red",
26		Surface: "rgb(1 2 3 / 50%)",	26		Surface: "rgb(1 2 3 / 50%)",
27		Text: "transparent",	27		Text: "transparent",

@@ -73,13 +73,13 @@ func TestResolveShellTheme(t *testing.T) {
73		currentPrefersDarkImpl = orig	73		currentPrefersDarkImpl = orig
74		})	74		})
75			75
76	-	appearance := port.WebUIAppearanceConfig{	76	+	appearance := dto.WebUIAppearanceConfig{
77		SansFont: "Inter",	77		SansFont: "Inter",
78		SerifFont: "Georgia",	78		SerifFont: "Georgia",
79		MonospaceFont: "JetBrains Mono",	79		MonospaceFont: "JetBrains Mono",
80		DefaultFontSize: 16,	80		DefaultFontSize: 16,
81		ColorScheme: "default",	81		ColorScheme: "default",
82	-	LightPalette: port.ColorPalette{	82	+	LightPalette: dto.ColorPalette{
83		Background: "#ffffff",	83		Background: "#ffffff",
84		Surface: "#f8f8f8",	84		Surface: "#f8f8f8",
85		SurfaceVariant: "#eeeeee",	85		SurfaceVariant: "#eeeeee",

@@ -88,7 +88,7 @@ func TestResolveShellTheme(t *testing.T) {
88		Accent: "#0055ff",	88		Accent: "#0055ff",
89		Border: "#dddddd",	89		Border: "#dddddd",
90		},	90		},
91	-	DarkPalette: port.ColorPalette{	91	+	DarkPalette: dto.ColorPalette{
92		Background: "#111111",	92		Background: "#111111",
93		Surface: "#1a1a1a",	93		Surface: "#1a1a1a",
94		SurfaceVariant: "#2a2a2a",	94		SurfaceVariant: "#2a2a2a",