detached a784a53

test(split): cover tick callback cleanup

commit
a784a5312720b4e7e0894f218eb8de71adf20df8
author
brice · · 2026-07-14 06:16 UTC
committer
brice · · 2026-07-14 07:06 UTC
parent
9c48930
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
1 file · +29 -0
A internal/ui/layout/split_cleanup_test.go +29 -0
@@ -0,0 +1,29 @@
1+package layout_test
2+
3+import (
4+ "context"
5+ "testing"
6+
7+ "github.com/stretchr/testify/mock"
8+
9+ "github.com/bnema/dumber/internal/ui/layout"
10+ "github.com/bnema/dumber/internal/ui/layout/mocks"
11+)
12+
13+func TestSplitViewCleanupReleasesTickCallbackExactlyOnce(t *testing.T) {
14+ factory := mocks.NewMockWidgetFactory(t)
15+ paned := mocks.NewMockPanedWidget(t)
16+ factory.EXPECT().NewPaned(layout.OrientationHorizontal).Return(paned).Once()
17+ paned.EXPECT().SetResizeStartChild(true).Once()
18+ paned.EXPECT().SetResizeEndChild(true).Once()
19+ paned.EXPECT().SetVisible(true).Once()
20+ paned.EXPECT().GetAllocatedWidth().Return(0).Once()
21+ paned.EXPECT().ConnectNotifyPosition(mock.Anything).Return(uint(0)).Once()
22+ paned.EXPECT().ConnectMap(mock.Anything).Return(uint(0)).Once()
23+ paned.EXPECT().AddTickCallback(mock.Anything).Return(uint(42)).Once()
24+ paned.EXPECT().RemoveTickCallback(uint(42)).Once()
25+
26+ sv := layout.NewSplitView(context.Background(), factory, layout.OrientationHorizontal, nil, nil, 0.5)
27+ sv.Cleanup()
28+ sv.Cleanup()
29+}
@@ -0,0 +1,29 @@
1+package layout_test
2+
3+import (
4+ "context"
5+ "testing"
6+
7+ "github.com/stretchr/testify/mock"
8+
9+ "github.com/bnema/dumber/internal/ui/layout"
10+ "github.com/bnema/dumber/internal/ui/layout/mocks"
11+)
12+
13+func TestSplitViewCleanupReleasesTickCallbackExactlyOnce(t *testing.T) {
14+ factory := mocks.NewMockWidgetFactory(t)
15+ paned := mocks.NewMockPanedWidget(t)
16+ factory.EXPECT().NewPaned(layout.OrientationHorizontal).Return(paned).Once()
17+ paned.EXPECT().SetResizeStartChild(true).Once()
18+ paned.EXPECT().SetResizeEndChild(true).Once()
19+ paned.EXPECT().SetVisible(true).Once()
20+ paned.EXPECT().GetAllocatedWidth().Return(0).Once()
21+ paned.EXPECT().ConnectNotifyPosition(mock.Anything).Return(uint(0)).Once()
22+ paned.EXPECT().ConnectMap(mock.Anything).Return(uint(0)).Once()
23+ paned.EXPECT().AddTickCallback(mock.Anything).Return(uint(42)).Once()
24+ paned.EXPECT().RemoveTickCallback(uint(42)).Once()
25+
26+ sv := layout.NewSplitView(context.Background(), factory, layout.OrientationHorizontal, nil, nil, 0.5)
27+ sv.Cleanup()
28+ sv.Cleanup()
29+}

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 8

Tags 42

↑↓ moveenter openesc close