docs(systemviews): summarize wasm parity work
- commit
- a9a951b739602a5635d41b111e34a1da8c08c752
- author
- brice · · 2026-04-24 03:18 UTC
- parent
- d944cf1
- signature
- GPG Verified
CD88F9E564E0102646FB6077A1A07C7C7C3E349D· arch-gpg Verified for the committer email
1 file · +11 -1
M docs/systemviews-wasm-crud-plan.md +11 -1
| @@ -8,7 +8,7 @@ This note captures the parity target for the `feat/systemviews-wasm` branch afte | |||
| 8 | 8 | - Branch: `feat/systemviews-wasm` | |
| 9 | 9 | - Merge baseline: `d84415e5` (`Merge branch 'main' into feat/systemviews-wasm`) | |
| 10 | 10 | - Vendor baseline: `go mod vendor` has been run in the worktree and `go list -mod=vendor ./...` succeeds there. | |
| 11 | - | - Root-checkout diagnostics may still report vendoring issues because the editor diagnostics point at `/home/brice/dev/projects/dumber`, not this branch worktree. | |
| 11 | + | - Root-checkout vendoring diagnostics were corrected separately with `go mod vendor`; branch validation should still use `-mod=vendor` after dependency changes. | |
| 12 | 12 | ||
| 13 | 13 | ## Clean architecture contract | |
| 14 | 14 | ||
| @@ -96,6 +96,16 @@ Implementation path: | |||
| 96 | 96 | 4. Use existing `ManagePanesUseCase.Split` with `SplitPaneInput.InitialURL` to keep domain/usecase clean. | |
| 97 | 97 | 5. Add tests in input, dispatcher, config defaults/schema, and workspace coordinator. | |
| 98 | 98 | ||
| 99 | + | ## Completed branch notes | |
| 100 | + | ||
| 101 | + | - Rendering now uses typed `github.com/a-h/templ` components under `internal/ui/systemviews/*.templ`; generated `*_templ.go` files are committed alongside source templates. | |
| 102 | + | - `make build-systemviews` runs `go tool templ generate -path internal/ui/systemviews -include-version=false` before building the WASM runtime. | |
| 103 | + | - History supports search, domain filters, pagination, analytics/domain summaries, single/range/domain deletion, row open actions, alerts, and keyboard navigation. | |
| 104 | + | - Favorites supports create/update/delete for favorites, folders, and tags; folder/tag filters; shortcut editing; tag assignment/removal; alerts; and keyboard navigation. | |
| 105 | + | - Config supports editable appearance, search defaults, search shortcut CRUD, performance profile/custom values, keybinding set/reset/reset-all, success/error states, and refreshes the config payload/theme after save. | |
| 106 | + | - Native global actions use `toggle_*_systemview` names and open/focus/close History/Favorites/Config system views through the coordinator/right-split path. | |
| 107 | + | - Trust-boundary hardening includes templ HTML escaping, URL scheme sanitization for rendered links, sanitized CSS color use for tag swatches, serialized DOM action handling, and route-level error states. | |
| 108 | + | ||
| 99 | 109 | ## Implementation notes | |
| 100 | 110 | ||
| 101 | 111 | - Do not resurrect `webui/`; the branch intentionally removed Svelte assets. | |
| @@ -8,7 +8,7 @@ This note captures the parity target for the `feat/systemviews-wasm` branch afte | |||||
| 8 | - Branch: `feat/systemviews-wasm` | 8 | - Branch: `feat/systemviews-wasm` | ||
| 9 | - Merge baseline: `d84415e5` (`Merge branch 'main' into feat/systemviews-wasm`) | 9 | - Merge baseline: `d84415e5` (`Merge branch 'main' into feat/systemviews-wasm`) | ||
| 10 | - Vendor baseline: `go mod vendor` has been run in the worktree and `go list -mod=vendor ./...` succeeds there. | 10 | - Vendor baseline: `go mod vendor` has been run in the worktree and `go list -mod=vendor ./...` succeeds there. | ||
| 11 | - | - Root-checkout diagnostics may still report vendoring issues because the editor diagnostics point at `/home/brice/dev/projects/dumber`, not this branch worktree. | 11 | + | - Root-checkout vendoring diagnostics were corrected separately with `go mod vendor`; branch validation should still use `-mod=vendor` after dependency changes. |
| 12 | 12 | ||||
| 13 | ## Clean architecture contract | 13 | ## Clean architecture contract | ||
| 14 | 14 | ||||
| @@ -96,6 +96,16 @@ Implementation path: | |||||
| 96 | 4. Use existing `ManagePanesUseCase.Split` with `SplitPaneInput.InitialURL` to keep domain/usecase clean. | 96 | 4. Use existing `ManagePanesUseCase.Split` with `SplitPaneInput.InitialURL` to keep domain/usecase clean. | ||
| 97 | 5. Add tests in input, dispatcher, config defaults/schema, and workspace coordinator. | 97 | 5. Add tests in input, dispatcher, config defaults/schema, and workspace coordinator. | ||
| 98 | 98 | ||||
| 99 | + | ## Completed branch notes | |||
| 100 | + | ||||
| 101 | + | - Rendering now uses typed `github.com/a-h/templ` components under `internal/ui/systemviews/*.templ`; generated `*_templ.go` files are committed alongside source templates. | |||
| 102 | + | - `make build-systemviews` runs `go tool templ generate -path internal/ui/systemviews -include-version=false` before building the WASM runtime. | |||
| 103 | + | - History supports search, domain filters, pagination, analytics/domain summaries, single/range/domain deletion, row open actions, alerts, and keyboard navigation. | |||
| 104 | + | - Favorites supports create/update/delete for favorites, folders, and tags; folder/tag filters; shortcut editing; tag assignment/removal; alerts; and keyboard navigation. | |||
| 105 | + | - Config supports editable appearance, search defaults, search shortcut CRUD, performance profile/custom values, keybinding set/reset/reset-all, success/error states, and refreshes the config payload/theme after save. | |||
| 106 | + | - Native global actions use `toggle_*_systemview` names and open/focus/close History/Favorites/Config system views through the coordinator/right-split path. | |||
| 107 | + | - Trust-boundary hardening includes templ HTML escaping, URL scheme sanitization for rendered links, sanitized CSS color use for tag swatches, serialized DOM action handling, and route-level error states. | |||
| 108 | + | ||||
| 99 | ## Implementation notes | 109 | ## Implementation notes | ||
| 100 | 110 | ||||
| 101 | - Do not resurrect `webui/`; the branch intentionally removed Svelte assets. | 111 | - Do not resurrect `webui/`; the branch intentionally removed Svelte assets. | ||