detached b24c68b

fix(ui): handle home dir lookup error in download path fallback

commit
b24c68bb40bbca79b81f00d3cf1c05830032b55b
author
bnema · · 2026-01-08 17:41 UTC
parent
bef9811
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
1 file · +8 -3
M internal/ui/app.go +8 -3
@@ -476,9 +476,14 @@ func (a *App) initDownloadHandler(ctx context.Context) {
476476 }
477477 }
478478 if downloadPath == "" {
479- // Final fallback to ~/Downloads.
480- home, _ := os.UserHomeDir()
481- downloadPath = filepath.Join(home, "Downloads")
479+ // Final fallback to ~/Downloads, with /tmp as last resort.
480+ home, err := os.UserHomeDir()
481+ if err != nil {
482+ log.Warn().Err(err).Msg("failed to get home dir, using /tmp for downloads")
483+ downloadPath = "/tmp"
484+ } else {
485+ downloadPath = filepath.Join(home, "Downloads")
486+ }
482487 }
483488
484489 // Create download event adapter to show toasts.
@@ -476,9 +476,14 @@ func (a *App) initDownloadHandler(ctx context.Context) {
476 }476 }
477 }477 }
478 if downloadPath == "" {478 if downloadPath == "" {
479- // Final fallback to ~/Downloads.479+ // Final fallback to ~/Downloads, with /tmp as last resort.
480- home, _ := os.UserHomeDir()480+ home, err := os.UserHomeDir()
481- downloadPath = filepath.Join(home, "Downloads")481+ if err != nil {
482+ log.Warn().Err(err).Msg("failed to get home dir, using /tmp for downloads")
483+ downloadPath = "/tmp"
484+ } else {
485+ downloadPath = filepath.Join(home, "Downloads")
486+ }
482 }487 }
483 488
484 // Create download event adapter to show toasts.489 // Create download event adapter to show toasts.

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 8

Tags 42

↑↓ moveenter openesc close