test(cef): cover nil-host resize pulses
- commit
- b594e4f416c47459a01fa54cbcee00cd8f71a71f
- author
- brice · · 2026-06-20 14:56 UTC
- parent
- 84b9d0c
- signature
- GPG Verified
CD88F9E564E0102646FB6077A1A07C7C7C3E349D· arch-gpg Verified for the committer email
1 file · +54 -0
M internal/infrastructure/cef/webview_viewport_test.go +54 -0
| @@ -492,3 +492,57 @@ func TestScheduleResizeRepaintPulse_SkipsStaleHost(t *testing.T) { | |||
| 492 | 492 | require.Empty(t, capturedHost.calls) | |
| 493 | 493 | require.Empty(t, currentHost.calls) | |
| 494 | 494 | } | |
| 495 | + | ||
| 496 | + | func TestScheduleResizeRepaintPulse_SkipsWhenHostNilAtScheduleTime(t *testing.T) { | |
| 497 | + | oldNewTask := cefNewTask | |
| 498 | + | oldPostDelayedTask := cefPostDelayedTask | |
| 499 | + | defer func() { | |
| 500 | + | cefNewTask = oldNewTask | |
| 501 | + | cefPostDelayedTask = oldPostDelayedTask | |
| 502 | + | }() | |
| 503 | + | ||
| 504 | + | cefNewTask = func(task purecef.Task) purecef.Task { return task } | |
| 505 | + | ||
| 506 | + | var scheduled []purecef.Task | |
| 507 | + | cefPostDelayedTask = func(_ purecef.ThreadID, task purecef.Task, _ int64) int32 { | |
| 508 | + | scheduled = append(scheduled, task) | |
| 509 | + | return 1 | |
| 510 | + | } | |
| 511 | + | ||
| 512 | + | wv := &WebView{ctx: context.Background()} | |
| 513 | + | ||
| 514 | + | wv.scheduleResizeRepaintPulse(context.Background(), "nil-host") | |
| 515 | + | ||
| 516 | + | require.Empty(t, scheduled) | |
| 517 | + | } | |
| 518 | + | ||
| 519 | + | func TestScheduleResizeRepaintPulse_SkipsWhenHostClearedBeforeExecution(t *testing.T) { | |
| 520 | + | oldNewTask := cefNewTask | |
| 521 | + | oldPostDelayedTask := cefPostDelayedTask | |
| 522 | + | defer func() { | |
| 523 | + | cefNewTask = oldNewTask | |
| 524 | + | cefPostDelayedTask = oldPostDelayedTask | |
| 525 | + | }() | |
| 526 | + | ||
| 527 | + | cefNewTask = func(task purecef.Task) purecef.Task { return task } | |
| 528 | + | ||
| 529 | + | var scheduled []purecef.Task | |
| 530 | + | cefPostDelayedTask = func(threadID purecef.ThreadID, task purecef.Task, delayMs int64) int32 { | |
| 531 | + | require.Equal(t, purecef.ThreadIDTidUi, threadID) | |
| 532 | + | require.NotNil(t, task) | |
| 533 | + | scheduled = append(scheduled, task) | |
| 534 | + | return 1 | |
| 535 | + | } | |
| 536 | + | ||
| 537 | + | host := &viewportSyncOrderHost{} | |
| 538 | + | wv := &WebView{ctx: context.Background(), host: host} | |
| 539 | + | ||
| 540 | + | wv.scheduleResizeRepaintPulse(context.Background(), "nil-host-before-execute") | |
| 541 | + | wv.host = nil | |
| 542 | + | ||
| 543 | + | require.Len(t, scheduled, 2) | |
| 544 | + | scheduled[0].Execute() | |
| 545 | + | scheduled[1].Execute() | |
| 546 | + | ||
| 547 | + | require.Empty(t, host.calls) | |
| 548 | + | } | |
| @@ -492,3 +492,57 @@ func TestScheduleResizeRepaintPulse_SkipsStaleHost(t *testing.T) { | |||||
| 492 | require.Empty(t, capturedHost.calls) | 492 | require.Empty(t, capturedHost.calls) | ||
| 493 | require.Empty(t, currentHost.calls) | 493 | require.Empty(t, currentHost.calls) | ||
| 494 | } | 494 | } | ||
| 495 | + | ||||
| 496 | + | func TestScheduleResizeRepaintPulse_SkipsWhenHostNilAtScheduleTime(t *testing.T) { | |||
| 497 | + | oldNewTask := cefNewTask | |||
| 498 | + | oldPostDelayedTask := cefPostDelayedTask | |||
| 499 | + | defer func() { | |||
| 500 | + | cefNewTask = oldNewTask | |||
| 501 | + | cefPostDelayedTask = oldPostDelayedTask | |||
| 502 | + | }() | |||
| 503 | + | ||||
| 504 | + | cefNewTask = func(task purecef.Task) purecef.Task { return task } | |||
| 505 | + | ||||
| 506 | + | var scheduled []purecef.Task | |||
| 507 | + | cefPostDelayedTask = func(_ purecef.ThreadID, task purecef.Task, _ int64) int32 { | |||
| 508 | + | scheduled = append(scheduled, task) | |||
| 509 | + | return 1 | |||
| 510 | + | } | |||
| 511 | + | ||||
| 512 | + | wv := &WebView{ctx: context.Background()} | |||
| 513 | + | ||||
| 514 | + | wv.scheduleResizeRepaintPulse(context.Background(), "nil-host") | |||
| 515 | + | ||||
| 516 | + | require.Empty(t, scheduled) | |||
| 517 | + | } | |||
| 518 | + | ||||
| 519 | + | func TestScheduleResizeRepaintPulse_SkipsWhenHostClearedBeforeExecution(t *testing.T) { | |||
| 520 | + | oldNewTask := cefNewTask | |||
| 521 | + | oldPostDelayedTask := cefPostDelayedTask | |||
| 522 | + | defer func() { | |||
| 523 | + | cefNewTask = oldNewTask | |||
| 524 | + | cefPostDelayedTask = oldPostDelayedTask | |||
| 525 | + | }() | |||
| 526 | + | ||||
| 527 | + | cefNewTask = func(task purecef.Task) purecef.Task { return task } | |||
| 528 | + | ||||
| 529 | + | var scheduled []purecef.Task | |||
| 530 | + | cefPostDelayedTask = func(threadID purecef.ThreadID, task purecef.Task, delayMs int64) int32 { | |||
| 531 | + | require.Equal(t, purecef.ThreadIDTidUi, threadID) | |||
| 532 | + | require.NotNil(t, task) | |||
| 533 | + | scheduled = append(scheduled, task) | |||
| 534 | + | return 1 | |||
| 535 | + | } | |||
| 536 | + | ||||
| 537 | + | host := &viewportSyncOrderHost{} | |||
| 538 | + | wv := &WebView{ctx: context.Background(), host: host} | |||
| 539 | + | ||||
| 540 | + | wv.scheduleResizeRepaintPulse(context.Background(), "nil-host-before-execute") | |||
| 541 | + | wv.host = nil | |||
| 542 | + | ||||
| 543 | + | require.Len(t, scheduled, 2) | |||
| 544 | + | scheduled[0].Execute() | |||
| 545 | + | scheduled[1].Execute() | |||
| 546 | + | ||||
| 547 | + | require.Empty(t, host.calls) | |||
| 548 | + | } | |||