detached d80cc8e

test(ticks): cover raw callback slot cleanup

commit
d80cc8e00a818df812cf0d1310951d5c5721acdf
author
brice · · 2026-07-14 06:22 UTC
committer
brice · · 2026-07-14 07:06 UTC
parent
1c59f12
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
2 files · +36 -0
A internal/infrastructure/cef/webview_begin_frame_cleanup_test.go +18 -0
@@ -0,0 +1,18 @@
1+package cef
2+
3+import (
4+ "testing"
5+
6+ "github.com/bnema/puregotk/v4/gtk"
7+)
8+
9+func TestStopBeginFrameLoopReleasesCallbackSlotWithoutWidget(t *testing.T) {
10+ callback := new(gtk.TickCallback)
11+ wv := &WebView{beginFrameTick: callback, beginFrameTickID: 17}
12+
13+ wv.stopBeginFrameLoop()
14+
15+ if wv.beginFrameTick != nil || wv.beginFrameTickID != 0 {
16+ t.Fatal("stop must release the BeginFrame callback slot even after the GTK widget is gone")
17+ }
18+}
@@ -0,0 +1,18 @@
1+package cef
2+
3+import (
4+ "testing"
5+
6+ "github.com/bnema/puregotk/v4/gtk"
7+)
8+
9+func TestStopBeginFrameLoopReleasesCallbackSlotWithoutWidget(t *testing.T) {
10+ callback := new(gtk.TickCallback)
11+ wv := &WebView{beginFrameTick: callback, beginFrameTickID: 17}
12+
13+ wv.stopBeginFrameLoop()
14+
15+ if wv.beginFrameTick != nil || wv.beginFrameTickID != 0 {
16+ t.Fatal("stop must release the BeginFrame callback slot even after the GTK widget is gone")
17+ }
18+}
A internal/ui/floating_pane_callback_cleanup_test.go +18 -0
@@ -0,0 +1,18 @@
1+package ui
2+
3+import (
4+ "testing"
5+
6+ "github.com/bnema/puregotk/v4/gtk"
7+)
8+
9+func TestStopFloatingResizeWatcherReleasesRawCallbackSlot(t *testing.T) {
10+ callback := new(gtk.TickCallback)
11+ session := &floatingWorkspaceSession{resizeTickCallback: callback, resizeTickID: 17, resizeWatcherActive: true}
12+
13+ (&App{}).stopFloatingResizeWatcher(session)
14+
15+ if session.resizeTickCallback != nil || session.resizeTickID != 0 || session.resizeWatcherActive {
16+ t.Fatal("stop must release the floating resize callback slot exactly once")
17+ }
18+}
@@ -0,0 +1,18 @@
1+package ui
2+
3+import (
4+ "testing"
5+
6+ "github.com/bnema/puregotk/v4/gtk"
7+)
8+
9+func TestStopFloatingResizeWatcherReleasesRawCallbackSlot(t *testing.T) {
10+ callback := new(gtk.TickCallback)
11+ session := &floatingWorkspaceSession{resizeTickCallback: callback, resizeTickID: 17, resizeWatcherActive: true}
12+
13+ (&App{}).stopFloatingResizeWatcher(session)
14+
15+ if session.resizeTickCallback != nil || session.resizeTickID != 0 || session.resizeWatcherActive {
16+ t.Fatal("stop must release the floating resize callback slot exactly once")
17+ }
18+}

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 8

Tags 42

↑↓ moveenter openesc close