test(ui): skip gtk window tests without display

commit: dccb0ab13030ef8150047d731cf8924a88eb9585
author: brice · 6mo ago · 2026-04-16 03:30 UTC
parent: 802dc32
signature: GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email

1 file · +60 -48

M internal/ui/app_browser_launch_test.go +60 -48


@@ -3,7 +3,10 @@ package ui
3	3		import (
4	4		"context"
5	5		"io"
	6	+	"os"
	7	+	"path/filepath"
6	8		"reflect"
	9	+	"strings"
7	10		"testing"
8	11		"unsafe"
9	12

@@ -21,6 +24,7 @@ import (
21	24		"github.com/bnema/dumber/internal/ui/layout"
22	25		layoutmocks "github.com/bnema/dumber/internal/ui/layout/mocks"
23	26		"github.com/bnema/dumber/internal/ui/window"
	27	+	"github.com/bnema/puregotk/v4/gdk"
24	28		"github.com/bnema/puregotk/v4/gio"
25	29		"github.com/bnema/puregotk/v4/gtk"
26	30		)

@@ -69,6 +73,54 @@ func (r fakeSessionStateRepo) GetAllSnapshots(context.Context) ([]entity.Sessi
69	73
70	74		func (r *fakeSessionStateRepo) GetTotalSnapshotsSize(context.Context) (int64, error) { return 0, nil }
71	75
	76	+	func testHasUsableGTKDisplay() bool {
	77	+	if waylandDisplay := os.Getenv("WAYLAND_DISPLAY"); waylandDisplay != "" {
	78	+	candidates := []string{waylandDisplay}
	79	+	if runtimeDir := os.Getenv("XDG_RUNTIME_DIR"); runtimeDir != "" && !filepath.IsAbs(waylandDisplay) {
	80	+	candidates = append([]string{filepath.Join(runtimeDir, waylandDisplay)}, candidates...)
	81	+	}
	82	+	for _, candidate := range candidates {
	83	+	if _, err := os.Stat(candidate); err == nil {
	84	+	return true
	85	+	}
	86	+	}
	87	+	}
	88	+
	89	+	if display := os.Getenv("DISPLAY"); display != "" {
	90	+	if strings.HasPrefix(display, ":") {
	91	+	displayNum := strings.TrimPrefix(display, ":")
	92	+	displayNum = strings.SplitN(displayNum, ".", 2)[0]
	93	+	if displayNum == "" {
	94	+	return false
	95	+	}
	96	+	if _, err := os.Stat(filepath.Join("/tmp/.X11-unix", "X"+displayNum)); err == nil {
	97	+	return true
	98	+	}
	99	+	return false
	100	+	}
	101	+	return true
	102	+	}
	103	+
	104	+	return false
	105	+	}
	106	+
	107	+	func requireGTKDisplayApp(t testing.T) gtk.Application {
	108	+	t.Helper()
	109	+	if !testHasUsableGTKDisplay() {
	110	+	t.Skip("GTK display not available")
	111	+	}
	112	+	EnsureAdwaitaInitialized()
	113	+	if gdk.DisplayGetDefault() == nil {
	114	+	t.Skip("GTK display not available")
	115	+	}
	116	+	appID := AppID
	117	+	gtkApp := gtk.NewApplication(&appID, gio.GApplicationNonUniqueValue)
	118	+	if gtkApp == nil {
	119	+	t.Fatal("gtk application creation failed")
	120	+	}
	121	+	return gtkApp
	122	+	}
	123	+
72	124		// setDependencyField uses reflection to reach unexported dependency fields for tests.
73	125		// Keep this test-only so production visibility stays narrow.
74	126		func setDependencyField(t testing.T, deps Dependencies, field string, value any) {

@@ -283,12 +335,7 @@ func TestApp_OpenFreshWindowRecordsTabOwnership(t *testing.T) {
283	335		}
284	336
285	337		func TestApp_RestoreSessionClearsStaleUIStateBeforeApplyingRestoredTabs(t *testing.T) {
286		-	EnsureAdwaitaInitialized()
287		-	appID := AppID
288		-	gtkApp := gtk.NewApplication(&appID, gio.GApplicationNonUniqueValue)
289		-	if gtkApp == nil {
290		-	t.Fatal("gtk application creation failed")
291		-	}
	338	+	gtkApp := requireGTKDisplayApp(t)
292	339		defer gtkApp.Unref()
293	340
294	341		mainWindow, err := window.New(context.Background(), gtkApp, "top")

@@ -344,12 +391,7 @@ func TestApp_RestoreSessionClearsStaleUIStateBeforeApplyingRestoredTabs(t *testi
344	391		}
345	392
346	393		func TestApp_RestoreSessionWiresStackedPaneTitleBarCallbacks(t *testing.T) {
347		-	EnsureAdwaitaInitialized()
348		-	appID := AppID
349		-	gtkApp := gtk.NewApplication(&appID, gio.GApplicationNonUniqueValue)
350		-	if gtkApp == nil {
351		-	t.Fatal("gtk application creation failed")
352		-	}
	394	+	gtkApp := requireGTKDisplayApp(t)
353	395		defer gtkApp.Unref()
354	396
355	397		mainWindow, err := window.New(context.Background(), gtkApp, "top")

@@ -613,12 +655,7 @@ func TestApp_OwnerOrLastFocusedBrowserWindowPrefersPaneOwner(t *testing.T) {
613	655		}
614	656
615	657		func TestApp_HandlePaneWindowTitleChangedTargetsOwningWindow(t *testing.T) {
616		-	EnsureAdwaitaInitialized()
617		-	appID := AppID
618		-	gtkApp := gtk.NewApplication(&appID, gio.GApplicationNonUniqueValue)
619		-	if gtkApp == nil {
620		-	t.Fatal("gtk application creation failed")
621		-	}
	658	+	gtkApp := requireGTKDisplayApp(t)
622	659		defer gtkApp.Unref()
623	660
624	661		firstMainWindow, err := window.New(context.Background(), gtkApp, "top")

@@ -657,12 +694,7 @@ func TestApp_HandlePaneWindowTitleChangedTargetsOwningWindow(t *testing.T) {
657	694		}
658	695
659	696		func TestApp_ActivateBrowserWindowResyncsTitleFromBackgroundPane(t *testing.T) {
660		-	EnsureAdwaitaInitialized()
661		-	appID := AppID
662		-	gtkApp := gtk.NewApplication(&appID, gio.GApplicationNonUniqueValue)
663		-	if gtkApp == nil {
664		-	t.Fatal("gtk application creation failed")
665		-	}
	697	+	gtkApp := requireGTKDisplayApp(t)
666	698		defer gtkApp.Unref()
667	699
668	700		firstMainWindow, err := window.New(context.Background(), gtkApp, "top")

@@ -707,12 +739,7 @@ func TestApp_ActivateBrowserWindowResyncsTitleFromBackgroundPane(t *testing.T) {
707	739		}
708	740
709	741		func TestApp_HandlePaneFullscreenChangedTargetsOwningWindow(t *testing.T) {
710		-	EnsureAdwaitaInitialized()
711		-	appID := AppID
712		-	gtkApp := gtk.NewApplication(&appID, gio.GApplicationNonUniqueValue)
713		-	if gtkApp == nil {
714		-	t.Fatal("gtk application creation failed")
715		-	}
	742	+	gtkApp := requireGTKDisplayApp(t)
716	743		defer gtkApp.Unref()
717	744
718	745		firstMainWindow, err := window.New(context.Background(), gtkApp, "top")

@@ -759,12 +786,7 @@ func TestApp_HandlePaneFullscreenChangedTargetsOwningWindow(t *testing.T) {
759	786		}
760	787
761	788		func TestApp_HandlePaneFullscreenChangedIgnoresUnresolvedPane(t *testing.T) {
762		-	EnsureAdwaitaInitialized()
763		-	appID := AppID
764		-	gtkApp := gtk.NewApplication(&appID, gio.GApplicationNonUniqueValue)
765		-	if gtkApp == nil {
766		-	t.Fatal("gtk application creation failed")
767		-	}
	789	+	gtkApp := requireGTKDisplayApp(t)
768	790		defer gtkApp.Unref()
769	791
770	792		firstMainWindow, err := window.New(context.Background(), gtkApp, "top")

@@ -881,12 +903,7 @@ func TestApp_MoveActivePaneToTabFromBrowserWindowActivatesTargetOwnerForCrossWin
881	903		}
882	904
883	905		func TestApp_InitKeyboardHandlerDoesNotReattachExistingWindowInput(t *testing.T) {
884		-	EnsureAdwaitaInitialized()
885		-	appID := AppID
886		-	gtkApp := gtk.NewApplication(&appID, gio.GApplicationNonUniqueValue)
887		-	if gtkApp == nil {
888		-	t.Fatal("gtk application creation failed")
889		-	}
	906	+	gtkApp := requireGTKDisplayApp(t)
890	907		defer gtkApp.Unref()
891	908
892	909		mainWindow, err := window.New(context.Background(), gtkApp, "top")

@@ -946,12 +963,7 @@ func (*testFocusedInputProvider) GetFocusedInput() port.TextInputTarget { return
946	963		func (*testFocusedInputProvider) SetFocusedInput(port.TextInputTarget) {}
947	964
948	965		func TestApp_UpdateBrowserWindowTabBarVisibilityHonorsHideWhenSingleTabDisabled(t *testing.T) {
949		-	EnsureAdwaitaInitialized()
950		-	appID := AppID
951		-	gtkApp := gtk.NewApplication(&appID, gio.GApplicationNonUniqueValue)
952		-	if gtkApp == nil {
953		-	t.Fatal("gtk application creation failed")
954		-	}
	966	+	gtkApp := requireGTKDisplayApp(t)
955	967		defer gtkApp.Unref()
956	968
957	969		mainWindow := &window.MainWindow{}

 import (
 	"context"
 	"io"
+	"os"
+	"path/filepath"
 	"reflect"
+	"strings"
 	"testing"
 	"unsafe"
 	"github.com/bnema/dumber/internal/ui/layout"
 	layoutmocks "github.com/bnema/dumber/internal/ui/layout/mocks"
 	"github.com/bnema/dumber/internal/ui/window"
+	"github.com/bnema/puregotk/v4/gdk"
 	"github.com/bnema/puregotk/v4/gio"
 	"github.com/bnema/puregotk/v4/gtk"
 )
 func (r *fakeSessionStateRepo) GetTotalSnapshotsSize(context.Context) (int64, error) { return 0, nil }
+func testHasUsableGTKDisplay() bool {
+	if waylandDisplay := os.Getenv("WAYLAND_DISPLAY"); waylandDisplay != "" {
+		candidates := []string{waylandDisplay}
+		if runtimeDir := os.Getenv("XDG_RUNTIME_DIR"); runtimeDir != "" && !filepath.IsAbs(waylandDisplay) {
+			candidates = append([]string{filepath.Join(runtimeDir, waylandDisplay)}, candidates...)
+		}
+		for _, candidate := range candidates {
+			if _, err := os.Stat(candidate); err == nil {
+				return true
+			}
+		}
+	}
+	if display := os.Getenv("DISPLAY"); display != "" {
+		if strings.HasPrefix(display, ":") {
+			displayNum := strings.TrimPrefix(display, ":")
+			displayNum = strings.SplitN(displayNum, ".", 2)[0]
+			if displayNum == "" {
+				return false
+			}
+			if _, err := os.Stat(filepath.Join("/tmp/.X11-unix", "X"+displayNum)); err == nil {
+				return true
+			}
+			return false
+		}
+		return true
+	}
+	return false
+}
+func requireGTKDisplayApp(t *testing.T) *gtk.Application {
+	t.Helper()
+	if !testHasUsableGTKDisplay() {
+		t.Skip("GTK display not available")
+	}
+	EnsureAdwaitaInitialized()
+	if gdk.DisplayGetDefault() == nil {
+		t.Skip("GTK display not available")
+	}
+	appID := AppID
+	gtkApp := gtk.NewApplication(&appID, gio.GApplicationNonUniqueValue)
+	if gtkApp == nil {
+		t.Fatal("gtk application creation failed")
+	}
+	return gtkApp
+}
 // setDependencyField uses reflection to reach unexported dependency fields for tests.
 // Keep this test-only so production visibility stays narrow.
 func setDependencyField(t *testing.T, deps *Dependencies, field string, value any) {
 }
 func TestApp_RestoreSessionClearsStaleUIStateBeforeApplyingRestoredTabs(t *testing.T) {
-	EnsureAdwaitaInitialized()
+	gtkApp := requireGTKDisplayApp(t)
-	appID := AppID
-	gtkApp := gtk.NewApplication(&appID, gio.GApplicationNonUniqueValue)
-	if gtkApp == nil {
-		t.Fatal("gtk application creation failed")
-	}
 	defer gtkApp.Unref()
 	mainWindow, err := window.New(context.Background(), gtkApp, "top")
 }
 func TestApp_RestoreSessionWiresStackedPaneTitleBarCallbacks(t *testing.T) {
-	EnsureAdwaitaInitialized()
+	gtkApp := requireGTKDisplayApp(t)
-	appID := AppID
-	gtkApp := gtk.NewApplication(&appID, gio.GApplicationNonUniqueValue)
-	if gtkApp == nil {
-		t.Fatal("gtk application creation failed")
-	}
 	defer gtkApp.Unref()
 	mainWindow, err := window.New(context.Background(), gtkApp, "top")
 }
 func TestApp_HandlePaneWindowTitleChangedTargetsOwningWindow(t *testing.T) {
-	EnsureAdwaitaInitialized()
+	gtkApp := requireGTKDisplayApp(t)
-	appID := AppID
-	gtkApp := gtk.NewApplication(&appID, gio.GApplicationNonUniqueValue)
-	if gtkApp == nil {
-		t.Fatal("gtk application creation failed")
-	}
 	defer gtkApp.Unref()
 	firstMainWindow, err := window.New(context.Background(), gtkApp, "top")
 }
 func TestApp_ActivateBrowserWindowResyncsTitleFromBackgroundPane(t *testing.T) {
-	EnsureAdwaitaInitialized()
+	gtkApp := requireGTKDisplayApp(t)
-	appID := AppID
-	gtkApp := gtk.NewApplication(&appID, gio.GApplicationNonUniqueValue)
-	if gtkApp == nil {
-		t.Fatal("gtk application creation failed")
-	}
 	defer gtkApp.Unref()
 	firstMainWindow, err := window.New(context.Background(), gtkApp, "top")
 }
 func TestApp_HandlePaneFullscreenChangedTargetsOwningWindow(t *testing.T) {
-	EnsureAdwaitaInitialized()
+	gtkApp := requireGTKDisplayApp(t)
-	appID := AppID
-	gtkApp := gtk.NewApplication(&appID, gio.GApplicationNonUniqueValue)
-	if gtkApp == nil {
-		t.Fatal("gtk application creation failed")
-	}
 	defer gtkApp.Unref()
 	firstMainWindow, err := window.New(context.Background(), gtkApp, "top")
 }
 func TestApp_HandlePaneFullscreenChangedIgnoresUnresolvedPane(t *testing.T) {
-	EnsureAdwaitaInitialized()
+	gtkApp := requireGTKDisplayApp(t)
-	appID := AppID
-	gtkApp := gtk.NewApplication(&appID, gio.GApplicationNonUniqueValue)
-	if gtkApp == nil {
-		t.Fatal("gtk application creation failed")
-	}
 	defer gtkApp.Unref()
 	firstMainWindow, err := window.New(context.Background(), gtkApp, "top")
 }
 func TestApp_InitKeyboardHandlerDoesNotReattachExistingWindowInput(t *testing.T) {
-	EnsureAdwaitaInitialized()
+	gtkApp := requireGTKDisplayApp(t)
-	appID := AppID
-	gtkApp := gtk.NewApplication(&appID, gio.GApplicationNonUniqueValue)
-	if gtkApp == nil {
-		t.Fatal("gtk application creation failed")
-	}
 	defer gtkApp.Unref()
 	mainWindow, err := window.New(context.Background(), gtkApp, "top")
 func (*testFocusedInputProvider) SetFocusedInput(port.TextInputTarget)  {}
 func TestApp_UpdateBrowserWindowTabBarVisibilityHonorsHideWhenSingleTabDisabled(t *testing.T) {
-	EnsureAdwaitaInitialized()
+	gtkApp := requireGTKDisplayApp(t)
-	appID := AppID
-	gtkApp := gtk.NewApplication(&appID, gio.GApplicationNonUniqueValue)
-	if gtkApp == nil {
-		t.Fatal("gtk application creation failed")
-	}
 	defer gtkApp.Unref()
 	mainWindow := &window.MainWindow{}