refactor: remove deprecated GStreamer buffer settings
- commit
- f1d0f968f7a524036eb2b6da547aa3ad6c6f7199
- author
- brice · · 2026-01-06 13:05 UTC
- parent
- 76e28c0
- signature
- GPG Verified
CD88F9E564E0102646FB6077A1A07C7C7C3E349D· arch-gpg Verified for the committer email
5 files · +0 -16
M internal/application/port/rendering_env.go +0 -4
| @@ -27,10 +27,6 @@ type RenderingEnvSettings struct { | |||
| 27 | 27 | GLRenderingMode string | |
| 28 | 28 | // GStreamerDebugLevel sets GStreamer debug verbosity (0-5). | |
| 29 | 29 | GStreamerDebugLevel int | |
| 30 | - | // VideoBufferSizeMB sets buffer size in megabytes for video streaming. | |
| 31 | - | VideoBufferSizeMB int | |
| 32 | - | // QueueBufferTimeSec sets queue buffer time in seconds for prebuffering. | |
| 33 | - | QueueBufferTimeSec int | |
| 34 | 30 | ||
| 35 | 31 | // --- WebKit compositor settings (from RenderingConfig) --- | |
| 36 | 32 | DisableDMABufRenderer bool | |
| @@ -27,10 +27,6 @@ type RenderingEnvSettings struct { | |||||
| 27 | GLRenderingMode string | 27 | GLRenderingMode string | ||
| 28 | // GStreamerDebugLevel sets GStreamer debug verbosity (0-5). | 28 | // GStreamerDebugLevel sets GStreamer debug verbosity (0-5). | ||
| 29 | GStreamerDebugLevel int | 29 | GStreamerDebugLevel int | ||
| 30 | - | // VideoBufferSizeMB sets buffer size in megabytes for video streaming. | |||
| 31 | - | VideoBufferSizeMB int | |||
| 32 | - | // QueueBufferTimeSec sets queue buffer time in seconds for prebuffering. | |||
| 33 | - | QueueBufferTimeSec int | |||
| 34 | 30 | ||||
| 35 | // --- WebKit compositor settings (from RenderingConfig) --- | 31 | // --- WebKit compositor settings (from RenderingConfig) --- | ||
| 36 | DisableDMABufRenderer bool | 32 | DisableDMABufRenderer bool | ||
M internal/bootstrap/webkit_stack.go +0 -2
| @@ -194,8 +194,6 @@ func configureRenderingEnvironment( | |||
| 194 | 194 | ForceVSync: cfg.Media.ForceVSync, | |
| 195 | 195 | GLRenderingMode: string(cfg.Media.GLRenderingMode), | |
| 196 | 196 | GStreamerDebugLevel: cfg.Media.GStreamerDebugLevel, | |
| 197 | - | VideoBufferSizeMB: cfg.Media.VideoBufferSizeMB, | |
| 198 | - | QueueBufferTimeSec: cfg.Media.QueueBufferTimeSec, | |
| 199 | 197 | ||
| 200 | 198 | // WebKit compositor settings | |
| 201 | 199 | DisableDMABufRenderer: cfg.Rendering.DisableDMABufRenderer, | |
| @@ -194,8 +194,6 @@ func configureRenderingEnvironment( | |||||
| 194 | ForceVSync: cfg.Media.ForceVSync, | 194 | ForceVSync: cfg.Media.ForceVSync, | ||
| 195 | GLRenderingMode: string(cfg.Media.GLRenderingMode), | 195 | GLRenderingMode: string(cfg.Media.GLRenderingMode), | ||
| 196 | GStreamerDebugLevel: cfg.Media.GStreamerDebugLevel, | 196 | GStreamerDebugLevel: cfg.Media.GStreamerDebugLevel, | ||
| 197 | - | VideoBufferSizeMB: cfg.Media.VideoBufferSizeMB, | |||
| 198 | - | QueueBufferTimeSec: cfg.Media.QueueBufferTimeSec, | |||
| 199 | 197 | ||||
| 200 | // WebKit compositor settings | 198 | // WebKit compositor settings | ||
| 201 | DisableDMABufRenderer: cfg.Rendering.DisableDMABufRenderer, | 199 | DisableDMABufRenderer: cfg.Rendering.DisableDMABufRenderer, | ||
M internal/infrastructure/config/defaults.go +0 -2
| @@ -282,8 +282,6 @@ func DefaultConfig() *Config { | |||
| 282 | 282 | ForceVSync: false, // Let compositor handle VSync | |
| 283 | 283 | GLRenderingMode: GLRenderingModeAuto, // GStreamer picks best GL API | |
| 284 | 284 | GStreamerDebugLevel: 0, // Disabled by default | |
| 285 | - | VideoBufferSizeMB: 0, // Not a valid GStreamer env var, removed | |
| 286 | - | QueueBufferTimeSec: 0, // Not a valid GStreamer env var, removed | |
| 287 | 285 | }, | |
| 288 | 286 | Runtime: RuntimeConfig{ | |
| 289 | 287 | Prefix: "", | |
| @@ -282,8 +282,6 @@ func DefaultConfig() *Config { | |||||
| 282 | ForceVSync: false, // Let compositor handle VSync | 282 | ForceVSync: false, // Let compositor handle VSync | ||
| 283 | GLRenderingMode: GLRenderingModeAuto, // GStreamer picks best GL API | 283 | GLRenderingMode: GLRenderingModeAuto, // GStreamer picks best GL API | ||
| 284 | GStreamerDebugLevel: 0, // Disabled by default | 284 | GStreamerDebugLevel: 0, // Disabled by default | ||
| 285 | - | VideoBufferSizeMB: 0, // Not a valid GStreamer env var, removed | |||
| 286 | - | QueueBufferTimeSec: 0, // Not a valid GStreamer env var, removed | |||
| 287 | }, | 285 | }, | ||
| 288 | Runtime: RuntimeConfig{ | 286 | Runtime: RuntimeConfig{ | ||
| 289 | Prefix: "", | 287 | Prefix: "", | ||
M internal/infrastructure/config/loader.go +0 -2
| @@ -490,8 +490,6 @@ func (m *Manager) setMediaDefaults(defaults *Config) { | |||
| 490 | 490 | m.viper.SetDefault("media.force_vsync", defaults.Media.ForceVSync) | |
| 491 | 491 | m.viper.SetDefault("media.gl_rendering_mode", string(defaults.Media.GLRenderingMode)) | |
| 492 | 492 | m.viper.SetDefault("media.gstreamer_debug_level", defaults.Media.GStreamerDebugLevel) | |
| 493 | - | m.viper.SetDefault("media.video_buffer_size_mb", defaults.Media.VideoBufferSizeMB) | |
| 494 | - | m.viper.SetDefault("media.queue_buffer_time_sec", defaults.Media.QueueBufferTimeSec) | |
| 495 | 493 | } | |
| 496 | 494 | ||
| 497 | 495 | func (m *Manager) setRuntimeDefaults(defaults *Config) { | |
| @@ -490,8 +490,6 @@ func (m *Manager) setMediaDefaults(defaults *Config) { | |||||
| 490 | m.viper.SetDefault("media.force_vsync", defaults.Media.ForceVSync) | 490 | m.viper.SetDefault("media.force_vsync", defaults.Media.ForceVSync) | ||
| 491 | m.viper.SetDefault("media.gl_rendering_mode", string(defaults.Media.GLRenderingMode)) | 491 | m.viper.SetDefault("media.gl_rendering_mode", string(defaults.Media.GLRenderingMode)) | ||
| 492 | m.viper.SetDefault("media.gstreamer_debug_level", defaults.Media.GStreamerDebugLevel) | 492 | m.viper.SetDefault("media.gstreamer_debug_level", defaults.Media.GStreamerDebugLevel) | ||
| 493 | - | m.viper.SetDefault("media.video_buffer_size_mb", defaults.Media.VideoBufferSizeMB) | |||
| 494 | - | m.viper.SetDefault("media.queue_buffer_time_sec", defaults.Media.QueueBufferTimeSec) | |||
| 495 | } | 493 | } | ||
| 496 | 494 | ||||
| 497 | func (m *Manager) setRuntimeDefaults(defaults *Config) { | 495 | func (m *Manager) setRuntimeDefaults(defaults *Config) { | ||
M internal/infrastructure/config/schema.go +0 -6
| @@ -167,12 +167,6 @@ type MediaConfig struct { | |||
| 167 | 167 | GLRenderingMode GLRenderingMode `mapstructure:"gl_rendering_mode" yaml:"gl_rendering_mode" toml:"gl_rendering_mode"` | |
| 168 | 168 | // GStreamerDebugLevel sets GStreamer debug verbosity (0=off, 1-5=increasing verbosity) | |
| 169 | 169 | GStreamerDebugLevel int `mapstructure:"gstreamer_debug_level" yaml:"gstreamer_debug_level" toml:"gstreamer_debug_level"` | |
| 170 | - | // VideoBufferSizeMB sets the video buffer size in megabytes for smoother streaming | |
| 171 | - | // Higher values reduce rebuffering but use more memory. Default: 64 MB | |
| 172 | - | VideoBufferSizeMB int `mapstructure:"video_buffer_size_mb" yaml:"video_buffer_size_mb" toml:"video_buffer_size_mb"` | |
| 173 | - | // QueueBufferTimeSec sets the queue buffer time in seconds | |
| 174 | - | // Higher values allow more prebuffering for bursty streams. Default: 20 seconds | |
| 175 | - | QueueBufferTimeSec int `mapstructure:"queue_buffer_time_sec" yaml:"queue_buffer_time_sec" toml:"queue_buffer_time_sec"` | |
| 176 | 170 | } | |
| 177 | 171 | ||
| 178 | 172 | // RuntimeConfig holds optional runtime overrides. | |
| @@ -167,12 +167,6 @@ type MediaConfig struct { | |||||
| 167 | GLRenderingMode GLRenderingMode `mapstructure:"gl_rendering_mode" yaml:"gl_rendering_mode" toml:"gl_rendering_mode"` | 167 | GLRenderingMode GLRenderingMode `mapstructure:"gl_rendering_mode" yaml:"gl_rendering_mode" toml:"gl_rendering_mode"` | ||
| 168 | // GStreamerDebugLevel sets GStreamer debug verbosity (0=off, 1-5=increasing verbosity) | 168 | // GStreamerDebugLevel sets GStreamer debug verbosity (0=off, 1-5=increasing verbosity) | ||
| 169 | GStreamerDebugLevel int `mapstructure:"gstreamer_debug_level" yaml:"gstreamer_debug_level" toml:"gstreamer_debug_level"` | 169 | GStreamerDebugLevel int `mapstructure:"gstreamer_debug_level" yaml:"gstreamer_debug_level" toml:"gstreamer_debug_level"` | ||
| 170 | - | // VideoBufferSizeMB sets the video buffer size in megabytes for smoother streaming | |||
| 171 | - | // Higher values reduce rebuffering but use more memory. Default: 64 MB | |||
| 172 | - | VideoBufferSizeMB int `mapstructure:"video_buffer_size_mb" yaml:"video_buffer_size_mb" toml:"video_buffer_size_mb"` | |||
| 173 | - | // QueueBufferTimeSec sets the queue buffer time in seconds | |||
| 174 | - | // Higher values allow more prebuffering for bursty streams. Default: 20 seconds | |||
| 175 | - | QueueBufferTimeSec int `mapstructure:"queue_buffer_time_sec" yaml:"queue_buffer_time_sec" toml:"queue_buffer_time_sec"` | |||
| 176 | } | 170 | } | ||
| 177 | 171 | ||||
| 178 | // RuntimeConfig holds optional runtime overrides. | 172 | // RuntimeConfig holds optional runtime overrides. | ||